/////////////////////////////////////////////////////////////////////////////
-// Name: timer.cpp
+// Name: src/msw/timer.cpp
// Purpose: wxTimer implementation
// Author: Julian Smart
-// Modified by:
+// Modified by: Vadim Zeitlin (use hash map instead of list, global rewrite)
// Created: 04/01/98
// RCS-ID: $Id$
-// Copyright: (c) Julian Smart and Markus Holzem
-// Licence: wxWindows license
+// Copyright: (c) Julian Smart
+// Licence: wxWindows licence
/////////////////////////////////////////////////////////////////////////////
-#ifdef __GNUG__
- #pragma implementation "timer.h"
-#endif
-
// For compilers that support precompilation, includes "wx.h".
#include "wx/wxprec.h"
#pragma hdrstop
#endif
-#include "wx/window.h"
-#include "wx/msw/private.h"
+#if wxUSE_TIMER
+
+#include "wx/msw/private/timer.h"
#ifndef WX_PRECOMP
- #include "wx/setup.h"
#include "wx/list.h"
#include "wx/event.h"
#include "wx/app.h"
+ #include "wx/intl.h"
+ #include "wx/log.h"
+ #include "wx/hashmap.h"
#endif
-#include "wx/intl.h"
-#include "wx/log.h"
-
-#include "wx/timer.h"
-
-#include <time.h>
-#include <sys/types.h>
-
-#if !defined(__SC__) && !defined(__GNUWIN32__) && !defined(__MWERKS__)
- #include <sys/timeb.h>
-#endif
+#include "wx/msw/private.h"
// ----------------------------------------------------------------------------
-// private functions
+// private globals
// ----------------------------------------------------------------------------
-wxList wxTimerList(wxKEY_INTEGER);
-UINT WINAPI _EXPORT wxTimerProc(HWND hwnd, WORD, int idTimer, DWORD);
+// define a hash containing all the timers: it is indexed by timer id and
+// contains the corresponding timer
+WX_DECLARE_HASH_MAP(unsigned long, wxMSWTimerImpl *, wxIntegerHash, wxIntegerEqual,
+ wxTimerMap);
+
+// instead of using a global here, wrap it in a static function as otherwise it
+// could have been used before being initialized if a timer object were created
+// globally
+static wxTimerMap& TimerMap()
+{
+ static wxTimerMap s_timerMap;
+
+ return s_timerMap;
+}
// ----------------------------------------------------------------------------
-// macros
+// private functions
// ----------------------------------------------------------------------------
-#ifdef __WIN32__
- #define _EXPORT /**/
-#else
- #define _EXPORT _export
-#endif
-
-#if !USE_SHARED_LIBRARY
- IMPLEMENT_ABSTRACT_CLASS(wxTimer, wxObject)
-#endif
+// timer callback used for all timers
+void WINAPI wxTimerProc(HWND hwnd, UINT msg, UINT_PTR idTimer, DWORD dwTime);
// ============================================================================
// implementation
// ============================================================================
// ----------------------------------------------------------------------------
-// wxTimer class
+// wxMSWTimerImpl class
// ----------------------------------------------------------------------------
-wxTimer::wxTimer(void)
-{
- milli = 0 ;
- lastMilli = -1 ;
- id = 0;
-}
-wxTimer::~wxTimer(void)
+bool wxMSWTimerImpl::Start(int milliseconds, bool oneShot)
{
- Stop();
-
- wxTimerList.DeleteObject(this);
-}
-
-bool wxTimer::Start(int milliseconds, bool mode)
-{
- oneShot = mode ;
- if (milliseconds < 0)
- milliseconds = lastMilli;
-
- wxCHECK_MSG( milliseconds > 0, FALSE, _T("invalid value for timer timeour") );
-
- lastMilli = milli = milliseconds;
-
- wxTimerList.DeleteObject(this);
- TIMERPROC wxTimerProcInst = (TIMERPROC)
- MakeProcInstance((FARPROC)wxTimerProc, wxGetInstance());
-
- id = SetTimer(NULL, (UINT)(id ? id : 1),
- (UINT)milliseconds, wxTimerProcInst);
- if (id > 0)
+ if ( !wxTimerImpl::Start(milliseconds, oneShot) )
+ return false;
+
+ m_id = ::SetTimer
+ (
+ NULL, // don't use window
+ 1, // id ignored with NULL hwnd anyhow
+ (UINT)m_milli, // delay
+ wxTimerProc // timer proc to call
+ );
+
+ if ( !m_id )
{
- wxTimerList.Append(id, this);
+ wxLogSysError(_("Couldn't create a timer"));
- return TRUE;
+ return false;
}
- else
+
+ // check that SetTimer() didn't reuse an existing id: according to the MSDN
+ // this can happen and this would be catastrophic to us as we rely on ids
+ // uniquely identifying the timers because we use them as keys in the hash
+ if ( TimerMap().find(m_id) != TimerMap().end() )
{
- wxLogSysError(_("Couldn't create a timer"));
+ wxLogError(_("Timer creation failed."));
- return FALSE;
+ ::KillTimer(NULL, m_id);
+ m_id = 0;
+
+ return false;
}
+
+ TimerMap()[m_id] = this;
+
+ return true;
}
-void wxTimer::Stop(void)
+void wxMSWTimerImpl::Stop()
{
- if (id) {
- KillTimer(NULL, (UINT)id);
- wxTimerList.DeleteObject(this); /* @@@@ */
- }
- id = 0 ;
- milli = 0 ;
+ wxASSERT_MSG( m_id, _T("should be running") );
+
+ ::KillTimer(NULL, m_id);
+
+ TimerMap().erase(m_id);
+
+ m_id = 0;
}
// ----------------------------------------------------------------------------
// private functions
// ----------------------------------------------------------------------------
-void wxProcessTimer(wxTimer& timer)
+
+void wxProcessTimer(wxMSWTimerImpl& timer)
{
- // Avoid to process spurious timer events
- if ( timer.id == 0)
- return;
+ wxASSERT_MSG( timer.IsRunning(), _T("bogus timer id") );
- if ( timer.oneShot )
+ if ( timer.IsOneShot() )
timer.Stop();
timer.Notify();
}
-UINT WINAPI _EXPORT wxTimerProc(HWND WXUNUSED(hwnd), WORD, int idTimer, DWORD)
+void WINAPI
+wxTimerProc(HWND WXUNUSED(hwnd),
+ UINT WXUNUSED(msg),
+ UINT_PTR idTimer,
+ DWORD WXUNUSED(dwTime))
{
- wxNode *node = wxTimerList.Find((long)idTimer);
+ wxTimerMap::iterator node = TimerMap().find((unsigned long)idTimer);
- wxCHECK_MSG( node, 0, _T("bogus timer id in wxTimerProc") );
+ wxCHECK_RET( node != TimerMap().end(), wxT("bogus timer id in wxTimerProc") );
- wxProcessTimer(*(wxTimer *)node->Data());
-
- return 0;
+ wxProcessTimer(*(node->second));
}
+
+#endif // wxUSE_TIMER
projects / wxWidgets.git / blobdiff