- /* set size hints */
- gint flag = 0; // GDK_HINT_POS;
- if ((m_minWidth != -1) || (m_minHeight != -1)) flag |= GDK_HINT_MIN_SIZE;
- if ((m_maxWidth != -1) || (m_maxHeight != -1)) flag |= GDK_HINT_MAX_SIZE;
- GdkGeometry geom;
- geom.min_width = m_minWidth;
- geom.min_height = m_minHeight;
- geom.max_width = m_maxWidth;
- geom.max_height = m_maxHeight;
+ // set size hints
+ gint flag = 0; // GDK_HINT_POS;
+ GdkGeometry geom;
+
+ if ((minWidth != -1) || (minHeight != -1)) flag |= GDK_HINT_MIN_SIZE;
+ if ((maxWidth != -1) || (maxHeight != -1)) flag |= GDK_HINT_MAX_SIZE;
+
+ geom.min_width = minWidth;
+ geom.min_height = minHeight;
+
+ // Because of the way we set GDK_HINT_MAX_SIZE above, if either of
+ // maxHeight or maxWidth is set, we must set them both, else the
+ // remaining -1 will be taken literally.
+
+ // I'm certain this also happens elsewhere, and is the probable
+ // cause of other such things as:
+ // Gtk-WARNING **: gtk_widget_size_allocate():
+ // attempt to allocate widget with width 65535 and height 600
+ // but I don't have time to track them all now..
+ //
+ // Really we need to encapulate all this height/width business and
+ // stop any old method from ripping at the members directly and
+ // scattering -1's without regard for who might resolve them later.
+
+ geom.max_width = ( maxHeight == -1 ) ? maxWidth
+ : ( maxWidth == -1 ) ? wxGetDisplaySize().GetWidth()
+ : maxWidth ;
+
+ geom.max_height = ( maxWidth == -1 ) ? maxHeight // ( == -1 here )
+ : ( maxHeight == -1 ) ? wxGetDisplaySize().GetHeight()
+ : maxHeight ;
+