enter wxPendingEventLocker critical section in ProcessPendingEvents() (fixes 1720352)

[wxWidgets.git] / src / mac / carbon / bmpbuttn.cpp

diff --git a/src/mac/carbon/bmpbuttn.cpp b/src/mac/carbon/bmpbuttn.cpp
index 9c16d3672ec1447711660173aed72f9a713e4fec..26ee9dc9535eaddcfb2ef3572ff54e7b5003c862 100644 (file)
--- a/src/mac/carbon/bmpbuttn.cpp
+++ b/src/mac/carbon/bmpbuttn.cpp
@@ -1,97 +1,178 @@
 /////////////////////////////////////////////////////////////////////////////
 /////////////////////////////////////////////////////////////////////////////

-// Name:        bmpbuttn.cpp
+// Name:        src/mac/carbon/bmpbuttn.cpp

 // Purpose:     wxBitmapButton
 // Author:      Stefan Csomor
 // Modified by:
 // Created:     1998-01-01
 // RCS-ID:      $Id$
 // Copyright:   (c) Stefan Csomor
 // Purpose:     wxBitmapButton
 // Author:      Stefan Csomor
 // Modified by:
 // Created:     1998-01-01
 // RCS-ID:      $Id$
 // Copyright:   (c) Stefan Csomor

-// Licence:       wxWindows licence
+// Licence:     wxWindows licence

 /////////////////////////////////////////////////////////////////////////////
 
 /////////////////////////////////////////////////////////////////////////////
 

-#ifdef __GNUG__
-#pragma implementation "bmpbuttn.h"
-#endif
+#include "wx/wxprec.h"
+
+#if wxUSE_BMPBUTTON

 
 

-#include "wx/window.h"

 #include "wx/bmpbuttn.h"
 
 #include "wx/bmpbuttn.h"
 

-#if !USE_SHARED_LIBRARY
-IMPLEMENT_DYNAMIC_CLASS(wxBitmapButton, wxButton)
+#ifndef WX_PRECOMP
+    #include "wx/dcmemory.h"

 #endif
 
 #endif
 

+IMPLEMENT_DYNAMIC_CLASS(wxBitmapButton, wxButton)
+

 #include "wx/mac/uma.h"
 #include "wx/mac/uma.h"

-#include "wx/bitmap.h"

 
 

-bool wxBitmapButton::Create(wxWindow *parent, wxWindowID id, const wxBitmap& bitmap,
-           const wxPoint& pos,
-           const wxSize& size, long style,
-           const wxValidator& validator,
-           const wxString& name)
+bool wxBitmapButton::Create( wxWindow *parent,
+                             wxWindowID id, const wxBitmap& bitmap,
+                             const wxPoint& pos,
+                             const wxSize& size,
+                             long style,
+                             const wxValidator& validator,
+                             const wxString& name )

 {
 {

-    if ( !wxBitmapButtonBase::Create(parent, id, _T(""), pos, size,
-                                     style, validator, name) )
+    m_macIsUserPane = false;
+
+    // since bitmapbuttonbase is subclass of button calling wxBitmapButtonBase::Create
+    // essentially creates an additional button
+    if ( !wxControl::Create( parent, id, pos, size, style, validator, name ) )

         return false;
 
         return false;
 

-    m_bmpNormal = bitmap;
- 
-    if (style & wxBU_AUTODRAW)
+    if ( style & wxBU_AUTODRAW )

     {
     {

-        m_marginX = wxDEFAULT_BUTTON_MARGIN;
+        m_marginX =

         m_marginY = wxDEFAULT_BUTTON_MARGIN;
     }
     else
     {
         m_marginY = wxDEFAULT_BUTTON_MARGIN;
     }
     else
     {

-        m_marginX = 0;
+        m_marginX =

         m_marginY = 0;
     }
 
         m_marginY = 0;
     }
 

-    int width = size.x;
-    int height = size.y;
+    OSStatus err = noErr;
+    ControlButtonContentInfo info;

 
 

-    if ( width == -1 && bitmap.Ok())
-        width = bitmap.GetWidth() + 2*m_marginX;
+    Rect bounds = wxMacGetBoundsForControl( this, pos, size );
+    m_peer = new wxMacControl( this );

 
 

-    if ( height == -1 && bitmap.Ok())
-        height = bitmap.GetHeight() + 2*m_marginY;
+    if ( bitmap.Ok() && HasFlag(wxBORDER_NONE) )
+    {
+        // in Mac OS X the icon controls (which are used for borderless bitmap
+        // buttons) can have only one of the few standard sizes and if they
+        // don't, the OS rescales them automatically resulting in really ugly
+        // images, so centre the image in a square of standard size instead

 
 

-    Rect bounds ;
-    Str255 title ;
-    m_bmpNormal = bitmap;
-    wxBitmapRefData * bmap = NULL ;
-    
-    if ( m_bmpNormal.Ok() )
-        bmap = (wxBitmapRefData*) ( m_bmpNormal.GetRefData()) ;
-    
-    MacPreControlCreate( parent , id ,  wxEmptyString , pos , wxSize( width , height ) ,style, validator , name , &bounds , title ) ;
-
-    m_macControl = ::NewControl( MAC_WXHWND(parent->MacGetRootWindow()) , &bounds , title , false , 0 , 
-        kControlBehaviorOffsetContents + 
-            ( bmap && bmap->m_bitmapType == kMacBitmapTypeIcon ? 
-            kControlContentCIconHandle : kControlContentPictHandle ) , 0, 
-          (( style & wxBU_AUTODRAW ) ? kControlBevelButtonSmallBevelProc : kControlBevelButtonNormalBevelProc ), (long) this ) ;
-    wxASSERT_MSG( (ControlHandle) m_macControl != NULL , wxT("No valid mac control") ) ;
-    
-    ControlButtonContentInfo info ;
-    wxMacCreateBitmapButton( &info , m_bmpNormal ) ;
-    if ( info.contentType != kControlNoContent )
+        // the supported sizes, sorted in decreasng order
+        static const int stdSizes[] = { 128, 48, 32, 16, 0 };
+
+        const int width = bitmap.GetWidth();
+        const int height = bitmap.GetHeight();
+
+        int n;
+        for ( n = 0; n < (int)WXSIZEOF(stdSizes); n++ )
+        {
+            const int sizeStd = stdSizes[n];
+            if ( width > sizeStd || height > sizeStd )
+            {
+                // it will become -1 if the bitmap is larger than the biggest
+                // supported size, this is intentional
+                n--;
+
+                break;
+            }
+        }
+
+        if ( n != -1 )
+        {
+            const int sizeStd = stdSizes[n];
+            if ( width != sizeStd || height != sizeStd )
+            {
+                wxASSERT_MSG( width <= sizeStd && height <= sizeStd,
+                              _T("bitmap shouldn't be cropped") );
+
+                m_bmpNormal.Create(sizeStd, sizeStd);
+                wxMemoryDC dcMem;
+                dcMem.SelectObject(m_bmpNormal);
+                dcMem.Clear();
+
+                dcMem.DrawBitmap(bitmap,
+                                 (sizeStd - width)/2, (sizeStd-height)/2,
+                                 true);
+            }
+        }
+        //else: let the system rescale the bitmap
+    }
+
+    if ( !m_bmpNormal.Ok() )
+        m_bmpNormal = bitmap;
+
+
+#ifdef __WXMAC_OSX__
+    if ( HasFlag( wxBORDER_NONE ) )
+    {
+        wxMacCreateBitmapButton( &info, m_bmpNormal, kControlContentIconRef );
+        err = CreateIconControl(
+                MAC_WXHWND(parent->MacGetTopLevelWindowRef()),
+                &bounds, &info, false, m_peer->GetControlRefAddr() );
+    }
+    else
+#endif

     {
     {

-        ::SetControlData( (ControlHandle) m_macControl , kControlButtonPart , kControlBevelButtonContentTag , sizeof(info) , (char*) &info ) ;
+        wxMacCreateBitmapButton( &info, m_bmpNormal );
+        err = CreateBevelButtonControl(
+                MAC_WXHWND(parent->MacGetTopLevelWindowRef()), &bounds, CFSTR(""),
+                ((style & wxBU_AUTODRAW) ? kControlBevelButtonSmallBevel : kControlBevelButtonNormalBevel ),
+                kControlBehaviorOffsetContents, &info, 0, 0, 0, m_peer->GetControlRefAddr() );

     }
     }

-    MacPostControlCreate() ;

 
 

-    return TRUE;
+    verify_noerr( err );
+
+    wxMacReleaseBitmapButton( &info );
+    wxASSERT_MSG( m_peer != NULL && m_peer->Ok(), wxT("No valid native Mac control") );
+
+    MacPostControlCreate( pos, size );
+
+    return true;

 }
 
 }
 

-void wxBitmapButton::SetBitmapLabel(const wxBitmap& bitmap)
+void wxBitmapButton::SetBitmapLabel( const wxBitmap& bitmap )

 {
     m_bmpNormal = bitmap;
 {
     m_bmpNormal = bitmap;

+    InvalidateBestSize();

 
 

-    ControlButtonContentInfo info ;
-    wxMacCreateBitmapButton( &info , m_bmpNormal ) ;
-    if ( info.contentType != kControlNoContent )
+    ControlButtonContentInfo info;
+
+#ifdef __WXMAC_OSX__
+    if ( HasFlag( wxBORDER_NONE ) )
+    {
+        wxMacCreateBitmapButton( &info, m_bmpNormal, kControlContentIconRef );
+        if ( info.contentType != kControlNoContent )
+            m_peer->SetData( kControlIconPart, kControlIconContentTag, info );
+    }
+    else
+#endif

     {
     {

-        ::SetControlData( (ControlHandle) m_macControl , kControlButtonPart , kControlBevelButtonContentTag , sizeof(info) , (char*) &info ) ;
+        wxMacCreateBitmapButton( &info, m_bmpNormal );
+        if ( info.contentType != kControlNoContent )
+            m_peer->SetData( kControlButtonPart, kControlBevelButtonContentTag, info );

     }
     }

+
+    wxMacReleaseBitmapButton( &info );
+}
+
+wxSize wxBitmapButton::DoGetBestSize() const
+{
+    wxSize best;
+
+    best.x = 2 * m_marginX;
+    best.y = 2 * m_marginY;
+    if ( m_bmpNormal.Ok() )
+    {
+        best.x += m_bmpNormal.GetWidth();
+        best.y += m_bmpNormal.GetHeight();
+    }
+
+    return best;

 }
 
 }
 

+#endif