unneeded line removed

[wxWidgets.git] / src / msw / tbar95.cpp

diff --git a/src/msw/tbar95.cpp b/src/msw/tbar95.cpp
index 21d8624e2afd0003f061ab698c92afaa25f8577c..d83469d6a6f106f1c9e61795d088ad709052979f 100644 (file)
--- a/src/msw/tbar95.cpp
+++ b/src/msw/tbar95.cpp
@@ -6,7 +6,7 @@
 // Created:     04/01/98
 // RCS-ID:      $Id$
 // Copyright:   (c) Julian Smart and Markus Holzem
 // Created:     04/01/98
 // RCS-ID:      $Id$
 // Copyright:   (c) Julian Smart and Markus Holzem

-// Licence:    wxWindows license
+// Licence:     wxWindows license

 /////////////////////////////////////////////////////////////////////////////
 
 #ifdef __GNUG__
 /////////////////////////////////////////////////////////////////////////////
 
 #ifdef __GNUG__


@@ -21,24 +21,26 @@
 #endif
 
 #ifndef WX_PRECOMP
 #endif
 
 #ifndef WX_PRECOMP

-#include "wx.h"
+#include "wx/wx.h"

 #endif
 
 #endif
 

-#if USE_BUTTONBAR && USE_TOOLBAR && defined(__WIN95__)
+#if wxUSE_BUTTONBAR && wxUSE_TOOLBAR && defined(__WIN95__)

 
 

-#ifndef __GNUWIN32__
+#if !defined(__GNUWIN32__) && !defined(__SALFORDC__)

 #include "malloc.h"
 #endif
 
 #include <windows.h>
 
 #include "malloc.h"
 #endif
 
 #include <windows.h>
 

-#ifndef __GNUWIN32__
+#if (defined(__WIN95__) && !defined(__GNUWIN32__)) || defined(__TWIN32__)

 #include <commctrl.h>
 #endif
 
 #include <commctrl.h>
 #endif
 

+#ifndef __TWIN32__

 #ifdef __GNUWIN32__
 #include "wx/msw/gnuwin32/extra.h"
 #endif
 #ifdef __GNUWIN32__
 #include "wx/msw/gnuwin32/extra.h"
 #endif

+#endif

 
 #include "wx/msw/dib.h"
 #include "wx/tbar95.h"
 
 #include "wx/msw/dib.h"
 #include "wx/tbar95.h"


@@ -72,19 +74,19 @@ NM_CUSTOMDRAW message and do your custom drawing.
 
 #if !USE_SHARED_LIBRARY
 IMPLEMENT_DYNAMIC_CLASS(wxToolBar95, wxToolBarBase)
 
 #if !USE_SHARED_LIBRARY
 IMPLEMENT_DYNAMIC_CLASS(wxToolBar95, wxToolBarBase)

+#endif

 
 BEGIN_EVENT_TABLE(wxToolBar95, wxToolBarBase)
 
 BEGIN_EVENT_TABLE(wxToolBar95, wxToolBarBase)

-       EVT_SIZE(wxToolBar95::OnSize)
-       EVT_PAINT(wxToolBar95::OnPaint)
-       EVT_KILL_FOCUS(wxToolBar95::OnKillFocus)
-       EVT_MOUSE_EVENTS(wxToolBar95::OnMouseEvent)
+    EVT_SIZE(wxToolBar95::OnSize)
+    EVT_PAINT(wxToolBar95::OnPaint)
+    EVT_MOUSE_EVENTS(wxToolBar95::OnMouseEvent)
+    EVT_KILL_FOCUS(wxToolBar95::OnKillFocus)

     EVT_SYS_COLOUR_CHANGED(wxToolBar95::OnSysColourChanged)
 END_EVENT_TABLE()
     EVT_SYS_COLOUR_CHANGED(wxToolBar95::OnSysColourChanged)
 END_EVENT_TABLE()

-#endif

 
 

-void wxMapBitmap(HBITMAP hBitmap, int width, int height);
+static void wxMapBitmap(HBITMAP hBitmap, int width, int height);

 
 

-wxToolBar95::wxToolBar95(void)
+wxToolBar95::wxToolBar95()

 {
   m_maxWidth = -1;
   m_maxHeight = -1;
 {
   m_maxWidth = -1;
   m_maxHeight = -1;


@@ -93,44 +95,41 @@ wxToolBar95::wxToolBar95(void)
   m_defaultHeight = DEFAULTBITMAPY;
 }
 
   m_defaultHeight = DEFAULTBITMAPY;
 }
 

-bool wxToolBar95::Create(wxWindow *parent, wxWindowID id, const wxPoint& pos, const wxSize& size,
-            long style, const wxString& name)
+bool wxToolBar95::Create(wxWindow *parent,
+                         wxWindowID id,
+                         const wxPoint& pos,
+                         const wxSize& size,
+                         long style,
+                         const wxString& name)

 {
   m_backgroundColour = wxColour(GetRValue(GetSysColor(COLOR_BTNFACE)),
 {
   m_backgroundColour = wxColour(GetRValue(GetSysColor(COLOR_BTNFACE)),

-       GetGValue(GetSysColor(COLOR_BTNFACE)), GetBValue(GetSysColor(COLOR_BTNFACE)));
+                                GetGValue(GetSysColor(COLOR_BTNFACE)),
+                                GetBValue(GetSysColor(COLOR_BTNFACE)));

   m_foregroundColour = *wxBLACK ;
 
   m_foregroundColour = *wxBLACK ;
 

-  m_defaultForegroundColour = *wxBLACK ;
-  m_defaultBackgroundColour = wxColour(GetRValue(GetSysColor(COLOR_BTNFACE)),
-       GetGValue(GetSysColor(COLOR_BTNFACE)), GetBValue(GetSysColor(COLOR_BTNFACE)));
+  wxASSERT_MSG( (style & wxTB_VERTICAL) == 0,
+                "Sorry, wxToolBar95 under Windows 95 only "
+                "supports horizontal orientation." );

 
 

-  if (style & wxTB_VERTICAL)
-    wxMessageBox("Sorry, wxToolBar95 under Windows 95 only supports vertical tiling.", "wxToolBar95 usage", wxOK);

   m_maxWidth = -1;
   m_maxHeight = -1;
   m_maxWidth = -1;
   m_maxHeight = -1;

-  
+

   m_hBitmap = 0;
 
   m_defaultWidth = DEFAULTBITMAPX;
   m_defaultHeight = DEFAULTBITMAPY;
   SetName(name);
 
   m_hBitmap = 0;
 
   m_defaultWidth = DEFAULTBITMAPX;
   m_defaultHeight = DEFAULTBITMAPY;
   SetName(name);
 

-  int x = pos.x;
-  int y = pos.y;
-  int width = size.x;
-  int height = size.y;
-

   m_windowStyle = style;
 
   SetFont(wxSystemSettings::GetSystemFont(wxSYS_DEFAULT_GUI_FONT));
   m_windowStyle = style;
 
   SetFont(wxSystemSettings::GetSystemFont(wxSYS_DEFAULT_GUI_FONT));

-

   SetParent(parent);
 
   SetParent(parent);
 

-  DWORD msflags = 0;
-  if (style & wxBORDER)
-    msflags |= WS_BORDER;
-  msflags |= WS_CHILD | WS_VISIBLE;
-  
+  int x = pos.x;
+  int y = pos.y;
+  int width = size.x;
+  int height = size.y;
+

   if (width <= 0)
     width = 100;
   if (height <= 0)
   if (width <= 0)
     width = 100;
   if (height <= 0)


@@ -141,37 +140,47 @@ bool wxToolBar95::Create(wxWindow *parent, wxWindowID id, const wxPoint& pos, co
     y = 0;
 
   m_windowId = (id < 0 ? NewControlId() : id);
     y = 0;
 
   m_windowId = (id < 0 ? NewControlId() : id);

-  DWORD msStyle = WS_CHILD | WS_BORDER | WS_VISIBLE | TBSTYLE_TOOLTIPS;
+  DWORD msflags = 0;
+  if (style & wxBORDER)
+    msflags |= WS_BORDER;
+  msflags |= WS_CHILD | WS_VISIBLE | TBSTYLE_TOOLTIPS;

 
   if (style & wxTB_FLAT)
   {
     if (wxTheApp->GetComCtl32Version() > 400)
 
   if (style & wxTB_FLAT)
   {
     if (wxTheApp->GetComCtl32Version() > 400)

-        msStyle |= TBSTYLE_FLAT;
+        msflags |= TBSTYLE_FLAT;

   }
 
   // Create the toolbar control.
   }
 
   // Create the toolbar control.

-  HWND hWndToolbar = CreateWindowEx(0L,   // No extended styles.
-    TOOLBARCLASSNAME,                 // Class name for the toolbar.
-    "",                               // No default text.
-    msStyle,    // Styles and defaults.
-    x, y, width, height,                    // Standard toolbar size and position.
-    (HWND) parent->GetHWND(),                       // Parent window of the toolbar.
-    (HMENU)m_windowId,                // Toolbar ID.
-    wxGetInstance(),                            // Current instance.
-    NULL );                           // No class data.
+  HWND hWndToolbar = CreateWindowEx
+                     (
+                      0L,                       // No extended styles.
+                      TOOLBARCLASSNAME,         // Class name for the toolbar.
+                      "",                       // No default text.
+                      msflags,                  // Styles
+                      x, y, width, height,      // Standard toolbar size and position.
+                      (HWND) parent->GetHWND(), // Parent window of the toolbar.
+                      (HMENU)m_windowId,        // Toolbar ID.
+                      wxGetInstance(),          // Current instance.
+                      NULL                      // No class data.
+                     );
+
+  wxCHECK_MSG( hWndToolbar, FALSE, "Toolbar creation failed" );

 
   // Toolbar-specific initialisation
 
   // Toolbar-specific initialisation

-  ::SendMessage(hWndToolbar, TB_BUTTONSTRUCTSIZE, (WPARAM)sizeof(TBBUTTON), (LPARAM)0);
+  ::SendMessage(hWndToolbar, TB_BUTTONSTRUCTSIZE,
+                (WPARAM)sizeof(TBBUTTON), (LPARAM)0);

 
   m_hWnd = (WXHWND) hWndToolbar;
 
   m_hWnd = (WXHWND) hWndToolbar;

-  if (parent) parent->AddChild(this);
-  
-  SubclassWin((WXHWND) hWndToolbar);
+  if (parent)
+      parent->AddChild(this);
+
+  SubclassWin((WXHWND)hWndToolbar);

 
   return TRUE;
 }
 
 
   return TRUE;
 }
 

-wxToolBar95::~wxToolBar95(void)
+wxToolBar95::~wxToolBar95()

 {
   UnsubclassWin();
 
 {
   UnsubclassWin();
 


@@ -182,13 +191,13 @@ wxToolBar95::~wxToolBar95(void)
   }
 }
 
   }
 }
 

-bool wxToolBar95::CreateTools(void)
+bool wxToolBar95::CreateTools()

 {
   if (m_tools.Number() == 0)
     return FALSE;
 
   HBITMAP oldToolBarBitmap = (HBITMAP) m_hBitmap;
 {
   if (m_tools.Number() == 0)
     return FALSE;
 
   HBITMAP oldToolBarBitmap = (HBITMAP) m_hBitmap;

-    
+

   int totalBitmapWidth = (int)(m_defaultWidth * m_tools.Number());
   int totalBitmapHeight = (int)m_defaultHeight;
 
   int totalBitmapWidth = (int)(m_defaultWidth * m_tools.Number());
   int totalBitmapHeight = (int)m_defaultHeight;
 


@@ -196,7 +205,7 @@ bool wxToolBar95::CreateTools(void)
   HDC dc = ::GetDC(NULL);
   m_hBitmap = (WXHBITMAP) ::CreateCompatibleBitmap(dc, totalBitmapWidth, totalBitmapHeight);
   ::ReleaseDC(NULL, dc);
   HDC dc = ::GetDC(NULL);
   m_hBitmap = (WXHBITMAP) ::CreateCompatibleBitmap(dc, totalBitmapWidth, totalBitmapHeight);
   ::ReleaseDC(NULL, dc);

-  
+

   // Now blit all the tools onto this bitmap
   HDC memoryDC = ::CreateCompatibleDC(NULL);
   HBITMAP oldBitmap = (HBITMAP) ::SelectObject(memoryDC, (HBITMAP) m_hBitmap);
   // Now blit all the tools onto this bitmap
   HDC memoryDC = ::CreateCompatibleDC(NULL);
   HBITMAP oldBitmap = (HBITMAP) ::SelectObject(memoryDC, (HBITMAP) m_hBitmap);


@@ -214,7 +223,7 @@ bool wxToolBar95::CreateTools(void)
 
       HBITMAP oldBitmap2 = (HBITMAP) ::SelectObject(memoryDC2, (HBITMAP) tool->m_bitmap1.GetHBITMAP());
       /* int bltResult = */
 
       HBITMAP oldBitmap2 = (HBITMAP) ::SelectObject(memoryDC2, (HBITMAP) tool->m_bitmap1.GetHBITMAP());
       /* int bltResult = */

-         BitBlt(memoryDC, x, 0, (int) m_defaultWidth, (int) m_defaultHeight, memoryDC2,
+      BitBlt(memoryDC, x, 0, (int) m_defaultWidth, (int) m_defaultHeight, memoryDC2,

                         0, 0, SRCCOPY);
       ::SelectObject(memoryDC2, oldBitmap2);
       x += (int)m_defaultWidth;
                         0, 0, SRCCOPY);
       ::SelectObject(memoryDC2, oldBitmap2);
       x += (int)m_defaultWidth;


@@ -295,18 +304,18 @@ bool wxToolBar95::CreateTools(void)
 
       bitmapId ++;
     }
 
       bitmapId ++;
     }

-        
+

     i ++;
     node = node->Next();
   }
 
     i ++;
     node = node->Next();
   }
 

-  int ans = (int)::SendMessage((HWND) GetHWND(), TB_ADDBUTTONS, (WPARAM)i, (LPARAM)& buttons);
-  ans = (int)::SendMessage((HWND) GetHWND(), TB_AUTOSIZE, (WPARAM)0, (LPARAM) 0);
+  long rc = ::SendMessage((HWND) GetHWND(), TB_ADDBUTTONS, (WPARAM)i, (LPARAM)& buttons);

 
 

-  RECT rect;
-  ::SendMessage((HWND) GetHWND(), TB_SETROWS, MAKEWPARAM(m_maxRows, TRUE), (LPARAM) & rect);
-  m_maxWidth = (rect.right - rect.left + 2);
-  m_maxHeight = (rect.bottom - rect.top + 2);
+  wxCHECK_MSG( rc, FALSE, "failed to add buttons to the toolbar" );
+
+  (void)::SendMessage((HWND) GetHWND(), TB_AUTOSIZE, (WPARAM)0, (LPARAM) 0);
+
+  SetRows(m_maxRows);

 
   return TRUE;
 }
 
   return TRUE;
 }


@@ -329,47 +338,64 @@ bool wxToolBar95::MSWCommand(WXUINT cmd, WXWORD id)
   return TRUE;
 }
 
   return TRUE;
 }
 

-bool wxToolBar95::MSWNotify(WXWPARAM WXUNUSED(wParam), WXLPARAM lParam)
+bool wxToolBar95::MSWNotify(WXWPARAM WXUNUSED(wParam),
+                            WXLPARAM lParam,
+                            WXLPARAM *result)

 {
 {

-       // First check if this applies to us
+    // First check if this applies to us

     NMHDR *hdr = (NMHDR *)lParam;
     NMHDR *hdr = (NMHDR *)lParam;

-    if (hdr->code != TTN_NEEDTEXT)
-               return FALSE;

 
 

-       HWND toolTipWnd = (HWND) ::SendMessage((HWND) GetHWND(), TB_GETTOOLTIPS, 0, 0);
-       if ( toolTipWnd != hdr->hwndFrom )
-               return FALSE;
+    // the tooltips control created by the toolbar is sometimes Unicode, even in
+    // an ANSI application
+    if ( (hdr->code != TTN_NEEDTEXTA) && (hdr->code != TTN_NEEDTEXTW) )
+        return FALSE;

 
 

-  LPTOOLTIPTEXT ttText = (LPTOOLTIPTEXT) lParam;
-  int id = (int)ttText->hdr.idFrom;
-  wxNode *node = m_tools.Find((long)id);
-  if (!node)
-    return FALSE;
-  
-  wxToolBarTool *tool = (wxToolBarTool *)node->Data();
+    HWND toolTipWnd = (HWND)::SendMessage((HWND)GetHWND(), TB_GETTOOLTIPS, 0, 0);
+    if ( toolTipWnd != hdr->hwndFrom )
+        return FALSE;

 
 

-  switch (ttText->hdr.code)
-  {
-    case TTN_NEEDTEXT:
-    {
-      if (tool->m_shortHelpString != "")
-        ttText->lpszText = (char *) (const char *)tool->m_shortHelpString;
+    LPTOOLTIPTEXT ttText = (LPTOOLTIPTEXT)lParam;
+    int id = (int)ttText->hdr.idFrom;
+    wxNode *node = m_tools.Find((long)id);
+    if (!node)
+        return FALSE;

 
 

-      // For backward compatibility...
-      OnMouseEnter(tool->m_index);
-      break;
+    wxToolBarTool *tool = (wxToolBarTool *)node->Data();
+
+    if ( tool->m_shortHelpString != "" )
+    {
+        if ( hdr->code == TTN_NEEDTEXTA )
+        {
+            ttText->lpszText = (char *)(const char *)tool->m_shortHelpString;
+        }
+#if (_WIN32_IE >= 0x0300)
+        else
+        {
+            // FIXME this is a temp hack only until I understand better what
+            //       must be done in both ANSI and Unicode builds
+            size_t lenAnsi = tool->m_shortHelpString.Len();
+            size_t lenUnicode = mbstowcs(NULL, tool->m_shortHelpString, lenAnsi);
+            wchar_t *pwz = new wchar_t[lenUnicode + 1];
+            mbstowcs(pwz, tool->m_shortHelpString, lenAnsi + 1);
+            memcpy(ttText->szText, pwz,
+                   (sizeof(ttText->szText) - 1)/sizeof(ttText->szText[0]));
+            ttText->szText[WXSIZEOF(ttText->szText)] = 0;
+
+            delete [] pwz;
+        }
+#endif // _WIN32_IE >= 0x0300

     }
     }

-    default:
-      return FALSE;
-      break;
-  }
-  
-  return TRUE;
+
+    // For backward compatibility...
+    OnMouseEnter(tool->m_index);
+
+    return TRUE;

 }
 
 void wxToolBar95::SetToolBitmapSize(const wxSize& size)
 {
 }
 
 void wxToolBar95::SetToolBitmapSize(const wxSize& size)
 {

-  m_defaultWidth = size.x; m_defaultHeight = size.y;
+  m_defaultWidth = size.x;
+  m_defaultHeight = size.y;

   ::SendMessage((HWND) GetHWND(), TB_SETBITMAPSIZE, 0, (LPARAM) MAKELONG ((int)size.x, (int)size.y));
 }
 
   ::SendMessage((HWND) GetHWND(), TB_SETBITMAPSIZE, 0, (LPARAM) MAKELONG ((int)size.x, (int)size.y));
 }
 


@@ -381,9 +407,9 @@ void wxToolBar95::SetRows(int nRows)
   m_maxHeight = (rect.bottom - rect.top + 2);
 }
 
   m_maxHeight = (rect.bottom - rect.top + 2);
 }
 

-wxSize wxToolBar95::GetMaxSize(void) const
+wxSize wxToolBar95::GetMaxSize() const

 {
 {

-  if (m_maxWidth == -1 | m_maxHeight == -1)
+  if ((m_maxWidth == -1) || (m_maxHeight == -1))

   {
     RECT rect;
     ::SendMessage((HWND) GetHWND(), TB_SETROWS, MAKEWPARAM(m_maxRows, TRUE), (LPARAM) & rect);
   {
     RECT rect;
     ::SendMessage((HWND) GetHWND(), TB_SETROWS, MAKEWPARAM(m_maxRows, TRUE), (LPARAM) & rect);


@@ -402,7 +428,7 @@ void wxToolBar95::GetSize(int *w, int *h) const
 }
 
 // The button size is bigger than the bitmap size
 }
 
 // The button size is bigger than the bitmap size

-wxSize wxToolBar95::GetToolSize(void) const
+wxSize wxToolBar95::GetToolSize() const

 {
   return wxSize(m_defaultWidth + 8, m_defaultHeight + 7);
 }
 {
   return wxSize(m_defaultWidth + 8, m_defaultHeight + 7);
 }


@@ -432,7 +458,12 @@ void wxToolBar95::ToggleTool(int toolIndex, bool toggle)
   }
 }
 
   }
 }
 

-void wxToolBar95::ClearTools(void)
+bool wxToolBar95::GetToolState(int toolIndex) const
+{
+    return (::SendMessage((HWND) GetHWND(), TB_ISBUTTONCHECKED, (WPARAM)toolIndex, (LPARAM)0) != 0);
+}
+
+void wxToolBar95::ClearTools()

 {
   // TODO: Don't know how to reset the toolbar bitmap, as yet.
   // But adding tools and calling CreateTools should probably
 {
   // TODO: Don't know how to reset the toolbar bitmap, as yet.
   // But adding tools and calling CreateTools should probably


@@ -446,7 +477,7 @@ void wxToolBar95::ClearTools(void)
 wxToolBarTool *wxToolBar95::AddTool(int index, const wxBitmap& bitmap, const wxBitmap& pushedBitmap,
              bool toggle, long xPos, long yPos, wxObject *clientData, const wxString& helpString1, const wxString& helpString2)
 {
 wxToolBarTool *wxToolBar95::AddTool(int index, const wxBitmap& bitmap, const wxBitmap& pushedBitmap,
              bool toggle, long xPos, long yPos, wxObject *clientData, const wxString& helpString1, const wxString& helpString2)
 {

-  wxToolBarTool *tool = new wxToolBarTool(index, bitmap, (wxBitmap *)NULL, toggle, xPos, yPos, helpString1, helpString2);
+  wxToolBarTool *tool = new wxToolBarTool(index, bitmap, wxNullBitmap, toggle, xPos, yPos, helpString1, helpString2);

   tool->m_clientData = clientData;
 
   if (xPos > -1)
   tool->m_clientData = clientData;
 
   if (xPos > -1)


@@ -459,7 +490,7 @@ wxToolBarTool *wxToolBar95::AddTool(int index, const wxBitmap& bitmap, const wxB
   else
     tool->m_y = m_yMargin;
 
   else
     tool->m_y = m_yMargin;
 

-  tool->SetSize(GetDefaultButtonWidth(), GetDefaultButtonHeight());
+  tool->SetSize(GetToolSize().x, GetToolSize().y);

 
   m_tools.Append((long)index, tool);
   return tool;
 
   m_tools.Append((long)index, tool);
   return tool;


@@ -469,9 +500,7 @@ wxToolBarTool *wxToolBar95::AddTool(int index, const wxBitmap& bitmap, const wxB
 void wxToolBar95::OnSysColourChanged(wxSysColourChangedEvent& event)
 {
     m_backgroundColour = wxColour(GetRValue(GetSysColor(COLOR_BTNFACE)),
 void wxToolBar95::OnSysColourChanged(wxSysColourChangedEvent& event)
 {
     m_backgroundColour = wxColour(GetRValue(GetSysColor(COLOR_BTNFACE)),

-           GetGValue(GetSysColor(COLOR_BTNFACE)), GetBValue(GetSysColor(COLOR_BTNFACE)));
-    m_defaultBackgroundColour = wxColour(GetRValue(GetSysColor(COLOR_BTNFACE)),
-           GetGValue(GetSysColor(COLOR_BTNFACE)), GetBValue(GetSysColor(COLOR_BTNFACE)));
+          GetGValue(GetSysColor(COLOR_BTNFACE)), GetBValue(GetSysColor(COLOR_BTNFACE)));

 
     // Remap the buttons
     CreateTools();
 
     // Remap the buttons
     CreateTools();


@@ -484,6 +513,20 @@ void wxToolBar95::OnSysColourChanged(wxSysColourChangedEvent& event)
     wxWindow::OnSysColourChanged(event);
 }
 
     wxWindow::OnSysColourChanged(event);
 }
 

+void wxToolBar95::OnMouseEvent(wxMouseEvent& event)
+{
+    if (event.RightDown())
+    {
+        // For now, we don't have an id. Later we could
+        // try finding the tool.
+        OnRightClick((int)-1, event.GetX(), event.GetY());
+    }
+    else
+    {
+        Default();
+    }
+}
+

 // These are the default colors used to map the bitmap colors
 // to the current system colors
 
 // These are the default colors used to map the bitmap colors
 // to the current system colors