No changes, just fix some typos in wxDFB comments.

[wxWidgets.git] / src / common / fswatchercmn.cpp

diff --git a/src/common/fswatchercmn.cpp b/src/common/fswatchercmn.cpp
index 1f8946be9e848a311850b700d361d26d7975afc0..7382c2f6fb52abbbbe2809bbdf7a5957b35617cc 100644 (file)
--- a/src/common/fswatchercmn.cpp
+++ b/src/common/fswatchercmn.cpp
@@ -79,10 +79,30 @@ wxFileSystemWatcherBase::~wxFileSystemWatcherBase()
 
 bool wxFileSystemWatcherBase::Add(const wxFileName& path, int events)
 {
-    // args validation & consistency checks
-    if (!path.FileExists() && !path.DirExists())
+    wxFSWPathType type = wxFSWPath_None;
+    if ( path.FileExists() )
+    {
+        type = wxFSWPath_File;
+    }
+    else if ( path.DirExists() )
+    {
+        type = wxFSWPath_Dir;
+    }
+    else
+    {
+        wxLogError(_("Can't monitor non-existent path \"%s\" for changes."),
+                   path.GetFullPath());
         return false;
+    }
 
+    return AddAny(path, events, type);
+}
+
+bool
+wxFileSystemWatcherBase::AddAny(const wxFileName& path,
+                                int events,
+                                wxFSWPathType type)
+{
     wxString canonical = GetCanonicalPath(path);
     if (canonical.IsEmpty())
         return false;
@@ -91,7 +111,7 @@ bool wxFileSystemWatcherBase::Add(const wxFileName& path, int events)
                 wxString::Format("Path '%s' is already watched", canonical));
 
     // adding a path in a platform specific way
-    wxFSWatchInfo watch(canonical, events);
+    wxFSWatchInfo watch(canonical, events, type);
     if ( !m_service->Add(watch) )
         return false;
 
@@ -139,17 +159,22 @@ bool wxFileSystemWatcherBase::AddTree(const wxFileName& path, int events,
         // all of them to Add() and let it choose? this is useful when adding a
         // file to a dir that is already watched, then not only should we know
         // about that, but Add() should also behave well then
-        virtual wxDirTraverseResult OnFile(const wxString& WXUNUSED(filename))
+        virtual wxDirTraverseResult OnFile(const wxString& filename)
         {
+            wxLogTrace(wxTRACE_FSWATCHER,
+                       "--- AddTree adding file '%s' ---", filename);
+            m_watcher->AddAny(wxFileName::FileName(filename),
+                             m_events, wxFSWPath_File);
             return wxDIR_CONTINUE;
         }
 
         virtual wxDirTraverseResult OnDir(const wxString& dirname)
         {
-            wxLogTrace(wxTRACE_FSWATCHER, "--- AddTree adding '%s' ---",
-                                                                    dirname);
+            wxLogTrace(wxTRACE_FSWATCHER,
+                       "--- AddTree adding directory '%s' ---", dirname);
             // we add as much as possible and ignore errors
-            m_watcher->Add(wxFileName(dirname), m_events);
+            m_watcher->AddAny(wxFileName::DirName(dirname),
+                             m_events, wxFSWPath_Dir);
             return wxDIR_CONTINUE;
         }
 
@@ -163,6 +188,9 @@ bool wxFileSystemWatcherBase::AddTree(const wxFileName& path, int events,
     AddTraverser traverser(this, events);
     dir.Traverse(traverser, filter);
 
+    // Add the path itself explicitly as Traverse() doesn't return it.
+    Add(path.GetPathWithSep(), events);
+
     return true;
 }
 
@@ -189,7 +217,7 @@ bool wxFileSystemWatcherBase::RemoveTree(const wxFileName& path)
 
         virtual wxDirTraverseResult OnDir(const wxString& dirname)
         {
-            m_watcher->RemoveTree(wxFileName(dirname));
+            m_watcher->Remove(wxFileName::DirName(dirname));
             return wxDIR_CONTINUE;
         }
 
@@ -201,6 +229,9 @@ bool wxFileSystemWatcherBase::RemoveTree(const wxFileName& path)
     RemoveTraverser traverser(this);
     dir.Traverse(traverser);
 
+    // As in AddTree() above, handle the path itself explicitly.
+    Remove(path);
+
     return true;
 }