Minor cleanup.

[wxWidgets.git] / src / common / image.cpp

diff --git a/src/common/image.cpp b/src/common/image.cpp
index 11e464a43c602cdc265f0103c1b227260bfd909d..f771aecf99231262a0e75a788d919d5324d61d3b 100644 (file)
--- a/src/common/image.cpp
+++ b/src/common/image.cpp
@@ -16,20 +16,20 @@
 
 #if wxUSE_IMAGE
 
 
 #if wxUSE_IMAGE
 

+#include "wx/image.h"
+

 #ifndef WX_PRECOMP
     #include "wx/log.h"
 #ifndef WX_PRECOMP
     #include "wx/log.h"

-    #include "wx/app.h"

     #include "wx/hash.h"
     #include "wx/utils.h"
     #include "wx/hash.h"
     #include "wx/utils.h"

+    #include "wx/math.h"
+    #include "wx/module.h"
+    #include "wx/palette.h"
+    #include "wx/intl.h"

 #endif
 
 #endif
 

-#include "wx/image.h"
-#include "wx/bitmap.h"

 #include "wx/filefn.h"
 #include "wx/wfstream.h"
 #include "wx/filefn.h"
 #include "wx/wfstream.h"

-#include "wx/intl.h"
-#include "wx/module.h"
-#include "wx/math.h"

 
 #if wxUSE_XPM
     #include "wx/xpmdecod.h"
 
 #if wxUSE_XPM
     #include "wx/xpmdecod.h"


@@ -38,6 +38,19 @@
 // For memcpy
 #include <string.h>
 
 // For memcpy
 #include <string.h>
 

+// make the code compile with either wxFile*Stream or wxFFile*Stream:
+#define HAS_FILE_STREAMS (wxUSE_STREAMS && (wxUSE_FILE || wxUSE_FFILE))
+
+#if HAS_FILE_STREAMS
+    #if wxUSE_FILE
+        typedef wxFileInputStream wxImageFileInputStream;
+        typedef wxFileOutputStream wxImageFileOutputStream;
+    #elif wxUSE_FFILE
+        typedef wxFFileInputStream wxImageFileInputStream;
+        typedef wxFFileOutputStream wxImageFileOutputStream;
+    #endif // wxUSE_FILE/wxUSE_FFILE
+#endif // HAS_FILE_STREAMS
+

 //-----------------------------------------------------------------------------
 // wxImage
 //-----------------------------------------------------------------------------
 //-----------------------------------------------------------------------------
 // wxImage
 //-----------------------------------------------------------------------------


@@ -107,7 +120,7 @@ wxImage wxNullImage;
 
 //-----------------------------------------------------------------------------
 
 
 //-----------------------------------------------------------------------------
 

-#define M_IMGDATA ((wxImageRefData *)m_refData)
+#define M_IMGDATA wx_static_cast(wxImageRefData*, m_refData)

 
 IMPLEMENT_DYNAMIC_CLASS(wxImage, wxObject)
 
 
 IMPLEMENT_DYNAMIC_CLASS(wxImage, wxObject)
 


@@ -234,36 +247,48 @@ void wxImage::Destroy()
     UnRef();
 }
 
     UnRef();
 }
 

-wxImage wxImage::Copy() const
+wxObjectRefData* wxImage::CreateRefData() const

 {
 {

-    wxImage image;
-
-    wxCHECK_MSG( Ok(), image, wxT("invalid image") );
-
-    image.Create( M_IMGDATA->m_width, M_IMGDATA->m_height, false );
-
-    unsigned char *data = image.GetData();
-
-    wxCHECK_MSG( data, image, wxT("unable to create image") );
-
-    image.SetMaskColour( M_IMGDATA->m_maskRed, M_IMGDATA->m_maskGreen, M_IMGDATA->m_maskBlue );
-    image.SetMask( M_IMGDATA->m_hasMask );
-
-    memcpy( data, GetData(), M_IMGDATA->m_width*M_IMGDATA->m_height*3 );
+    return new wxImageRefData;
+}

 
 

-    wxImageRefData *imgData = (wxImageRefData *)image.m_refData;
+wxObjectRefData* wxImage::CloneRefData(const wxObjectRefData* that) const
+{
+    const wxImageRefData* refData = wx_static_cast(const wxImageRefData*, that);
+    wxCHECK_MSG(refData->m_ok, NULL, wxT("invalid image") );

 
 

-    // also copy the alpha channel
-    if (HasAlpha())
+    wxImageRefData* refData_new = new wxImageRefData;
+    refData_new->m_width = refData->m_width;
+    refData_new->m_height = refData->m_height;
+    refData_new->m_maskRed = refData->m_maskRed;
+    refData_new->m_maskGreen = refData->m_maskGreen;
+    refData_new->m_maskBlue = refData->m_maskBlue;
+    refData_new->m_hasMask = refData->m_hasMask;
+    refData_new->m_ok = true;
+    unsigned size = unsigned(refData->m_width) * unsigned(refData->m_height);
+    if (refData->m_alpha != NULL)

     {
     {

-        image.SetAlpha();
-        unsigned char* alpha = image.GetAlpha();
-        memcpy( alpha, GetAlpha(), M_IMGDATA->m_width*M_IMGDATA->m_height );
+        refData_new->m_alpha = (unsigned char*)malloc(size);
+        memcpy(refData_new->m_alpha, refData->m_alpha, size);

     }
     }

+    size *= 3;
+    refData_new->m_data = (unsigned char*)malloc(size);
+    memcpy(refData_new->m_data, refData->m_data, size);
+#if wxUSE_PALETTE
+    refData_new->m_palette = refData->m_palette;
+#endif
+    refData_new->m_optionNames = refData->m_optionNames;
+    refData_new->m_optionValues = refData->m_optionValues;
+    return refData_new;
+}

 
 

-    // also copy the image options
-    imgData->m_optionNames = M_IMGDATA->m_optionNames;
-    imgData->m_optionValues = M_IMGDATA->m_optionValues;
+wxImage wxImage::Copy() const
+{
+    wxImage image;
+
+    wxCHECK_MSG( Ok(), image, wxT("invalid image") );
+
+    image.m_refData = CloneRefData(m_refData);

 
     return image;
 }
 
     return image;
 }


@@ -271,7 +296,7 @@ wxImage wxImage::Copy() const
 wxImage wxImage::ShrinkBy( int xFactor , int yFactor ) const
 {
     if( xFactor == 1 && yFactor == 1 )
 wxImage wxImage::ShrinkBy( int xFactor , int yFactor ) const
 {
     if( xFactor == 1 && yFactor == 1 )

-        return Copy() ;
+        return *this;

 
     wxImage image;
 
 
     wxImage image;
 


@@ -730,6 +755,8 @@ void wxImage::Paste( const wxImage &image, int x, int y )
     wxCHECK_RET( Ok(), wxT("invalid image") );
     wxCHECK_RET( image.Ok(), wxT("invalid image") );
 
     wxCHECK_RET( Ok(), wxT("invalid image") );
     wxCHECK_RET( image.Ok(), wxT("invalid image") );
 

+    AllocExclusive();
+

     int xx = 0;
     int yy = 0;
     int width = image.GetWidth();
     int xx = 0;
     int yy = 0;
     int width = image.GetWidth();


@@ -811,6 +838,8 @@ void wxImage::Replace( unsigned char r1, unsigned char g1, unsigned char b1,
 {
     wxCHECK_RET( Ok(), wxT("invalid image") );
 
 {
     wxCHECK_RET( Ok(), wxT("invalid image") );
 

+    AllocExclusive();
+

     unsigned char *data = GetData();
 
     const int w = GetWidth();
     unsigned char *data = GetData();
 
     const int w = GetWidth();


@@ -947,6 +976,8 @@ void wxImage::SetRGB( int x, int y, unsigned char r, unsigned char g, unsigned c
     long pos = XYToIndex(x, y);
     wxCHECK_RET( pos != -1, wxT("invalid image coordinates") );
 
     long pos = XYToIndex(x, y);
     wxCHECK_RET( pos != -1, wxT("invalid image coordinates") );
 

+    AllocExclusive();
+

     pos *= 3;
 
     M_IMGDATA->m_data[ pos   ] = r;
     pos *= 3;
 
     M_IMGDATA->m_data[ pos   ] = r;


@@ -958,6 +989,8 @@ void wxImage::SetRGB( const wxRect& rect_, unsigned char r, unsigned char g, uns
 {
     wxCHECK_RET( Ok(), wxT("invalid image") );
 
 {
     wxCHECK_RET( Ok(), wxT("invalid image") );
 

+    AllocExclusive();
+

     wxRect rect(rect_);
     wxRect imageRect(0, 0, GetWidth(), GetHeight());
     if ( rect == wxRect() )
     wxRect rect(rect_);
     wxRect imageRect(0, 0, GetWidth(), GetHeight());
     if ( rect == wxRect() )


@@ -966,8 +999,8 @@ void wxImage::SetRGB( const wxRect& rect_, unsigned char r, unsigned char g, uns
     }
     else
     {
     }
     else
     {

-        wxCHECK_RET( imageRect.Inside(rect.GetTopLeft()) &&
-                     imageRect.Inside(rect.GetBottomRight()),
+        wxCHECK_RET( imageRect.Contains(rect.GetTopLeft()) &&
+                     imageRect.Contains(rect.GetBottomRight()),

                      wxT("invalid bounding rectangle") );
     }
 
                      wxT("invalid bounding rectangle") );
     }
 


@@ -1096,6 +1129,8 @@ void wxImage::SetAlpha(int x, int y, unsigned char alpha)
     long pos = XYToIndex(x, y);
     wxCHECK_RET( pos != -1, wxT("invalid image coordinates") );
 
     long pos = XYToIndex(x, y);
     wxCHECK_RET( pos != -1, wxT("invalid image coordinates") );
 

+    AllocExclusive();
+

     M_IMGDATA->m_alpha[pos] = alpha;
 }
 
     M_IMGDATA->m_alpha[pos] = alpha;
 }
 


@@ -1138,6 +1173,8 @@ void wxImage::SetAlpha( unsigned char *alpha, bool static_data )
 {
     wxCHECK_RET( Ok(), wxT("invalid image") );
 
 {
     wxCHECK_RET( Ok(), wxT("invalid image") );
 

+    AllocExclusive();
+

     if ( !alpha )
     {
         alpha = (unsigned char *)malloc(M_IMGDATA->m_width*M_IMGDATA->m_height);
     if ( !alpha )
     {
         alpha = (unsigned char *)malloc(M_IMGDATA->m_width*M_IMGDATA->m_height);


@@ -1199,6 +1236,8 @@ void wxImage::SetMaskColour( unsigned char r, unsigned char g, unsigned char b )
 {
     wxCHECK_RET( Ok(), wxT("invalid image") );
 
 {
     wxCHECK_RET( Ok(), wxT("invalid image") );
 

+    AllocExclusive();
+

     M_IMGDATA->m_maskRed = r;
     M_IMGDATA->m_maskGreen = g;
     M_IMGDATA->m_maskBlue = b;
     M_IMGDATA->m_maskRed = r;
     M_IMGDATA->m_maskGreen = g;
     M_IMGDATA->m_maskBlue = b;


@@ -1248,6 +1287,8 @@ void wxImage::SetMask( bool mask )
 {
     wxCHECK_RET( Ok(), wxT("invalid image") );
 
 {
     wxCHECK_RET( Ok(), wxT("invalid image") );
 

+    AllocExclusive();
+

     M_IMGDATA->m_hasMask = mask;
 }
 
     M_IMGDATA->m_hasMask = mask;
 }
 


@@ -1307,6 +1348,8 @@ bool wxImage::SetMaskFromImage(const wxImage& mask,
         return false ;
     }
 
         return false ;
     }
 

+    AllocExclusive();
+

     unsigned char *imgdata = GetData();
     unsigned char *maskdata = mask.GetData();
 
     unsigned char *imgdata = GetData();
     unsigned char *maskdata = mask.GetData();
 


@@ -1346,6 +1389,8 @@ bool wxImage::ConvertAlphaToMask(unsigned char threshold)
         return false;
     }
 
         return false;
     }
 

+    AllocExclusive();
+

     SetMask(true);
     SetMaskColour(mr, mg, mb);
 
     SetMask(true);
     SetMaskColour(mr, mg, mb);
 


@@ -1399,6 +1444,8 @@ void wxImage::SetPalette(const wxPalette& palette)
 {
     wxCHECK_RET( Ok(), wxT("invalid image") );
 
 {
     wxCHECK_RET( Ok(), wxT("invalid image") );
 

+    AllocExclusive();
+

     M_IMGDATA->m_palette = palette;
 }
 
     M_IMGDATA->m_palette = palette;
 }
 


@@ -1412,6 +1459,8 @@ void wxImage::SetOption(const wxString& name, const wxString& value)
 {
     wxCHECK_RET( Ok(), wxT("invalid image") );
 
 {
     wxCHECK_RET( Ok(), wxT("invalid image") );
 

+    AllocExclusive();
+

     int idx = M_IMGDATA->m_optionNames.Index(name, false);
     if (idx == wxNOT_FOUND)
     {
     int idx = M_IMGDATA->m_optionNames.Index(name, false);
     if (idx == wxNOT_FOUND)
     {


@@ -1459,12 +1508,14 @@ bool wxImage::HasOption(const wxString& name) const
 // image I/O
 // ----------------------------------------------------------------------------
 
 // image I/O
 // ----------------------------------------------------------------------------
 

-bool wxImage::LoadFile( const wxString& filename, long type, int index )
+bool wxImage::LoadFile( const wxString& WXUNUSED_UNLESS_STREAMS(filename),
+                        long WXUNUSED_UNLESS_STREAMS(type),
+                        int WXUNUSED_UNLESS_STREAMS(index) )

 {
 {

-#if wxUSE_STREAMS
+#if HAS_FILE_STREAMS

     if (wxFileExists(filename))
     {
     if (wxFileExists(filename))
     {

-        wxFileInputStream stream(filename);
+        wxImageFileInputStream stream(filename);

         wxBufferedInputStream bstream( stream );
         return LoadFile(bstream, type, index);
     }
         wxBufferedInputStream bstream( stream );
         return LoadFile(bstream, type, index);
     }


@@ -1474,17 +1525,19 @@ bool wxImage::LoadFile( const wxString& filename, long type, int index )
 
         return false;
     }
 
         return false;
     }

-#else // !wxUSE_STREAMS
+#else // !HAS_FILE_STREAMS

     return false;
     return false;

-#endif // wxUSE_STREAMS
+#endif // HAS_FILE_STREAMS

 }
 
 }
 

-bool wxImage::LoadFile( const wxString& filename, const wxString& mimetype, int index )
+bool wxImage::LoadFile( const wxString& WXUNUSED_UNLESS_STREAMS(filename),
+                        const wxString& WXUNUSED_UNLESS_STREAMS(mimetype),
+                        int WXUNUSED_UNLESS_STREAMS(index) )

 {
 {

-#if wxUSE_STREAMS
+#if HAS_FILE_STREAMS

     if (wxFileExists(filename))
     {
     if (wxFileExists(filename))
     {

-        wxFileInputStream stream(filename);
+        wxImageFileInputStream stream(filename);

         wxBufferedInputStream bstream( stream );
         return LoadFile(bstream, mimetype, index);
     }
         wxBufferedInputStream bstream( stream );
         return LoadFile(bstream, mimetype, index);
     }


@@ -1494,9 +1547,9 @@ bool wxImage::LoadFile( const wxString& filename, const wxString& mimetype, int
 
         return false;
     }
 
         return false;
     }

-#else // !wxUSE_STREAMS
+#else // !HAS_FILE_STREAMS

     return false;
     return false;

-#endif // wxUSE_STREAMS
+#endif // HAS_FILE_STREAMS

 }
 
 
 }
 
 


@@ -1517,60 +1570,63 @@ bool wxImage::SaveFile( const wxString& filename ) const
     return false;
 }
 
     return false;
 }
 

-bool wxImage::SaveFile( const wxString& filename, int type ) const
+bool wxImage::SaveFile( const wxString& WXUNUSED_UNLESS_STREAMS(filename),
+                        int WXUNUSED_UNLESS_STREAMS(type) ) const

 {
 {

-#if wxUSE_STREAMS
+#if HAS_FILE_STREAMS

     wxCHECK_MSG( Ok(), false, wxT("invalid image") );
 
     ((wxImage*)this)->SetOption(wxIMAGE_OPTION_FILENAME, filename);
 
     wxCHECK_MSG( Ok(), false, wxT("invalid image") );
 
     ((wxImage*)this)->SetOption(wxIMAGE_OPTION_FILENAME, filename);
 

-    wxFileOutputStream stream(filename);
+    wxImageFileOutputStream stream(filename);

 
     if ( stream.IsOk() )
     {
         wxBufferedOutputStream bstream( stream );
         return SaveFile(bstream, type);
     }
 
     if ( stream.IsOk() )
     {
         wxBufferedOutputStream bstream( stream );
         return SaveFile(bstream, type);
     }

-#endif // wxUSE_STREAMS
+#endif // HAS_FILE_STREAMS

 
     return false;
 }
 
 
     return false;
 }
 

-bool wxImage::SaveFile( const wxString& filename, const wxString& mimetype ) const
+bool wxImage::SaveFile( const wxString& WXUNUSED_UNLESS_STREAMS(filename),
+                        const wxString& WXUNUSED_UNLESS_STREAMS(mimetype) ) const

 {
 {

-#if wxUSE_STREAMS
+#if HAS_FILE_STREAMS

     wxCHECK_MSG( Ok(), false, wxT("invalid image") );
 
     ((wxImage*)this)->SetOption(wxIMAGE_OPTION_FILENAME, filename);
 
     wxCHECK_MSG( Ok(), false, wxT("invalid image") );
 
     ((wxImage*)this)->SetOption(wxIMAGE_OPTION_FILENAME, filename);
 

-    wxFileOutputStream stream(filename);
+    wxImageFileOutputStream stream(filename);

 
     if ( stream.IsOk() )
     {
         wxBufferedOutputStream bstream( stream );
         return SaveFile(bstream, mimetype);
     }
 
     if ( stream.IsOk() )
     {
         wxBufferedOutputStream bstream( stream );
         return SaveFile(bstream, mimetype);
     }

-#endif // wxUSE_STREAMS
+#endif // HAS_FILE_STREAMS

 
     return false;
 }
 
 
     return false;
 }
 

-bool wxImage::CanRead( const wxString &name )
+bool wxImage::CanRead( const wxString& WXUNUSED_UNLESS_STREAMS(name) )

 {
 {

-#if wxUSE_STREAMS
-  wxFileInputStream stream(name);
-  return CanRead(stream);
+#if HAS_FILE_STREAMS
+    wxImageFileInputStream stream(name);
+    return CanRead(stream);

 #else
 #else

-  return false;
+    return false;

 #endif
 }
 
 #endif
 }
 

-int wxImage::GetImageCount( const wxString &name, long type )
+int wxImage::GetImageCount( const wxString& WXUNUSED_UNLESS_STREAMS(name),
+                            long WXUNUSED_UNLESS_STREAMS(type) )

 {
 {

-#if wxUSE_STREAMS
-  wxFileInputStream stream(name);
-  if (stream.Ok())
-      return GetImageCount(stream, type);
+#if HAS_FILE_STREAMS
+    wxImageFileInputStream stream(name);
+    if (stream.Ok())
+        return GetImageCount(stream, type);

 #endif
 
   return 0;
 #endif
 
   return 0;


@@ -1616,7 +1672,7 @@ int wxImage::GetImageCount( wxInputStream &stream, long type )
 
     if ( !handler )
     {
 
     if ( !handler )
     {

-        wxLogWarning(_("No image handler for type %d defined."), type);
+        wxLogWarning(_("No image handler for type %ld defined."), type);

         return false;
     }
 
         return false;
     }
 


@@ -1626,7 +1682,7 @@ int wxImage::GetImageCount( wxInputStream &stream, long type )
     }
     else
     {
     }
     else
     {

-        wxLogError(_("Image file is not of type %d."), type);
+        wxLogError(_("Image file is not of type %ld."), type);

         return 0;
     }
 }
         return 0;
     }
 }


@@ -1659,14 +1715,14 @@ bool wxImage::LoadFile( wxInputStream& stream, long type, int index )
 
     if (handler == 0)
     {
 
     if (handler == 0)
     {

-        wxLogWarning( _("No image handler for type %d defined."), type );
+        wxLogWarning( _("No image handler for type %ld defined."), type );

 
         return false;
     }
 
     if (stream.IsSeekable() && !handler->CanRead(stream))
     {
 
         return false;
     }
 
     if (stream.IsSeekable() && !handler->CanRead(stream))
     {

-        wxLogError(_("Image file is not of type %d."), type);
+        wxLogError(_("Image file is not of type %ld."), type);

         return false;
     }
     else
         return false;
     }
     else


@@ -2009,6 +2065,8 @@ wxImage::RGBValue wxImage::HSVtoRGB(const HSVValue& hsv)
  */
 void wxImage::RotateHue(double angle)
 {
  */
 void wxImage::RotateHue(double angle)
 {

+    AllocExclusive();
+

     unsigned char *srcBytePtr;
     unsigned char *dstBytePtr;
     unsigned long count;
     unsigned char *srcBytePtr;
     unsigned char *dstBytePtr;
     unsigned long count;


@@ -2068,7 +2126,7 @@ bool wxImageHandler::CanRead( const wxString& name )
 {
     if (wxFileExists(name))
     {
 {
     if (wxFileExists(name))
     {

-        wxFileInputStream stream(name);
+        wxImageFileInputStream stream(name);

         return CanRead(stream);
     }
 
         return CanRead(stream);
     }