decouple item index from string value (patch 1905702)

[wxWidgets.git] / src / gtk / assertdlg_gtk.c

diff --git a/src/gtk/assertdlg_gtk.c b/src/gtk/assertdlg_gtk.c
index 88dec90bb5f276373d28ca8384a76ebc0a93bd92..26d760b73caa490bbade157287fb4067f299bac8 100644 (file)
--- a/src/gtk/assertdlg_gtk.c
+++ b/src/gtk/assertdlg_gtk.c
@@ -33,8 +33,10 @@ extern "C" {
    Constants
  ---------------------------------------------------------------------------- */
 
    Constants
  ---------------------------------------------------------------------------- */
 

-// NB: when changing order of the columns also update the gtk_list_store_new() call
-//     in gtk_assert_dialog_create_backtrace_list_model() function
+/*
+   NB: when changing order of the columns also update the gtk_list_store_new() call
+       in gtk_assert_dialog_create_backtrace_list_model() function
+ */

 #define STACKFRAME_LEVEL_COLIDX        0
 #define FUNCTION_NAME_COLIDX           1
 #define SOURCE_FILE_COLIDX             2
 #define STACKFRAME_LEVEL_COLIDX        0
 #define FUNCTION_NAME_COLIDX           1
 #define SOURCE_FILE_COLIDX             2


@@ -71,14 +73,16 @@ GtkWidget *gtk_assert_dialog_add_button_to (GtkBox *box, const gchar *label,
     return button;
 }
 
     return button;
 }
 

-void gtk_assert_dialog_add_button (GtkAssertDialog *dlg, const gchar *label,
-                                   const gchar *stock, gint response_id)
+GtkWidget *gtk_assert_dialog_add_button (GtkAssertDialog *dlg, const gchar *label,
+                                         const gchar *stock, gint response_id)

 {
     /* create the button */
     GtkWidget *button = gtk_assert_dialog_add_button_to (NULL, label, stock, response_id);
 
     /* add the button to the dialog's action area */
     gtk_dialog_add_action_widget (GTK_DIALOG (dlg), button, response_id);
 {
     /* create the button */
     GtkWidget *button = gtk_assert_dialog_add_button_to (NULL, label, stock, response_id);
 
     /* add the button to the dialog's action area */
     gtk_dialog_add_action_widget (GTK_DIALOG (dlg), button, response_id);

+
+    return button;

 }
 
 void gtk_assert_dialog_append_text_column (GtkWidget *treeview, const gchar *name, int index)
 }
 
 void gtk_assert_dialog_append_text_column (GtkWidget *treeview, const gchar *name, int index)


@@ -101,18 +105,18 @@ GtkWidget *gtk_assert_dialog_create_backtrace_list_model ()
 
     /* create list store */
     store = gtk_list_store_new (5,
 
     /* create list store */
     store = gtk_list_store_new (5,

-                                G_TYPE_UINT,        // stack frame number
-                                G_TYPE_STRING,      // function name
-                                G_TYPE_STRING,      // source file name
-                                G_TYPE_UINT,        // line number
-                                G_TYPE_STRING);     // function arguments
+                                G_TYPE_UINT,        /* stack frame number */
+                                G_TYPE_STRING,      /* function name      */
+                                G_TYPE_STRING,      /* source file name   */
+                                G_TYPE_STRING,      /* line number        */
+                                G_TYPE_STRING);     /* function arguments */

 
     /* create the tree view */
     treeview = gtk_tree_view_new_with_model (GTK_TREE_MODEL(store));
     g_object_unref (store);
     gtk_tree_view_set_rules_hint (GTK_TREE_VIEW (treeview), TRUE);
 
 
     /* create the tree view */
     treeview = gtk_tree_view_new_with_model (GTK_TREE_MODEL(store));
     g_object_unref (store);
     gtk_tree_view_set_rules_hint (GTK_TREE_VIEW (treeview), TRUE);
 

-    // append columns
+    /* append columns */

     gtk_assert_dialog_append_text_column(treeview, "#", STACKFRAME_LEVEL_COLIDX);
     gtk_assert_dialog_append_text_column(treeview, "Function name", FUNCTION_NAME_COLIDX);
     gtk_assert_dialog_append_text_column(treeview, "Function args", FUNCTION_ARGS_COLIDX);
     gtk_assert_dialog_append_text_column(treeview, "#", STACKFRAME_LEVEL_COLIDX);
     gtk_assert_dialog_append_text_column(treeview, "Function name", FUNCTION_NAME_COLIDX);
     gtk_assert_dialog_append_text_column(treeview, "Function args", FUNCTION_ARGS_COLIDX);


@@ -143,13 +147,12 @@ void gtk_assert_dialog_process_backtrace (GtkAssertDialog *dlg)
    GtkAssertDialog signal handlers
  ---------------------------------------------------------------------------- */
 
    GtkAssertDialog signal handlers
  ---------------------------------------------------------------------------- */
 

-#if GTK_CHECK_VERSION(2,4,0)        // GtkFileChooserDialog and GtkExpander
-                                    // are only available in GTK+ >= 2.4
+/* GtkFileChooserDialog and GtkExpander are only available in GTK+ >= 2.4 */
+#if GTK_CHECK_VERSION(2,4,0)

 
 void gtk_assert_dialog_expander_callback (GtkWidget *widget, GtkAssertDialog *dlg)
 {
 
 void gtk_assert_dialog_expander_callback (GtkWidget *widget, GtkAssertDialog *dlg)
 {

-    // for some reason we need to invert the return value of gtk_expander_get_expanded
-    // to get the real expanded status
+    /* status is not yet updated so we need to invert it to get the new one */

     gboolean expanded = !gtk_expander_get_expanded (GTK_EXPANDER(dlg->expander));
     gtk_window_set_resizable (GTK_WINDOW (dlg), expanded);
 
     gboolean expanded = !gtk_expander_get_expanded (GTK_EXPANDER(dlg->expander));
     gtk_window_set_resizable (GTK_WINDOW (dlg), expanded);
 


@@ -178,23 +181,28 @@ void gtk_assert_dialog_save_backtrace_callback (GtkWidget *widget, GtkAssertDial
         FILE *fp;
 
         filename = gtk_file_chooser_get_filename (GTK_FILE_CHOOSER (dialog));
         FILE *fp;
 
         filename = gtk_file_chooser_get_filename (GTK_FILE_CHOOSER (dialog));

-        msg = gtk_assert_dialog_get_message (dlg);
-        backtrace = gtk_assert_dialog_get_backtrace (dlg);
-
-        /* open the file and write all info inside it */
-        fp = fopen (filename, "w");
-        if (fp && filename)
-            fprintf (fp, "ASSERT INFO:\n%s\n\nBACKTRACE:\n%s", msg, backtrace);
-
-        g_free (filename);
-        g_free (msg);
-        g_free (backtrace);
-        fclose (fp);
+        if ( filename )
+        {
+            msg = gtk_assert_dialog_get_message (dlg);
+            backtrace = gtk_assert_dialog_get_backtrace (dlg);
+
+            /* open the file and write all info inside it */
+            fp = fopen (filename, "w");
+            if (fp)
+            {
+                fprintf (fp, "ASSERT INFO:\n%s\n\nBACKTRACE:\n%s", msg, backtrace);
+                fclose (fp);
+            }
+
+            g_free (filename);
+            g_free (msg);
+            g_free (backtrace);
+        }

     }
 
     gtk_widget_destroy (dialog);
 }
     }
 
     gtk_widget_destroy (dialog);
 }

-#endif
+#endif /* GTK+ 2.4+ */

 
 void gtk_assert_dialog_copy_callback (GtkWidget *widget, GtkAssertDialog *dlg)
 {
 
 void gtk_assert_dialog_copy_callback (GtkWidget *widget, GtkAssertDialog *dlg)
 {


@@ -222,6 +230,15 @@ void gtk_assert_dialog_copy_callback (GtkWidget *widget, GtkAssertDialog *dlg)
     g_string_free (str, TRUE);
 }
 
     g_string_free (str, TRUE);
 }
 

+void gtk_assert_dialog_continue_callback (GtkWidget *widget, GtkAssertDialog *dlg)
+{
+    gint response =
+        gtk_toggle_button_get_active (GTK_TOGGLE_BUTTON(dlg->shownexttime)) ?
+            GTK_ASSERT_DIALOG_CONTINUE : GTK_ASSERT_DIALOG_CONTINUE_SUPPRESSING;
+
+    gtk_dialog_response (GTK_DIALOG(dlg), response);
+}
+

 
 /* ----------------------------------------------------------------------------
    GtkAssertDialogClass implementation
 
 /* ----------------------------------------------------------------------------
    GtkAssertDialogClass implementation


@@ -234,10 +251,10 @@ static void     gtk_assert_dialog_class_init        (GtkAssertDialogClass *klass
 GtkType gtk_assert_dialog_get_type (void)
 {
     static GtkType assert_dialog_type = 0;
 GtkType gtk_assert_dialog_get_type (void)
 {
     static GtkType assert_dialog_type = 0;

-    
+

     if (!assert_dialog_type)
     {
     if (!assert_dialog_type)
     {

-        static const GTypeInfo assert_dialog_info =
+        const GTypeInfo assert_dialog_info =

         {
             sizeof (GtkAssertDialogClass),
             NULL,           /* base_init */
         {
             sizeof (GtkAssertDialogClass),
             NULL,           /* base_init */


@@ -263,57 +280,61 @@ void gtk_assert_dialog_class_init(GtkAssertDialogClass *klass)
 
 void gtk_assert_dialog_init(GtkAssertDialog *dlg)
 {
 
 void gtk_assert_dialog_init(GtkAssertDialog *dlg)
 {

-    GtkWidget *vbox, *hbox, *image;
+    GtkWidget *continuebtn;

 
 

-    /* start the main vbox */
-    gtk_widget_push_composite_child ();
-    vbox = gtk_vbox_new (FALSE, 8);
-    gtk_container_set_border_width (GTK_CONTAINER(vbox), 8);
-    gtk_box_pack_start (GTK_BOX (GTK_DIALOG (dlg)->vbox), vbox, TRUE, TRUE, 5);
+    {
+        GtkWidget *vbox, *hbox, *image;

 
 

+        /* start the main vbox */
+        gtk_widget_push_composite_child ();
+        vbox = gtk_vbox_new (FALSE, 8);
+        gtk_container_set_border_width (GTK_CONTAINER(vbox), 8);
+        gtk_box_pack_start (GTK_BOX (GTK_DIALOG (dlg)->vbox), vbox, TRUE, TRUE, 5);

 
 

-    /* add the icon+message hbox */
-    hbox = gtk_hbox_new (FALSE, 0);
-    gtk_box_pack_start (GTK_BOX(vbox), hbox, FALSE, FALSE, 0);

 
 

-    /* icon */
-    image = gtk_image_new_from_stock (GTK_STOCK_DIALOG_ERROR, GTK_ICON_SIZE_DIALOG);
-    gtk_box_pack_start (GTK_BOX(hbox), image, FALSE, FALSE, 12);
+        /* add the icon+message hbox */
+        hbox = gtk_hbox_new (FALSE, 0);
+        gtk_box_pack_start (GTK_BOX(vbox), hbox, FALSE, FALSE, 0);

 
 

-    {
-        GtkWidget *vbox2, *info;
-
-        /* message */
-        vbox2 = gtk_vbox_new (FALSE, 0);
-        gtk_box_pack_start (GTK_BOX (hbox), vbox2, TRUE, TRUE, 0);
-        info = gtk_label_new ("An assertion failed!");
-        gtk_box_pack_start (GTK_BOX(vbox2), info, TRUE, TRUE, 8);
-
-        /* assert message */
-        dlg->message = gtk_label_new (NULL);
-        gtk_label_set_selectable (GTK_LABEL (dlg->message), TRUE);
-        gtk_label_set_line_wrap (GTK_LABEL (dlg->message), TRUE);
-        gtk_label_set_justify (GTK_LABEL (dlg->message), GTK_JUSTIFY_LEFT);
-        gtk_widget_set_size_request (GTK_WIDGET(dlg->message), 450, -1);
-
-        gtk_box_pack_end (GTK_BOX(vbox2), GTK_WIDGET(dlg->message), TRUE, TRUE, 8);
-    }
+        /* icon */
+        image = gtk_image_new_from_stock (GTK_STOCK_DIALOG_ERROR, GTK_ICON_SIZE_DIALOG);
+        gtk_box_pack_start (GTK_BOX(hbox), image, FALSE, FALSE, 12);

 
 

-    /* add the expander */
+        {
+            GtkWidget *vbox2, *info;
+
+            /* message */
+            vbox2 = gtk_vbox_new (FALSE, 0);
+            gtk_box_pack_start (GTK_BOX (hbox), vbox2, TRUE, TRUE, 0);
+            info = gtk_label_new ("An assertion failed!");
+            gtk_box_pack_start (GTK_BOX(vbox2), info, TRUE, TRUE, 8);
+
+            /* assert message */
+            dlg->message = gtk_label_new (NULL);
+            gtk_label_set_selectable (GTK_LABEL (dlg->message), TRUE);
+            gtk_label_set_line_wrap (GTK_LABEL (dlg->message), TRUE);
+            gtk_label_set_justify (GTK_LABEL (dlg->message), GTK_JUSTIFY_LEFT);
+            gtk_widget_set_size_request (GTK_WIDGET(dlg->message), 450, -1);
+
+            gtk_box_pack_end (GTK_BOX(vbox2), GTK_WIDGET(dlg->message), TRUE, TRUE, 8);
+        }
+
+        /* add the expander */

 #if GTK_CHECK_VERSION(2,4,0)
 #if GTK_CHECK_VERSION(2,4,0)

-    if (!gtk_check_version (2, 4, 0))
-    {
-        dlg->expander = gtk_expander_new_with_mnemonic ("Back_trace:");
-        gtk_box_pack_start (GTK_BOX(vbox), dlg->expander, TRUE, TRUE, 0);
-        g_signal_connect (GTK_EXPANDER(dlg->expander), "activate",
-                          G_CALLBACK(gtk_assert_dialog_expander_callback), dlg);
-    }
-    else
+        if (!gtk_check_version (2, 4, 0))
+        {
+            dlg->expander = gtk_expander_new_with_mnemonic ("Back_trace:");
+            gtk_box_pack_start (GTK_BOX(vbox), dlg->expander, TRUE, TRUE, 0);
+            g_signal_connect (GTK_EXPANDER(dlg->expander), "activate",
+                              G_CALLBACK(gtk_assert_dialog_expander_callback), dlg);
+        }
+        else

 #endif
 #endif

-    {
-        // if GtkExpander is unavailable, then use a static frame instead
-        dlg->expander = gtk_frame_new ("Back_trace:");
-        gtk_box_pack_start (GTK_BOX(vbox), dlg->expander, TRUE, TRUE, 0);
+        {
+            /* if GtkExpander is unavailable, then use a static frame instead */
+            dlg->expander = gtk_frame_new ("Back_trace:");
+            gtk_box_pack_start (GTK_BOX(vbox), dlg->expander, TRUE, TRUE, 0);
+        }

     }
 
     {
     }
 
     {


@@ -357,12 +378,18 @@ void gtk_assert_dialog_init(GtkAssertDialog *dlg)
         g_signal_connect (button, "clicked", G_CALLBACK(gtk_assert_dialog_copy_callback), dlg);
     }
 
         g_signal_connect (button, "clicked", G_CALLBACK(gtk_assert_dialog_copy_callback), dlg);
     }
 

-    /* add the buttons */
+    /* add the checkbutton */
+    dlg->shownexttime = gtk_check_button_new_with_mnemonic("Show this _dialog the next time");
+    gtk_toggle_button_set_active (GTK_TOGGLE_BUTTON(dlg->shownexttime), TRUE);
+    gtk_box_pack_end (GTK_BOX(GTK_DIALOG(dlg)->action_area), dlg->shownexttime, FALSE, TRUE, 8);
+
+    /* add the stop button */

     gtk_assert_dialog_add_button (dlg, "_Stop", GTK_STOCK_QUIT, GTK_ASSERT_DIALOG_STOP);
     gtk_assert_dialog_add_button (dlg, "_Stop", GTK_STOCK_QUIT, GTK_ASSERT_DIALOG_STOP);

-    gtk_assert_dialog_add_button (dlg, "_Continue", GTK_STOCK_YES, GTK_ASSERT_DIALOG_CONTINUE);
-    gtk_assert_dialog_add_button (dlg, "Continue su_ppressing", GTK_STOCK_OK,
-                                  GTK_ASSERT_DIALOG_CONTINUE_SUPPRESSING);
-    gtk_dialog_set_default_response (GTK_DIALOG (dlg), GTK_ASSERT_DIALOG_STOP);
+
+    /* add the continue button */
+    continuebtn = gtk_assert_dialog_add_button (dlg, "_Continue", GTK_STOCK_YES, GTK_ASSERT_DIALOG_CONTINUE);
+    gtk_dialog_set_default_response (GTK_DIALOG (dlg), GTK_ASSERT_DIALOG_CONTINUE);
+    g_signal_connect (continuebtn, "clicked", G_CALLBACK(gtk_assert_dialog_continue_callback), dlg);

 
     /* complete creation */
     dlg->callback = NULL;
 
     /* complete creation */
     dlg->callback = NULL;


@@ -392,8 +419,8 @@ gchar *gtk_assert_dialog_get_message (GtkAssertDialog *dlg)
 
 gchar *gtk_assert_dialog_get_backtrace (GtkAssertDialog *dlg)
 {
 
 gchar *gtk_assert_dialog_get_backtrace (GtkAssertDialog *dlg)
 {

-    gchar *function, *arguments, *sourcefile;
-    guint count, linenum;
+    gchar *function, *arguments, *sourcefile, *linenum;
+    guint count;

 
     GtkTreeModel *model;
     GtkTreeIter iter;
 
     GtkTreeModel *model;
     GtkTreeIter iter;


@@ -418,17 +445,18 @@ gchar *gtk_assert_dialog_get_backtrace (GtkAssertDialog *dlg)
                             LINE_NUMBER_COLIDX, &linenum,
                             -1);
 
                             LINE_NUMBER_COLIDX, &linenum,
                             -1);
 

+        g_string_append_printf (string, "[%u] %s(%s)",
+                                count, function, arguments);

         if (sourcefile[0] != '\0')
         if (sourcefile[0] != '\0')

-            g_string_append_printf (string, "[%d] %s(%s) %s:%d\n",
-                                    count, function, arguments,
-                                    sourcefile, linenum);
-        else
-            g_string_append_printf (string, "[%d] %s(%s)\n",
-                                    count, function, arguments);
+            g_string_append_printf (string, " %s", sourcefile);
+        if (linenum[0] != '\0')
+            g_string_append_printf (string, ":%s", linenum);
+        g_string_append (string, "\n");

 
         g_free (function);
         g_free (arguments);
         g_free (sourcefile);
 
         g_free (function);
         g_free (arguments);
         g_free (sourcefile);

+        g_free (linenum);

 
     } while (gtk_tree_model_iter_next (model, &iter));
 
 
     } while (gtk_tree_model_iter_next (model, &iter));
 


@@ -460,8 +488,8 @@ void gtk_assert_dialog_set_backtrace_callback(GtkAssertDialog *assertdlg,
 
     if (gtk_check_version (2, 4, 0))
     {
 
     if (gtk_check_version (2, 4, 0))
     {

-        // we need to immediately process the stack trace as we're not using
-        // an expander since GTK does not support it
+        /* we need to immediately process the stack trace as we're not using
+           an expander since GTK does not support it */

         gtk_assert_dialog_process_backtrace (assertdlg);
     }
 }
         gtk_assert_dialog_process_backtrace (assertdlg);
     }
 }


@@ -474,6 +502,7 @@ void gtk_assert_dialog_append_stack_frame(GtkAssertDialog *dlg,
 {
     GtkTreeModel *model;
     GtkTreeIter iter;
 {
     GtkTreeModel *model;
     GtkTreeIter iter;

+    GString *linenum;

     gint count;
 
     g_return_if_fail (GTK_IS_ASSERT_DIALOG (dlg));
     gint count;
 
     g_return_if_fail (GTK_IS_ASSERT_DIALOG (dlg));


@@ -482,6 +511,10 @@ void gtk_assert_dialog_append_stack_frame(GtkAssertDialog *dlg,
     /* how many items are in the list up to now ? */
     count = gtk_tree_model_iter_n_children (model, NULL);
 
     /* how many items are in the list up to now ? */
     count = gtk_tree_model_iter_n_children (model, NULL);
 

+    linenum = g_string_new("");
+    if ( line_number != 0 )
+        g_string_printf (linenum, "%u", line_number);
+

     /* add data to the list store */
     gtk_list_store_append (GTK_LIST_STORE(model), &iter);
     gtk_list_store_set (GTK_LIST_STORE(model), &iter,
     /* add data to the list store */
     gtk_list_store_append (GTK_LIST_STORE(model), &iter);
     gtk_list_store_set (GTK_LIST_STORE(model), &iter,


@@ -489,8 +522,10 @@ void gtk_assert_dialog_append_stack_frame(GtkAssertDialog *dlg,
                         FUNCTION_NAME_COLIDX, function,
                         FUNCTION_ARGS_COLIDX, arguments,
                         SOURCE_FILE_COLIDX, sourcefile,
                         FUNCTION_NAME_COLIDX, function,
                         FUNCTION_ARGS_COLIDX, arguments,
                         SOURCE_FILE_COLIDX, sourcefile,

-                        LINE_NUMBER_COLIDX, line_number,
+                        LINE_NUMBER_COLIDX, linenum->str,

                         -1);
                         -1);

+
+    g_string_free (linenum, TRUE);

 }
 
 GtkWidget *gtk_assert_dialog_new(void)
 }
 
 GtkWidget *gtk_assert_dialog_new(void)