* in this Software without prior written authorization from GROUPE BULL.
*/
-#ifdef __GNUG__
+#if defined(__GNUG__) && !defined(NO_GCC_PRAGMA)
#pragma implementation "xpmdecod.h"
#endif
#include "wx/intl.h"
#include <string.h>
-#ifdef __VISUALC__
#include <ctype.h>
-#endif
#include "wx/xpmdecod.h"
unsigned char buf[9];
if ( !stream.Read(buf, WXSIZEOF(buf)) )
- return FALSE;
+ return false;
- stream.SeekI(-WXSIZEOF(buf), wxFromCurrent);
+ stream.SeekI(-(wxFileOffset)WXSIZEOF(buf), wxFromCurrent);
return memcmp(buf, "/* XPM */", WXSIZEOF(buf)) == 0;
}
wxCharBuffer buffer(length);
char *xpm_buffer = (char *)buffer.data();
- if ( stream.Read(xpm_buffer, length).LastError() == wxSTREAM_READ_ERROR )
+ if ( stream.Read(xpm_buffer, length).GetLastError() == wxSTREAM_READ_ERROR )
return wxNullImage;
xpm_buffer[length] = '\0';
if ( (*q == '*') && (*(q + 1) == '/') )
break;
}
- strcpy(p, q + 2);
+
+ // memmove allows overlaps (unlike strcpy):
+ size_t cpylen = strlen(q + 2) + 1;
+ memmove(p, q + 2, cpylen);
}
/*
*/
wxImage img = ReadData(xpm_lines);
-#ifdef __WIN16__
- delete[] (char**) xpm_lines;
-#else
delete[] xpm_lines;
-#endif
return img;
}
{"seagreen", myRGB(82, 149, 132)},
{"seashell", myRGB(255, 245, 238)},
{"sienna", myRGB(150, 82, 45)},
+ {"silver", myRGB(192, 192, 192)},
{"skyblue", myRGB(114, 159, 255)},
{"slateblue", myRGB(126, 136, 171)},
{"slategray", myRGB(112, 128, 144)},
{"yellowgreen", myRGB(50, 216, 56)},
{NULL, myRGB(0, 0, 0)}
};
-static int numTheRGBRecords = 234;
+static int numTheRGBRecords = 235;
static unsigned char ParseHexadecimal(char digit1, char digit2)
{
unsigned char i1, i2;
if (digit1 >= 'a')
- i1 = digit1 - 'a' + 0x0A;
+ i1 = (unsigned char)(digit1 - 'a' + 0x0A);
else if (digit1 >= 'A')
- i1 = digit1 - 'A' + 0x0A;
+ i1 = (unsigned char)(digit1 - 'A' + 0x0A);
else
- i1 = digit1 - '0';
+ i1 = (unsigned char)(digit1 - '0');
if (digit2 >= 'a')
- i2 = digit2 - 'a' + 0x0A;
+ i2 = (unsigned char)(digit2 - 'a' + 0x0A);
else if (digit2 >= 'A')
- i2 = digit2 - 'A' + 0x0A;
+ i2 = (unsigned char)(digit2 - 'A' + 0x0A);
else
- i2 = digit2 - '0';
- return (0x10 * i1 + i2);
+ i2 = (unsigned char)(digit2 - '0');
+ return (unsigned char)(0x10 * i1 + i2);
}
static bool GetRGBFromName(const char *inname, bool *isNone,
*r = ParseHexadecimal(inname[1], inname[2]);
*g = ParseHexadecimal(inname[1*ofs+1], inname[1*ofs+2]);
*b = ParseHexadecimal(inname[2*ofs+1], inname[2*ofs+2]);
- *isNone = FALSE;
- return TRUE;
+ *isNone = false;
+ return true;
}
- name = strdup(inname);
+ name = wxStrdupA(inname);
// theRGBRecords[] has no names with spaces, and no grey, but a
// lot of gray...
p = name;
while (*p)
{
- *p = tolower(*p);
+ *p = (char)tolower(*p);
p++;
}
bool found;
if ( strcmp(name, "none") == 0 )
{
- *isNone = TRUE;
- found = TRUE;
+ *isNone = true;
+ found = true;
}
else // not "None"
{
- found = FALSE;
+ found = false;
// binary search:
left = 0;
*r = (unsigned char)((rgbVal >> 16) & 0xFF);
*g = (unsigned char)((rgbVal >> 8) & 0xFF);
*b = (unsigned char)((rgbVal) & 0xFF);
- *isNone = FALSE;
- found = TRUE;
+ *isNone = false;
+ found = true;
break;
}
else if ( cmp < 0 )
{
unsigned char R,G,B;
};
-WX_DECLARE_STRING_HASH_MAP(wxXPMColourMapData, wxXPMColourMap)
+WX_DECLARE_STRING_HASH_MAP(wxXPMColourMapData, wxXPMColourMap);
wxImage wxXPMDecoder::ReadData(const char **xpm_data)
{
bool hasMask;
wxXPMColourMapData clr_data;
wxXPMColourMap clr_tbl;
+ wxXPMColourMap::iterator it;
+ wxString maskKey;
/*
* Read hints and initialize structures:
*/
-
+
count = sscanf(xpm_data[0], "%u %u %u %u",
&width, &height, &colors_cnt, &chars_per_pixel);
if ( count != 4 || width * height * colors_cnt == 0 )
img.Create(width, height);
if ( !img.Ok() ) return img;
- img.SetMask(FALSE);
+ img.SetMask(false);
key[chars_per_pixel] = wxT('\0');
- hasMask = FALSE;
+ hasMask = false;
/*
* Create colour map:
if ( clr_def == NULL )
{
- wxLogError(_("XPM: malformed colour definition '%s'!"), xpm_data[1+i]);
+ wxLogError(_("XPM: malformed colour definition '%s'!"),
+ xpm_data[1+i]);
clr_data.R = 255, clr_data.G = 0, clr_data.B = 255;
}
else
if ( !GetRGBFromName(clr_def, &isNone,
&clr_data.R, &clr_data.G, &clr_data.B) )
{
- wxLogError(_("XPM: malformed colour definition '%s'!"), xpm_data[1+i]);
+ wxLogError(_("XPM: malformed colour definition '%s'!"),
+ xpm_data[1+i]);
clr_data.R = 255, clr_data.G = 0, clr_data.B = 255;
}
else
{
if ( isNone )
{
- img.SetMask(TRUE);
+ img.SetMask(true);
img.SetMaskColour(255, 0, 255);
- hasMask = TRUE;
+ hasMask = true;
clr_data.R = 255, clr_data.G = 0, clr_data.B = 255;
- }
- else
- {
- if ( hasMask && clr_data.R == 255 &&
- clr_data.G == 0 && clr_data.B == 255 )
- clr_data.B = 254;
+ maskKey = key;
}
}
}
clr_tbl[key] = clr_data;
}
+ /*
+ * Modify colour entries with RGB = (255,0,255) to (255,0,254) if
+ * mask colour is present (so that existing pixels with (255,0,255)
+ * magenta colour are not incorrectly made transparent):
+ */
+ if (hasMask)
+ {
+ for (it = clr_tbl.begin(); it != clr_tbl.end(); it++)
+ {
+ if (it->second.R == 255 && it->second.G == 0 &&
+ it->second.B == 255 &&
+ it->first != maskKey)
+ {
+ it->second.B = 254;
+ }
+ }
+ }
+
/*
* Parse image data:
*/
unsigned char *img_data = img.GetData();
wxXPMColourMap::iterator entry;
wxXPMColourMap::iterator end = clr_tbl.end();
-
+
for (j = 0; j < height; j++)
{
for (i = 0; i < width; i++, img_data += 3)
if ( entry == end )
{
wxLogError(_("XPM: Malformed pixel data!"));
+
+ // better return right now as otherwise we risk to flood the
+ // user with error messages as something seems to be seriously
+ // wrong with the file and so we could give this message for
+ // each remaining pixel if we don't bail out
+ return wxNullImage;
}
else
{
projects / wxWidgets.git / blobdiff