reverted Robert's over-optimisation, correct fix coming soon

[wxWidgets.git] / src / xrc / xh_chckl.cpp

diff --git a/src/xrc/xh_chckl.cpp b/src/xrc/xh_chckl.cpp
index b033b133214bbed2d5b2cccec8bd0410711e0f55..536c011ae616325145c480e4cd8d9326b258e794 100644 (file)
--- a/src/xrc/xh_chckl.cpp
+++ b/src/xrc/xh_chckl.cpp
@@ -1,13 +1,13 @@
 /////////////////////////////////////////////////////////////////////////////
 // Name:        xh_chckl.cpp
 /////////////////////////////////////////////////////////////////////////////
 // Name:        xh_chckl.cpp

-// Purpose:     XML resource for wxCheckList
+// Purpose:     XRC resource for wxCheckList

 // Author:      Bob Mitchell
 // Created:     2000/03/21
 // RCS-ID:      $Id$
 // Copyright:   (c) 2000 Bob Mitchell and Verant Interactive
 // Licence:     wxWindows licence
 /////////////////////////////////////////////////////////////////////////////
 // Author:      Bob Mitchell
 // Created:     2000/03/21
 // RCS-ID:      $Id$
 // Copyright:   (c) 2000 Bob Mitchell and Verant Interactive
 // Licence:     wxWindows licence
 /////////////////////////////////////////////////////////////////////////////

- 
+

 #ifdef __GNUG__
 #pragma implementation "xh_chckl.h"
 #endif
 #ifdef __GNUG__
 #pragma implementation "xh_chckl.h"
 #endif


@@ -19,42 +19,66 @@
     #pragma hdrstop
 #endif
 
     #pragma hdrstop
 #endif
 

+#if wxUSE_XRC
+
+#if wxUSE_OWNER_DRAWN || !defined(__WXMSW__)
+

 #include "wx/xrc/xh_chckl.h"
 #include "wx/checklst.h"
 #include "wx/xrc/xh_chckl.h"
 #include "wx/checklst.h"

+#include "wx/intl.h"
+#include "wx/log.h"
+
+IMPLEMENT_DYNAMIC_CLASS(wxCheckListBoxXmlHandler, wxXmlResourceHandler)

 
 

-wxCheckListXmlHandler::wxCheckListXmlHandler() 
-: wxXmlResourceHandler(), m_insideBox(FALSE)
+wxCheckListBoxXmlHandler::wxCheckListBoxXmlHandler()
+: wxXmlResourceHandler(), m_insideBox(false)

 {
 {

-    // no styles
+    // wxListBox styles:
+    XRC_ADD_STYLE(wxLB_SINGLE);
+    XRC_ADD_STYLE(wxLB_MULTIPLE);
+    XRC_ADD_STYLE(wxLB_EXTENDED);
+    XRC_ADD_STYLE(wxLB_HSCROLL);
+    XRC_ADD_STYLE(wxLB_ALWAYS_SB);
+    XRC_ADD_STYLE(wxLB_NEEDED_SB);
+    XRC_ADD_STYLE(wxLB_SORT);
+    

     AddWindowStyles();
 }
 
     AddWindowStyles();
 }
 

-wxObject *wxCheckListXmlHandler::DoCreateResource()
-{ 
-    if (m_class == wxT("wxCheckList"))
+wxObject *wxCheckListBoxXmlHandler::DoCreateResource()
+{
+    if (m_class == wxT("wxCheckListBox")
+#if WXWIN_COMPATIBILITY_2_4
+        || m_class == wxT("wxCheckList")
+#endif
+       )

     {
     {

+#if WXWIN_COMPATIBILITY_2_4
+        if (m_class == wxT("wxCheckList"))
+            wxLogDebug(wxT("'wxCheckList' name is deprecated, use 'wxCheckListBox' instead."));
+#endif

         // need to build the list of strings from children
         // need to build the list of strings from children

-        m_insideBox = TRUE;
+        m_insideBox = true;

         CreateChildrenPrivately(NULL, GetParamNode(wxT("content")));
         wxString *strings = (wxString *) NULL;
         CreateChildrenPrivately(NULL, GetParamNode(wxT("content")));
         wxString *strings = (wxString *) NULL;

-        if( strList.GetCount() > 0 )
+        if (strList.GetCount() > 0)

         {
             strings = new wxString[strList.GetCount()];
             int count = strList.GetCount();
         {
             strings = new wxString[strList.GetCount()];
             int count = strList.GetCount();

-            for( int i = 0; i < count; i++ )
-                strings[i]=strList[i];
+            for(int i = 0; i < count; i++)
+                strings[i] = strList[i];

         }
 
         }
 

+        XRC_MAKE_INSTANCE(control, wxCheckListBox)

 
 

-        wxCheckListBox *control = new wxCheckListBox(m_parentAsWindow,
-                                    GetID(),
-                                    GetPosition(), GetSize(),
-                                    strList.GetCount(),
-                                    strings,
-                                    GetStyle(),
-                                    wxDefaultValidator,
-                                    GetName()
-                                    );
+        control->Create(m_parentAsWindow,
+                        GetID(),
+                        GetPosition(), GetSize(),
+                        strList.GetCount(),
+                        strings,
+                        GetStyle(),
+                        wxDefaultValidator,
+                        GetName());

 
         // step through children myself (again.)
         wxXmlNode *n = GetParamNode(wxT("content"));
 
         // step through children myself (again.)
         wxXmlNode *n = GetParamNode(wxT("content"));


@@ -70,17 +94,17 @@ wxObject *wxCheckListXmlHandler::DoCreateResource()
             wxString v = n->GetPropVal(wxT("checked"), wxEmptyString);
             v.MakeLower();
             if (v && v == wxT("1"))
             wxString v = n->GetPropVal(wxT("checked"), wxEmptyString);
             v.MakeLower();
             if (v && v == wxT("1"))

-                control->Check( i, TRUE );
+                control->Check( i, true );

 
 

-            i++;        
+            i++;

             n = n->GetNext();
         }
             n = n->GetNext();
         }

-        
+

         SetupWindow(control);
 
         SetupWindow(control);
 

-        if( strings != NULL )
-            delete [] strings;
-        strList.Clear();    // dump the strings   
+        if (strings != NULL)
+            delete[] strings;
+        strList.Clear();    // dump the strings

 
         return control;
     }
 
         return control;
     }


@@ -90,20 +114,23 @@ wxObject *wxCheckListXmlHandler::DoCreateResource()
         // handle <item checked="boolean">Label</item>
 
         // add to the list
         // handle <item checked="boolean">Label</item>
 
         // add to the list

-        strList.Add( GetNodeContent(m_node) );
-
+        wxString str = GetNodeContent(m_node);
+        if (m_resource->GetFlags() & wxXRC_USE_LOCALE)
+            str = wxGetTranslation(str);
+        strList.Add(str);

         return NULL;
     }
         return NULL;
     }

-

 }
 
 }
 

-
-
-bool wxCheckListXmlHandler::CanHandle(wxXmlNode *node)
+bool wxCheckListBoxXmlHandler::CanHandle(wxXmlNode *node)

 {
 {

-    return (IsOfClass(node, wxT("wxCheckList")) ||
-           (m_insideBox && node->GetName() == wxT("item"))
-           );
+    return (IsOfClass(node, wxT("wxCheckListBox")) ||
+#if WXWIN_COMPATIBILITY_2_4
+            IsOfClass(node, wxT("wxCheckList")) ||
+#endif
+           (m_insideBox && node->GetName() == wxT("item")));

 }
 
 }
 

+#endif // wxUSE_OWNER_DRAWN || !defined(__WXMSW__)

 
 

+#endif // wxUSE_XRC