// allocation failures are handled by the caller
return false;
}
- memcpy(m_pchData, pData->data(), nLen*sizeof(wxChar));
+ wxMemcpy(m_pchData, pData->data(), nLen);
}
wxASSERT( !GetStringData()->IsShared() ); // we must be the only owner
// wxString class core
// ===========================================================================
-// ---------------------------------------------------------------------------
-// common conversion routines
-// ---------------------------------------------------------------------------
-
-#if wxUSE_WCHAR_T
-
-//Convert a wide character string of a specified length
-//to a multi-byte character string, ignoring intermittent null characters
-//returns the actual length of the string
-inline size_t wxMbstr(wxCharBuffer& buffer, const wchar_t* szString,
- size_t nStringLen, wxMBConv& conv)
-{
- const wchar_t* szEnd = szString + nStringLen + 1;
- const wchar_t* szPos = szString;
- const wchar_t* szStart = szPos;
-
- size_t nActualLength = 0;
-
- //Convert the string until the length() is reached, continuing the
- //loop every time a null character is reached
- while(szPos != szEnd)
- {
- wxASSERT(szPos < szEnd); //something is _really_ screwed up if this rings true
-
- //Get the length of the current (sub)string
- size_t nLen = conv.WC2MB(NULL, szPos, 0);
-
- wxASSERT(nLen != (size_t)-1); //should not be true! If it is system wctomb could be bad
-
- nActualLength += nLen + 1;
-
- wxASSERT(nActualLength <= (nStringLen<<1) + 1); //If this is true it means buffer overflow
-
- //Convert the current (sub)string
- if ( conv.WC2MB(&buffer.data()[szPos - szStart], szPos, nLen + 1) == (size_t)-1 )
- {
- //error - return empty buffer
- wxFAIL_MSG(wxT("Error converting wide-character string to a multi-byte string"));
- buffer.data()[0] = '\0';
- return 0;
- }
-
- //Increment to next (sub)string
- //Note that we have to use wxWcslen here instead of nLen
- //here because XX2XX gives us the size of the output buffer,
- //not neccessarly the length of the string
- szPos += wxWcslen(szPos) + 1;
- }
-
- return nActualLength - 1; //success - return actual length
-}
-
-//Convert a multi-byte character string of a specified length
-//to a wide character string, ignoring intermittent null characters
-//returns the actual length
-inline size_t wxWcstr( wxWCharBuffer& buffer, const char* szString,
- size_t nStringLen, wxMBConv& conv)
-{
- const char* szEnd = szString + nStringLen + 1;
- const char* szPos = szString;
- const char* szStart = szPos;
-
- size_t nActualLength = 0;
-
- //Convert the string until the length() is reached, continuing the
- //loop every time a null character is reached
- while(szPos != szEnd)
- {
- wxASSERT(szPos < szEnd); //something is _really_ screwed up if this rings true
-
- //Get the length of the current (sub)string
- size_t nLen = conv.MB2WC(NULL, szPos, 0);
-
- wxASSERT(nLen != (size_t)-1); //should not be true! If it is system mbtowc could be bad
-
- nActualLength += nLen + 1;
-
- wxASSERT(nActualLength <= nStringLen + 1); //If this is true it means buffer overflow
-
- //Convert the current (sub)string
- if ( conv.MB2WC(&buffer.data()[szPos - szStart], szPos, nLen + 1) == (size_t)-1 )
- {
- //error - return empty buffer
- wxFAIL_MSG(wxT("Error converting multi-byte string to a wide-character string"));
- buffer.data()[0] = '\0';
- return 0;
- }
-
- //Increment to next (sub)string
- //Note that we have to use strlen here instead of nLen
- //here because XX2XX gives us the size of the output buffer,
- //not neccessarly the length of the string
- szPos += strlen(szPos) + 1;
- }
-
- return nActualLength - 1; //success - return actual length
-}
-
-#endif //wxUSE_WCHAR_T
-
// ---------------------------------------------------------------------------
// construction and conversion
// ---------------------------------------------------------------------------
nLen = 0;
}
+
// anything to do?
if ( (nLen != 0) && (nLen != (size_t)-1) )
{
- //When converting mb->wc it never inflates to more characters than the length
- wxWCharBuffer buffer(nLen + 1);
-
- //Convert the string
- size_t nActualLength = wxWcstr(buffer, psz, nLen, conv);
+ //Get length of converted string
+ size_t dwConvLen = conv.MB2WC(NULL, psz, 0, nLen);
- if ( !Alloc(nActualLength + 1) )
- {
- wxFAIL_MSG(wxT("Out of memory in wxString"));
- }
- else
+ //if valid, do the conversion
+ if (dwConvLen != (size_t) -1)
{
- //Copy the data
- assign(buffer.data(), nActualLength);
+ //Get internal buffer
+ wxStringBufferLength internalBuffer(*this, dwConvLen + 1);
+
+ //Do the actual conversion & Set the length of the buffer
+ internalBuffer.SetLength(
+ conv.MB2WC(internalBuffer, psz, dwConvLen + 1, nLen)
+ );
}
}
}
//Convert wxString in Unicode mode to a multi-byte string
const wxCharBuffer wxString::mb_str(wxMBConv& conv) const
{
- //*2 is the worst case - probably for UTF8
- wxCharBuffer buffer((length() << 1) + 1);
+ //Get length of converted string
+ size_t dwConvLen = conv.WC2MB(NULL, (*this).c_str(), 0, length());
+
+ //if valid, do the conversion
+ if (dwConvLen != (size_t) -1)
+ {
+ //Create good buffer
+ wxCharBuffer buffer(dwConvLen + 1);
- //Do the actual conversion (will return a blank string on error)
- wxMbstr(buffer, (*this).c_str(), length(), conv);
+ //Do the actual conversion
+ conv.WC2MB(buffer.data(), (*this).c_str(), dwConvLen + 1, length());
+ return buffer;
+ }
+
+ //create bogus buffer
+ wxCharBuffer buffer(1);
+ buffer.data()[0u] = 0;
return buffer;
}
// anything to do?
if ( (nLen != 0) && (nLen != (size_t)-1) )
{
- //*2 is the worst case - probably for UTF8
- wxCharBuffer buffer((nLen << 1) + 1);
-
- //do the actual conversion (if it fails we get an empty string)
- size_t nActualLength = wxMbstr(buffer, pwz, nLen, conv);
+ //Get length of converted string
+ size_t dwConvLen = conv.WC2MB(NULL, pwz, 0, nLen);
- if ( !Alloc(nActualLength + 1) )
- {
- wxFAIL_MSG(wxT("Out of memory in wxString"));
- }
- else
+ //if valid, do the conversion
+ if (dwConvLen != (size_t) -1)
{
- //copy the data
- assign(buffer.data(), nActualLength);
+ //Get internal buffer
+ wxStringBufferLength internalBuffer(*this, dwConvLen + 1);
+
+ //Do the actual conversion & Set the length of the buffer
+ internalBuffer.SetLength(
+ conv.WC2MB(internalBuffer, pwz, dwConvLen + 1, nLen)
+ );
}
}
}
//mode is not enabled and wxUSE_WCHAR_T is enabled
const wxWCharBuffer wxString::wc_str(wxMBConv& conv) const
{
- //mb->wc never inflates to more than the length
- wxWCharBuffer buffer(length() + 1);
+ //Get length of converted string
+ size_t dwConvLen = conv.MB2WC(NULL, (*this).c_str(), 0, length());
- //Do the actual conversion (will return a blank string on error)
- wxWcstr(buffer, (*this).c_str(), length(), conv);
+ //if valid, do the conversion
+ if (dwConvLen != (size_t) -1)
+ {
+ //Create good buffer
+ wxWCharBuffer buffer(dwConvLen + 1);
+
+ //Do the actual conversion
+ conv.MB2WC(buffer.data(), (*this).c_str(), dwConvLen + 1, length());
+
+ return buffer;
+ }
+ //create bogus buffer
+ wxWCharBuffer buffer(1);
+ buffer.data()[0u] = 0;
return buffer;
}
const wchar_t *pwc = c_str();
for ( ;; )
{
- *dest++ = *pwc > SCHAR_MAX ? '_' : *pwc;
+ *dest++ = *pwc > SCHAR_MAX ? wxT('_') : *pwc;
// the output string can't have embedded NULs anyhow, so we can safely
// stop at first of them even if we do have any
{
const wxChar *s = (const wxChar*) *this;
if (wxStrlen(s))
- if ((s[0] == '-') || (s[0] == '+')) s++;
+ if ((s[0] == wxT('-')) || (s[0] == wxT('+'))) s++;
while(*s){
if(!wxIsdigit(*s)) return(false);
s++;
projects / wxWidgets.git / blobdiff