two fixes from Justin Bradford

[wxWidgets.git] / src / msw / dib.cpp

diff --git a/src/msw/dib.cpp b/src/msw/dib.cpp
index c48d865d23dc5011bda70f4c6d2805c5c4a0421a..3b42e9c0f7089b16150897835572c5fca7adf54c 100644 (file)
--- a/src/msw/dib.cpp
+++ b/src/msw/dib.cpp
@@ -1,44 +1,46 @@
-/*******************************************************************************
- *                                                                               *
- * MODULE        : DIB.CC                                                        *
- *                                                                               *
- *  DESCRIPTION : Routines for dealing with Device Independent Bitmaps.        *
- *                                                                               *
- *  FUNCTIONS        :                                                              *
- *                                                                               *
- *                wxReadDIB()           - Reads a DIB                            *
- *                                                                               *
- *                  WriteDIB()              - Writes a global handle in CF_DIB format*
- *                                        to a file.                               *
- *                                                                               *
- *                  wxPaletteSize()       - Calculates the palette size in bytes   *
- *                                        of given DIB                               *
- *                                                                               *
- *                  DibNumColors()      - Determines the number of colors in DIB *
- *                                                                               *
- *                  DibFromBitmap()     - Creates a DIB repr. the DDB passed in. *
- *                                                                               *
- *                                                                               *
- *                  lread()              - Private routine to read more than 64k  *
- *                                                                               *
- *                  lwrite()              - Private routine to write more than 64k *
- *                                                                               *
- *******************************************************************************/
+///////////////////////////////////////////////////////////////////////////////
+// Name:        src/msw/dib.cpp
+// Purpose:     implements wxDIB class
+// Author:      Vadim Zeitlin
+// Modified by:
+// Created:     03.03.03 (replaces the old file with the same name)
+// RCS-ID:      $Id$
+// Copyright:   (c) 2003 Vadim Zeitlin <vadim@wxwindows.org>
+// License:     wxWindows licence
+///////////////////////////////////////////////////////////////////////////////
+
+/*
+    TODO: support for palettes is very incomplete, several functions simply
+          ignore them (we should select and realize the palette, if any, before
+          caling GetDIBits() in the DC we use with it.
+ */
+
+// ============================================================================
+// declarations
+// ============================================================================
+
+// ----------------------------------------------------------------------------
+// headers
+// ----------------------------------------------------------------------------

 
 // For compilers that support precompilation, includes "wx.h".
 #include "wx/wxprec.h"
 
 
 // For compilers that support precompilation, includes "wx.h".
 #include "wx/wxprec.h"
 

-#if defined(__BORLANDC__)
-#pragma hdrstop
+#ifdef __BORLANDC__
+    #pragma hdrstop

 #endif
 
 #ifndef WX_PRECOMP
 #endif
 
 #ifndef WX_PRECOMP

+    #include "wx/string.h"
+    #include "wx/log.h"
+#endif //WX_PRECOMP
+
+#if wxUSE_WXDIB
+

 #include "wx/bitmap.h"
 #include "wx/bitmap.h"

-#include "wx/log.h"

 #include "wx/intl.h"
 #include "wx/intl.h"

-#endif
+#include "wx/file.h"

 
 

-#include <windows.h>

 #include <stdio.h>
 #include <stdlib.h>
 
 #include <stdio.h>
 #include <stdlib.h>
 


@@ -46,903 +48,566 @@
 #include <memory.h>
 #endif
 
 #include <memory.h>
 #endif
 

-#include "wx/msw/dib.h"
-

 #ifdef __GNUWIN32_OLD__
     #include "wx/msw/gnuwin32/extra.h"
 #endif
 
 #ifdef __GNUWIN32_OLD__
     #include "wx/msw/gnuwin32/extra.h"
 #endif
 

-#ifndef SEEK_CUR
-/* flags for _lseek */
-#define        SEEK_CUR 1
-#define        SEEK_END 2
-#define        SEEK_SET 0
-#endif
-
-#define MAXREAD  32768                                 /* Number of bytes to be read during */
-                                                 /* each read operation.                         */
-
-/* Header signatutes for various resources */
-#define BFT_ICON         0x4349         /* 'IC' */
-#define BFT_BITMAP 0x4d42         /* 'BM' */
-#define BFT_CURSOR 0x5450         /* 'PT(' */
-
-/* macro to determine if resource is a DIB */
-#define ISDIB(bft) ((bft) == BFT_BITMAP)
-
-/* Macro to align given value to the closest DWORD (unsigned long ) */
-#define ALIGNULONG(i)        ((i+3)/4*4)
-
-/* Macro to determine to round off the given value to the closest byte */
-#define WIDTHBYTES(i)        ((i+31)/32*4)
-
-#define PALVERSION                0x300
-#define MAXPALETTE        256          /* max. # supported palette entries */
-
-static DWORD PASCAL lread(int fh, VOID FAR *pv, DWORD ul);
-static DWORD PASCAL lwrite(int fh, VOID FAR *pv, DWORD ul);
-
-static BOOL        WriteDIB (LPTSTR szFile,HANDLE hdib);
-WORD        wxPaletteSize (VOID FAR * pv); // This is non-static as some apps use it externally
-static WORD        DibNumColors (VOID FAR * pv);
-// HANDLE        DibFromBitmap (HBITMAP hbm, DWORD biStyle, WORD biBits, HPALETTE hpal);
-static BOOL PASCAL MakeBitmapAndPalette(HDC,HANDLE,HPALETTE *,HBITMAP *);
+#include "wx/image.h"
+#include "wx/msw/dib.h"

 
 

-/****************************************************************************
- *                                                                            *
- *  FUNCTION   : WriteDIB(LPSTR szFile,HANDLE hdib)                            *
- *                                                                            *
- *  PURPOSE    : Write a global handle in CF_DIB format to a file.            *
- *                                                                            *
- *  RETURNS    : TRUE  - if successful.                                     *
- *                 FALSE - otherwise                                            *
- *                                                                            *
- ****************************************************************************/
+// ----------------------------------------------------------------------------
+// private functions
+// ----------------------------------------------------------------------------

 
 

-static BOOL WriteDIB(LPTSTR szFile, HANDLE hdib)
+// calculate the number of palette entries needed for the bitmap with this
+// number of bits per pixel
+static inline WORD wxGetNumOfBitmapColors(WORD bitsPerPixel)

 {
 {

-        BITMAPFILEHEADER        hdr;
-        LPBITMAPINFOHEADER  lpbi;
-        int                 fh;
-        OFSTRUCT            of;
-
-        if (!hdib)
-                return FALSE;
-
-        fh = OpenFile(wxConvertWX2MB(szFile), &of, OF_CREATE | OF_READWRITE);
-        if (fh == -1)
-                return FALSE;
-
-#ifdef __WINDOWS_386__
-        lpbi = (LPBITMAPINFOHEADER) MK_FP32(GlobalLock(hdib));
-#else
-        lpbi = (LPBITMAPINFOHEADER) GlobalLock(hdib);
-#endif
-    /* Fill in the fields of the file header */
-        hdr.bfType = BFT_BITMAP;
-        hdr.bfSize = GlobalSize(hdib) + sizeof(BITMAPFILEHEADER);
-        hdr.bfReserved1 = 0;
-        hdr.bfReserved2 = 0;
-        hdr.bfOffBits = (DWORD) sizeof(BITMAPFILEHEADER) + lpbi->biSize +
-                 wxPaletteSize(lpbi);
-
-    /* Write the file header */
-        _lwrite(fh, (LPSTR) &hdr, sizeof(BITMAPFILEHEADER));
-
-    /* Write the DIB header and the bits */
-        lwrite(fh, (LPSTR) lpbi, GlobalSize(hdib));
-
-        GlobalUnlock(hdib);
-        _lclose(fh);
-        return TRUE;
+    // only 1, 4 and 8bpp bitmaps use palettes (well, they could be used with
+    // 24bpp ones too but we don't support this as I think it's quite uncommon)
+    return bitsPerPixel <= 8 ? 1 << bitsPerPixel : 0;

 }
 
 }
 

-/****************************************************************************
- *                                                                            *
- *  FUNCTION   :  wxPaletteSize(VOID FAR * pv)                                    *
- *                                                                            *
- *  PURPOSE    :  Calculates the palette size in bytes. If the info. block  *
- *                  is of the BITMAPCOREHEADER type, the number of colors is  *
- *                  multiplied by 3 to give the palette size, otherwise the   *
- *                  number of colors is multiplied by 4.                                                                *
- *                                                                            *
- *  RETURNS    :  Palette size in number of bytes.                            *
- *                                                                            *
- ****************************************************************************/
-
-WORD wxPaletteSize(VOID FAR * pv)
+// wrapper around ::GetObject() for DIB sections
+static inline bool GetDIBSection(HBITMAP hbmp, DIBSECTION *ds)

 {
 {

-        LPBITMAPINFOHEADER lpbi;
-        WORD               NumColors;
-
-        lpbi = (LPBITMAPINFOHEADER) pv;
-        NumColors = DibNumColors(lpbi);
-
-        if (lpbi->biSize == sizeof(BITMAPCOREHEADER))
-                return (WORD)(NumColors * sizeof(RGBTRIPLE));
-        else
-                return (WORD)(NumColors * sizeof(RGBQUAD));
+    // note that at least under Win9x (this doesn't seem to happen under Win2K
+    // but this doesn't mean anything, of course), GetObject() may return
+    // sizeof(DIBSECTION) for a bitmap which is *not* a DIB section and the way
+    // to check for it is by looking at the bits pointer
+    return ::GetObject(hbmp, sizeof(DIBSECTION), ds) == sizeof(DIBSECTION) &&
+                ds->dsBm.bmBits;

 }
 
 }
 

-/****************************************************************************
- *                                                                            *
- *  FUNCTION   : DibNumColors(VOID FAR * pv)                                    *
- *                                                                            *
- *  PURPOSE    : Determines the number of colors in the DIB by looking at   *
- *                 the BitCount filed in the info block.                            *
- *                                                                            *
- *  RETURNS    : The number of colors in the DIB.                            *
- *                                                                            *
- ****************************************************************************/
-
-static WORD DibNumColors(VOID FAR *pv)
-{
-        int                 bits;
-        BITMAPINFOHEADER        *lpbi;
-        BITMAPCOREHEADER        *lpbc;
-
-        lpbi = ((BITMAPINFOHEADER*) pv);
-        lpbc = ((BITMAPCOREHEADER*) pv);
-
-    /*        With the BITMAPINFO format headers, the size of the palette
-     *        is in biClrUsed, whereas in the BITMAPCORE - style headers, it
-     *        is dependent on the bits per pixel ( = 2 raised to the power of
-     *        bits/pixel).
-     */
-        if (lpbi->biSize != sizeof(BITMAPCOREHEADER)) {
-                if (lpbi->biClrUsed != 0)
-                        return (WORD) lpbi->biClrUsed;
-                bits = lpbi->biBitCount;
-                }
-        else
-                bits = lpbc->bcBitCount;
-
-        switch (bits) {
-  case 1:
-                return 2;
-  case 4:
-                return 16;
-  case 8:
-                return 256;
-  default:
-                /* A 24 bitcount DIB has no color table */
-                return 0;
-                }
-}
+// ============================================================================
+// implementation
+// ============================================================================

 
 

-/****************************************************************************
- *                                                                            *
- *  FUNCTION   : DibFromBitmap()                                            *
- *                                                                            *
- *  PURPOSE    : Will create a global memory block in DIB format that            *
- *                 represents the Device-dependent bitmap (DDB) passed in.    *
- *                                                                            *
- *  RETURNS    : A handle to the DIB                                            *
- *                                                                            *
- ****************************************************************************/
-
-#if NOTHING
-static HANDLE DibFromBitmap(HBITMAP hbm, DWORD biStyle, WORD biBits, HPALETTE hpal)
+// ----------------------------------------------------------------------------
+// wxDIB creation
+// ----------------------------------------------------------------------------
+
+bool wxDIB::Create(int width, int height, int depth)

 {
 {

-        BITMAP               bm;
-        BITMAPINFOHEADER     bi;
-        BITMAPINFOHEADER FAR *lpbi;
-        DWORD                dwLen;
-        HANDLE               hdib;
-        HANDLE               h;
-        HDC                  hdc;
-
-        if (!hbm)
-                return NULL;
-
-        if (hpal == NULL)
-                hpal = GetStockObject(DEFAULT_PALETTE);
-
-        GetObject(hbm, sizeof (bm), (LPSTR) &bm);
-
-        if (biBits == 0)
-                biBits = bm.bmPlanes * bm.bmBitsPixel;
-
-        bi.biSize = sizeof(BITMAPINFOHEADER);
-        bi.biWidth = bm.bmWidth;
-        bi.biHeight = bm.bmHeight;
-        bi.biPlanes = 1;
-        bi.biBitCount = biBits;
-        bi.biCompression = biStyle;
-        bi.biSizeImage = 0;
-        bi.biXPelsPerMeter = 0;
-        bi.biYPelsPerMeter = 0;
-        bi.biClrUsed = 0;
-        bi.biClrImportant = 0;
-
-        dwLen = bi.biSize + wxPaletteSize(&bi);
-
-        hdc = GetDC((HWND) NULL);
-        hpal = SelectPalette(hdc, hpal, FALSE);
-        RealizePalette(hdc);
-
-        hdib = GlobalAlloc(GHND, dwLen);
-
-        if (!hdib) {
-                SelectPalette(hdc, hpal, FALSE);
-                ReleaseDC(NULL, hdc);
-                return NULL;
-                }
+    // we don't handle the palette yet
+    wxASSERT_MSG( depth == 24 || depth == 32,
+                    _T("unsupported image depth in wxDIB::Create()") );

 
 

-#ifdef __WINDOWS_386__
-        lpbi = (BITMAPINFOHEADER FAR *) MK_FP32(GlobalLock(hdib));
-#else
-        lpbi = (BITMAPINFOHEADER FAR *) GlobalLock(hdib);
-#endif
+    static const int infosize = sizeof(BITMAPINFOHEADER);

 
 

-        *lpbi = bi;
+    BITMAPINFO *info = (BITMAPINFO *)malloc(infosize);
+    wxCHECK_MSG( info, false, _T("malloc(BITMAPINFO) failed") );

 
 

-    /*        call GetDIBits with a NULL lpBits param, so it will calculate the
-     *  biSizeImage field for us
-     */
-        GetDIBits(hdc, hbm, 0, (WORD) bi.biHeight,
-                 NULL, (LPBITMAPINFO) lpbi, DIB_RGB_COLORS);
+    memset(info, 0, infosize);

 
 

-        bi = *lpbi;
-        GlobalUnlock(hdib);
+    info->bmiHeader.biSize = infosize;
+    info->bmiHeader.biWidth = width;

 
 

-    /* If the driver did not fill in the biSizeImage field, make one up */
-        if (bi.biSizeImage == 0) {
-                bi.biSizeImage = WIDTHBYTES((DWORD)bm.bmWidth * biBits) * bm.bmHeight;
+    // we use positive height here which corresponds to a DIB with normal, i.e.
+    // bottom to top, order -- normally using negative height (which means
+    // reversed for MS and hence natural for all the normal people top to
+    // bottom line scan order) could be used to avoid the need for the image
+    // reversal in Create(image) but this doesn't work under NT, only Win9x!
+    info->bmiHeader.biHeight = height;

 
 

-                if (biStyle != BI_RGB)
-                        bi.biSizeImage = (bi.biSizeImage * 3) / 2;
-                }
+    info->bmiHeader.biPlanes = 1;
+    info->bmiHeader.biBitCount = depth;
+    info->bmiHeader.biSizeImage = GetLineSize(width, depth)*height;

 
 

-    /*        realloc the buffer big enough to hold all the bits */
-        dwLen = bi.biSize + wxPaletteSize(&bi) + bi.biSizeImage;
-        if (h = GlobalReAlloc(hdib, dwLen, 0))
-                hdib = h;
-        else {
-                GlobalFree(hdib);
-                hdib = NULL;
-
-                SelectPalette(hdc, hpal, FALSE);
-                ReleaseDC(NULL, hdc);
-                return hdib;
-                }
+    m_handle = ::CreateDIBSection
+                 (
+                    0,              // hdc (unused with DIB_RGB_COLORS)
+                    info,           // bitmap description
+                    DIB_RGB_COLORS, // use RGB, not palette
+                    &m_data,        // [out] DIB bits
+                    NULL,           // don't use file mapping
+                    0               // file mapping offset (not used here)
+                 );

 
 

-    /*        call GetDIBits with a NON-NULL lpBits param, and actualy get the
-     *  bits this time
-     */
-#ifdef __WINDOWS_386__
-        lpbi = (BITMAPINFOHEADER FAR *) MK_FP32(GlobalLock(hdib));
-#else
-        lpbi = (BITMAPINFOHEADER FAR *) GlobalLock(hdib);
-#endif
-
-        if (GetDIBits(hdc,
-                 hbm,
-                 0,
-                 (WORD) bi.biHeight,
-                 (LPSTR) lpbi + (WORD) lpbi->biSize + wxPaletteSize(lpbi),
-                 (LPBITMAPINFO) lpbi, DIB_RGB_COLORS) == 0) {
-                GlobalUnlock(hdib);
-                hdib = NULL;
-                SelectPalette(hdc, hpal, FALSE);
-                ReleaseDC((HWND) NULL, hdc);
-                return NULL;
-                }
+    free(info);

 
 

-        bi = *lpbi;
-        GlobalUnlock(hdib);
+    if ( !m_handle )
+    {
+        wxLogLastError(wxT("CreateDIBSection"));

 
 

-        SelectPalette(hdc, hpal, FALSE);
-        ReleaseDC(NULL, hdc);
-        return hdib;
-}
-#endif
+        return false;
+    }

 
 

- /************* PRIVATE ROUTINES TO READ/WRITE MORE THAN 64K ***************/
-/****************************************************************************
- *                                                                            *
- *  FUNCTION   : lread(int fh, VOID FAR *pv, DWORD ul)                            *
- *                                                                            *
- *  PURPOSE    : Reads data in steps of 32k till all the data has been read.*
- *                                                                            *
- *  RETURNS    : 0 - If read did not proceed correctly.                     *
- *                 number of bytes read otherwise.                            *
- *                                                                            *
- ****************************************************************************/
-
-static DWORD PASCAL lread(int fh, void far *pv, DWORD ul)
-{
-        DWORD     ulT = ul;
-#if defined(WINNT) || defined(__WIN32__) || defined(__WIN32__) || defined(__WXWINE__)
-        BYTE *hp = (BYTE *) pv;
-#else
-        BYTE huge *hp = (BYTE huge *) pv;
-#endif
-        while (ul > (DWORD) MAXREAD) {
-                if (_lread(fh, (LPSTR) hp, (WORD) MAXREAD) != MAXREAD)
-                        return 0;
-                ul -= MAXREAD;
-                hp += MAXREAD;
-                }
-        if (_lread(fh, (LPSTR) hp, (WXUINT) ul) != (WXUINT) ul)
-                return 0;
-        return ulT;
-}
+    m_width = width;
+    m_height = height;
+    m_depth = depth;

 
 

-/****************************************************************************
- *                                                                            *
- *  FUNCTION   : lwrite(int fh, VOID FAR *pv, DWORD ul)                     *
- *                                                                            *
- *  PURPOSE    : Writes data in steps of 32k till all the data is written.  *
- *                                                                            *
- *  RETURNS    : 0 - If write did not proceed correctly.                    *
- *                 number of bytes written otherwise.                            *
- *                                                                            *
- ****************************************************************************/
-
-static DWORD PASCAL lwrite(int fh, VOID FAR *pv, DWORD ul)
-{
-        DWORD     ulT = ul;
-#if defined(WINNT) || defined(__WIN32__) || defined(__WIN32__) || defined(__WXWINE__)
-        BYTE *hp = (BYTE *) pv;
-#else
-        BYTE huge *hp = (BYTE huge *) pv;
-#endif
-        while (ul > MAXREAD) {
-                if (_lwrite(fh, (LPSTR) hp, (WORD) MAXREAD) != MAXREAD)
-                        return 0;
-                ul -= MAXREAD;
-                hp += MAXREAD;
-                }
-        if (_lwrite(fh, (LPSTR) hp, (WXUINT) ul) != (WXUINT) ul)
-                return 0;
-        return ulT;
+    return true;

 }
 
 }
 

-/****************************************************************************
- *
- *  FUNCTION   : ReadDIB(hWnd)
- *
- *  PURPOSE    : Reads a DIB from a file, obtains a handle to its
- *                 BITMAPINFO struct. and loads the DIB.  Once the DIB
- *               is loaded, the function also creates a bitmap and
- *               palette out of the DIB for a device-dependent form.
- *
- *  RETURNS    : TRUE  - DIB loaded and bitmap/palette created
- *                       The DIBINIT structure pointed to by pInfo is
- *                       filled with the appropriate handles.
- *                 FALSE - otherwise
- *
- ****************************************************************************/
-BOOL wxReadDIB(LPTSTR lpFileName, HBITMAP *bitmap, HPALETTE *palette)
+bool wxDIB::Create(const wxBitmap& bmp)

 {
 {

-    int fh;
-    LPBITMAPINFOHEADER lpbi;
-    OFSTRUCT               of;
-    BITMAPFILEHEADER   bf;
-    WORD                nNumColors;
-    BOOL result = FALSE;
-    WORD offBits;
-    HDC hDC;
-    BOOL bCoreHead = FALSE;
-    HANDLE hDIB = 0;
-
-    /* Open the file and get a handle to it's BITMAPINFO */
-
-    fh = OpenFile (wxConvertWX2MB(lpFileName), &of, OF_READ);
-    if (fh == -1) {
-        wxLogError(_("Can't open file '%s'"), lpFileName);
-        return (0);
-    }
-
-    hDIB = GlobalAlloc(GHND, (DWORD)(sizeof(BITMAPINFOHEADER) +
-                                            256 * sizeof(RGBQUAD)));
-    if (!hDIB)
-        return(0);
-
-#ifdef __WINDOWS_386__
-    lpbi = (LPBITMAPINFOHEADER)MK_FP32(GlobalLock(hDIB));
-#else
-    lpbi = (LPBITMAPINFOHEADER)GlobalLock(hDIB);
-#endif
-
-    /* read the BITMAPFILEHEADER */
-    if (sizeof (bf) != _lread (fh, (LPSTR)&bf, sizeof (bf)))
-        goto ErrExit;
+    wxCHECK_MSG( bmp.Ok(), false, _T("wxDIB::Create(): invalid bitmap") );

 
 

-    if (bf.bfType != 0x4d42)        /* 'BM' */
-        goto ErrExit;
+    // this bitmap could already be a DIB section in which case we don't need
+    // to convert it to DIB
+    HBITMAP hbmp = GetHbitmapOf(bmp);

 
 

-    if (sizeof(BITMAPCOREHEADER) != _lread (fh, (LPSTR)lpbi, sizeof(BITMAPCOREHEADER)))
-        goto ErrExit;
-
-    if (lpbi->biSize == sizeof(BITMAPCOREHEADER))
-    {
-        lpbi->biSize = sizeof(BITMAPINFOHEADER);
-        lpbi->biBitCount = ((LPBITMAPCOREHEADER)lpbi)->bcBitCount;
-        lpbi->biPlanes = ((LPBITMAPCOREHEADER)lpbi)->bcPlanes;
-        lpbi->biHeight = ((LPBITMAPCOREHEADER)lpbi)->bcHeight;
-        lpbi->biWidth = ((LPBITMAPCOREHEADER)lpbi)->bcWidth;
-        bCoreHead = TRUE;
-    }
-    else
+    DIBSECTION ds;
+    if ( GetDIBSection(hbmp, &ds) )

     {
     {

-            // get to the start of the header and read INFOHEADER
-        _llseek(fh,sizeof(BITMAPFILEHEADER),SEEK_SET);
-        if (sizeof(BITMAPINFOHEADER) != _lread (fh, (LPSTR)lpbi, sizeof(BITMAPINFOHEADER)))
-            goto ErrExit;
-    }
+        m_handle = hbmp;

 
 

-    nNumColors = (WORD)lpbi->biClrUsed;
-    if ( nNumColors == 0 )
-    {
-        /* no color table for 24-bit, default size otherwise */
-        if (lpbi->biBitCount != 24)
-            nNumColors = 1 << lpbi->biBitCount;        /* standard size table */
-    }
+        // wxBitmap will free it, not we
+        m_ownsHandle = false;

 
 

-    /*        fill in some default values if they are zero */
-    if (lpbi->biClrUsed == 0)
-        lpbi->biClrUsed = nNumColors;
+        // copy all the bitmap parameters too as we have them now anyhow
+        m_width = ds.dsBm.bmWidth;
+        m_height = ds.dsBm.bmHeight;
+        m_depth = ds.dsBm.bmBitsPixel;

 
 

-    if (lpbi->biSizeImage == 0)
-    {
-        lpbi->biSizeImage = ((((lpbi->biWidth * (DWORD)lpbi->biBitCount) + 31) & ~31) >> 3)
-                         * lpbi->biHeight;
+        m_data = ds.dsBm.bmBits;

     }
     }

+    else // no, it's a DDB -- convert it to DIB
+    {
+        const int w = bmp.GetWidth();
+        const int h = bmp.GetHeight();
+        int d = bmp.GetDepth();
+        if ( d == -1 )
+            d = wxDisplayDepth();

 
 

-    /* get a proper-sized buffer for header, color table and bits */
-    GlobalUnlock(hDIB);
-    hDIB = GlobalReAlloc(hDIB, lpbi->biSize +
-                                            nNumColors * sizeof(RGBQUAD) +
-                                        lpbi->biSizeImage, 0);
-    if (!hDIB)        /* can't resize buffer for loading */
-        goto ErrExit2;
-
-#ifdef __WINDOWS_386__
-    lpbi = (LPBITMAPINFOHEADER)MK_FP32(GlobalLock(hDIB));
-#else
-    lpbi = (LPBITMAPINFOHEADER)GlobalLock(hDIB);
-#endif
+        if ( !Create(w, h, d) )
+            return false;

 
 

-    /* read the color table */
-    if (!bCoreHead)
-        _lread(fh, (LPSTR)(lpbi) + lpbi->biSize, nNumColors * sizeof(RGBQUAD));
-    else
-    {
-        signed int i;
-        RGBQUAD FAR *pQuad;
-        RGBTRIPLE FAR *pTriple;
+        if ( !GetDIBSection(m_handle, &ds) )
+        {
+            // we've just created a new DIB section, why should this fail?
+            wxFAIL_MSG( _T("GetObject(DIBSECTION) unexpectedly failed") );

 
 

-        _lread(fh, (LPSTR)(lpbi) + lpbi->biSize, nNumColors * sizeof(RGBTRIPLE));
+            return false;
+        }

 
 

-        pQuad = (RGBQUAD FAR *)((LPSTR)lpbi + lpbi->biSize);
-        pTriple = (RGBTRIPLE FAR *) pQuad;
-        for (i = nNumColors - 1; i >= 0; i--)
+        if ( !::GetDIBits
+                (
+                    ScreenHDC(),                // the DC to use
+                    hbmp,                       // the source DDB
+                    0,                          // first scan line
+                    h,                          // number of lines to copy
+                    ds.dsBm.bmBits,             // pointer to the buffer
+                    (BITMAPINFO *)&ds.dsBmih,   // bitmap header
+                    DIB_RGB_COLORS              // and not DIB_PAL_COLORS
+                ) )

         {
         {

-            pQuad[i].rgbRed = pTriple[i].rgbtRed;
-            pQuad[i].rgbBlue = pTriple[i].rgbtBlue;
-            pQuad[i].rgbGreen = pTriple[i].rgbtGreen;
-            pQuad[i].rgbReserved = 0;
+            wxLogLastError(wxT("GetDIBits()"));
+
+            return 0;

         }
     }
 
         }
     }
 

-    /* offset to the bits from start of DIB header */
-    offBits = (WORD)(lpbi->biSize + nNumColors * sizeof(RGBQUAD));
+    return true;
+}
+
+// ----------------------------------------------------------------------------
+// Loading/saving the DIBs
+// ----------------------------------------------------------------------------

 
 

-    if (bf.bfOffBits != 0L)
+bool wxDIB::Load(const wxString& filename)
+{
+    m_handle = (HBITMAP)::LoadImage
+                         (
+                            wxGetInstance(),
+                            filename,
+                            IMAGE_BITMAP,
+                            0, 0, // don't specify the size
+                            LR_CREATEDIBSECTION | LR_LOADFROMFILE
+                         );
+    if ( !m_handle )

     {
     {

-        _llseek(fh,bf.bfOffBits,SEEK_SET);
+        wxLogLastError(_T("LoadImage(LR_CREATEDIBSECTION | LR_LOADFROMFILE)"));
+
+        return false;

     }
 
     }
 

-    if (lpbi->biSizeImage == lread(fh, (LPSTR)lpbi + offBits, lpbi->biSizeImage))
-    {
-        GlobalUnlock(hDIB);
+    return true;
+}
+
+bool wxDIB::Save(const wxString& filename)
+{
+    wxCHECK_MSG( m_handle, false, _T("wxDIB::Save(): invalid object") );

 
 

-        hDC = GetDC(NULL);
-        if (!MakeBitmapAndPalette(hDC, hDIB, palette,
-                                        bitmap))
+    wxFile file(filename, wxFile::write);
+    bool ok = file.IsOpened();
+    if ( ok )
+    {
+        DIBSECTION ds;
+        if ( !GetDIBSection(m_handle, &ds) )

         {
         {

-            ReleaseDC(NULL,hDC);
-            goto ErrExit2;
+            wxLogLastError(_T("GetObject(hDIB)"));

         }
         else
         {
         }
         else
         {

-            ReleaseDC(NULL,hDC);
-            GlobalFree(hDIB);
-            result = TRUE;
+            BITMAPFILEHEADER bmpHdr;
+            wxZeroMemory(bmpHdr);
+
+            const size_t sizeHdr = ds.dsBmih.biSize;
+            const size_t sizeImage = ds.dsBmih.biSizeImage;
+
+            bmpHdr.bfType = 0x4d42;    // 'BM' in little endian
+            bmpHdr.bfOffBits = sizeof(BITMAPFILEHEADER) + ds.dsBmih.biSize;
+            bmpHdr.bfSize = bmpHdr.bfOffBits + sizeImage;
+
+            // first write the file header, then the bitmap header and finally the
+            // bitmap data itself
+            ok = file.Write(&bmpHdr, sizeof(bmpHdr)) == sizeof(bmpHdr) &&
+                    file.Write(&ds.dsBmih, sizeHdr) == sizeHdr &&
+                        file.Write(ds.dsBm.bmBits, sizeImage) == sizeImage;

         }
     }
         }
     }

-    else
+
+    if ( !ok )

     {
     {

-ErrExit:
-        GlobalUnlock(hDIB);
-ErrExit2:
-        GlobalFree(hDIB);
+        wxLogError(_("Failed to save the bitmap image to file \"%s\"."),
+                   filename.c_str());

     }
 
     }
 

-    _lclose(fh);
-    return(result);
+    return ok;

 }
 
 }
 

-/****************************************************************************
- *
- *  FUNCTION   : MakeBitmapAndPalette
- *
- *  PURPOSE    : Given a DIB, creates a bitmap and corresponding palette
- *               to be used for a device-dependent representation of
- *               of the image.
- *
- *  RETURNS    : TRUE  --> success. phPal and phBitmap are filled with
- *                         appropriate handles.  Caller is responsible
- *                         for freeing objects.
- *               FALSE --> unable to create objects.  both pointer are
- *                         not valid
- *
- ****************************************************************************/
-static BOOL PASCAL MakeBitmapAndPalette(HDC hDC, HANDLE hDIB,
-                        HPALETTE * phPal, HBITMAP * phBitmap)
-{
-    LPBITMAPINFOHEADER lpInfo;
-    BOOL result = FALSE;
-    HBITMAP hBitmap;
-    HPALETTE hPalette, hOldPal;
-    LPSTR lpBits;
-
-#ifdef __WINDOWS_386__
-    lpInfo = (LPBITMAPINFOHEADER) MK_FP32(GlobalLock(hDIB));
-#else
-    lpInfo = (LPBITMAPINFOHEADER) GlobalLock(hDIB);
-#endif
+// ----------------------------------------------------------------------------
+// wxDIB accessors
+// ----------------------------------------------------------------------------

 
 

-    hPalette = wxMakeDIBPalette(lpInfo);
-    if ( hPalette )
+void wxDIB::DoGetObject() const
+{
+    // only do something if we have a valid DIB but we don't [yet] have valid
+    // data
+    if ( m_handle && !m_data )

     {
     {

-        // Need to realize palette for converting DIB to bitmap.
-        hOldPal = SelectPalette(hDC, hPalette, TRUE);
-        RealizePalette(hDC);
-
-        lpBits = (LPSTR)lpInfo + (WORD)lpInfo->biSize +
-                (WORD)lpInfo->biClrUsed * sizeof(RGBQUAD);
-        hBitmap = CreateDIBitmap(hDC, lpInfo, CBM_INIT, lpBits,
-                                (LPBITMAPINFO)lpInfo, DIB_RGB_COLORS);
-
-        SelectPalette(hDC, hOldPal, TRUE);
-        RealizePalette(hDC);
-
-        if (!hBitmap)
-            DeleteObject(hPalette);
-        else
+        // although all the info we need is in BITMAP and so we don't really
+        // need DIBSECTION we still ask for it as modifying the bit values only
+        // works for the real DIBs and not for the bitmaps and it's better to
+        // check for this now rather than trying to find out why it doesn't
+        // work later
+        DIBSECTION ds;
+        if ( !GetDIBSection(m_handle, &ds) )

         {
         {

-            *phBitmap = hBitmap;
-            *phPal = hPalette;
-            result = TRUE;
+            wxLogLastError(_T("GetObject(hDIB)"));
+            return;

         }
         }

+
+        wxDIB *self = wxConstCast(this, wxDIB);
+
+        self->m_width = ds.dsBm.bmWidth;
+        self->m_height = ds.dsBm.bmHeight;
+        self->m_depth = ds.dsBm.bmBitsPixel;
+        self->m_data = ds.dsBm.bmBits;

     }
     }

+}

 
 

-       GlobalUnlock (hDIB);  // glt
+// ----------------------------------------------------------------------------
+// DDB <-> DIB conversions
+// ----------------------------------------------------------------------------

 
 

-    return(result);
+HBITMAP wxDIB::CreateDDB(HDC hdc) const
+{
+    wxCHECK_MSG( m_handle, 0, _T("wxDIB::CreateDDB(): invalid object") );
+
+    DIBSECTION ds;
+    if ( !GetDIBSection(m_handle, &ds) )
+    {
+        wxLogLastError(_T("GetObject(hDIB)"));
+
+        return 0;
+    }
+
+    return ConvertToBitmap((BITMAPINFO *)&ds.dsBmih, hdc, ds.dsBm.bmBits);

 }
 
 }
 

-/****************************************************************************
- *                                                                            *
- *  FUNCTION   : wxMakeDIBPalette(lpInfo)                                            *
- *                                                                            *
- *  PURPOSE    : Given a BITMAPINFOHEADER, create a palette based on
- *                 the color table.
- *
- *                                                                            *
- *  RETURNS    : non-zero - handle of a corresponding palette
- *                 zero - unable to create palette
- *                                                                            *
- ****************************************************************************/
-HPALETTE wxMakeDIBPalette(LPBITMAPINFOHEADER lpInfo)
+/* static */
+HBITMAP wxDIB::ConvertToBitmap(const BITMAPINFO *pbmi, HDC hdc, void *bits)

 {
 {

-#ifdef __WXWINE__
-        return (FALSE);
-#else
-    LPLOGPALETTE npPal;
-    RGBQUAD far *lpRGB;
-    HPALETTE hLogPal;
-    WORD i;
-
-    /* since biClrUsed field was filled during the loading of the DIB,
-    ** we know it contains the number of colors in the color table.
-    */
-    if (lpInfo->biClrUsed)
+    wxCHECK_MSG( pbmi, 0, _T("invalid DIB in ConvertToBitmap") );
+
+    // here we get BITMAPINFO struct followed by the actual bitmap bits and
+    // BITMAPINFO starts with BITMAPINFOHEADER followed by colour info
+    const BITMAPINFOHEADER *pbmih = &pbmi->bmiHeader;
+
+    // get the pointer to the start of the real image data if we have a plain
+    // DIB and not a DIB section (in the latter case the pointer must be passed
+    // to us by the caller)
+    if ( !bits )

     {
     {

-/*
-        npPal = (NPLOGPALETTE)LocalAlloc(LMEM_FIXED, sizeof(LOGPALETTE) +
-                                (WORD)lpInfo->biClrUsed * sizeof(PALETTEENTRY));
-*/
-        npPal = (LPLOGPALETTE)malloc(sizeof(LOGPALETTE) +
-                                (WORD)lpInfo->biClrUsed * sizeof(PALETTEENTRY));
-        if (!npPal)
-            return(FALSE);
-
-        npPal->palVersion = 0x300;
-        npPal->palNumEntries = (WORD)lpInfo->biClrUsed;
-
-        /* get pointer to the color table */
-        lpRGB = (RGBQUAD FAR *)((LPSTR)lpInfo + lpInfo->biSize);
-
-        /* copy colors from the color table to the LogPalette structure */
-        for (i = 0; (DWORD)i < lpInfo->biClrUsed; i++, lpRGB++)
+        // we must skip over the colour table to get to the image data
+        //
+        // colour table either has the real colour data in which case its
+        // number of entries is given by biClrUsed or is used for masks to be
+        // used for extracting colour information from true colour bitmaps in
+        // which case it always have exactly 3 DWORDs
+        int numColors;
+        switch ( pbmih->biCompression )

         {
         {

-            npPal->palPalEntry[i].peRed = lpRGB->rgbRed;
-            npPal->palPalEntry[i].peGreen = lpRGB->rgbGreen;
-            npPal->palPalEntry[i].peBlue = lpRGB->rgbBlue;
-            npPal->palPalEntry[i].peFlags = 0;
-        }
+            case BI_BITFIELDS:
+                numColors = 3;
+                break;
+
+            case BI_RGB:
+                // biClrUsed has the number of colors but it may be not initialized at
+                // all
+                numColors = pbmih->biClrUsed;
+                if ( !numColors )
+                {
+                    numColors = wxGetNumOfBitmapColors(pbmih->biBitCount);
+                }
+                break;

 
 

-        hLogPal = CreatePalette((LPLOGPALETTE)npPal);
-//        LocalFree((HANDLE)npPal);
-        free(npPal);
+            default:
+                // no idea how it should be calculated for the other cases
+                numColors = 0;
+        }

 
 

-        return(hLogPal);
+        bits = (char *)pbmih + sizeof(*pbmih) + numColors*sizeof(RGBQUAD);

     }
 
     }
 

-    /* 24-bit DIB with no color table.  return default palette.  Another
-    ** option would be to create a 256 color "rainbow" palette to provide
-    ** some good color choices.
-    */
-    else
-        return((HPALETTE) GetStockObject(DEFAULT_PALETTE));
-#endif
+    HBITMAP hbmp = ::CreateDIBitmap
+                     (
+                        hdc ? hdc           // create bitmap compatible
+                            : (HDC) ScreenHDC(),  //  with this DC
+                        pbmih,              // used to get size &c
+                        CBM_INIT,           // initialize bitmap bits too
+                        bits,               // ... using this data
+                        pbmi,               // this is used for palette only
+                        DIB_RGB_COLORS      // direct or indexed palette?
+                     );
+
+    if ( !hbmp )
+    {
+        wxLogLastError(wxT("CreateDIBitmap"));
+    }

 
 

+    return hbmp;

 }
 
 }
 

-bool wxLoadIntoBitmap(wxChar *filename, wxBitmap *bitmap, wxPalette **pal)
+/* static */
+size_t wxDIB::ConvertFromBitmap(BITMAPINFO *pbi, HBITMAP hbmp)

 {
 {

-  HBITMAP hBitmap = NULL;
-  HPALETTE hPalette = NULL;
+    wxASSERT_MSG( hbmp, wxT("invalid bmp can't be converted to DIB") );

 
 

-  bool success = (wxReadDIB(filename, &hBitmap, &hPalette) != 0);
+    // prepare all the info we need
+    BITMAP bm;
+    if ( !::GetObject(hbmp, sizeof(bm), &bm) )
+    {
+        wxLogLastError(wxT("GetObject(bitmap)"));

 
 

-  if (!success)
-  {
-    if (hPalette)
-        DeleteObject(hPalette);
-    return FALSE;
-  }
+        return 0;
+    }

 
 

-  if (hPalette)
-  {
-#if wxUSE_PALETTE
-    if (pal)
+    // we need a BITMAPINFO anyhow and if we're not given a pointer to it we
+    // use this one
+    BITMAPINFO bi2;
+
+    const bool wantSizeOnly = pbi == NULL;
+    if ( wantSizeOnly )
+        pbi = &bi2;
+
+    // just for convenience
+    const int h = bm.bmHeight;
+
+    // init the header
+    BITMAPINFOHEADER& bi = pbi->bmiHeader;
+    wxZeroMemory(bi);
+    bi.biSize = sizeof(BITMAPINFOHEADER);
+    bi.biWidth = bm.bmWidth;
+    bi.biHeight = h;
+    bi.biPlanes = 1;
+    bi.biBitCount = bm.bmBitsPixel;
+
+    // memory we need for BITMAPINFO only
+    DWORD dwLen = bi.biSize + wxGetNumOfBitmapColors(bm.bmBitsPixel) * sizeof(RGBQUAD);
+
+    // get either just the image size or the image bits
+    if ( !::GetDIBits
+            (
+                ScreenHDC(),                        // the DC to use
+                hbmp,                               // the source DDB
+                0,                                  // first scan line
+                h,                                  // number of lines to copy
+                wantSizeOnly ? NULL                 // pointer to the buffer or
+                             : (char *)pbi + dwLen, // NULL if we don't have it
+                pbi,                                // bitmap header
+                DIB_RGB_COLORS                      // or DIB_PAL_COLORS
+            ) )

     {
     {

-      *pal = new wxPalette;
-      (*pal)->SetHPALETTE((WXHPALETTE) hPalette);
+        wxLogLastError(wxT("GetDIBits()"));
+
+        return 0;

     }
     }

-    else
-#endif // wxUSE_PALETTE
-      DeleteObject(hPalette);
-  }
-  else if (pal)
-    *pal = NULL;

 
 

-  if (hBitmap)
-  {
-    BITMAP bm;
-    GetObject(hBitmap, sizeof(bm), (LPSTR)&bm);
-
-    bitmap->SetHBITMAP((WXHBITMAP) hBitmap);
-    bitmap->SetWidth(bm.bmWidth);
-    bitmap->SetHeight(bm.bmHeight);
-    bitmap->SetDepth(bm.bmPlanes * bm.bmBitsPixel);
-#if WXWIN_COMPATIBILITY_2
-    bitmap->SetOk(TRUE);
-#endif // WXWIN_COMPATIBILITY_2
-    return TRUE;
-  }
-  else return FALSE;
+    // return the total size
+    return dwLen + bi.biSizeImage;

 }
 
 }
 

-wxBitmap *wxLoadBitmap(wxChar *filename, wxPalette **pal)
+/* static */
+HGLOBAL wxDIB::ConvertFromBitmap(HBITMAP hbmp)

 {
 {

-  wxBitmap *bitmap = new wxBitmap;
-  if (wxLoadIntoBitmap(filename, bitmap, pal))
-    return bitmap;
-  else
-  {
-    delete bitmap;
-    return NULL;
-  }
-}
+    // first calculate the size needed
+    const size_t size = ConvertFromBitmap(NULL, hbmp);
+    if ( !size )
+    {
+        // conversion to DDB failed?
+        return NULL;
+    }

 
 

-//---------------------------------------------------------------------
-//
-// Function:   InitBitmapInfoHeader
-//
-// Purpose:    Does a "standard" initialization of a BITMAPINFOHEADER,
-//             given the Width, Height, and Bits per Pixel for the
-//             DIB.
-//
-//             By standard, I mean that all the relevant fields are set
-//             to the specified values.  biSizeImage is computed, the
-//             biCompression field is set to "no compression," and all
-//             other fields are 0.
-//
-//             Note that DIBs only allow BitsPixel values of 1, 4, 8, or
-//             24.  This routine makes sure that one of these values is
-//             used (whichever is most appropriate for the specified
-//             nBPP).
-//
-// Parms:      lpBmInfoHdr == Far pointer to a BITMAPINFOHEADER structure
-//                            to be filled in.
-//             dwWidth     == Width of DIB (not in Win 3.0 & 3.1, high
-//                            word MUST be 0).
-//             dwHeight    == Height of DIB (not in Win 3.0 & 3.1, high
-//                            word MUST be 0).
-//             nBPP        == Bits per Pixel for the DIB.
-//
-// History:   Date      Reason
-//            11/07/91  Created
-//
-//---------------------------------------------------------------------
-
-static void InitBitmapInfoHeader (LPBITMAPINFOHEADER lpBmInfoHdr,
-                                        DWORD dwWidth,
-                                        DWORD dwHeight,
-                                          int nBPP)
-{
-//   _fmemset (lpBmInfoHdr, 0, sizeof (BITMAPINFOHEADER));
-   memset (lpBmInfoHdr, 0, sizeof (BITMAPINFOHEADER));
-
-   lpBmInfoHdr->biSize      = sizeof (BITMAPINFOHEADER);
-   lpBmInfoHdr->biWidth     = dwWidth;
-   lpBmInfoHdr->biHeight    = dwHeight;
-   lpBmInfoHdr->biPlanes    = 1;
-
-   if (nBPP <= 1)
-      nBPP = 1;
-   else if (nBPP <= 4)
-      nBPP = 4;
-   else if (nBPP <= 8)
-      nBPP = 8;
-/* Doesn't work
-   else if (nBPP <= 16)
-      nBPP = 16;
-*/
-   else
-      nBPP = 24;
-
-   lpBmInfoHdr->biBitCount  = nBPP;
-   lpBmInfoHdr->biSizeImage = WIDTHBYTES (dwWidth * nBPP) * dwHeight;
-}
+    HGLOBAL hDIB = ::GlobalAlloc(GMEM_MOVEABLE, size);
+    if ( !hDIB )
+    {
+        // this is an error which does risk to happen especially under Win9x
+        // and which the user may understand so let him know about it
+        wxLogError(_("Failed to allocated %luKb of memory for bitmap data."),
+                   (unsigned long)(size / 1024));

 
 

+        return NULL;
+    }

 
 

+    if ( !ConvertFromBitmap((BITMAPINFO *)(void *)GlobalPtr(hDIB), hbmp) )
+    {
+        // this really shouldn't happen... it worked the first time, why not
+        // now?
+        wxFAIL_MSG( _T("wxDIB::ConvertFromBitmap() unexpectedly failed") );

 
 

+        return NULL;
+    }

 
 

-LPSTR wxFindDIBBits (LPSTR lpbi)
-{
-   return (lpbi + *(LPDWORD)lpbi + wxPaletteSize (lpbi));
+    return hDIB;

 }
 
 }
 

-//---------------------------------------------------------------------
-//
-// Function:   BitmapToDIB
-//
-// Purpose:    Given a device dependent bitmap and a palette, returns
-//             a handle to global memory with a DIB spec in it.  The
-//             DIB is rendered using the colors of the palette passed in.
-//
-//             Stolen almost verbatim from ShowDIB.
-//
-// Parms:      hBitmap == Handle to device dependent bitmap compatible
-//                        with default screen display device.
-//             hPal    == Palette to render the DDB with.  If it's NULL,
-//                        use the default palette.
-//
-// History:   Date      Reason
-//             6/01/91  Created
-//
-//---------------------------------------------------------------------
-
-HANDLE wxBitmapToDIB (HBITMAP hBitmap, HPALETTE hPal)
-{
-   BITMAP             Bitmap;
-   BITMAPINFOHEADER   bmInfoHdr;
-   LPBITMAPINFOHEADER lpbmInfoHdr;
-   LPSTR              lpBits;
-   HDC                hMemDC;
-   HANDLE             hDIB;
-   HPALETTE           hOldPal = NULL;
+// ----------------------------------------------------------------------------
+// palette support
+// ----------------------------------------------------------------------------

 
 

-      // Do some setup -- make sure the Bitmap passed in is valid,
-      //  get info on the bitmap (like its height, width, etc.),
-      //  then setup a BITMAPINFOHEADER.
+#if wxUSE_PALETTE

 
 

-   if (!hBitmap)
-      return NULL;
+wxPalette *wxDIB::CreatePalette() const
+{
+    wxCHECK_MSG( m_handle, NULL, _T("wxDIB::CreatePalette(): invalid object") );

 
 

-   if (!GetObject (hBitmap, sizeof (Bitmap), (LPSTR) &Bitmap))
-      return NULL;
+    DIBSECTION ds;
+    if ( !GetDIBSection(m_handle, &ds) )
+    {
+        wxLogLastError(_T("GetObject(hDIB)"));

 
 

-   InitBitmapInfoHeader (&bmInfoHdr,
-                         Bitmap.bmWidth,
-                         Bitmap.bmHeight,
-                         Bitmap.bmPlanes * Bitmap.bmBitsPixel);
+        return 0;
+    }

 
 

+    // how many colours are we going to have in the palette?
+    DWORD biClrUsed = ds.dsBmih.biClrUsed;
+    if ( !biClrUsed )
+    {
+        // biClrUsed field might not be set
+        biClrUsed = wxGetNumOfBitmapColors(ds.dsBmih.biBitCount);
+    }

 
 

-      // Now allocate memory for the DIB.  Then, set the BITMAPINFOHEADER
-      //  into this memory, and find out where the bitmap bits go.
+    if ( !biClrUsed )
+    {
+        // bitmaps of this depth don't have palettes at all
+        //
+        // NB: another possibility would be to return
+        //     GetStockObject(DEFAULT_PALETTE) or even CreateHalftonePalette()?
+        return NULL;
+    }

 
 

-   hDIB = GlobalAlloc (GHND, sizeof (BITMAPINFOHEADER) +
-             wxPaletteSize ((LPSTR) &bmInfoHdr) + bmInfoHdr.biSizeImage);
+    // LOGPALETTE struct has only 1 element in palPalEntry array, we're
+    // going to have biClrUsed of them so add necessary space
+    LOGPALETTE *pPalette = (LOGPALETTE *)
+        malloc(sizeof(LOGPALETTE) + (biClrUsed - 1)*sizeof(PALETTEENTRY));
+    wxCHECK_MSG( pPalette, NULL, _T("out of memory") );

 
 

-   if (!hDIB)
-      return NULL;
+    // initialize the palette header
+    pPalette->palVersion = 0x300;  // magic number, not in docs but works
+    pPalette->palNumEntries = biClrUsed;

 
 

-#ifdef __WINDOWS_386__
-   lpbmInfoHdr  = (LPBITMAPINFOHEADER) MK_FP32(GlobalLock (hDIB));
-#else
-   lpbmInfoHdr  = (LPBITMAPINFOHEADER) GlobalLock (hDIB);
-#endif
-
-   *lpbmInfoHdr = bmInfoHdr;
-   lpBits       = wxFindDIBBits ((LPSTR) lpbmInfoHdr);
+    // and the colour table (it starts right after the end of the header)
+    const RGBQUAD *pRGB = (RGBQUAD *)((char *)&ds.dsBmih + ds.dsBmih.biSize);
+    for ( DWORD i = 0; i < biClrUsed; i++, pRGB++ )
+    {
+        pPalette->palPalEntry[i].peRed = pRGB->rgbRed;
+        pPalette->palPalEntry[i].peGreen = pRGB->rgbGreen;
+        pPalette->palPalEntry[i].peBlue = pRGB->rgbBlue;
+        pPalette->palPalEntry[i].peFlags = 0;
+    }

 
 

+    HPALETTE hPalette = ::CreatePalette(pPalette);

 
 

-      // Now, we need a DC to hold our bitmap.  If the app passed us
-      //  a palette, it should be selected into the DC.
+    free(pPalette);

 
 

-   hMemDC       = GetDC (NULL);
+    if ( !hPalette )
+    {
+        wxLogLastError(_T("CreatePalette"));

 
 

-   if (hPal)
-      {
-      hOldPal = SelectPalette (hMemDC, hPal, FALSE);
-      RealizePalette (hMemDC);
-      }
+        return NULL;
+    }

 
 

+    wxPalette *palette = new wxPalette;
+    palette->SetHPALETTE((WXHPALETTE)hPalette);

 
 

+    return palette;
+}

 
 

-      // We're finally ready to get the DIB.  Call the driver and let
-      //  it party on our bitmap.  It will fill in the color table,
-      //  and bitmap bits of our global memory block.
+#endif // wxUSE_PALETTE

 
 

-   if (!GetDIBits (hMemDC,
-                   hBitmap,
-                   0,
-                   Bitmap.bmHeight,
-                   lpBits,
-                   (LPBITMAPINFO) lpbmInfoHdr,
-                   DIB_RGB_COLORS))
-      {
-      GlobalUnlock (hDIB);
-      GlobalFree (hDIB);
-      hDIB = NULL;
-      }
-   else
-      GlobalUnlock (hDIB);
+// ----------------------------------------------------------------------------
+// wxImage support
+// ----------------------------------------------------------------------------

 
 

+#if wxUSE_IMAGE

 
 

-      // Finally, clean up and return.
+bool wxDIB::Create(const wxImage& image)
+{
+    wxCHECK_MSG( image.Ok(), false, _T("invalid wxImage in wxDIB ctor") );
+
+    const int h = image.GetHeight();
+    const int w = image.GetWidth();
+
+    // if we have alpha channel, we need to create a 32bpp RGBA DIB, otherwise
+    // a 24bpp RGB is sufficient
+    const bool hasAlpha = image.HasAlpha();
+    const int bpp = hasAlpha ? 32 : 24;
+
+    if ( !Create(w, h, bpp) )
+        return false;
+
+    // DIBs are stored in bottom to top order (see also the comment above in
+    // Create()) so we need to copy bits line by line and starting from the end
+    const int srcBytesPerLine = w * 3;
+    const int dstBytesPerLine = GetLineSize(w, bpp);
+    const unsigned char *src = image.GetData() + ((h - 1) * srcBytesPerLine);
+    const unsigned char *alpha = hasAlpha ? image.GetAlpha() + (h - 1)*w : NULL;
+    unsigned char *dstLineStart = (unsigned char *)m_data;
+    for ( int y = 0; y < h; y++ )
+    {
+        // copy one DIB line
+        unsigned char *dst = dstLineStart;
+        for ( int x = 0; x < w; x++ )
+        {
+            // also, the order of RGB is inversed for DIBs
+            *dst++ = src[2];
+            *dst++ = src[1];
+            *dst++ = src[0];

 
 

-   if (hOldPal)
-      SelectPalette (hMemDC, hOldPal, FALSE);
+            src += 3;

 
 

-   ReleaseDC (NULL, hMemDC);
+            if ( alpha )
+                *dst++ = *alpha++;
+        }

 
 

-   return hDIB;
-}
+        // pass to the previous line in the image
+        src -= 2*srcBytesPerLine;
+        if ( alpha )
+            alpha -= 2*w;

 
 

-bool wxSaveBitmap(wxChar *filename, wxBitmap *bitmap, wxPalette *colourmap)
-{
-  HPALETTE hPalette = 0;
-#if wxUSE_PALETTE
-  if (colourmap)
-    hPalette = (HPALETTE) colourmap->GetHPALETTE();
-#endif // wxUSE_PALETTE
+        // and to the next one in the DIB
+        dstLineStart += dstBytesPerLine;
+    }

 
 

-  HANDLE dibHandle = wxBitmapToDIB((HBITMAP) bitmap->GetHBITMAP(), hPalette);
-  if (dibHandle)
-  {
-    bool success = (WriteDIB(filename, dibHandle) != 0);
-    GlobalFree(dibHandle);
-    return success;
-  }
-  else return FALSE;
+    return true;

 }
 
 }
 

+#endif // wxUSE_IMAGE
+
+#endif
+    // wxUSE_WXDIB
+