Some manual updates; in MDI sample, child frames now have default size/position ...

[wxWidgets.git] / src / common / log.cpp

diff --git a/src/common/log.cpp b/src/common/log.cpp
index 08436bececdfc8e658304a8bf7eba44082f18b96..447f2feda9c494a20bd21e4d493fd84ef2b7f3d0 100644 (file)
--- a/src/common/log.cpp
+++ b/src/common/log.cpp
@@ -32,6 +32,7 @@
   #include  <wx/app.h>
   #include  <wx/string.h>
   #include  <wx/intl.h>
+  #include  <wx/menu.h>
 
   #include  <wx/generic/msgdlgg.h>
   #include  <wx/filedlg.h>
@@ -40,6 +41,7 @@
 
 #include  <wx/file.h>
 #include  <wx/textfile.h>
+#include  <wx/utils.h>
 #include  <wx/log.h>
 
 // other standard headers
@@ -213,8 +215,8 @@ wxLog::wxLog()
   m_ulTraceMask  = (wxTraceMask)0;        // -1 to set all bits
 }
 
-wxLog *wxLog::GetActiveTarget() 
-{ 
+wxLog *wxLog::GetActiveTarget()
+{
   if ( !ms_bInitialized ) {
     // prevent infinite recursion if someone calls wxLogXXX() from
     // wxApp::CreateLogTarget()
@@ -230,20 +232,20 @@ wxLog *wxLog::GetActiveTarget()
     // do nothing if it fails - what can we do?
   }
 
-  return ms_pLogger; 
+  return ms_pLogger;
 }
 
 wxLog *wxLog::SetActiveTarget(wxLog *pLogger)
-{ 
+{
   // flush the old messages before changing
   if ( ms_pLogger != NULL )
     ms_pLogger->Flush();
 
   ms_bInitialized = TRUE;
 
-  wxLog *pOldLogger = ms_pLogger; 
-  ms_pLogger = pLogger; 
-  return pOldLogger; 
+  wxLog *pOldLogger = ms_pLogger;
+  ms_pLogger = pLogger;
+  return pOldLogger;
 }
 
 void wxLog::DoLog(wxLogLevel level, const char *szString)
@@ -300,7 +302,7 @@ void wxLog::DoLog(wxLogLevel level, const char *szString)
         DoLogString(str << (level == wxLOG_Trace ? _("Trace") : _("Debug"))
                         << ": " << szString);
       #endif
-            
+
       break;
 
     default:
@@ -308,7 +310,7 @@ void wxLog::DoLog(wxLogLevel level, const char *szString)
   }
 }
 
-void wxLog::DoLogString(const char *szString)
+void wxLog::DoLogString(const char *WXUNUSED(szString))
 {
   wxFAIL_MSG("DoLogString must be overrided if it's called.");
 }
@@ -389,10 +391,10 @@ void wxLogGui::Flush()
     return;
 
   // @@@ ugly...
-  
+
   // concatenate all strings (but not too many to not overfill the msg box)
   wxString str;
-  uint nLines    = 0, 
+  uint nLines    = 0,
        nMsgCount = m_aMessages.Count();
 
   // start from the most recent message
@@ -477,7 +479,7 @@ void wxLogGui::DoLog(wxLogLevel level, const char *szString)
 
       m_aMessages.Add(szString);
       break;
-    
+
     default:
       wxFAIL_MSG("unknown log level in wxLogGui::DoLog");
   }
@@ -523,7 +525,7 @@ BEGIN_EVENT_TABLE(wxLogFrame, wxFrame)
   EVT_MENU(Menu_Clear, wxLogFrame::OnClear)
 
   EVT_CLOSE(wxLogFrame::OnCloseWindow)
-END_EVENT_TABLE() 
+END_EVENT_TABLE()
 
 wxLogFrame::wxLogFrame(const char *szTitle)
           : wxFrame(NULL, -1, szTitle)
@@ -558,19 +560,19 @@ wxLogFrame::wxLogFrame(const char *szTitle)
   // @@ what about status bar? needed (for menu prompts)?
 }
 
-void wxLogFrame::OnClose(wxCommandEvent& event)
+void wxLogFrame::OnClose(wxCommandEvent& WXUNUSED(event))
 {
   // just hide the window
   Show(FALSE);
 }
 
-void wxLogFrame::OnCloseWindow(wxCloseEvent& event)
+void wxLogFrame::OnCloseWindow(wxCloseEvent& WXUNUSED(event))
 {
   // just hide the window
   Show(FALSE);
 }
 
-void wxLogFrame::OnSave(wxCommandEvent& event)
+void wxLogFrame::OnSave(wxCommandEvent& WXUNUSED(event))
 {
   // get the file name
   // -----------------
@@ -583,9 +585,9 @@ void wxLogFrame::OnSave(wxCommandEvent& event)
   // open file
   // ---------
   wxFile file;
-  bool bOk;
+  bool bOk = FALSE; 
   if ( wxFile::Exists(szFileName) ) {
-    bool bAppend;
+    bool bAppend = FALSE;
     wxString strMsg;
     strMsg.Printf(_("Append log to file '%s' "
                     "(choosing [No] will overwrite it)?"), szFileName);
@@ -618,7 +620,6 @@ void wxLogFrame::OnSave(wxCommandEvent& event)
 
   // retrieve text and save it
   // -------------------------
-  
 #ifdef __WXGTK__
   // @@@@ TODO: no GetNumberOfLines and GetLineText in wxGTK yet
   wxLogError("Sorry, this function is not implemented under GTK");
@@ -628,7 +629,7 @@ void wxLogFrame::OnSave(wxCommandEvent& event)
     bOk = file.Write(m_pTextCtrl->GetLineText(nLine) + wxTextFile::GetEOL());
   }
 #endif //GTK
-  
+
   if ( bOk )
     bOk = file.Close();
 
@@ -638,7 +639,7 @@ void wxLogFrame::OnSave(wxCommandEvent& event)
   }
 }
 
-void wxLogFrame::OnClear(wxCommandEvent& event)
+void wxLogFrame::OnClear(wxCommandEvent& WXUNUSED(event))
 {
   m_pTextCtrl->Clear();
 }
@@ -647,7 +648,7 @@ wxLogWindow::wxLogWindow(const char *szTitle, bool bShow)
 {
   m_pOldLog = wxLog::GetActiveTarget();
   m_pLogFrame = new wxLogFrame(szTitle);
-  
+
   if ( bShow )
     m_pLogFrame->Show(TRUE);
 }
@@ -661,13 +662,13 @@ void wxLogWindow::DoLog(wxLogLevel level, const char *szString)
 {
   // first let the previous logger show it
   if ( m_pOldLog != NULL ) {
-    // @@@ why can't we access protected wxLog method from here (we derive 
+    // @@@ why can't we access protected wxLog method from here (we derive
     // from wxLog)? gcc gives "DoLog is protected in this context", what
     // does this mean? Anyhow, the cast is harmless and let's us do what
     // we want.
     ((wxLogWindow *)m_pOldLog)->DoLog(level, szString);
   }
-  
+
   // and this will format it nicely and call our DoLogString()
   wxLog::DoLog(level, szString);
 }
@@ -776,7 +777,7 @@ const char *wxSysErrorMsg(unsigned long nErrCode)
       // get error message from system
       LPVOID lpMsgBuf;
       FormatMessage(FORMAT_MESSAGE_ALLOCATE_BUFFER | FORMAT_MESSAGE_FROM_SYSTEM,
-                    NULL, nErrCode, 
+                    NULL, nErrCode,
                     MAKELANGID(LANG_NEUTRAL, SUBLANG_DEFAULT),
                     (LPTSTR)&lpMsgBuf,
                     0, NULL);
@@ -787,7 +788,7 @@ const char *wxSysErrorMsg(unsigned long nErrCode)
       LocalFree(lpMsgBuf);
 
       // returned string is capitalized and ended with '\r\n' - bad
-      s_szBuf[0] = (char)tolower(s_szBuf[0]);
+      s_szBuf[0] = (char)wxToLower(s_szBuf[0]);
       size_t len = strlen(s_szBuf);
       if ( len > 0 ) {
         // truncate string
@@ -844,10 +845,10 @@ void wxOnAssert(const char *szFile, int nLine, const char *szMsg)
     strcat(szBuf, ".");
   }
 
-  // send it to the normal log destination
-  wxLogDebug(szBuf);
-
   if ( !s_bNoAsserts ) {
+    // send it to the normal log destination
+    wxLogDebug(szBuf);
+
     strcat(szBuf, _("\nDo you want to stop the program?"
                     "\nYou can also choose [Cancel] to suppress "
                     "further warnings."));
@@ -861,7 +862,7 @@ void wxOnAssert(const char *szFile, int nLine, const char *szMsg)
       case wxCANCEL:
         s_bNoAsserts = TRUE;
         break;
-        
+
       //case wxNO: nothing to do
     }
   }