remove extraneous semicolons (patch 1299687)

[wxWidgets.git] / src / msw / renderer.cpp

diff --git a/src/msw/renderer.cpp b/src/msw/renderer.cpp
index 49bbb5e9202f0cad89b6af038e0021f3f9afdeb2..eb278ab3c20c88531ee0bd8d2cdc0d4cab97f4c1 100644 (file)
--- a/src/msw/renderer.cpp
+++ b/src/msw/renderer.cpp
@@ -32,7 +32,20 @@
 
 #include "wx/splitter.h"
 #include "wx/renderer.h"
 
 #include "wx/splitter.h"
 #include "wx/renderer.h"

+#include "wx/settings.h"

 #include "wx/msw/uxtheme.h"
 #include "wx/msw/uxtheme.h"

+#include "wx/msw/private.h"
+
+// tmschema.h is in Win32 Platform SDK and might not be available with earlier
+// compilers
+#ifndef CP_DROPDOWNBUTTON
+    #define CP_DROPDOWNBUTTON  1
+
+    #define CBXS_NORMAL        1
+    #define CBXS_HOT           2
+    #define CBXS_PRESSED       3
+    #define CBXS_DISABLED      4
+#endif

 
 // ----------------------------------------------------------------------------
 // wxRendererMSW: wxRendererNative implementation for "old" Win32 systems
 
 // ----------------------------------------------------------------------------
 // wxRendererMSW: wxRendererNative implementation for "old" Win32 systems


@@ -58,6 +71,8 @@ private:
 // wxRendererXP: wxRendererNative implementation for Windows XP and later
 // ----------------------------------------------------------------------------
 
 // wxRendererXP: wxRendererNative implementation for Windows XP and later
 // ----------------------------------------------------------------------------
 

+#if wxUSE_UXTHEME
+

 class WXDLLEXPORT wxRendererXP : public wxDelegateRendererNative
 {
 public:
 class WXDLLEXPORT wxRendererXP : public wxDelegateRendererNative
 {
 public:


@@ -78,10 +93,16 @@ public:
 
     virtual wxSplitterRenderParams GetSplitterParams(const wxWindow *win);
 
 
     virtual wxSplitterRenderParams GetSplitterParams(const wxWindow *win);
 

+    virtual void DrawComboBoxDropButton(wxWindow *win,
+                                        wxDC& dc,
+                                        const wxRect& rect,
+                                        int flags = 0);

 private:
     DECLARE_NO_COPY_CLASS(wxRendererXP)
 };
 
 private:
     DECLARE_NO_COPY_CLASS(wxRendererXP)
 };
 

+#endif // wxUSE_UXTHEME
+

 // ============================================================================
 // wxRendererNative and wxRendererMSW implementation
 // ============================================================================
 // ============================================================================
 // wxRendererNative and wxRendererMSW implementation
 // ============================================================================


@@ -89,9 +110,13 @@ private:
 /* static */
 wxRendererNative& wxRendererNative::GetDefault()
 {
 /* static */
 wxRendererNative& wxRendererNative::GetDefault()
 {

+#if wxUSE_UXTHEME

     wxUxThemeEngine *themeEngine = wxUxThemeEngine::Get();
     wxUxThemeEngine *themeEngine = wxUxThemeEngine::Get();

-    return themeEngine && themeEngine->IsAppThemed() ? wxRendererXP::Get()
-                                                     : wxRendererMSW::Get();
+    if ( themeEngine && themeEngine->IsAppThemed() )
+        return wxRendererXP::Get();
+#endif // wxUSE_UXTHEME
+
+    return wxRendererMSW::Get();

 }
 
 /* static */
 }
 
 /* static */


@@ -102,6 +127,10 @@ wxRendererNative& wxRendererMSW::Get()
     return s_rendererMSW;
 }
 
     return s_rendererMSW;
 }
 

+#if defined(__WXWINCE__) && !defined(DFCS_FLAT)
+#define DFCS_FLAT 0
+#endif
+

 void
 wxRendererMSW::DrawComboBoxDropButton(wxWindow * WXUNUSED(win),
                                       wxDC& dc,
 void
 wxRendererMSW::DrawComboBoxDropButton(wxWindow * WXUNUSED(win),
                                       wxDC& dc,


@@ -111,14 +140,14 @@ wxRendererMSW::DrawComboBoxDropButton(wxWindow * WXUNUSED(win),
     RECT r;
     r.left = rect.GetLeft();
     r.top = rect.GetTop();
     RECT r;
     r.left = rect.GetLeft();
     r.top = rect.GetTop();

-    r.bottom = rect.GetBottom();
-    r.right = rect.GetRight();
+    r.bottom = rect.y + rect.height;
+    r.right = rect.x + rect.width;

 
     int style = DFCS_SCROLLCOMBOBOX;
     if ( flags & wxCONTROL_DISABLED )
         style |= DFCS_INACTIVE;
     if ( flags & wxCONTROL_PRESSED )
 
     int style = DFCS_SCROLLCOMBOBOX;
     if ( flags & wxCONTROL_DISABLED )
         style |= DFCS_INACTIVE;
     if ( flags & wxCONTROL_PRESSED )

-        style |= DFCS_PUSHED;
+        style |= DFCS_PUSHED | DFCS_FLAT;

 
     ::DrawFrameControl(GetHdcOf(dc), &r, DFC_SCROLL, style);
 }
 
     ::DrawFrameControl(GetHdcOf(dc), &r, DFC_SCROLL, style);
 }


@@ -127,6 +156,8 @@ wxRendererMSW::DrawComboBoxDropButton(wxWindow * WXUNUSED(win),
 // wxRendererXP implementation
 // ============================================================================
 
 // wxRendererXP implementation
 // ============================================================================
 

+#if wxUSE_UXTHEME
+

 /* static */
 wxRendererNative& wxRendererXP::Get()
 {
 /* static */
 wxRendererNative& wxRendererXP::Get()
 {


@@ -135,6 +166,47 @@ wxRendererNative& wxRendererXP::Get()
     return s_rendererXP;
 }
 
     return s_rendererXP;
 }
 

+// NOTE: There is no guarantee that the button drawn fills the entire rect (XP
+// default theme, for example), so the caller should have cleared button's
+// background before this call. This is quite likely a wxMSW-specific thing.
+void
+wxRendererXP::DrawComboBoxDropButton(wxWindow * win,
+                                      wxDC& dc,
+                                      const wxRect& rect,
+                                      int flags)
+{
+    wxUxThemeHandle hTheme(win, L"COMBOBOX");
+    if ( hTheme )
+    {
+        RECT r;
+        r.left = rect.x;
+        r.top = rect.y;
+        r.right = rect.x + rect.width;
+        r.bottom = rect.y + rect.height;
+
+        int state;
+        if ( flags & wxCONTROL_PRESSED )
+            state = CBXS_PRESSED;
+        else if ( flags & wxCONTROL_CURRENT )
+            state = CBXS_HOT;
+        else if ( flags & wxCONTROL_DISABLED )
+            state = CBXS_DISABLED;
+        else
+            state = CBXS_NORMAL;
+
+        wxUxThemeEngine::Get()->DrawThemeBackground
+                                (
+                                    hTheme,
+                                    (HDC) dc.GetHDC(),
+                                    CP_DROPDOWNBUTTON,
+                                    state,
+                                    &r,
+                                    NULL
+                                );
+
+    }
+}
+

 // ----------------------------------------------------------------------------
 // splitter drawing
 // ----------------------------------------------------------------------------
 // ----------------------------------------------------------------------------
 // splitter drawing
 // ----------------------------------------------------------------------------


@@ -173,38 +245,22 @@ wxRendererXP::DrawSplitterSash(wxWindow *win,
 {
     if ( !win->HasFlag(wxSP_NO_XP_THEME) )
     {
 {
     if ( !win->HasFlag(wxSP_NO_XP_THEME) )
     {

-        wxUxThemeHandle hTheme(win, L"WINDOW");
-        if ( hTheme )
+        dc.SetPen(*wxTRANSPARENT_PEN);
+        dc.SetBrush(wxBrush(wxSystemSettings::GetColour(wxSYS_COLOUR_BTNFACE)));
+        if ( orient == wxVERTICAL )
+        {
+            dc.DrawRectangle(position, 0, SASH_WIDTH, size.y);
+        }
+        else // wxHORIZONTAL

         {
         {

-            RECT rect;
-            if ( orient == wxVERTICAL )
-            {
-                rect.left = position;
-                rect.right = position + SASH_WIDTH;
-                rect.top = 0;
-                rect.bottom = size.y;
-            }
-            else // wxHORIZONTAL
-            {
-                rect.left = 0;
-                rect.right = size.x;
-                rect.top = position;
-                rect.bottom = position + SASH_WIDTH;
-            }
-
-            wxUxThemeEngine::Get()->DrawThemeBackground
-                                    (
-                                        (WXHTHEME)hTheme,
-                                        dc.GetHDC(),
-                                        29, // WP_DIALOG: dlg background
-                                        0, // no particular state
-                                        &rect,
-                                        NULL
-                                    );
-            return;
+            dc.DrawRectangle(0, position, size.x, SASH_WIDTH);

         }
         }

+
+        return;

     }
 
     m_rendererNative.DrawSplitterSash(win, dc, size, position, orient, flags);
 }
 
     }
 
     m_rendererNative.DrawSplitterSash(win, dc, size, position, orient, flags);
 }
 

+#endif // wxUSE_UXTHEME
+