Avoid core dumps when SetImageList is used.

[wxWidgets.git] / src / msw / timer.cpp

diff --git a/src/msw/timer.cpp b/src/msw/timer.cpp
index 79419ead0f38da96000a7cd0832fbd8e90619555..796db83d7a6c63b073eaf46eb93f46a51f27c24f 100644 (file)
--- a/src/msw/timer.cpp
+++ b/src/msw/timer.cpp
@@ -1,15 +1,15 @@
 /////////////////////////////////////////////////////////////////////////////
 /////////////////////////////////////////////////////////////////////////////

-// Name:        timer.cpp
+// Name:        msw/timer.cpp

 // Purpose:     wxTimer implementation
 // Author:      Julian Smart
 // Modified by:
 // Created:     04/01/98
 // RCS-ID:      $Id$
 // Purpose:     wxTimer implementation
 // Author:      Julian Smart
 // Modified by:
 // Created:     04/01/98
 // RCS-ID:      $Id$

-// Copyright:   (c) Julian Smart and Markus Holzem
-// Licence:     wxWindows license
+// Copyright:   (c) Julian Smart
+// Licence:     wxWindows licence

 /////////////////////////////////////////////////////////////////////////////
 
 /////////////////////////////////////////////////////////////////////////////
 

-#ifdef __GNUG__
+#if defined(__GNUG__) && !defined(NO_GCC_PRAGMA)

     #pragma implementation "timer.h"
 #endif
 
     #pragma implementation "timer.h"
 #endif
 


@@ -20,48 +20,49 @@
     #pragma hdrstop
 #endif
 
     #pragma hdrstop
 #endif
 

-#include "wx/window.h"
-#include "wx/msw/private.h"
+#if wxUSE_TIMER

 
 #ifndef WX_PRECOMP
 
 #ifndef WX_PRECOMP

-    #include "wx/setup.h"
+    #include "wx/window.h"

     #include "wx/list.h"
     #include "wx/event.h"
     #include "wx/app.h"
     #include "wx/list.h"
     #include "wx/event.h"
     #include "wx/app.h"

+    #include "wx/intl.h"
+    #include "wx/log.h"

 #endif
 
 #endif
 

-#include "wx/intl.h"
-#include "wx/log.h"
+#include "wx/hashmap.h"

 
 #include "wx/timer.h"
 
 
 #include "wx/timer.h"
 

-#include <time.h>
-#include <sys/types.h>
+#include "wx/msw/private.h"

 
 

-#if !defined(__SC__) && !defined(__GNUWIN32__) && !defined(__MWERKS__)
-    #include <sys/timeb.h>
-#endif
+// from utils.cpp
+extern "C" WXDLLIMPEXP_BASE HWND
+wxCreateHiddenWindow(LPCTSTR *pclassname, LPCTSTR classname, WNDPROC wndproc);
+
+// ----------------------------------------------------------------------------
+// private globals
+// ----------------------------------------------------------------------------
+
+// define a hash containing all the timers: it is indexed by timer id and
+// contains the corresponding timer
+WX_DECLARE_HASH_MAP(unsigned long, wxTimer *, wxIntegerHash, wxIntegerEqual,
+                    wxTimerMap);
+
+static wxTimerMap g_timerMap;

 
 // ----------------------------------------------------------------------------
 // private functions
 // ----------------------------------------------------------------------------
 
 
 // ----------------------------------------------------------------------------
 // private functions
 // ----------------------------------------------------------------------------
 

-wxList wxTimerList(wxKEY_INTEGER);
-UINT WINAPI _EXPORT wxTimerProc(HWND hwnd, WORD, int idTimer, DWORD);
+void WINAPI wxTimerProc(HWND hwnd, WORD, int idTimer, DWORD);

 
 // ----------------------------------------------------------------------------
 // macros
 // ----------------------------------------------------------------------------
 
 
 // ----------------------------------------------------------------------------
 // macros
 // ----------------------------------------------------------------------------
 

-#ifdef __WIN32__
-    #define _EXPORT
-#else
-    #define _EXPORT _export
-#endif
-
-#if !USE_SHARED_LIBRARY
-    IMPLEMENT_ABSTRACT_CLASS(wxTimer, wxObject)
-#endif
+IMPLEMENT_ABSTRACT_CLASS(wxTimer, wxObject)

 
 // ============================================================================
 // implementation
 
 // ============================================================================
 // implementation


@@ -71,59 +72,65 @@ UINT WINAPI _EXPORT wxTimerProc(HWND hwnd, WORD, int idTimer, DWORD);
 // wxTimer class
 // ----------------------------------------------------------------------------
 
 // wxTimer class
 // ----------------------------------------------------------------------------
 

-wxTimer::wxTimer()
+void wxTimer::Init()

 {
 {

-    milli = 0;
-    lastMilli = -1;
-    id = 0;
+    m_id = 0;

 }
 
 wxTimer::~wxTimer()
 {
 }
 
 wxTimer::~wxTimer()
 {

-    Stop();
-
-    wxTimerList.DeleteObject(this);
+    wxTimer::Stop();

 }
 
 }
 

-bool wxTimer::Start(int milliseconds, bool mode)
+bool wxTimer::Start(int milliseconds, bool oneShot)

 {
 {

-    oneShot = mode;
-    if (milliseconds < 0)
-        milliseconds = lastMilli;
+    (void)wxTimerBase::Start(milliseconds, oneShot);

 
 

-    wxCHECK_MSG( milliseconds > 0, FALSE, T("invalid value for timer timeour") );
+    wxCHECK_MSG( m_milli > 0, false, wxT("invalid value for timer timeour") );

 
 

-    lastMilli = milli = milliseconds;
+    m_id = ::SetTimer
+             (
+                NULL,                       // don't use window
+                1,                          // id ignored with NULL hwnd anyhow
+                (UINT)m_milli,              // delay
+                (TIMERPROC)wxTimerProc      // timer proc to call
+             );

 
 

-    wxTimerList.DeleteObject(this);
-    TIMERPROC wxTimerProcInst = (TIMERPROC)
-        MakeProcInstance((FARPROC)wxTimerProc, wxGetInstance());
-
-    id = SetTimer(NULL, (UINT)(id ? id : 1),
-                  (UINT)milliseconds, wxTimerProcInst);
-    if (id > 0)
+    if ( !m_id )

     {
     {

-        wxTimerList.Append(id, this);
+        wxLogSysError(_("Couldn't create a timer"));

 
 

-        return TRUE;
+        return false;

     }
     }

-    else
+
+    // check that SetTimer() didn't reuse an existing id: according to the MSDN
+    // this can happen and this would be catastrophic to us as we rely on ids
+    // uniquely identifying the timers because we use them as keys in the hash
+    if ( g_timerMap.find(m_id) != g_timerMap.end() )

     {
     {

-        wxLogSysError(_("Couldn't create a timer"));
+        wxLogError(_("Timer creation failed."));
+
+        ::KillTimer(NULL, m_id);
+        m_id = 0;

 
 

-        return FALSE;
+        return false;

     }
     }

+
+    g_timerMap[m_id] = this;
+
+    return true;

 }
 
 void wxTimer::Stop()
 {
 }
 
 void wxTimer::Stop()
 {

-    if ( id )
+    if ( m_id )

     {
     {

-        KillTimer(NULL, (UINT)id);
-        wxTimerList.DeleteObject(this);
+        ::KillTimer(NULL, m_id);
+
+        g_timerMap.erase(m_id);

     }
     }

-    id = 0;
-    milli = 0;
+
+    m_id = 0;

 }
 
 // ----------------------------------------------------------------------------
 }
 
 // ----------------------------------------------------------------------------


@@ -132,23 +139,22 @@ void wxTimer::Stop()
 
 void wxProcessTimer(wxTimer& timer)
 {
 
 void wxProcessTimer(wxTimer& timer)
 {

-    // Avoid to process spurious timer events
-    if ( timer.id == 0)
-        return;
+    wxASSERT_MSG( timer.m_id != 0, _T("bogus timer id") );

 
 

-    if ( timer.oneShot )
+    if ( timer.IsOneShot() )

         timer.Stop();
 
     timer.Notify();
 }
 
         timer.Stop();
 
     timer.Notify();
 }
 

-UINT WINAPI _EXPORT wxTimerProc(HWND WXUNUSED(hwnd), WORD, int idTimer, DWORD)
+void WINAPI wxTimerProc(HWND WXUNUSED(hwnd), WORD, int idTimer, DWORD)

 {
 {

-    wxNode *node = wxTimerList.Find((long)idTimer);
+    wxTimerMap::iterator node = g_timerMap.find(idTimer);

 
 

-    wxCHECK_MSG( node, 0, T("bogus timer id in wxTimerProc") );
+    wxCHECK_RET( node != g_timerMap.end(), wxT("bogus timer id in wxTimerProc") );

 
 

-    wxProcessTimer(*(wxTimer *)node->Data());
-
-    return 0;
+    wxProcessTimer(*(node->second));

 }
 }

+
+#endif // wxUSE_TIMER
+