signed/unsigned comparison warning fixed

[wxWidgets.git] / src / msw / timer.cpp

diff --git a/src/msw/timer.cpp b/src/msw/timer.cpp
index 79419ead0f38da96000a7cd0832fbd8e90619555..0fe07b64a3ef841b1fd38e24a5b8e8177e7fad7b 100644 (file)
--- a/src/msw/timer.cpp
+++ b/src/msw/timer.cpp
@@ -5,8 +5,8 @@
 // Modified by:
 // Created:     04/01/98
 // RCS-ID:      $Id$
-// Copyright:   (c) Julian Smart and Markus Holzem
-// Licence:     wxWindows license
+// Copyright:   (c) Julian Smart
+// Licence:     wxWindows licence
 /////////////////////////////////////////////////////////////////////////////
 
 #ifdef __GNUG__
@@ -20,27 +20,21 @@
     #pragma hdrstop
 #endif
 
-#include "wx/window.h"
-#include "wx/msw/private.h"
+#if wxUSE_TIMER
 
 #ifndef WX_PRECOMP
     #include "wx/setup.h"
+    #include "wx/window.h"
     #include "wx/list.h"
     #include "wx/event.h"
     #include "wx/app.h"
+    #include "wx/intl.h"
+    #include "wx/log.h"
 #endif
 
-#include "wx/intl.h"
-#include "wx/log.h"
-
 #include "wx/timer.h"
 
-#include <time.h>
-#include <sys/types.h>
-
-#if !defined(__SC__) && !defined(__GNUWIN32__) && !defined(__MWERKS__)
-    #include <sys/timeb.h>
-#endif
+#include "wx/msw/private.h"
 
 // ----------------------------------------------------------------------------
 // private functions
@@ -59,10 +53,13 @@ UINT WINAPI _EXPORT wxTimerProc(HWND hwnd, WORD, int idTimer, DWORD);
     #define _EXPORT _export
 #endif
 
-#if !USE_SHARED_LIBRARY
-    IMPLEMENT_ABSTRACT_CLASS(wxTimer, wxObject)
+// should probably be in wx/msw/private.h
+#ifdef __WXMICROWIN__
+    #define MakeProcInstance(proc, hinst) proc
 #endif
 
+IMPLEMENT_ABSTRACT_CLASS(wxTimer, wxObject)
+
 // ============================================================================
 // implementation
 // ============================================================================
@@ -71,59 +68,54 @@ UINT WINAPI _EXPORT wxTimerProc(HWND hwnd, WORD, int idTimer, DWORD);
 // wxTimer class
 // ----------------------------------------------------------------------------
 
-wxTimer::wxTimer()
+void wxTimer::Init()
 {
-    milli = 0;
-    lastMilli = -1;
-    id = 0;
+    m_id = 0;
 }
 
 wxTimer::~wxTimer()
 {
-    Stop();
+    wxTimer::Stop();
 
     wxTimerList.DeleteObject(this);
 }
 
-bool wxTimer::Start(int milliseconds, bool mode)
+bool wxTimer::Start(int milliseconds, bool oneShot)
 {
-    oneShot = mode;
-    if (milliseconds < 0)
-        milliseconds = lastMilli;
+    (void)wxTimerBase::Start(milliseconds, oneShot);
 
-    wxCHECK_MSG( milliseconds > 0, FALSE, T("invalid value for timer timeour") );
+    wxCHECK_MSG( m_milli > 0, false, wxT("invalid value for timer timeour") );
 
-    lastMilli = milli = milliseconds;
-
-    wxTimerList.DeleteObject(this);
     TIMERPROC wxTimerProcInst = (TIMERPROC)
         MakeProcInstance((FARPROC)wxTimerProc, wxGetInstance());
 
-    id = SetTimer(NULL, (UINT)(id ? id : 1),
-                  (UINT)milliseconds, wxTimerProcInst);
-    if (id > 0)
+    m_id = ::SetTimer(NULL, (UINT)(m_id ? m_id : 1),
+                      (UINT)m_milli, wxTimerProcInst);
+
+    if ( m_id > 0 )
     {
-        wxTimerList.Append(id, this);
+        wxTimerList.Append(m_id, this);
 
-        return TRUE;
+        return true;
     }
     else
     {
         wxLogSysError(_("Couldn't create a timer"));
 
-        return FALSE;
+        return false;
     }
 }
 
 void wxTimer::Stop()
 {
-    if ( id )
+    if ( m_id )
     {
-        KillTimer(NULL, (UINT)id);
+        ::KillTimer(NULL, (UINT)m_id);
+
         wxTimerList.DeleteObject(this);
     }
-    id = 0;
-    milli = 0;
+
+    m_id = 0;
 }
 
 // ----------------------------------------------------------------------------
@@ -133,10 +125,10 @@ void wxTimer::Stop()
 void wxProcessTimer(wxTimer& timer)
 {
     // Avoid to process spurious timer events
-    if ( timer.id == 0)
+    if ( timer.m_id == 0)
         return;
 
-    if ( timer.oneShot )
+    if ( timer.IsOneShot() )
         timer.Stop();
 
     timer.Notify();
@@ -146,9 +138,11 @@ UINT WINAPI _EXPORT wxTimerProc(HWND WXUNUSED(hwnd), WORD, int idTimer, DWORD)
 {
     wxNode *node = wxTimerList.Find((long)idTimer);
 
-    wxCHECK_MSG( node, 0, T("bogus timer id in wxTimerProc") );
+    wxCHECK_MSG( node, 0, wxT("bogus timer id in wxTimerProc") );
 
-    wxProcessTimer(*(wxTimer *)node->Data());
+    wxProcessTimer(*(wxTimer *)node->GetData());
 
     return 0;
 }
+
+#endif // wxUSE_TIMER