m_headers.clear();
}
+void wxHTTP::ClearCookies()
+{
+ m_cookies.clear();
+}
+
wxString wxHTTP::GetContentType() const
{
return GetHeader(wxT("Content-Type"));
return it;
}
+wxHTTP::wxCookieIterator wxHTTP::FindCookie(const wxString& cookie)
+{
+ wxCookieIterator it = m_cookies.begin();
+ for ( wxCookieIterator en = m_cookies.end(); it != en; ++it )
+ {
+ if ( cookie.CmpNoCase(it->first) == 0 )
+ break;
+ }
+
+ return it;
+}
+
+wxHTTP::wxCookieConstIterator wxHTTP::FindCookie(const wxString& cookie) const
+{
+ wxCookieConstIterator it = m_cookies.begin();
+ for ( wxCookieConstIterator en = m_cookies.end(); it != en; ++it )
+ {
+ if ( cookie.CmpNoCase(it->first) == 0 )
+ break;
+ }
+
+ return it;
+}
+
void wxHTTP::SetHeader(const wxString& header, const wxString& h_data)
{
if (m_read) {
return it == m_headers.end() ? wxGetEmptyString() : it->second;
}
+wxString wxHTTP::GetCookie(const wxString& cookie) const
+{
+ wxCookieConstIterator it = FindCookie(cookie);
+
+ return it == m_cookies.end() ? wxGetEmptyString() : it->second;
+}
+
wxString wxHTTP::GenerateAuthString(const wxString& user, const wxString& pass) const
{
+ // TODO: Use wxBase64Encode() now that we have it instead of reproducing it
+
static const char *base64 = "ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789+/";
wxString buf;
wxStringTokenizer tokenzr;
ClearHeaders();
+ ClearCookies();
m_read = true;
for ( ;; )
if (m_lastError != wxPROTO_NOERR)
return false;
- if (line.length() == 0)
+ if ( line.empty() )
break;
wxString left_str = line.BeforeFirst(':');
- m_headers[left_str] = line.AfterFirst(':').Strip(wxString::both);
+ if(!left_str.CmpNoCase("Set-Cookie"))
+ {
+ wxString cookieName = line.AfterFirst(':').Strip(wxString::both).BeforeFirst('=');
+ wxString cookieValue = line.AfterFirst(':').Strip(wxString::both).AfterFirst('=').BeforeFirst(';');
+ m_cookies[cookieName] = cookieValue;
+
+ // For compatibility
+ m_headers[left_str] = line.AfterFirst(':').Strip(wxString::both);
+ }
+ else
+ {
+ m_headers[left_str] = line.AfterFirst(':').Strip(wxString::both);
+ }
}
return true;
}
wxIPV4address *addr;
if (m_addr) {
- delete m_addr;
- m_addr = NULL;
+ wxDELETE(m_addr);
Close();
}
m_addr = addr = new wxIPV4address();
if (!addr->Hostname(host)) {
- delete m_addr;
- m_addr = NULL;
+ wxDELETE(m_addr);
m_lastError = wxPROTO_NETERR;
return false;
}
else if (!addr->Service(wxT("http")))
addr->Service(80);
- SetHeader(wxT("Host"), host);
+ wxString hostHdr = host;
+ if ( port && port != 80 )
+ hostHdr << wxT(":") << port;
+ SetHeader(wxT("Host"), hostHdr);
m_lastError = wxPROTO_NOERR;
return true;
m_addr = addr.Clone();
wxIPV4address *ipv4addr = wxDynamicCast(&addr, wxIPV4address);
- if (ipv4addr)
- SetHeader(wxT("Host"), ipv4addr->OrigHostname());
+ if ( ipv4addr )
+ {
+ wxString hostHdr = ipv4addr->OrigHostname();
+ unsigned short port = ipv4addr->Service();
+ if ( port && port != 80 )
+ hostHdr << wxT(":") << port;
+ SetHeader(wxT("Host"), hostHdr);
+ }
m_lastError = wxPROTO_NOERR;
return true;
case wxHTTP_POST:
request = wxT("POST");
- if ( GetHeader( wxT("Content-Length") ).IsNull() )
+ if ( GetHeader( wxT("Content-Length") ).empty() )
SetHeader( wxT("Content-Length"), wxString::Format( wxT("%lu"), (unsigned long)m_post_buf.Len() ) );
break;
m_http_response = 0;
// If there is no User-Agent defined, define it.
- if (GetHeader(wxT("User-Agent")).IsNull())
+ if ( GetHeader(wxT("User-Agent")).empty() )
SetHeader(wxT("User-Agent"), wxT("wxWidgets 2.x"));
// Send authentication information
Write("\r\n", 2);
if ( req == wxHTTP_POST ) {
- Write(m_post_buf.mbc_str(), m_post_buf.Len());
+ // Post data can be arbitrary binary data when the "binary" content
+ // transfer encoding is used so don't assume it's ASCII only or
+ // NUL-terminated.
+ {
+ const wxScopedCharBuffer buf(m_post_buf.To8BitData());
+ Write(buf, buf.length());
+ } // delete the buffer before modifying the string it points to, it
+ // wouldn't really be a problem here even if we didn't do this
+ // because we won't use this buffer again but this will avoid any
+ // nasty surprises in the future if this code changes
+
m_post_buf = wxEmptyString;
}
protected:
size_t OnSysRead(void *buffer, size_t bufsize);
- DECLARE_NO_COPY_CLASS(wxHTTPStream)
+ wxDECLARE_NO_COPY_CLASS(wxHTTPStream);
};
size_t wxHTTPStream::OnSysRead(void *buffer, size_t bufsize)
{
- if (m_httpsize > 0 && m_read_bytes >= m_httpsize)
+ if (m_read_bytes >= m_httpsize)
{
m_lasterror = wxSTREAM_EOF;
return 0;