fix a crash when dismissing the popup window because of a key press

[wxWidgets.git] / src / mac / carbon / button.cpp

diff --git a/src/mac/carbon/button.cpp b/src/mac/carbon/button.cpp
index 19600ac5d797cf03fb6c383d28dc2938e21c7bba..cbc1d846d95bf5ca56a7c54f1d034813a45b3e86 100644 (file)
--- a/src/mac/carbon/button.cpp
+++ b/src/mac/carbon/button.cpp
@@ -37,9 +37,9 @@ bool wxButton::Create(wxWindow *parent, wxWindowID id, const wxString& label,
        
        MacPreControlCreate( parent , id ,  label , pos , size ,style, validator , name , &bounds , title ) ;
 
-       m_macControl = ::NewControl( parent->GetMacRootWindow() , &bounds , title , false , 0 , 0 , 1, 
+       m_macControl = ::NewControl( MAC_WXHWND(parent->MacGetRootWindow()) , &bounds , title , false , 0 , 0 , 1, 
                kControlPushButtonProc , (long) this ) ;
-       wxASSERT_MSG( m_macControl != NULL , "No valid mac control" ) ;
+       wxASSERT_MSG( (ControlHandle) m_macControl != NULL , "No valid mac control" ) ;
        
        MacPostControlCreate() ;
 
@@ -50,25 +50,24 @@ void wxButton::SetDefault()
 {
     wxWindow *parent = GetParent();
     wxButton *btnOldDefault = NULL;
-    wxPanel *panel = wxDynamicCast(parent, wxPanel);
-    if ( panel )
+    if ( parent )
     {
-        btnOldDefault = wxDynamicCast(panel->GetDefaultItem(),
+        btnOldDefault = wxDynamicCast(parent->GetDefaultItem(),
            wxButton);
-        panel->SetDefaultItem(this);
+        parent->SetDefaultItem(this);
     }
 
        Boolean inData;
        if ( btnOldDefault && btnOldDefault->m_macControl )
        {
                inData = 0;
-               ::SetControlData( btnOldDefault->m_macControl , kControlButtonPart ,
+               ::SetControlData( (ControlHandle) btnOldDefault->m_macControl , kControlButtonPart ,
                                                   kControlPushButtonDefaultTag , sizeof( Boolean ) , (char*)(&inData) ) ;
        }
-       if ( m_macControl )
+       if ( (ControlHandle) m_macControl )
        {
                inData = 1;
-               ::SetControlData( m_macControl , kControlButtonPart ,
+               ::SetControlData(  (ControlHandle) m_macControl , kControlButtonPart ,
                                                   kControlPushButtonDefaultTag , sizeof( Boolean ) , (char*)(&inData) ) ;
        }
 }
@@ -96,20 +95,23 @@ wxSize wxButton::GetDefaultSize()
 
 void wxButton::Command (wxCommandEvent & event)
 {
-       if ( m_macControl )
+       if ( (ControlHandle) m_macControl )
        {
-               HiliteControl( m_macControl , kControlButtonPart ) ;
+               HiliteControl(  (ControlHandle) m_macControl , kControlButtonPart ) ;
                unsigned long finalTicks ;
                Delay( 8 , &finalTicks ) ;
-               HiliteControl( m_macControl , 0 ) ;
+               HiliteControl(  (ControlHandle) m_macControl , 0 ) ;
        }
     ProcessCommand (event);
 }
 
-void wxButton::MacHandleControlClick( ControlHandle control , SInt16 controlpart ) 
+void wxButton::MacHandleControlClick( WXWidget control , wxInt16 controlpart ) 
 {
+  if ( controlpart != kControlNoPart )
+  {
     wxCommandEvent event(wxEVT_COMMAND_BUTTON_CLICKED, m_windowId );
     event.SetEventObject(this);
     ProcessCommand(event);
+  }
 }