[this message is for the previous commit as well]

[wxWidgets.git] / src / x11 / app.cpp

diff --git a/src/x11/app.cpp b/src/x11/app.cpp
index e40d31131d31e932322894c7a1b13ffec75c03ea..34416b4f9b6f1861d9ab7339a3c3288af5da3774 100644 (file)
--- a/src/x11/app.cpp
+++ b/src/x11/app.cpp
@@ -180,8 +180,10 @@ void wxApp::CleanUp()
 int wxEntryStart( int& argc, char *argv[] )
 {
 #ifdef __WXDEBUG__
+#if !wxUSE_NANOX
     // install the X error handler
     gs_pfnXErrorHandler = XSetErrorHandler( wxXErrorHandler );
+#endif
 #endif // __WXDEBUG__
 
     wxString displayName;
@@ -401,7 +403,7 @@ bool wxApp::Initialized()
 
 int wxApp::MainLoop()
 {
-     int rt;
+    int rt;
     m_mainLoop = new wxEventLoop;
 
     rt = m_mainLoop->Run();
@@ -447,17 +449,17 @@ static Bool expose_predicate (Display *display, XEvent *xevent, XPointer arg)
     // wxUSE_NANOX
 
 //-----------------------------------------------------------------------
-// Processes an X event.
+// Processes an X event, returning TRUE if the event was processed.
 //-----------------------------------------------------------------------
 
-void wxApp::ProcessXEvent(WXEvent* _event)
+bool wxApp::ProcessXEvent(WXEvent* _event)
 {
     XEvent* event = (XEvent*) _event;
 
     wxWindow* win = NULL;
     Window window = XEventGetWindow(event);
     Window actualWindow = window;
-    
+
     // Find the first wxWindow that corresponds to this event window
     // Because we're receiving events after a window
     // has been destroyed, assume a 1:1 match between
@@ -466,14 +468,18 @@ void wxApp::ProcessXEvent(WXEvent* _event)
 
     win = wxGetWindowFromTable(window);
     if (!win)
-           return;
+        return FALSE;
 
+#ifdef __WXDEBUG__
+    wxString windowClass = win->GetClassInfo()->GetClassName();
+#endif
+    
     switch (event->type)
     {
         case KeyPress:
         {
             if (!win->IsEnabled())
-                return;
+                return FALSE;
 
             wxKeyEvent keyEvent(wxEVT_KEY_DOWN);
             wxTranslateKeyEvent(keyEvent, win, window, event);
@@ -485,20 +491,20 @@ void wxApp::ProcessXEvent(WXEvent* _event)
             if (!win->GetEventHandler()->ProcessEvent( keyEvent ))
             {
                 keyEvent.SetEventType(wxEVT_CHAR);
-                win->GetEventHandler()->ProcessEvent( keyEvent );
+                if (!win->GetEventHandler()->ProcessEvent( keyEvent ))
+                    return FALSE;
             }
-            return;
+            return TRUE;
         }
         case KeyRelease:
         {
             if (!win->IsEnabled())
-                return;
+                return FALSE;
 
             wxKeyEvent keyEvent(wxEVT_KEY_UP);
             wxTranslateKeyEvent(keyEvent, win, window, event);
         
-            win->GetEventHandler()->ProcessEvent( keyEvent );
-            return;
+            return win->GetEventHandler()->ProcessEvent( keyEvent );
         }
         case ConfigureNotify:
         {
@@ -506,22 +512,25 @@ void wxApp::ProcessXEvent(WXEvent* _event)
             if (event->update.utype == GR_UPDATE_SIZE)
 #endif
             {
+                //wxLogDebug("ConfigureNotify: %s", windowClass.c_str());
                 wxSizeEvent sizeEvent( wxSize(XConfigureEventGetWidth(event), XConfigureEventGetHeight(event)), win->GetId() );
                 sizeEvent.SetEventObject( win );
                 
-                win->GetEventHandler()->ProcessEvent( sizeEvent );
+                return win->GetEventHandler()->ProcessEvent( sizeEvent );
             }
+            return FALSE;
+            break;
         }
 #if !wxUSE_NANOX
         case PropertyNotify:
         {
-            HandlePropertyChange(_event);
-            return;
+            //wxLogDebug("PropertyNotify: %s", windowClass.c_str());
+            return HandlePropertyChange(_event);
         }
         case ClientMessage:
         {
             if (!win->IsEnabled())
-                return;
+                return FALSE;
 
             Atom wm_delete_window = XInternAtom(wxGlobalDisplay(), "WM_DELETE_WINDOW", True);
             Atom wm_protocols = XInternAtom(wxGlobalDisplay(), "WM_PROTOCOLS", True);
@@ -531,9 +540,10 @@ void wxApp::ProcessXEvent(WXEvent* _event)
                 if ((Atom) (event->xclient.data.l[0]) == wm_delete_window)
                 {
                     win->Close(FALSE);
+                    return TRUE;
                 }
             }
-            return;
+            return FALSE;
         }
         case ResizeRequest:
         {
@@ -555,10 +565,10 @@ void wxApp::ProcessXEvent(WXEvent* _event)
                 wxSizeEvent sizeEvent(sz, win->GetId());
                 sizeEvent.SetEventObject(win);
 
-                win->GetEventHandler()->ProcessEvent( sizeEvent );
+                return win->GetEventHandler()->ProcessEvent( sizeEvent );
             }
 
-            return;
+            return FALSE;
         }
 #endif
 #if wxUSE_NANOX
@@ -567,12 +577,15 @@ void wxApp::ProcessXEvent(WXEvent* _event)
             if (win)
             {
                 win->Close(FALSE);
+                return TRUE;
             }
+            return FALSE;
             break;
         }
 #endif
         case Expose:
         {
+            //wxLogDebug("Expose: %s", windowClass.c_str());
             win->GetUpdateRegion().Union( XExposeEventGetX(event), XExposeEventGetY(event),
                                           XExposeEventGetWidth(event), XExposeEventGetHeight(event));
                                               
@@ -597,7 +610,7 @@ void wxApp::ProcessXEvent(WXEvent* _event)
 
             win->SendEraseEvents();
 
-            return;
+            return TRUE;
         }
 #if !wxUSE_NANOX
         case GraphicsExpose:
@@ -618,7 +631,7 @@ void wxApp::ProcessXEvent(WXEvent* _event)
                 win->SendEraseEvents();
             }
 
-            return;
+            return TRUE;
         }
 #endif
         case EnterNotify:
@@ -628,7 +641,7 @@ void wxApp::ProcessXEvent(WXEvent* _event)
         case MotionNotify:
         {
             if (!win->IsEnabled())
-                return;
+                return FALSE;
                 
             // Here we check if the top level window is
             // disabled, which is one aspect of modality.
@@ -636,25 +649,33 @@ void wxApp::ProcessXEvent(WXEvent* _event)
             while (tlw && !tlw->IsTopLevel())
                 tlw = tlw->GetParent();
             if (tlw && !tlw->IsEnabled())
-                return;
-            
+                return FALSE;
+                
             if (event->type == ButtonPress)
             {
                 if ((win != wxWindow::FindFocus()) && win->AcceptsFocus())
                 {
                     // This might actually be done in wxWindow::SetFocus()
-                    // and not here.
+                    // and not here. TODO.
                     g_prevFocus = wxWindow::FindFocus();
                     g_nextFocus = win;
                     
                     win->SetFocus();
+                    // return TRUE;
                 }
             }
-
+            
+#if !wxUSE_NANOX
+            if (event->type == LeaveNotify || event->type == EnterNotify)
+            {
+                // Throw out NotifyGrab and NotifyUngrab
+                if (event->xcrossing.mode != NotifyNormal)
+                    return FALSE;
+            }
+#endif
             wxMouseEvent wxevent;
             wxTranslateMouseEvent(wxevent, win, window, event);
-            win->GetEventHandler()->ProcessEvent( wxevent );
-            return;
+            return win->GetEventHandler()->ProcessEvent( wxevent );
         }
         case FocusIn:
             {
@@ -670,8 +691,9 @@ void wxApp::ProcessXEvent(WXEvent* _event)
                     focusEvent.SetWindow( g_prevFocus );
                     g_prevFocus = NULL;
                     
-                    win->GetEventHandler()->ProcessEvent(focusEvent);
+                    return win->GetEventHandler()->ProcessEvent(focusEvent);
                 }
+                return FALSE;
                 break;
             }
         case FocusOut:
@@ -687,8 +709,9 @@ void wxApp::ProcessXEvent(WXEvent* _event)
                     focusEvent.SetEventObject(win);
                     focusEvent.SetWindow( g_nextFocus );
                     g_nextFocus = NULL;
-                    win->GetEventHandler()->ProcessEvent(focusEvent);
+                    return win->GetEventHandler()->ProcessEvent(focusEvent);
                 }
+                return FALSE;
                 break;
             }
 #ifndef wxUSE_NANOX
@@ -696,6 +719,7 @@ void wxApp::ProcessXEvent(WXEvent* _event)
             {
                 // Do we want to process this (for top-level windows)?
                 // But we want to be able to veto closes, anyway
+                return FALSE;
                 break;
             }
 #endif
@@ -705,9 +729,11 @@ void wxApp::ProcessXEvent(WXEvent* _event)
             //wxString eventName = wxGetXEventName(XEvent& event);
             //wxLogDebug(wxT("Event %s not handled"), eventName.c_str());
 #endif
+            return FALSE;
             break;
         }
     }
+    return FALSE;
 }
 
 // Returns TRUE if more time is needed.
@@ -742,11 +768,12 @@ void wxApp::Dispatch()
 
 // This should be redefined in a derived class for
 // handling property change events for XAtom IPC.
-void wxApp::HandlePropertyChange(WXEvent *event)
+bool wxApp::HandlePropertyChange(WXEvent *event)
 {
     // by default do nothing special
     // TODO: what to do for X11
     // XtDispatchEvent((XEvent*) event);
+    return FALSE;
 }
 
 void wxApp::OnIdle(wxIdleEvent& event)
@@ -854,7 +881,7 @@ bool wxApp::OnInitGui()
     delete wxLog::SetActiveTarget(new wxLogStderr);
     
     if (!wxAppBase::OnInitGui())
-       return FALSE;
+    return FALSE;
     
     GetMainColormap( wxApp::GetDisplay() );
 
@@ -893,13 +920,13 @@ Window wxGetWindowParent(Window window)
 #endif
     Window* children = NULL;
 
-    // #define XQueryTree(d,w,r,p,c,nc)                GrQueryTree(w,p,c,nc)
+    // #define XQueryTree(d,w,r,p,c,nc)     GrQueryTree(w,p,c,nc)
     int res = 1;
 #if !wxUSE_NANOX
     res =
 #endif
         XQueryTree((Display*) wxGetDisplay(), window, & root, & parent,
-                        & children, & noChildren);
+             & children, & noChildren);
     if (children)
         XFree(children);
     if (res)