Fixed some warnings

[wxWidgets.git] / src / msw / ole / automtn.cpp

diff --git a/src/msw/ole/automtn.cpp b/src/msw/ole/automtn.cpp
index 364608fd6b1dbf07b5dee22e4eb1e46ea0521692..369dfec16fe5242347566fde5d1b1dce7f32d48b 100644 (file)
--- a/src/msw/ole/automtn.cpp
+++ b/src/msw/ole/automtn.cpp
@@ -56,6 +56,8 @@
 
 #if wxUSE_OLE_AUTOMATION
 
 
 #if wxUSE_OLE_AUTOMATION
 

+#include <wx/vector.h>
+

 // Report an OLE error when calling the specified method to the user via wxLog.
 static void
 ShowException(const wxString& member,
 // Report an OLE error when calling the specified method to the user via wxLog.
 static void
 ShowException(const wxString& member,


@@ -68,6 +70,7 @@ ShowException(const wxString& member,
 wxAutomationObject::wxAutomationObject(WXIDISPATCH* dispatchPtr)
 {
     m_dispatchPtr = dispatchPtr;
 wxAutomationObject::wxAutomationObject(WXIDISPATCH* dispatchPtr)
 {
     m_dispatchPtr = dispatchPtr;

+    m_lcid = LOCALE_SYSTEM_DEFAULT;

 }
 
 wxAutomationObject::~wxAutomationObject()
 }
 
 wxAutomationObject::~wxAutomationObject()


@@ -79,47 +82,59 @@ wxAutomationObject::~wxAutomationObject()
     }
 }
 
     }
 }
 

+namespace
+{
+
+// A simple helper that ensures that VARIANT is destroyed on scope exit.
+struct wxOleVariantArg : VARIANTARG
+{
+    wxOleVariantArg()  { VariantInit(this);  }
+    ~wxOleVariantArg() { VariantClear(this); }
+};
+
+} // anonymous namespace
+
+

 #define INVOKEARG(i) (args ? args[i] : *(ptrArgs[i]))
 
 // For Put/Get, no named arguments are allowed.
 #define INVOKEARG(i) (args ? args[i] : *(ptrArgs[i]))
 
 // For Put/Get, no named arguments are allowed.

+// WARNING: if args contain IDispatches, their reference count will be decreased
+// by one after Invoke() returns!

 bool wxAutomationObject::Invoke(const wxString& member, int action,
         wxVariant& retValue, int noArgs, wxVariant args[], const wxVariant* ptrArgs[]) const
 {
     if (!m_dispatchPtr)
         return false;
 
 bool wxAutomationObject::Invoke(const wxString& member, int action,
         wxVariant& retValue, int noArgs, wxVariant args[], const wxVariant* ptrArgs[]) const
 {
     if (!m_dispatchPtr)
         return false;
 

-    // nonConstMember is necessary because the wxString class doesn't have enough consts...
-    wxString nonConstMember(member);
-
-    int ch = nonConstMember.Find('.');
+    int ch = member.Find('.');

     if (ch != -1)
     {
         // Use dot notation to get the next object
     if (ch != -1)
     {
         // Use dot notation to get the next object

-        wxString member2(nonConstMember.Left((size_t) ch));
-        wxString rest(nonConstMember.Right(nonConstMember.length() - ch - 1));
+        wxString member2(member.Left((size_t) ch));
+        wxString rest(member.Right(member.length() - ch - 1));

         wxAutomationObject obj;
         if (!GetObject(obj, member2))
             return false;
         return obj.Invoke(rest, action, retValue, noArgs, args, ptrArgs);
     }
 
         wxAutomationObject obj;
         if (!GetObject(obj, member2))
             return false;
         return obj.Invoke(rest, action, retValue, noArgs, args, ptrArgs);
     }
 

-    VARIANTARG vReturn;
-    VariantInit(& vReturn);
-
-    VARIANTARG* vReturnPtr = & vReturn;
+    wxOleVariantArg vReturn;
+    wxOleVariantArg* vReturnPtr = & vReturn;

 
     // Find number of names args
     int namedArgCount = 0;
     int i;
     for (i = 0; i < noArgs; i++)
 
     // Find number of names args
     int namedArgCount = 0;
     int i;
     for (i = 0; i < noArgs; i++)

-        if (!INVOKEARG(i).GetName().IsNull())
+    {
+        if ( !INVOKEARG(i).GetName().empty() )

         {
             namedArgCount ++;
         }
         {
             namedArgCount ++;
         }

+    }

 
     int namedArgStringCount = namedArgCount + 1;
 
     int namedArgStringCount = namedArgCount + 1;

-    BSTR* argNames = new BSTR[namedArgStringCount];
-    argNames[0] = wxConvertStringToOle(member);
+    wxVector<wxBasicString> argNames(namedArgStringCount, wxString());
+    argNames[0] = member;

 
     // Note that arguments are specified in reverse order
     // (all totally logical; hey, we're dealing with OLE here.)
 
     // Note that arguments are specified in reverse order
     // (all totally logical; hey, we're dealing with OLE here.)


@@ -127,15 +142,15 @@ bool wxAutomationObject::Invoke(const wxString& member, int action,
     int j = 0;
     for (i = 0; i < namedArgCount; i++)
     {
     int j = 0;
     for (i = 0; i < namedArgCount; i++)
     {

-        if (!INVOKEARG(i).GetName().IsNull())
+        if ( !INVOKEARG(i).GetName().empty() )

         {
         {

-            argNames[(namedArgCount-j)] = wxConvertStringToOle(INVOKEARG(i).GetName());
+            argNames[(namedArgCount-j)] = INVOKEARG(i).GetName();

             j ++;
         }
     }
 
     // + 1 for the member name, + 1 again in case we're a 'put'
             j ++;
         }
     }
 
     // + 1 for the member name, + 1 again in case we're a 'put'

-    DISPID* dispIds = new DISPID[namedArgCount + 2];
+    wxVector<DISPID> dispIds(namedArgCount + 2);

 
     HRESULT hr;
     DISPPARAMS dispparams;
 
     HRESULT hr;
     DISPPARAMS dispparams;


@@ -143,13 +158,14 @@ bool wxAutomationObject::Invoke(const wxString& member, int action,
 
     // Get the IDs for the member and its arguments.  GetIDsOfNames expects the
     // member name as the first name, followed by argument names (if any).
 
     // Get the IDs for the member and its arguments.  GetIDsOfNames expects the
     // member name as the first name, followed by argument names (if any).

-    hr = ((IDispatch*)m_dispatchPtr)->GetIDsOfNames(IID_NULL, argNames,
-                                1 + namedArgCount, LOCALE_SYSTEM_DEFAULT, dispIds);
+    hr = ((IDispatch*)m_dispatchPtr)->GetIDsOfNames(IID_NULL,
+                                // We rely on the fact that wxBasicString is
+                                // just BSTR with some methods here.
+                                reinterpret_cast<BSTR *>(&argNames[0]),
+                                1 + namedArgCount, m_lcid, &dispIds[0]);

     if (FAILED(hr))
     {
         ShowException(member, hr);
     if (FAILED(hr))
     {
         ShowException(member, hr);

-        delete[] argNames;
-        delete[] dispIds;

         return false;
     }
 
         return false;
     }
 


@@ -163,41 +179,25 @@ bool wxAutomationObject::Invoke(const wxString& member, int action,
     }
 
     // Convert the wxVariants to VARIANTARGs
     }
 
     // Convert the wxVariants to VARIANTARGs

-    VARIANTARG* oleArgs = new VARIANTARG[noArgs];
+    wxVector<wxOleVariantArg> oleArgs(noArgs);

     for (i = 0; i < noArgs; i++)
     {
         // Again, reverse args
         if (!wxConvertVariantToOle(INVOKEARG((noArgs-1) - i), oleArgs[i]))
     for (i = 0; i < noArgs; i++)
     {
         // Again, reverse args
         if (!wxConvertVariantToOle(INVOKEARG((noArgs-1) - i), oleArgs[i]))

-        {
-            delete[] argNames;
-            delete[] dispIds;
-            delete[] oleArgs;

             return false;
             return false;

-        }

     }
 
     }
 

-    dispparams.rgdispidNamedArgs = dispIds + 1;
-    dispparams.rgvarg = oleArgs;
+    dispparams.rgdispidNamedArgs = &dispIds[0] + 1;
+    dispparams.rgvarg = oleArgs.empty() ? NULL : &oleArgs[0];

     dispparams.cArgs = noArgs;
     dispparams.cNamedArgs = namedArgCount;
 
     EXCEPINFO excep;
     wxZeroMemory(excep);
 
     dispparams.cArgs = noArgs;
     dispparams.cNamedArgs = namedArgCount;
 
     EXCEPINFO excep;
     wxZeroMemory(excep);
 

-    hr = ((IDispatch*)m_dispatchPtr)->Invoke(dispIds[0], IID_NULL, LOCALE_SYSTEM_DEFAULT,
+    hr = ((IDispatch*)m_dispatchPtr)->Invoke(dispIds[0], IID_NULL, m_lcid,

                         (WORD)action, &dispparams, vReturnPtr, &excep, &uiArgErr);
 
                         (WORD)action, &dispparams, vReturnPtr, &excep, &uiArgErr);
 

-    for (i = 0; i < namedArgStringCount; i++)
-    {
-        SysFreeString(argNames[i]);
-    }
-    delete[] argNames;
-    delete[] dispIds;
-
-    for (i = 0; i < noArgs; i++)
-        VariantClear(& oleArgs[i]) ;
-    delete[] oleArgs;
-

     if (FAILED(hr))
     {
         // display the exception information if appropriate:
     if (FAILED(hr))
     {
         // display the exception information if appropriate:


@@ -208,8 +208,6 @@ bool wxAutomationObject::Invoke(const wxString& member, int action,
         SysFreeString(excep.bstrDescription);
         SysFreeString(excep.bstrHelpFile);
 
         SysFreeString(excep.bstrDescription);
         SysFreeString(excep.bstrHelpFile);
 

-        if (vReturnPtr)
-            VariantClear(vReturnPtr);

         return false;
     }
     else
         return false;
     }
     else


@@ -217,13 +215,19 @@ bool wxAutomationObject::Invoke(const wxString& member, int action,
         if (vReturnPtr)
         {
             // Convert result to wxVariant form
         if (vReturnPtr)
         {
             // Convert result to wxVariant form

-            wxConvertOleToVariant(vReturn, retValue);
+            if (!wxConvertOleToVariant(vReturn, retValue))
+                return false;

             // Mustn't release the dispatch pointer
             if (vReturn.vt == VT_DISPATCH)
             {
                 vReturn.pdispVal = NULL;
             }
             // Mustn't release the dispatch pointer
             if (vReturn.vt == VT_DISPATCH)
             {
                 vReturn.pdispVal = NULL;
             }

-            VariantClear(& vReturn);
+            // Mustn't free the SAFEARRAY if it is contained in the retValue
+            if ((vReturn.vt & VT_ARRAY) &&
+                    retValue.GetType() == wxS("safearray"))
+            {
+                vReturn.parray = NULL;
+            }

         }
     }
     return true;
         }
     }
     return true;


@@ -470,6 +474,7 @@ bool wxAutomationObject::GetObject(wxAutomationObject& obj, const wxString& prop
     if (dispatch)
     {
         obj.SetDispatchPtr(dispatch);
     if (dispatch)
     {
         obj.SetDispatchPtr(dispatch);

+        obj.SetLCID(GetLCID());

         return true;
     }
     else
         return true;
     }
     else


@@ -483,6 +488,7 @@ bool wxAutomationObject::GetObject(wxAutomationObject& obj, const wxString& prop
     if (dispatch)
     {
         obj.SetDispatchPtr(dispatch);
     if (dispatch)
     {
         obj.SetDispatchPtr(dispatch);

+        obj.SetLCID(GetLCID());

         return true;
     }
     else
         return true;
     }
     else


@@ -548,8 +554,15 @@ bool wxAutomationObject::GetInstance(const wxString& progId, int flags) const
         }
         else
         {
         }
         else
         {

-            wxLogSysError(hr,
-                          _("Cannot get an active instance of \"%s\""), progId);
+            // Log an error except if we're supposed to fail silently when the
+            // error is that no current instance exists.
+            if ( hr != MK_E_UNAVAILABLE ||
+                    !(flags & wxAutomationInstance_SilentIfNone) )
+            {
+                wxLogSysError(hr,
+                              _("Cannot get an active instance of \"%s\""),
+                              progId);
+            }

         }
 
         return false;
         }
 
         return false;


@@ -585,6 +598,16 @@ bool wxAutomationObject::CreateInstance(const wxString& progId) const
     return m_dispatchPtr != NULL;
 }
 
     return m_dispatchPtr != NULL;
 }
 

+LCID wxAutomationObject::GetLCID() const
+{
+    return m_lcid;
+}
+
+void wxAutomationObject::SetLCID(LCID lcid)
+{
+    m_lcid = lcid;
+}
+

 static void
 ShowException(const wxString& member,
               HRESULT hr,
 static void
 ShowException(const wxString& member,
               HRESULT hr,