if ( !m_hWnd )
{
- wxLogDebug(wxT("Failed to create a control of class '%s'"), classname);
- wxFAIL_MSG(_T("something is very wrong, CreateWindowEx failed"));
+#ifdef __WXDEBUG__
+ wxFAIL_MSG(wxString::Format
+ (
+ _T("CreateWindowEx(\"%s\", flags=%08x, ex=%08x) failed"),
+ classname, (unsigned int)style, (unsigned int)exstyle
+ ));
+#endif // __WXDEBUG__
return false;
}
-#if wxUSE_CTL3D
- if ( want3D )
- {
- Ctl3dSubclassCtl(GetHwnd());
- m_useCtl3D = true;
- }
-#endif // wxUSE_CTL3D
-
// install wxWidgets window proc for this window
SubclassWin(m_hWnd);
// In wxMSW it was only wxSpinCtrl derived from wxSpinButton but in
// WinCE of Smartphones this happens also for native wxTextCtrl,
// wxChoice and others.
-wxSize wxControl::GetBestSpinerSize(const bool is_vertical) const
+wxSize wxControl::GetBestSpinnerSize(const bool is_vertical) const
{
// take size according to layout
wxSize bestSize(
#if defined(__SMARTPHONE__) && defined(__WXWINCE__)
0,GetCharHeight()
#else
- GetSystemMetrics(is_vertical ? SM_CXVSCROLL : SM_CXHSCROLL),
- GetSystemMetrics(is_vertical ? SM_CYVSCROLL : SM_CYHSCROLL)
+ ::GetSystemMetrics(is_vertical ? SM_CXVSCROLL : SM_CXHSCROLL),
+ ::GetSystemMetrics(is_vertical ? SM_CYVSCROLL : SM_CYHSCROLL)
#endif
);
}
#endif // Win95
-WXHBRUSH wxControl::MSWControlColorSolid(WXHDC pDC, wxColour colBg)
+WXHBRUSH wxControl::DoMSWControlColor(WXHDC pDC, wxColour colBg)
{
HDC hdc = (HDC)pDC;
if ( m_hasFgCol )
{
::SetTextColor(hdc, wxColourToRGB(GetForegroundColour()));
- if ( !colBg.Ok() )
- colBg = GetBackgroundColour();
}
+ // use the background colour override if a valid colour is given
+ WXHBRUSH hbr;
if ( colBg.Ok() )
{
::SetBkColor(hdc, wxColourToRGB(colBg));
+ // draw children with the same colour as the parent
wxBrush *brush = wxTheBrushList->FindOrCreateBrush(colBg, wxSOLID);
- return (WXHBRUSH)brush->GetResourceHandle();
+ hbr = (WXHBRUSH)brush->GetResourceHandle();
+ }
+ else // use our own background colour and recurse upwards if necessary
+ {
+ hbr = MSWGetBgBrush(pDC);
}
- return 0;
+ return hbr;
}
WXHBRUSH wxControl::MSWControlColor(WXHDC pDC)
{
- WXHBRUSH hbr = MSWControlColorSolid(pDC, m_hasBgCol ? m_backgroundColour
- : wxNullColour);
- if ( hbr )
- return hbr;
-
+ // by default consider that the controls text shouldn't erase the
+ // background under it (this is true for all static controls, check boxes,
+ // radio buttons, ...
::SetBkMode((HDC)pDC, TRANSPARENT);
- hbr = MSWGetBgBrush(pDC);
-
- return hbr ? hbr : MSWGetDefaultBgBrush();
+ return DoMSWControlColor(pDC, wxNullColour);
}
WXHBRUSH wxControl::MSWControlColorDisabled(WXHDC pDC)
{
- return MSWControlColorSolid
- (
- pDC,
- wxSystemSettings::GetColour(wxSYS_COLOUR_BTNFACE)
- );
+ return DoMSWControlColor(pDC,
+ wxSystemSettings::GetColour(wxSYS_COLOUR_BTNFACE));
}
// ---------------------------------------------------------------------------