Need to use the same instance handles

[wxWidgets.git] / src / msw / dragimag.cpp

diff --git a/src/msw/dragimag.cpp b/src/msw/dragimag.cpp
index acffef371a5117d4714c776e494198ba9aa099e8..0789752ef0613378373fcdb9bcaaa6897cfe7dd2 100644 (file)
--- a/src/msw/dragimag.cpp
+++ b/src/msw/dragimag.cpp
@@ -17,18 +17,19 @@
 // headers
 // ----------------------------------------------------------------------------
 
 // headers
 // ----------------------------------------------------------------------------
 

-#ifdef __GNUG__
+#if defined(__GNUG__) && !defined(NO_GCC_PRAGMA)

 #pragma implementation "dragimag.h"
 #endif
 
 // For compilers that support precompilation, includes "wx.h".
 #include "wx/wxprec.h"
 #pragma implementation "dragimag.h"
 #endif
 
 // For compilers that support precompilation, includes "wx.h".
 #include "wx/wxprec.h"

-#include "wx/msw/private.h"

 
 #ifdef __BORLANDC__
 #pragma hdrstop
 #endif
 
 
 #ifdef __BORLANDC__
 #pragma hdrstop
 #endif
 

+#if wxUSE_DRAGIMAGE
+

 #if defined(__WIN95__)
 
 #ifndef WX_PRECOMP
 #if defined(__WIN95__)
 
 #ifndef WX_PRECOMP


@@ -41,6 +42,7 @@
 #include "wx/settings.h"
 #endif
 
 #include "wx/settings.h"
 #endif
 

+#include "wx/msw/private.h"

 #include "wx/log.h"
 #include "wx/intl.h"
 #include "wx/frame.h"
 #include "wx/log.h"
 #include "wx/intl.h"
 #include "wx/frame.h"


@@ -49,10 +51,20 @@
 #include "wx/msw/dragimag.h"
 #include "wx/msw/private.h"
 
 #include "wx/msw/dragimag.h"
 #include "wx/msw/private.h"
 

-#if defined(__WIN95__) && !(defined(__GNUWIN32_OLD__) || defined(__TWIN32__))
+#ifdef __WXWINCE__  // for SM_CXCURSOR and SM_CYCURSOR
+#include "wx/msw/wince/missing.h"
+#endif // __WXWINCE__
+
+#if defined(__WIN95__) && !(defined(__GNUWIN32_OLD__) && !defined(__CYGWIN10__))

 #include <commctrl.h>
 #endif
 
 #include <commctrl.h>
 #endif
 

+// Wine doesn't have this yet
+#ifndef ListView_CreateDragImage
+#define ListView_CreateDragImage(hwnd, i, lpptUpLeft) \
+    (HIMAGELIST)SNDMSG((hwnd), LVM_CREATEDRAGIMAGE, (WPARAM)(int)(i), (LPARAM)(LPPOINT)(lpptUpLeft))
+#endif
+

 // ----------------------------------------------------------------------------
 // macros
 // ----------------------------------------------------------------------------
 // ----------------------------------------------------------------------------
 // macros
 // ----------------------------------------------------------------------------


@@ -102,13 +114,16 @@ void wxDragImage::Init()
 ////////////////////////////////////////////////////////////////////////////
 
 // Create a drag image from a bitmap and optional cursor
 ////////////////////////////////////////////////////////////////////////////
 
 // Create a drag image from a bitmap and optional cursor

-bool wxDragImage::Create(const wxBitmap& image, const wxCursor& cursor, const wxPoint& cursorHotspot)
+bool wxDragImage::Create(const wxBitmap& image, const wxCursor& cursor)

 {
     if ( m_hImageList )
         ImageList_Destroy(GetHimageList());
     m_hImageList = 0;
 
     UINT flags = 0 ;
 {
     if ( m_hImageList )
         ImageList_Destroy(GetHimageList());
     m_hImageList = 0;
 
     UINT flags = 0 ;

+#ifdef __WXWINCE__
+    flags = ILC_COLOR;
+#else

     if (image.GetDepth() <= 4)
         flags = ILC_COLOR4;
     else if (image.GetDepth() <= 8)
     if (image.GetDepth() <= 4)
         flags = ILC_COLOR4;
     else if (image.GetDepth() <= 8)


@@ -119,10 +134,15 @@ bool wxDragImage::Create(const wxBitmap& image, const wxCursor& cursor, const wx
         flags = ILC_COLOR24;
     else
         flags = ILC_COLOR32;
         flags = ILC_COLOR24;
     else
         flags = ILC_COLOR32;

+#endif

 
     bool mask = (image.GetMask() != 0);
 
     bool mask = (image.GetMask() != 0);

-    if ( mask )
-        flags |= ILC_MASK;
+
+    // Curiously, even if the image doesn't have a mask,
+    // we still have to use ILC_MASK or the image won't show
+    // up when dragged.
+//    if ( mask )
+    flags |= ILC_MASK;

 
     m_hImageList = (WXHIMAGELIST) ImageList_Create(image.GetWidth(), image.GetHeight(), flags, 1, 1);
 
 
     m_hImageList = (WXHIMAGELIST) ImageList_Create(image.GetWidth(), image.GetHeight(), flags, 1, 1);
 


@@ -146,19 +166,21 @@ bool wxDragImage::Create(const wxBitmap& image, const wxCursor& cursor, const wx
         wxLogError(_("Couldn't add an image to the image list."));
     }
     m_cursor = cursor; // Can only combine with drag image after calling BeginDrag.
         wxLogError(_("Couldn't add an image to the image list."));
     }
     m_cursor = cursor; // Can only combine with drag image after calling BeginDrag.

-    m_cursorHotspot = cursorHotspot;

 
     return (index != -1) ;
 }
 
 // Create a drag image from an icon and optional cursor
 
     return (index != -1) ;
 }
 
 // Create a drag image from an icon and optional cursor

-bool wxDragImage::Create(const wxIcon& image, const wxCursor& cursor, const wxPoint& cursorHotspot)
+bool wxDragImage::Create(const wxIcon& image, const wxCursor& cursor)

 {
     if ( m_hImageList )
         ImageList_Destroy(GetHimageList());
     m_hImageList = 0;
 
     UINT flags = 0 ;
 {
     if ( m_hImageList )
         ImageList_Destroy(GetHimageList());
     m_hImageList = 0;
 
     UINT flags = 0 ;

+#ifdef __WXWINCE__
+    flags = ILC_COLOR;
+#else

     if (image.GetDepth() <= 4)
         flags = ILC_COLOR4;
     else if (image.GetDepth() <= 8)
     if (image.GetDepth() <= 4)
         flags = ILC_COLOR4;
     else if (image.GetDepth() <= 8)


@@ -169,6 +191,7 @@ bool wxDragImage::Create(const wxIcon& image, const wxCursor& cursor, const wxPo
         flags = ILC_COLOR24;
     else
         flags = ILC_COLOR32;
         flags = ILC_COLOR24;
     else
         flags = ILC_COLOR32;

+#endif

     bool mask = TRUE;
     if ( mask )
         flags |= ILC_MASK;
     bool mask = TRUE;
     if ( mask )
         flags |= ILC_MASK;


@@ -184,15 +207,14 @@ bool wxDragImage::Create(const wxIcon& image, const wxCursor& cursor, const wxPo
     }
 
     m_cursor = cursor; // Can only combine with drag image after calling BeginDrag.
     }
 
     m_cursor = cursor; // Can only combine with drag image after calling BeginDrag.

-    m_cursorHotspot = cursorHotspot;

 
     return (index != -1) ;
 }
 
 // Create a drag image from a string and optional cursor
 
     return (index != -1) ;
 }
 
 // Create a drag image from a string and optional cursor

-bool wxDragImage::Create(const wxString& str, const wxCursor& cursor, const wxPoint& cursorHotspot)
+bool wxDragImage::Create(const wxString& str, const wxCursor& cursor)

 {
 {

-    wxFont font(wxSystemSettings::GetSystemFont(wxSYS_DEFAULT_GUI_FONT));
+    wxFont font(wxSystemSettings::GetFont(wxSYS_DEFAULT_GUI_FONT));

 
     long w, h;
     wxScreenDC dc;
 
     long w, h;
     wxScreenDC dc;


@@ -222,22 +244,24 @@ bool wxDragImage::Create(const wxString& str, const wxCursor& cursor, const wxPo
     dc2.SelectObject(wxNullBitmap);
 
     // Make the bitmap masked
     dc2.SelectObject(wxNullBitmap);
 
     // Make the bitmap masked

-    wxImage image(bitmap);
+    wxImage image = bitmap.ConvertToImage();

     image.SetMaskColour(255, 255, 255);
     image.SetMaskColour(255, 255, 255);

-    bitmap = image.ConvertToBitmap();
-
-    return Create(bitmap, cursor, cursorHotspot);
+    return Create(wxBitmap(image), cursor);

 }
 
 }
 

+#if wxUSE_TREECTRL

 // Create a drag image for the given tree control item
 bool wxDragImage::Create(const wxTreeCtrl& treeCtrl, wxTreeItemId& id)
 {
     if ( m_hImageList )
         ImageList_Destroy(GetHimageList());
 // Create a drag image for the given tree control item
 bool wxDragImage::Create(const wxTreeCtrl& treeCtrl, wxTreeItemId& id)
 {
     if ( m_hImageList )
         ImageList_Destroy(GetHimageList());

-    m_hImageList = (WXHIMAGELIST) TreeView_CreateDragImage((HWND) treeCtrl.GetHWND(), (HTREEITEM) (WXHTREEITEM) id);
-    return TRUE;
+    m_hImageList = (WXHIMAGELIST)
+        TreeView_CreateDragImage(GetHwndOf(&treeCtrl), (HTREEITEM) id.m_pItem);
+    return m_hImageList != 0;

 }
 }

+#endif

 
 

+#if wxUSE_LISTCTRL

 // Create a drag image for the given list control item
 bool wxDragImage::Create(const wxListCtrl& listCtrl, long id)
 {
 // Create a drag image for the given list control item
 bool wxDragImage::Create(const wxListCtrl& listCtrl, long id)
 {


@@ -248,6 +272,7 @@ bool wxDragImage::Create(const wxListCtrl& listCtrl, long id)
     m_hImageList = (WXHIMAGELIST) ListView_CreateDragImage((HWND) listCtrl.GetHWND(), id, & pt);
     return TRUE;
 }
     m_hImageList = (WXHIMAGELIST) ListView_CreateDragImage((HWND) listCtrl.GetHWND(), id, & pt);
     return TRUE;
 }

+#endif

 
 // Begin drag
 bool wxDragImage::BeginDrag(const wxPoint& hotspot, wxWindow* window, bool fullScreen, wxRect* rect)
 
 // Begin drag
 bool wxDragImage::BeginDrag(const wxPoint& hotspot, wxWindow* window, bool fullScreen, wxRect* rect)


@@ -282,6 +307,24 @@ bool wxDragImage::BeginDrag(const wxPoint& hotspot, wxWindow* window, bool fullS
             m_hCursorImageList = (WXHIMAGELIST) ImageList_Create(cxCursor, cyCursor, ILC_MASK, 1, 1);
         }
 
             m_hCursorImageList = (WXHIMAGELIST) ImageList_Create(cxCursor, cyCursor, ILC_MASK, 1, 1);
         }
 

+        // See if we can find the cursor hotspot
+        wxPoint curHotSpot(hotspot);
+
+        // Although it seems to produce the right position, when the hotspot goeos
+        // negative it has strange effects on the image.
+        // How do we stop the cursor jumping right and below of where it should be?
+#if 0
+        ICONINFO iconInfo;
+        if (::GetIconInfo((HICON) (HCURSOR) m_cursor.GetHCURSOR(), & iconInfo) != 0)
+        {
+            curHotSpot.x -= iconInfo.xHotspot;
+            curHotSpot.y -= iconInfo.yHotspot;
+        }
+#endif
+        //wxString msg;
+        //msg.Printf("Hotspot = %d, %d", curHotSpot.x, curHotSpot.y);
+        //wxLogDebug(msg);
+

         // First add the cursor to the image list
         HCURSOR hCursor = (HCURSOR) m_cursor.GetHCURSOR();
         int cursorIndex = ImageList_AddIcon((HIMAGELIST) m_hCursorImageList, (HICON) hCursor);
         // First add the cursor to the image list
         HCURSOR hCursor = (HCURSOR) m_cursor.GetHCURSOR();
         int cursorIndex = ImageList_AddIcon((HIMAGELIST) m_hCursorImageList, (HICON) hCursor);


@@ -290,18 +333,18 @@ bool wxDragImage::BeginDrag(const wxPoint& hotspot, wxWindow* window, bool fullS
 
         if (cursorIndex != -1)
         {
 
         if (cursorIndex != -1)
         {

-            ImageList_SetDragCursorImage((HIMAGELIST) m_hCursorImageList, cursorIndex, m_cursorHotspot.x, m_cursorHotspot.y);
+            ImageList_SetDragCursorImage((HIMAGELIST) m_hCursorImageList, cursorIndex, curHotSpot.x, curHotSpot.y);

         }
 #endif
     }
 
         }
 #endif
     }
 

-    m_window = window;
-

 #if !wxUSE_SIMPLER_DRAGIMAGE
     if (m_cursor.Ok())
         ::ShowCursor(FALSE);
 #endif
 
 #if !wxUSE_SIMPLER_DRAGIMAGE
     if (m_cursor.Ok())
         ::ShowCursor(FALSE);
 #endif
 

+    m_window = window;
+

     ::SetCapture(GetHwndOf(window));
 
     return TRUE;
     ::SetCapture(GetHwndOf(window));
 
     return TRUE;


@@ -361,7 +404,7 @@ bool wxDragImage::Move(const wxPoint& pt)
     // These are in window, not client coordinates.
     // So need to convert to client coordinates.
     wxPoint pt2(pt);
     // These are in window, not client coordinates.
     // So need to convert to client coordinates.
     wxPoint pt2(pt);

-    if (m_window)
+    if (m_window && !m_fullScreen)

     {
         RECT rect;
         rect.left = 0; rect.top = 0;
     {
         RECT rect;
         rect.left = 0; rect.top = 0;


@@ -376,10 +419,14 @@ bool wxDragImage::Move(const wxPoint& pt)
         // Subtract the (negative) values, i.e. add a small increment
         pt2.x -= rect.left; pt2.y -= rect.top;
     }
         // Subtract the (negative) values, i.e. add a small increment
         pt2.x -= rect.left; pt2.y -= rect.top;
     }

+    else if (m_window && m_fullScreen)
+    {
+        pt2 = m_window->ClientToScreen(pt2);
+    }

 
     bool ret = (ImageList_DragMove( pt2.x, pt2.y ) != 0);
 
 
     bool ret = (ImageList_DragMove( pt2.x, pt2.y ) != 0);
 

-    m_position = pt;
+    m_position = pt2;

 
     return ret;
 }
 
     return ret;
 }


@@ -413,3 +460,4 @@ bool wxDragImage::Hide()
 #endif
     // __WIN95__
 
 #endif
     // __WIN95__
 

+#endif // wxUSE_DRAGIMAGE