Fix for GetValue

[wxWidgets.git] / src / common / filename.cpp

diff --git a/src/common/filename.cpp b/src/common/filename.cpp
index e99778308bbb6a3e2cd30a92508efad740b79629..05a84579cf2537cb86b2beca262dc09749ad36e8 100644 (file)
--- a/src/common/filename.cpp
+++ b/src/common/filename.cpp
@@ -146,7 +146,7 @@ public:
         m_hFile = ::CreateFile
                     (
                      filename,                      // name
         m_hFile = ::CreateFile
                     (
                      filename,                      // name

-                     mode == Read ? GENERIC_READ    // access mask 
+                     mode == Read ? GENERIC_READ    // access mask

                                   : GENERIC_WRITE,
                      0,                             // no sharing
                      NULL,                          // no secutity attr
                                   : GENERIC_WRITE,
                      0,                             // no sharing
                      NULL,                          // no secutity attr


@@ -415,7 +415,7 @@ void wxFileName::Assign(const wxString& fullpathOrig,
                   _T("the path shouldn't contain file name nor extension") );
 
 #else // !__WXDEBUG__
                   _T("the path shouldn't contain file name nor extension") );
 
 #else // !__WXDEBUG__

-    SplitPath(fullname, NULL /* no path */, &name, &ext, format); 
+    SplitPath(fullname, NULL /* no path */, &name, &ext, format);

     SplitPath(fullpath, &volume, &path, NULL, NULL, format);
 #endif // __WXDEBUG__/!__WXDEBUG__
 
     SplitPath(fullpath, &volume, &path, NULL, NULL, format);
 #endif // __WXDEBUG__/!__WXDEBUG__
 


@@ -751,10 +751,10 @@ bool wxFileName::Mkdir( const wxString& dir, int perm, int flags )
         filename.AssignDir(dir);
 
         wxString currPath;
         filename.AssignDir(dir);
 
         wxString currPath;

-        if ( filename.HasVolume())  
-        { 
+        if ( filename.HasVolume())
+        {

             currPath << wxGetVolumeString(filename.GetVolume(), wxPATH_NATIVE);
             currPath << wxGetVolumeString(filename.GetVolume(), wxPATH_NATIVE);

-        } 
+        }

 
         wxArrayString dirs = filename.GetDirs();
         size_t count = dirs.GetCount();
 
         wxArrayString dirs = filename.GetDirs();
         size_t count = dirs.GetCount();


@@ -912,6 +912,11 @@ bool wxFileName::Normalize(int flags,
         m_ext.MakeLower();
     }
 
         m_ext.MakeLower();
     }
 

+    // we do have the path now
+    //
+    // NB: need to do this before (maybe) calling Assign() below
+    m_relative = FALSE;
+

 #if defined(__WIN32__)
     if ( (flags & wxPATH_NORM_LONG) && (format == wxPATH_DOS) )
     {
 #if defined(__WIN32__)
     if ( (flags & wxPATH_NORM_LONG) && (format == wxPATH_DOS) )
     {


@@ -919,9 +924,6 @@ bool wxFileName::Normalize(int flags,
     }
 #endif // Win32
 
     }
 #endif // Win32
 

-    // we do have the path now
-    m_relative = FALSE;
-

     return TRUE;
 }
 
     return TRUE;
 }
 


@@ -991,7 +993,7 @@ bool wxFileName::MakeRelativeTo(const wxString& pathBase, wxPathFormat format)
         if ( m_dirs.IsEmpty() && IsDir() )
         {
             m_dirs.Add(_T('.'));
         if ( m_dirs.IsEmpty() && IsDir() )
         {
             m_dirs.Add(_T('.'));

-        }   
+        }

     }
 
     m_relative = TRUE;
     }
 
     m_relative = TRUE;


@@ -1144,113 +1146,40 @@ wxString wxFileName::GetPath( int flags, wxPathFormat format ) const
     }
 
     // the leading character
     }
 
     // the leading character

-    if ( format == wxPATH_MAC )
-    {
-        if ( m_relative )
-            fullpath += wxFILE_SEP_PATH_MAC;
-    }
-    else if ( format == wxPATH_DOS )
-    {
-        if (!m_relative)
-            fullpath += wxFILE_SEP_PATH_DOS;
-    }
-    else if ( format == wxPATH_UNIX )
+    switch ( format )

     {
     {

-        if (!m_relative)
-            fullpath += wxFILE_SEP_PATH_UNIX;
-    }
+        case wxPATH_MAC:
+            if ( m_relative )
+                fullpath += wxFILE_SEP_PATH_MAC;
+            break;

 
 

-    // then concatenate all the path components using the path separator
-    size_t dirCount = m_dirs.GetCount();
-    if ( dirCount )
-    {
-        if ( format == wxPATH_VMS )
-        {
-            fullpath += wxT('[');
-        }
+        case wxPATH_DOS:
+            if (!m_relative)
+                fullpath += wxFILE_SEP_PATH_DOS;
+            break;

 
 

-        for ( size_t i = 0; i < dirCount; i++ )
-        {
-            // TODO: What to do with ".." under VMS
+        default:
+            wxFAIL_MSG( _T("unknown path format") );
+            // fall through

 
 

-            switch (format)
+        case wxPATH_UNIX:
+            if ( !m_relative )

             {
             {

-                case wxPATH_MAC:
+                // normally the absolute file names starts with a slash with
+                // one exception: file names like "~/foo.bar" don't have it
+                if ( m_dirs.IsEmpty() || m_dirs[0u] != _T('~') )

                 {
                 {

-                    if (m_dirs[i] == wxT("."))
-                        break;
-                    if (m_dirs[i] != wxT(".."))  // convert back from ".." to nothing
-                         fullpath += m_dirs[i];
-                    fullpath += wxT(':');
-                    break;
-                }
-                case wxPATH_DOS:
-                {
-                    fullpath += m_dirs[i];
-                    fullpath += wxT('\\');
-                    break;
-                }
-                case wxPATH_UNIX:
-                {
-                    fullpath += m_dirs[i];
-                    fullpath += wxT('/');
-                    break;
-                }
-                case wxPATH_VMS:
-                {
-                    if (m_dirs[i] != wxT(".."))  // convert back from ".." to nothing
-                        fullpath += m_dirs[i];
-                    if (i == dirCount-1)
-                        fullpath += wxT(']');
-                    else
-                        fullpath += wxT('.');
-                    break;
-                }
-                default:
-                {
-                    wxFAIL_MSG( wxT("error") );
+                    fullpath += wxFILE_SEP_PATH_UNIX;

                 }
             }
                 }
             }

-        }
-    }
-
-    if ( (flags & wxPATH_GET_SEPARATOR) && !fullpath.empty() )
-    {
-        fullpath += GetPathSeparator(format);
-    }
-
-    return fullpath;
-}
-
-wxString wxFileName::GetFullPath( wxPathFormat format ) const
-{
-    format = GetFormat(format);
-
-    // first put the volume
-    wxString fullpath = wxGetVolumeString(m_volume, format);
+            break;

 
 

-    // the leading character
-    if ( format == wxPATH_MAC )
-    {
-        if ( m_relative )
-            fullpath += wxFILE_SEP_PATH_MAC;
-    }
-    else if ( format == wxPATH_DOS )
-    {
-        if ( !m_relative )
-            fullpath += wxFILE_SEP_PATH_DOS;
-    }
-    else if ( format == wxPATH_UNIX )
-    {
-        if ( !m_relative )
-        {
-            // normally the absolute file names starts with a slash with one
-            // exception: file names like "~/foo.bar" don't have it
-            if ( m_dirs.IsEmpty() || m_dirs[0u] != _T('~') )
-            {
-                fullpath += wxFILE_SEP_PATH_UNIX;
-            }
-        }
+        case wxPATH_VMS:
+            // no leading character here but use this place to unset
+            // wxPATH_GET_SEPARATOR flag: under VMS it doesn't make sense as,
+            // if I understand correctly, there should never be a dot before
+            // the closing bracket
+            flags &= ~wxPATH_GET_SEPARATOR;

     }
 
     // then concatenate all the path components using the path separator
     }
 
     // then concatenate all the path components using the path separator


@@ -1262,53 +1191,61 @@ wxString wxFileName::GetFullPath( wxPathFormat format ) const
             fullpath += wxT('[');
         }
 
             fullpath += wxT('[');
         }
 

-

         for ( size_t i = 0; i < dirCount; i++ )
         {
         for ( size_t i = 0; i < dirCount; i++ )
         {

-            // TODO: What to do with ".." under VMS
-

             switch (format)
             {
                 case wxPATH_MAC:
             switch (format)
             {
                 case wxPATH_MAC:

-                {
-                    if (m_dirs[i] == wxT("."))
-                        break;
-                    if (m_dirs[i] != wxT(".."))  // convert back from ".." to nothing
+                    if ( m_dirs[i] == wxT(".") )
+                    {
+                        // skip appending ':', this shouldn't be done in this
+                        // case as "::" is interpreted as ".." under Unix
+                        continue;
+                    }
+
+                    // convert back from ".." to nothing
+                    if ( m_dirs[i] != wxT("..") )

                          fullpath += m_dirs[i];
                          fullpath += m_dirs[i];

-                    fullpath += wxT(':');

                     break;
                     break;

-                }
+
+                default:
+                    wxFAIL_MSG( wxT("unexpected path format") );
+                    // still fall through
+

                 case wxPATH_DOS:
                 case wxPATH_DOS:

-                {
-                    fullpath += m_dirs[i];
-                    fullpath += wxT('\\');
-                    break;
-                }

                 case wxPATH_UNIX:
                 case wxPATH_UNIX:

-                {

                     fullpath += m_dirs[i];
                     fullpath += m_dirs[i];

-                    fullpath += wxT('/');

                     break;
                     break;

-                }
+

                 case wxPATH_VMS:
                 case wxPATH_VMS:

-                {
-                    if (m_dirs[i] != wxT(".."))  // convert back from ".." to nothing
+                    // TODO: What to do with ".." under VMS
+
+                    // convert back from ".." to nothing
+                    if ( m_dirs[i] != wxT("..") )

                         fullpath += m_dirs[i];
                         fullpath += m_dirs[i];

-                    if (i == dirCount-1)
-                        fullpath += wxT(']');
-                    else
-                        fullpath += wxT('.');

                     break;
                     break;

-                }
-                default:
-                {
-                    wxFAIL_MSG( wxT("error") );
-                }

             }
             }

+
+            if ( (flags & wxPATH_GET_SEPARATOR) || (i != dirCount - 1) )
+                fullpath += GetPathSeparator(format);
+        }
+
+        if ( format == wxPATH_VMS )
+        {
+            fullpath += wxT(']');

         }
     }
 
         }
     }
 

-    // finally add the file name and extension
+    return fullpath;
+}
+
+wxString wxFileName::GetFullPath( wxPathFormat format ) const
+{
+    // we already have a function to get the path
+    wxString fullpath = GetPath(wxPATH_GET_VOLUME | wxPATH_GET_SEPARATOR,
+                                format);
+
+    // now just add the file name and extension to it

     fullpath += GetFullName();
 
     return fullpath;
     fullpath += GetFullName();
 
     return fullpath;


@@ -1351,12 +1288,15 @@ wxString wxFileName::GetLongPath() const
     bool success = FALSE;
 
 #if wxUSE_DYNAMIC_LOADER
     bool success = FALSE;
 
 #if wxUSE_DYNAMIC_LOADER

-    typedef DWORD (*GET_LONG_PATH_NAME)(const wxChar *, wxChar *, DWORD);
+    typedef DWORD (WINAPI *GET_LONG_PATH_NAME)(const wxChar *, wxChar *, DWORD);

 
     static bool s_triedToLoad = FALSE;
 
     if ( !s_triedToLoad )
     {
 
     static bool s_triedToLoad = FALSE;
 
     if ( !s_triedToLoad )
     {

+        // suppress the errors about missing GetLongPathName[AW]
+        wxLogNull noLog;
+

         s_triedToLoad = TRUE;
         wxDynamicLibrary dllKernel(_T("kernel32"));
         if ( dllKernel.IsLoaded() )
         s_triedToLoad = TRUE;
         wxDynamicLibrary dllKernel(_T("kernel32"));
         if ( dllKernel.IsLoaded() )


@@ -1394,6 +1334,7 @@ wxString wxFileName::GetLongPath() const
             }
         }
     }
             }
         }
     }

+

     if (success)
         return pathOut;
 #endif // wxUSE_DYNAMIC_LOADER
     if (success)
         return pathOut;
 #endif // wxUSE_DYNAMIC_LOADER


@@ -1737,16 +1678,16 @@ bool wxFileName::GetTimes(wxDateTime *dtAccess,
         FILETIME ftAccess, ftCreate, ftWrite;
 
         if ( ::GetFileTime(fh,
         FILETIME ftAccess, ftCreate, ftWrite;
 
         if ( ::GetFileTime(fh,

-                           dtMod ? &ftCreate : NULL,
+                           dtCreate ? &ftCreate : NULL,

                            dtAccess ? &ftAccess : NULL,
                            dtAccess ? &ftAccess : NULL,

-                           dtCreate ? &ftWrite : NULL) )
+                           dtMod ? &ftWrite : NULL) )

         {
         {

-            if ( dtMod )
-                ConvertFileTimeToWx(dtMod, ftCreate);
+            if ( dtCreate )
+                ConvertFileTimeToWx(dtCreate, ftCreate);

             if ( dtAccess )
                 ConvertFileTimeToWx(dtAccess, ftAccess);
             if ( dtAccess )
                 ConvertFileTimeToWx(dtAccess, ftAccess);

-            if ( dtCreate )
-                ConvertFileTimeToWx(dtCreate, ftWrite);
+            if ( dtMod )
+                ConvertFileTimeToWx(dtMod, ftWrite);

 
             return TRUE;
         }
 
             return TRUE;
         }


@@ -1763,41 +1704,64 @@ bool wxFileName::GetTimes(wxDateTime *dtAccess,
 #ifdef __WXMAC__
 
 const short kMacExtensionMaxLength = 16 ;
 #ifdef __WXMAC__
 
 const short kMacExtensionMaxLength = 16 ;

-typedef struct
+class MacDefaultExtensionRecord

 {
 {

+public :
+  MacDefaultExtensionRecord()
+  {
+    m_ext[0] = 0 ;
+    m_type = m_creator = NULL ;
+  }
+  MacDefaultExtensionRecord( const MacDefaultExtensionRecord& from )
+  {
+    strcpy( m_ext , from.m_ext ) ;
+    m_type = from.m_type ;
+    m_creator = from.m_creator ;
+  }
+  MacDefaultExtensionRecord( char * extension , OSType type , OSType creator )
+  {
+    strncpy( m_ext , extension , kMacExtensionMaxLength ) ;
+    m_ext[kMacExtensionMaxLength] = 0 ;
+    m_type = type ;
+    m_creator = creator ;
+  }

   char m_ext[kMacExtensionMaxLength] ;
   OSType m_type ;
   OSType m_creator ;
   char m_ext[kMacExtensionMaxLength] ;
   OSType m_type ;
   OSType m_creator ;

-} MacDefaultExtensionRecord ;
+}  ;

 
 #include "wx/dynarray.h"
 WX_DECLARE_OBJARRAY(MacDefaultExtensionRecord, MacDefaultExtensionArray) ;
 
 #include "wx/dynarray.h"
 WX_DECLARE_OBJARRAY(MacDefaultExtensionRecord, MacDefaultExtensionArray) ;

+
+bool gMacDefaultExtensionsInited = false ;
+

 #include "wx/arrimpl.cpp"
 #include "wx/arrimpl.cpp"

-WX_DEFINE_OBJARRAY(MacDefaultExtensionArray) ;
+
+WX_DEFINE_EXPORTED_OBJARRAY(MacDefaultExtensionArray) ;

 
 MacDefaultExtensionArray gMacDefaultExtensions ;
 
 MacDefaultExtensionArray gMacDefaultExtensions ;

-bool gMacDefaultExtensionsInited = false ;

 
 static void MacEnsureDefaultExtensionsLoaded()
 {
   if ( !gMacDefaultExtensionsInited )
   {
 
 static void MacEnsureDefaultExtensionsLoaded()
 {
   if ( !gMacDefaultExtensionsInited )
   {

+    

     // load the default extensions
     // load the default extensions

-    MacDefaultExtensionRecord defaults[] =
+    MacDefaultExtensionRecord defaults[1] =

     {
     {

-      { "txt" , 'TEXT' , 'ttxt' } ,
-      
+      MacDefaultExtensionRecord( "txt" , 'TEXT' , 'ttxt' ) ,
+

     } ;
     // we could load the pc exchange prefs here too
     } ;
     // we could load the pc exchange prefs here too

-    
+

     for ( int i = 0 ; i < WXSIZEOF( defaults ) ; ++i )
     {
       gMacDefaultExtensions.Add( defaults[i] ) ;
     for ( int i = 0 ; i < WXSIZEOF( defaults ) ; ++i )
     {
       gMacDefaultExtensions.Add( defaults[i] ) ;

-    } 
+    }

     gMacDefaultExtensionsInited = true ;
   }
 }
     gMacDefaultExtensionsInited = true ;
   }
 }

-bool wxFileName::MacSetTypeAndCreator( wxUint32 type , wxUint32 creator ) 
+bool wxFileName::MacSetTypeAndCreator( wxUint32 type , wxUint32 creator )

 {
   FInfo fndrInfo ;
   FSSpec spec ;
 {
   FInfo fndrInfo ;
   FSSpec spec ;


@@ -1811,7 +1775,7 @@ bool wxFileName::MacSetTypeAndCreator( wxUint32 type , wxUint32 creator )
   return true ;
 }
 
   return true ;
 }
 

-bool wxFileName::MacGetTypeAndCreator( wxUint32 *type , wxUint32 *creator ) 
+bool wxFileName::MacGetTypeAndCreator( wxUint32 *type , wxUint32 *creator )

 {
   FInfo fndrInfo ;
   FSSpec spec ;
 {
   FInfo fndrInfo ;
   FSSpec spec ;


@@ -1835,7 +1799,7 @@ bool wxFileName::MacSetDefaultTypeAndCreator()
     return false;
 }
 
     return false;
 }
 

-bool wxFileName::MacFindDefaultTypeAndCreator( const wxString& ext , wxUint32 *type , wxUint32 *creator ) 
+bool wxFileName::MacFindDefaultTypeAndCreator( const wxString& ext , wxUint32 *type , wxUint32 *creator )

 {
   MacEnsureDefaultExtensionsLoaded() ;
   wxString extl = ext.Lower() ;
 {
   MacEnsureDefaultExtensionsLoaded() ;
   wxString extl = ext.Lower() ;