readability cleanup

[wxWidgets.git] / src / motif / evtloop.cpp

diff --git a/src/motif/evtloop.cpp b/src/motif/evtloop.cpp
index 217cbfa0abd6e8c0a63693c767482fee6dcdd588..205496ca057d002ec9f4bf2a2da4f7d859c227a8 100644 (file)
--- a/src/motif/evtloop.cpp
+++ b/src/motif/evtloop.cpp
@@ -1,5 +1,5 @@
 ///////////////////////////////////////////////////////////////////////////////
 ///////////////////////////////////////////////////////////////////////////////

-// Name:        motif/evtloop.cpp
+// Name:        src/motif/evtloop.cpp

 // Purpose:     implements wxEventLoop for Motif
 // Author:      Mattia Barbon
 // Modified by:
 // Purpose:     implements wxEventLoop for Motif
 // Author:      Mattia Barbon
 // Modified by:


@@ -17,10 +17,6 @@
 // headers
 // ----------------------------------------------------------------------------
 
 // headers
 // ----------------------------------------------------------------------------
 

-#ifdef __GNUG__
-    #pragma implementation "evtloop.h"
-#endif
-

 #ifdef __VMS
 #define XtParent XTPARENT
 #define XtDisplay XTDISPLAY
 #ifdef __VMS
 #define XtParent XTPARENT
 #define XtDisplay XTDISPLAY


@@ -35,6 +31,7 @@
 #include "wx/evtloop.h"
 #include "wx/event.h"
 #include "wx/app.h"
 #include "wx/evtloop.h"
 #include "wx/event.h"
 #include "wx/app.h"

+#include "wx/window.h"

 
 #ifdef __VMS__
 #pragma message disable nosimpint
 
 #ifdef __VMS__
 #pragma message disable nosimpint


@@ -45,6 +42,7 @@
 #pragma message enable nosimpint
 #endif
 
 #pragma message enable nosimpint
 #endif
 

+#include "wx/unix/private.h"

 #include "wx/motif/private.h"
 
 static bool CheckForKeyUp(XEvent* event);
 #include "wx/motif/private.h"
 
 static bool CheckForKeyUp(XEvent* event);


@@ -82,9 +80,7 @@ private:
 
 static bool SendIdleMessage()
 {
 
 static bool SendIdleMessage()
 {

-    wxIdleEvent event;
-
-    return wxTheApp->ProcessEvent(event) && event.MoreRequested();
+    return wxTheApp->ProcessIdle();

 }
 
 bool wxEventLoopImpl::SendIdleMessage()
 }
 
 bool wxEventLoopImpl::SendIdleMessage()


@@ -100,18 +96,13 @@ bool wxEventLoopImpl::SendIdleMessage()
 // wxEventLoop running and exiting
 // ----------------------------------------------------------------------------
 
 // wxEventLoop running and exiting
 // ----------------------------------------------------------------------------
 

-wxEventLoop *wxEventLoop::ms_activeLoop = NULL;
+wxEventLoop *wxEventLoopBase::ms_activeLoop = NULL;

 
 wxEventLoop::~wxEventLoop()
 {
     wxASSERT_MSG( !m_impl, _T("should have been deleted in Run()") );
 }
 
 
 wxEventLoop::~wxEventLoop()
 {
     wxASSERT_MSG( !m_impl, _T("should have been deleted in Run()") );
 }
 

-bool wxEventLoop::IsRunning() const
-{
-    return m_impl != NULL;
-}
-

 int wxEventLoop::Run()
 {
     // event loops are not recursive, you need to create another loop!
 int wxEventLoop::Run()
 {
     // event loops are not recursive, you need to create another loop!


@@ -168,11 +159,13 @@ bool wxEventLoop::Dispatch()
         ProcessXEvent( &event );
     }
     else
         ProcessXEvent( &event );
     }
     else

-#ifdef __VMS
-     XtAppProcessEvent( context, XtIMTimer|XtIMAlternateInput );
-#else
-     XtAppProcessEvent( context, XtIMTimer|XtIMAlternateInput|XtIMSignal );
+    {
+        XtAppProcessEvent( context, XtIMTimer | XtIMAlternateInput
+#ifdef XtIMSignal
+                           | XtIMSignal

 #endif
 #endif

+                         );
+    }

 
     return m_impl ? m_impl->GetKeepGoing() : true;
 }
 
     return m_impl ? m_impl->GetKeepGoing() : true;
 }


@@ -233,7 +226,7 @@ void ProcessXEvent(XEvent* event)
          * window is recieved. Prevents flicker as windows are resized.
          */
 
          * window is recieved. Prevents flicker as windows are resized.
          */
 

-        Display *disp = XtDisplay((Widget) wxTheApp->GetTopLevelWidget());
+        Display *disp = event->xany.display;

         Window win = event->xany.window;
         XEvent report;
 
         Window win = event->xany.window;
         XEvent report;
 


@@ -259,12 +252,12 @@ bool CheckForAccelerator(XEvent* event)
     {
         // Find a wxWindow for this window
         // TODO: should get display for the window, not the current display
     {
         // Find a wxWindow for this window
         // TODO: should get display for the window, not the current display

-        Widget widget = XtWindowToWidget((Display*) wxGetDisplay(),
+        Widget widget = XtWindowToWidget(event->xany.display,

                                          event->xany.window);
         wxWindow* win = NULL;
 
         // Find the first wxWindow that corresponds to this event window
                                          event->xany.window);
         wxWindow* win = NULL;
 
         // Find the first wxWindow that corresponds to this event window

-        while (widget && !(win = wxGetWindowFromTable(widget)))
+        while (widget && ((win = wxGetWindowFromTable(widget))!=NULL))

             widget = XtParent(widget);
 
         if (!widget || !win)
             widget = XtParent(widget);
 
         if (!widget || !win)


@@ -293,12 +286,12 @@ bool CheckForKeyDown(XEvent* event)
 {
     if (event->xany.type == KeyPress)
     {
 {
     if (event->xany.type == KeyPress)
     {

-        Widget widget = XtWindowToWidget((Display*) wxGetDisplay(),
-                     event->xany.window);
+        Widget widget = XtWindowToWidget(event->xany.display,
+                                         event->xany.window);

         wxWindow* win = NULL;
 
         // Find the first wxWindow that corresponds to this event window
         wxWindow* win = NULL;
 
         // Find the first wxWindow that corresponds to this event window

-        while (widget && !(win = wxGetWindowFromTable(widget)))
+        while (widget && ((win = wxGetWindowFromTable(widget))!=NULL))

             widget = XtParent(widget);
 
         if (!widget || !win)
             widget = XtParent(widget);
 
         if (!widget || !win)


@@ -307,7 +300,7 @@ bool CheckForKeyDown(XEvent* event)
         wxKeyEvent keyEvent(wxEVT_KEY_DOWN);
         wxTranslateKeyEvent(keyEvent, win, (Widget) 0, event);
 
         wxKeyEvent keyEvent(wxEVT_KEY_DOWN);
         wxTranslateKeyEvent(keyEvent, win, (Widget) 0, event);
 

-        return win->ProcessEvent( keyEvent );
+        return win->GetEventHandler()->ProcessEvent( keyEvent );

     }
 
     return false;
     }
 
     return false;


@@ -319,12 +312,12 @@ bool CheckForKeyUp(XEvent* event)
 {
     if (event->xany.type == KeyRelease)
     {
 {
     if (event->xany.type == KeyRelease)
     {

-        Widget widget = XtWindowToWidget((Display*) wxGetDisplay(),
-                         event->xany.window);
+        Widget widget = XtWindowToWidget(event->xany.display,
+                                         event->xany.window);

         wxWindow* win = NULL;
 
         // Find the first wxWindow that corresponds to this event window
         wxWindow* win = NULL;
 
         // Find the first wxWindow that corresponds to this event window

-        while (widget && !(win = wxGetWindowFromTable(widget)))
+        while (widget && ((win = wxGetWindowFromTable(widget))!=NULL))

                 widget = XtParent(widget);
 
         if (!widget || !win)
                 widget = XtParent(widget);
 
         if (!widget || !win)


@@ -333,7 +326,7 @@ bool CheckForKeyUp(XEvent* event)
         wxKeyEvent keyEvent(wxEVT_KEY_UP);
         wxTranslateKeyEvent(keyEvent, win, (Widget) 0, event);
 
         wxKeyEvent keyEvent(wxEVT_KEY_UP);
         wxTranslateKeyEvent(keyEvent, win, (Widget) 0, event);
 

-        return win->ProcessEvent( keyEvent );
+        return win->GetEventHandler()->ProcessEvent( keyEvent );

     }
 
     return false;
     }
 
     return false;


@@ -361,7 +354,7 @@ bool wxDoEventLoopIteration( wxEventLoop& evtLoop )
         // leave the main loop to give other threads a chance to
         // perform their GUI work
         wxMutexGuiLeave();
         // leave the main loop to give other threads a chance to
         // perform their GUI work
         wxMutexGuiLeave();

-        wxUsleep(20);
+        wxMilliSleep(20);

         wxMutexGuiEnter();
     }
 #endif
         wxMutexGuiEnter();
     }
 #endif


@@ -391,7 +384,6 @@ bool wxDoEventLoopIteration( wxEventLoop& evtLoop )
 #include <sys/time.h>
 #include <unistd.h>
 
 #include <sys/time.h>
 #include <unistd.h>
 

-static XtInputId inputId;

 static int idleFds[2] = { -1, -1 };
 
 class wxIdlePipeModule : public wxModule
 static int idleFds[2] = { -1, -1 };
 
 class wxIdlePipeModule : public wxModule


@@ -401,9 +393,11 @@ public:
 
     virtual bool OnInit()
     {
 
     virtual bool OnInit()
     {

+        // Must be done before modules are initialized
+#if 0

         if( pipe(idleFds) != 0 )
             return false;
         if( pipe(idleFds) != 0 )
             return false;

-
+#endif

         return true;
     }
 
         return true;
     }
 


@@ -413,10 +407,10 @@ public:
         close( idleFds[1] );
     }
 private:
         close( idleFds[1] );
     }
 private:

-    DECLARE_DYNAMIC_CLASS(wxIdlePipeModule);
+    DECLARE_DYNAMIC_CLASS(wxIdlePipeModule)

 };
 
 };
 

-IMPLEMENT_DYNAMIC_CLASS(wxIdlePipeModule, wxModule);
+IMPLEMENT_DYNAMIC_CLASS(wxIdlePipeModule, wxModule)

 
 static void wxInputCallback( XtPointer, int* fd, XtInputId* )
 {
 
 static void wxInputCallback( XtPointer, int* fd, XtInputId* )
 {


@@ -431,8 +425,8 @@ static void wxInputCallback( XtPointer, int* fd, XtInputId* )
         timeout.tv_sec = 0;
         timeout.tv_usec = 0;
 
         timeout.tv_sec = 0;
         timeout.tv_usec = 0;
 

-        FD_ZERO( &in );
-        FD_SET( *fd, &in );
+        wxFD_ZERO( &in );
+        wxFD_SET( *fd, &in );

 
         if( select( *fd + 1, &in, NULL, NULL, &timeout ) <= 0 )
             break;
 
         if( select( *fd + 1, &in, NULL, NULL, &timeout ) <= 0 )
             break;


@@ -443,7 +437,7 @@ static void wxInputCallback( XtPointer, int* fd, XtInputId* )
 
 static void wxBreakDispatch()
 {
 
 static void wxBreakDispatch()
 {

-    char dummy;
+    char dummy = 0; // for valgrind

 
     // check if wxWakeUpIdle has already been called
     fd_set in;
 
     // check if wxWakeUpIdle has already been called
     fd_set in;


@@ -452,8 +446,8 @@ static void wxBreakDispatch()
     timeout.tv_sec = 0;
     timeout.tv_usec = 0;
 
     timeout.tv_sec = 0;
     timeout.tv_usec = 0;
 

-    FD_ZERO( &in );
-    FD_SET( idleFds[0], &in );
+    wxFD_ZERO( &in );
+    wxFD_SET( idleFds[0], &in );

 
     if( select( idleFds[0] + 1, &in, NULL, NULL, &timeout ) > 0 )
         return;
 
     if( select( idleFds[0] + 1, &in, NULL, NULL, &timeout ) > 0 )
         return;


@@ -462,19 +456,29 @@ static void wxBreakDispatch()
     write( idleFds[1], &dummy, 1 );
 }
 
     write( idleFds[1], &dummy, 1 );
 }
 

-void wxWakeUpIdle()
+void wxApp::WakeUpIdle()

 {
     ::wxBreakDispatch();
 }
 
 {
     ::wxBreakDispatch();
 }
 

+bool wxInitIdleFds()
+{
+    if( pipe(idleFds) != 0 )
+        return false;
+    return true;
+}
+

 bool wxAddIdleCallback()
 {
 bool wxAddIdleCallback()
 {

+    if (!wxInitIdleFds())
+        return false;
+

     // install input handler for wxWakeUpIdle
     // install input handler for wxWakeUpIdle

-    inputId = XtAppAddInput( (XtAppContext) wxTheApp->GetAppContext(),
-                             idleFds[0],
-                             (XtPointer)XtInputReadMask,
-                             wxInputCallback,
-                             NULL );
+    XtAppAddInput((XtAppContext) wxTheApp->GetAppContext(),
+                  idleFds[0],
+                  (XtPointer)XtInputReadMask,
+                  wxInputCallback,
+                  NULL);

 
     return true;
 }
 
     return true;
 }