Warning fixes to unused variables, int/wxChar keycode and other typecasting, not...

[wxWidgets.git] / src / generic / prntdlgg.cpp

diff --git a/src/generic/prntdlgg.cpp b/src/generic/prntdlgg.cpp
index 1184a4db2a43f2f502162fdf59f381ce998eb014..e201b9d82c2b44ca68429b9bd6bc601d3c82e60a 100644 (file)
--- a/src/generic/prntdlgg.cpp
+++ b/src/generic/prntdlgg.cpp
@@ -17,7 +17,7 @@
 // headers
 // ----------------------------------------------------------------------------
 
 // headers
 // ----------------------------------------------------------------------------
 

-#ifdef __GNUG__
+#if defined(__GNUG__) && !defined(NO_GCC_PRAGMA)

     #pragma implementation "prntdlgg.h"
 #endif
 
     #pragma implementation "prntdlgg.h"
 #endif
 


@@ -28,13 +28,11 @@
     #pragma hdrstop
 #endif
 
     #pragma hdrstop
 #endif
 

-#if wxUSE_PRINTING_ARCHITECTURE
+#if wxUSE_PRINTING_ARCHITECTURE && (!defined(__WXMSW__) || wxUSE_POSTSCRIPT_ARCHITECTURE_IN_MSW)

 
 #ifndef WX_PRECOMP
     #include "wx/utils.h"
     #include "wx/dc.h"
 
 #ifndef WX_PRECOMP
     #include "wx/utils.h"
     #include "wx/dc.h"

-    #include "wx/app.h"
-    #include "wx/frame.h"

     #include "wx/stattext.h"
     #include "wx/statbox.h"
     #include "wx/button.h"
     #include "wx/stattext.h"
     #include "wx/statbox.h"
     #include "wx/button.h"


@@ -42,7 +40,6 @@
     #include "wx/textctrl.h"
     #include "wx/radiobox.h"
     #include "wx/filedlg.h"
     #include "wx/textctrl.h"
     #include "wx/radiobox.h"
     #include "wx/filedlg.h"

-    #include "wx/choice.h"

     #include "wx/combobox.h"
     #include "wx/intl.h"
     #include "wx/sizer.h"
     #include "wx/combobox.h"
     #include "wx/intl.h"
     #include "wx/sizer.h"


@@ -59,58 +56,87 @@
     #include "wx/generic/dcpsg.h"
 #endif
 
     #include "wx/generic/dcpsg.h"
 #endif
 

+#include "wx/prntbase.h"

 #include "wx/printdlg.h"
 #include "wx/paper.h"
 #include "wx/filename.h"
 #include "wx/printdlg.h"
 #include "wx/paper.h"
 #include "wx/filename.h"

-
-// For print paper things
-#include "wx/prntbase.h"
+#include "wx/tokenzr.h"

 
 #include <stdlib.h>
 #include <string.h>
 
 // ----------------------------------------------------------------------------
 
 #include <stdlib.h>
 #include <string.h>
 
 // ----------------------------------------------------------------------------

-// wxWin macros
+// global vars

 // ----------------------------------------------------------------------------
 
 // ----------------------------------------------------------------------------
 

+extern wxPrintPaperDatabase *wxThePrintPaperDatabase;

 
 #if wxUSE_POSTSCRIPT
 
 
 #if wxUSE_POSTSCRIPT
 

-IMPLEMENT_CLASS(wxGenericPrintDialog, wxDialog)
-IMPLEMENT_CLASS(wxGenericPrintSetupDialog, wxDialog)
+//----------------------------------------------------------------------------
+// wxPostScriptNativeData
+//----------------------------------------------------------------------------

 
 

-BEGIN_EVENT_TABLE(wxGenericPrintDialog, wxDialog)
-    EVT_BUTTON(wxID_OK, wxGenericPrintDialog::OnOK)
-    EVT_BUTTON(wxPRINTID_SETUP, wxGenericPrintDialog::OnSetup)
-    EVT_RADIOBOX(wxPRINTID_RANGE, wxGenericPrintDialog::OnRange)
-END_EVENT_TABLE()
+IMPLEMENT_CLASS(wxPostScriptPrintNativeData, wxPrintNativeDataBase)

 
 

-#endif // wxUSE_POSTSCRIPT
+wxPostScriptPrintNativeData::wxPostScriptPrintNativeData()
+{
+    m_previewCommand = wxT("");
+#ifdef __VMS__
+    m_printerCommand = wxT("print");
+    m_printerOptions = wxT("/nonotify/queue=psqueue");
+    m_afmPath = wxT("sys$ps_font_metrics:");
+#endif

 
 

-IMPLEMENT_CLASS(wxGenericPageSetupDialog, wxDialog)
+#ifdef __WXMSW__
+    m_printerCommand = wxT("print");
+    m_printerOptions = wxT("");
+    m_afmPath = wxT("c:\\windows\\system\\");
+#endif

 
 

-BEGIN_EVENT_TABLE(wxGenericPageSetupDialog, wxDialog)
-    EVT_BUTTON(wxPRINTID_SETUP, wxGenericPageSetupDialog::OnPrinter)
-END_EVENT_TABLE()
+#if !defined(__VMS__) && !defined(__WXMSW__)
+    m_printerCommand = wxT("lpr");
+    m_printerOptions = wxT("");
+    m_afmPath = wxT("");
+#endif

 
 

-// ----------------------------------------------------------------------------
-// global vars
-// ----------------------------------------------------------------------------
+    m_printerScaleX = 1.0;
+    m_printerScaleY = 1.0;
+    m_printerTranslateX = 0;
+    m_printerTranslateY = 0;
+}

 
 

-extern wxPrintPaperDatabase *wxThePrintPaperDatabase;
+wxPostScriptPrintNativeData::~wxPostScriptPrintNativeData()
+{
+}

 
 

-#if wxUSE_POSTSCRIPT
+bool wxPostScriptPrintNativeData::TransferTo( wxPrintData &data )
+{
+    return true;
+}
+
+bool wxPostScriptPrintNativeData::TransferFrom( const wxPrintData &data )
+{
+    return true;
+}

 
 // ----------------------------------------------------------------------------
 // Generic print dialog for non-Windows printing use.
 // ----------------------------------------------------------------------------
 
 
 // ----------------------------------------------------------------------------
 // Generic print dialog for non-Windows printing use.
 // ----------------------------------------------------------------------------
 

+IMPLEMENT_CLASS(wxGenericPrintDialog, wxPrintDialogBase)
+
+BEGIN_EVENT_TABLE(wxGenericPrintDialog, wxPrintDialogBase)
+    EVT_BUTTON(wxID_OK, wxGenericPrintDialog::OnOK)
+    EVT_BUTTON(wxPRINTID_SETUP, wxGenericPrintDialog::OnSetup)
+    EVT_RADIOBOX(wxPRINTID_RANGE, wxGenericPrintDialog::OnRange)
+END_EVENT_TABLE()
+

 wxGenericPrintDialog::wxGenericPrintDialog(wxWindow *parent,
                                            wxPrintDialogData* data)
 wxGenericPrintDialog::wxGenericPrintDialog(wxWindow *parent,
                                            wxPrintDialogData* data)

-                    : wxDialog(parent, -1, _("Print"),
+                    : wxPrintDialogBase(parent, wxID_ANY, _("Print"),

                                wxPoint(0, 0), wxSize(600, 600),
                                wxDEFAULT_DIALOG_STYLE |
                                wxPoint(0, 0), wxSize(600, 600),
                                wxDEFAULT_DIALOG_STYLE |

-                               wxDIALOG_MODAL |

                                wxTAB_TRAVERSAL)
 {
     if ( data )
                                wxTAB_TRAVERSAL)
 {
     if ( data )


@@ -121,41 +147,63 @@ wxGenericPrintDialog::wxGenericPrintDialog(wxWindow *parent,
 
 wxGenericPrintDialog::wxGenericPrintDialog(wxWindow *parent,
                                            wxPrintData* data)
 
 wxGenericPrintDialog::wxGenericPrintDialog(wxWindow *parent,
                                            wxPrintData* data)

-                    : wxDialog(parent, -1, _("Print"),
+                    : wxPrintDialogBase(parent, wxID_ANY, _("Print"),

                                wxPoint(0, 0), wxSize(600, 600),
                                wxDEFAULT_DIALOG_STYLE |
                                wxPoint(0, 0), wxSize(600, 600),
                                wxDEFAULT_DIALOG_STYLE |

-                               wxDIALOG_MODAL |

                                wxTAB_TRAVERSAL)
 {
     if ( data )
         m_printDialogData = *data;
                                wxTAB_TRAVERSAL)
 {
     if ( data )
         m_printDialogData = *data;

-
+        

     Init(parent);
 }
 
 void wxGenericPrintDialog::Init(wxWindow * WXUNUSED(parent))
 {
     Init(parent);
 }
 
 void wxGenericPrintDialog::Init(wxWindow * WXUNUSED(parent))
 {

-  //    wxDialog::Create(parent, -1, _("Print"), wxPoint(0, 0), wxSize(600, 600),
-  //                     wxDEFAULT_DIALOG_STYLE | wxDIALOG_MODAL | wxTAB_TRAVERSAL);
+  //    wxDialog::Create(parent, wxID_ANY, _("Print"), wxPoint(0, 0), wxSize(600, 600),
+  //                     wxDEFAULT_DIALOG_STYLE | wxTAB_TRAVERSAL);

 
     wxBoxSizer *mainsizer = new wxBoxSizer( wxVERTICAL );
 
     wxBoxSizer *mainsizer = new wxBoxSizer( wxVERTICAL );

+    
+    // 1) top row
+
+    wxPrintFactory* factory = wxPrintFactory::GetFactory();

 
 

-    // 1) top row 
+    wxStaticBoxSizer *topsizer = new wxStaticBoxSizer(
+        new wxStaticBox( this, wxID_ANY, _( "Printer options" ) ), wxHORIZONTAL );
+    wxFlexGridSizer *flex = new wxFlexGridSizer( 2 );
+    flex->AddGrowableCol( 1 );
+    topsizer->Add( flex, 1, wxGROW );

         
         

-    wxStaticBoxSizer *topsizer = new wxStaticBoxSizer( 
-        new wxStaticBox( this, -1, _( "Printer options" ) ), wxHORIZONTAL );

     m_printToFileCheckBox = new wxCheckBox( this, wxPRINTID_PRINTTOFILE, _("Print to File") );
     m_printToFileCheckBox = new wxCheckBox( this, wxPRINTID_PRINTTOFILE, _("Print to File") );

-    topsizer->Add( m_printToFileCheckBox, 0, wxCENTER|wxALL, 5 );
-
-    topsizer->Add( 60,2,1 );
-
-    m_setupButton = new wxButton(this, wxPRINTID_SETUP, _("Setup...") );
-    topsizer->Add( m_setupButton, 0, wxCENTER|wxALL, 5 );
+    flex->Add( m_printToFileCheckBox, 0, wxALIGN_CENTER_VERTICAL|wxALL, 5 );

     
     

-    mainsizer->Add( topsizer, 0, wxLEFT|wxTOP|wxRIGHT, 10 );
+    m_setupButton = new wxButton(this, wxPRINTID_SETUP, _("Setup...") );
+    flex->Add( m_setupButton, 0, wxALIGN_CENTER_VERTICAL|wxALIGN_RIGHT|wxALL, 5 );

     
     

+    if (!factory->HasPrintSetupDialog())
+        m_setupButton->Enable( false );
+        
+    if (factory->HasPrinterLine())
+    {
+        flex->Add( new wxStaticText( this, -1, _("Printer:") ), 
+            0, wxALIGN_CENTER_VERTICAL|wxALL, 5 );
+        flex->Add( new wxStaticText( this, -1, factory->CreatePrinterLine() ), 
+            0, wxALIGN_CENTER_VERTICAL|wxALL, 5 );
+    }
+
+    if (factory->HasStatusLine())
+    {
+        flex->Add( new wxStaticText( this, -1, _("Status:") ), 
+            0, wxALIGN_CENTER_VERTICAL|wxALL-wxTOP, 5 );
+        flex->Add( new wxStaticText( this, -1, factory->CreateStatusLine() ), 
+            0, wxALIGN_CENTER_VERTICAL|wxALL-wxTOP, 5 );
+    }
+
+    mainsizer->Add( topsizer, 0, wxLEFT|wxTOP|wxRIGHT|wxGROW, 10 );
+

     // 2) middle row with radio box
     // 2) middle row with radio box

-    
+

     wxString *choices = new wxString[2];
     choices[0] = _("All");
     choices[1] = _("Pages");
     wxString *choices = new wxString[2];
     choices[0] = _("All");
     choices[1] = _("Pages");


@@ -163,7 +211,7 @@ void wxGenericPrintDialog::Init(wxWindow * WXUNUSED(parent))
     m_fromText = (wxTextCtrl*)NULL;
     m_toText = (wxTextCtrl*)NULL;
     m_rangeRadioBox = (wxRadioBox *)NULL;
     m_fromText = (wxTextCtrl*)NULL;
     m_toText = (wxTextCtrl*)NULL;
     m_rangeRadioBox = (wxRadioBox *)NULL;

-    
+

     if (m_printDialogData.GetFromPage() != 0)
     {
         m_rangeRadioBox = new wxRadioBox(this, wxPRINTID_RANGE, _("Print Range"),
     if (m_printDialogData.GetFromPage() != 0)
     {
         m_rangeRadioBox = new wxRadioBox(this, wxPRINTID_RANGE, _("Print Range"),


@@ -176,36 +224,36 @@ void wxGenericPrintDialog::Init(wxWindow * WXUNUSED(parent))
     }
 
     // 3) bottom row
     }
 
     // 3) bottom row

-    
+

     wxBoxSizer *bottomsizer = new wxBoxSizer( wxHORIZONTAL );
 
     if (m_printDialogData.GetFromPage() != 0)
     {
         bottomsizer->Add( new wxStaticText(this, wxPRINTID_STATIC, _("From:") ), 0, wxCENTER|wxALL, 5 );
     wxBoxSizer *bottomsizer = new wxBoxSizer( wxHORIZONTAL );
 
     if (m_printDialogData.GetFromPage() != 0)
     {
         bottomsizer->Add( new wxStaticText(this, wxPRINTID_STATIC, _("From:") ), 0, wxCENTER|wxALL, 5 );

-        m_fromText = new wxTextCtrl(this, wxPRINTID_FROM, wxT(""), wxDefaultPosition, wxSize(40, -1));
+        m_fromText = new wxTextCtrl(this, wxPRINTID_FROM, wxEmptyString, wxDefaultPosition, wxSize(40, wxDefaultCoord));

         bottomsizer->Add( m_fromText, 1, wxCENTER|wxRIGHT, 10 );
 
         bottomsizer->Add( new wxStaticText(this, wxPRINTID_STATIC, _("To:") ), 0, wxCENTER|wxALL, 5);
         bottomsizer->Add( m_fromText, 1, wxCENTER|wxRIGHT, 10 );
 
         bottomsizer->Add( new wxStaticText(this, wxPRINTID_STATIC, _("To:") ), 0, wxCENTER|wxALL, 5);

-        m_toText = new wxTextCtrl(this, wxPRINTID_TO, wxT(""), wxDefaultPosition, wxSize(40, -1));
+        m_toText = new wxTextCtrl(this, wxPRINTID_TO, wxEmptyString, wxDefaultPosition, wxSize(40, wxDefaultCoord));

         bottomsizer->Add( m_toText, 1, wxCENTER|wxRIGHT, 10 );
     }
 
     bottomsizer->Add( new wxStaticText(this, wxPRINTID_STATIC, _("Copies:") ), 0, wxCENTER|wxALL, 5 );
         bottomsizer->Add( m_toText, 1, wxCENTER|wxRIGHT, 10 );
     }
 
     bottomsizer->Add( new wxStaticText(this, wxPRINTID_STATIC, _("Copies:") ), 0, wxCENTER|wxALL, 5 );

-    m_noCopiesText = new wxTextCtrl(this, wxPRINTID_COPIES, wxT(""), wxPoint(252, 130), wxSize(40, -1));
+    m_noCopiesText = new wxTextCtrl(this, wxPRINTID_COPIES, wxEmptyString, wxPoint(252, 130), wxSize(40, wxDefaultCoord));

     bottomsizer->Add( m_noCopiesText, 1, wxCENTER|wxRIGHT, 10 );
 
     mainsizer->Add( bottomsizer, 0, wxTOP|wxLEFT|wxRIGHT, 12 );
 
 #if wxUSE_STATLINE
     // 4) static line
     bottomsizer->Add( m_noCopiesText, 1, wxCENTER|wxRIGHT, 10 );
 
     mainsizer->Add( bottomsizer, 0, wxTOP|wxLEFT|wxRIGHT, 12 );
 
 #if wxUSE_STATLINE
     // 4) static line

-    mainsizer->Add( new wxStaticLine( this, -1 ), 0, wxEXPAND | wxLEFT|wxRIGHT|wxTOP, 10 );
+    mainsizer->Add( new wxStaticLine( this, wxID_ANY ), 0, wxEXPAND | wxLEFT|wxRIGHT|wxTOP, 10 );

 #endif
 
     // 5) buttons
 
     mainsizer->Add( CreateButtonSizer( wxOK|wxCANCEL), 0, wxCENTER|wxALL, 10 );
 
 #endif
 
     // 5) buttons
 
     mainsizer->Add( CreateButtonSizer( wxOK|wxCANCEL), 0, wxCENTER|wxALL, 10 );
 

-    SetAutoLayout( TRUE );
+    SetAutoLayout( true );

     SetSizer( mainsizer );
 
     mainsizer->Fit( this );
     SetSizer( mainsizer );
 
     mainsizer->Fit( this );


@@ -218,33 +266,7 @@ void wxGenericPrintDialog::Init(wxWindow * WXUNUSED(parent))
 
 int wxGenericPrintDialog::ShowModal()
 {
 
 int wxGenericPrintDialog::ShowModal()
 {

-    if ( m_printDialogData.GetSetupDialog() )
-    {
-        // Make sure wxPrintData object reflects the settings now, in case the setup dialog
-        // changes it. In fact there aren't any common settings at
-        // present, but there might be in future.
-        // TransferDataFromWindow();
-
-        wxGenericPrintSetupDialog *genericPrintSetupDialog =
-            new wxGenericPrintSetupDialog(this, & m_printDialogData.GetPrintData());
-        int ret = genericPrintSetupDialog->ShowModal();
-        if ( ret != wxID_CANCEL )
-        {
-            // Transfer settings to  the print dialog's print data.
-            m_printDialogData.GetPrintData() = genericPrintSetupDialog->GetPrintData();
-        }
-        genericPrintSetupDialog->Destroy();
-
-        // Restore the wxPrintData settings again (uncomment if any settings become common
-        // to both dialogs)
-        // TransferDataToWindow();
-
-        return ret;
-    }
-    else
-    {
-        return wxDialog::ShowModal();
-    }
+    return wxDialog::ShowModal();

 }
 
 wxGenericPrintDialog::~wxGenericPrintDialog()
 }
 
 wxGenericPrintDialog::~wxGenericPrintDialog()


@@ -255,6 +277,11 @@ void wxGenericPrintDialog::OnOK(wxCommandEvent& WXUNUSED(event))
 {
     TransferDataFromWindow();
 
 {
     TransferDataFromWindow();
 

+    // An empty 'to' field signals printing just the
+    // 'from' page.
+    if (m_printDialogData.GetToPage() < 1)
+        m_printDialogData.SetToPage(m_printDialogData.GetFromPage());
+

     // There are some interactions between the global setup data
     // and the standard print dialog. The global printing 'mode'
     // is determined by whether the user checks Print to file
     // There are some interactions between the global setup data
     // and the standard print dialog. The global printing 'mode'
     // is determined by whether the user checks Print to file


@@ -262,20 +289,20 @@ void wxGenericPrintDialog::OnOK(wxCommandEvent& WXUNUSED(event))
     if (m_printDialogData.GetPrintToFile())
     {
         m_printDialogData.GetPrintData().SetPrintMode(wxPRINT_MODE_FILE);
     if (m_printDialogData.GetPrintToFile())
     {
         m_printDialogData.GetPrintData().SetPrintMode(wxPRINT_MODE_FILE);

-        
+

         wxFileName fname( m_printDialogData.GetPrintData().GetFilename() );
         wxFileName fname( m_printDialogData.GetPrintData().GetFilename() );

-        
+

         wxFileDialog dialog( this, _("PostScript file"),
             fname.GetPath(), fname.GetFullName(), wxT("*.ps"), wxOPEN | wxOVERWRITE_PROMPT );
         if (dialog.ShowModal() != wxID_OK) return;
         wxFileDialog dialog( this, _("PostScript file"),
             fname.GetPath(), fname.GetFullName(), wxT("*.ps"), wxOPEN | wxOVERWRITE_PROMPT );
         if (dialog.ShowModal() != wxID_OK) return;

-
+        

         m_printDialogData.GetPrintData().SetFilename( dialog.GetPath() );
     }
     else
     {
         m_printDialogData.GetPrintData().SetPrintMode(wxPRINT_MODE_PRINTER);
     }
         m_printDialogData.GetPrintData().SetFilename( dialog.GetPath() );
     }
     else
     {
         m_printDialogData.GetPrintData().SetPrintMode(wxPRINT_MODE_PRINTER);
     }

-
+    

     EndModal(wxID_OK);
 }
 
     EndModal(wxID_OK);
 }
 


@@ -285,22 +312,27 @@ void wxGenericPrintDialog::OnRange(wxCommandEvent& event)
 
     if (event.GetInt() == 0)
     {
 
     if (event.GetInt() == 0)
     {

-        m_fromText->Enable(FALSE);
-        m_toText->Enable(FALSE);
+        m_fromText->Enable(false);
+        m_toText->Enable(false);

     }
     else if (event.GetInt() == 1)
     {
     }
     else if (event.GetInt() == 1)
     {

-        m_fromText->Enable(TRUE);
-        m_toText->Enable(TRUE);
+        m_fromText->Enable(true);
+        m_toText->Enable(true);

     }
 }
 
 void wxGenericPrintDialog::OnSetup(wxCommandEvent& WXUNUSED(event))
 {
     }
 }
 
 void wxGenericPrintDialog::OnSetup(wxCommandEvent& WXUNUSED(event))
 {

-    wxGenericPrintSetupDialog dialog( this, &m_printDialogData.GetPrintData() );
-    if (dialog.ShowModal() != wxID_CANCEL)
+    wxPrintFactory* factory = wxPrintFactory::GetFactory();
+
+    if (factory->HasPrintSetupDialog())

     {
     {

-        m_printDialogData = dialog.GetPrintData();
+        // The print setup dialog should change the
+        // print data in-place if not cancelled.
+        wxDialog *dialog = factory->CreatePrintSetupDialog( this, &m_printDialogData.GetPrintData() );
+        dialog->ShowModal();
+        dialog->Destroy();

     }
 }
 
     }
 }
 


@@ -312,26 +344,26 @@ bool wxGenericPrintDialog::TransferDataToWindow()
        {
           if (m_printDialogData.GetEnablePageNumbers())
           {
        {
           if (m_printDialogData.GetEnablePageNumbers())
           {

-             m_fromText->Enable(TRUE);
-             m_toText->Enable(TRUE);
-             m_fromText->SetValue(
-                 wxString::Format(_T("%d"), m_printDialogData.GetFromPage()));
-             m_toText->SetValue(
-                wxString::Format(_T("%d"), m_printDialogData.GetToPage()));
+             m_fromText->Enable(true);
+             m_toText->Enable(true);
+             if (m_printDialogData.GetFromPage() > 0)
+                m_fromText->SetValue(wxString::Format(_T("%d"), m_printDialogData.GetFromPage()));
+             if (m_printDialogData.GetToPage() > 0)
+                m_toText->SetValue(wxString::Format(_T("%d"), m_printDialogData.GetToPage()));

              if(m_rangeRadioBox)
              if(m_rangeRadioBox)

-                if (m_printDialogData.GetAllPages())
+                if (m_printDialogData.GetAllPages() || m_printDialogData.GetFromPage() == 0)

                    m_rangeRadioBox->SetSelection(0);
                 else
                    m_rangeRadioBox->SetSelection(1);
           }
           else
           {
                    m_rangeRadioBox->SetSelection(0);
                 else
                    m_rangeRadioBox->SetSelection(1);
           }
           else
           {

-             m_fromText->Enable(FALSE);
-             m_toText->Enable(FALSE);
+             m_fromText->Enable(false);
+             m_toText->Enable(false);

              if(m_rangeRadioBox)
              {
                 m_rangeRadioBox->SetSelection(0);
              if(m_rangeRadioBox)
              {
                 m_rangeRadioBox->SetSelection(0);

-                m_rangeRadioBox->wxRadioBox::Enable(1, FALSE);
+                m_rangeRadioBox->wxRadioBox::Enable(1, false);

              }
           }
        }
              }
           }
        }


@@ -341,7 +373,7 @@ bool wxGenericPrintDialog::TransferDataToWindow()
 
     m_printToFileCheckBox->SetValue(m_printDialogData.GetPrintToFile());
     m_printToFileCheckBox->Enable(m_printDialogData.GetEnablePrintToFile());
 
     m_printToFileCheckBox->SetValue(m_printDialogData.GetPrintToFile());
     m_printToFileCheckBox->Enable(m_printDialogData.GetEnablePrintToFile());

-    return TRUE;
+    return true;

 }
 
 bool wxGenericPrintDialog::TransferDataFromWindow()
 }
 
 bool wxGenericPrintDialog::TransferDataFromWindow()


@@ -358,7 +390,7 @@ bool wxGenericPrintDialog::TransferDataFromWindow()
                     m_printDialogData.SetFromPage( res );
             }
             if(m_toText)
                     m_printDialogData.SetFromPage( res );
             }
             if(m_toText)

-            {   
+            {

                 wxString value = m_toText->GetValue();
                 if (value.ToLong( &res ))
                     m_printDialogData.SetToPage( res );
                 wxString value = m_toText->GetValue();
                 if (value.ToLong( &res ))
                     m_printDialogData.SetToPage( res );


@@ -366,10 +398,16 @@ bool wxGenericPrintDialog::TransferDataFromWindow()
         }
         if(m_rangeRadioBox)
         {
         }
         if(m_rangeRadioBox)
         {

-           if (m_rangeRadioBox->GetSelection() == 0)
-              m_printDialogData.SetAllPages(TRUE);
-           else
-              m_printDialogData.SetAllPages(FALSE);
+            if (m_rangeRadioBox->GetSelection() == 0)
+            {
+                m_printDialogData.SetAllPages(true);
+                
+                // This means all pages, more or less
+                m_printDialogData.SetFromPage(1);
+                m_printDialogData.SetToPage(32000);
+            }
+            else
+                m_printDialogData.SetAllPages(false);

         }
     }
     else
         }
     }
     else


@@ -377,101 +415,300 @@ bool wxGenericPrintDialog::TransferDataFromWindow()
         m_printDialogData.SetFromPage(1);
         m_printDialogData.SetToPage(32000);
     }
         m_printDialogData.SetFromPage(1);
         m_printDialogData.SetToPage(32000);
     }

-    
+

     wxString value = m_noCopiesText->GetValue();
     if (value.ToLong( &res ))
         m_printDialogData.SetNoCopies( res );
     wxString value = m_noCopiesText->GetValue();
     if (value.ToLong( &res ))
         m_printDialogData.SetNoCopies( res );

-        
-    m_printDialogData.SetPrintToFile(m_printToFileCheckBox->GetValue());

 
 

-    return TRUE;
+    m_printDialogData.SetPrintToFile(m_printToFileCheckBox->GetValue());
+    
+    return true;

 }
 
 }
 

-/*
-TODO: collate and noCopies should be duplicated across dialog data and print data objects
-(slightly different semantics on Windows but let's ignore this for a bit).
-*/
-

 wxDC *wxGenericPrintDialog::GetPrintDC()
 {
 wxDC *wxGenericPrintDialog::GetPrintDC()
 {

-  //    return new wxPostScriptDC(wxThePrintSetupData->GetPrinterFile(), FALSE, (wxWindow *) NULL);
-  return new wxPostScriptDC(GetPrintDialogData().GetPrintData());
+    return new wxPostScriptDC(GetPrintDialogData().GetPrintData());

 }
 
 // ----------------------------------------------------------------------------
 // Generic print setup dialog
 // ----------------------------------------------------------------------------
 
 }
 
 // ----------------------------------------------------------------------------
 // Generic print setup dialog
 // ----------------------------------------------------------------------------
 

+IMPLEMENT_CLASS(wxGenericPrintSetupDialog, wxDialog)
+
+BEGIN_EVENT_TABLE(wxGenericPrintSetupDialog, wxDialog)
+    EVT_LIST_ITEM_ACTIVATED(wxPRINTID_PRINTER, wxGenericPrintSetupDialog::OnPrinter)
+END_EVENT_TABLE()
+

 wxGenericPrintSetupDialog::wxGenericPrintSetupDialog(wxWindow *parent, wxPrintData* data):
 wxGenericPrintSetupDialog::wxGenericPrintSetupDialog(wxWindow *parent, wxPrintData* data):

-wxDialog(parent, -1, _("Print Setup"), wxPoint(0, 0), wxSize(600, 600), wxDEFAULT_DIALOG_STYLE|wxDIALOG_MODAL|wxTAB_TRAVERSAL)
+wxDialog(parent, wxID_ANY, _("Print Setup"), wxPoint(0, 0), wxSize(600, 600), wxDEFAULT_DIALOG_STYLE|wxTAB_TRAVERSAL)

 {
     Init(data);
 }
 
 {
     Init(data);
 }
 

+/* XPM */
+static char * check_xpm[] = {
+/* width height ncolors chars_per_pixel */
+"16 16 3 1",
+/* colors */
+"      s None  c None",
+"X     c #000000",
+".     c #808080",
+/* pixels */
+"                ",
+"                ",
+"                ",
+"             .. ",
+"            XX  ",
+"           XX.  ",
+"          .XX   ",
+"          XX    ",
+"   X     XX.    ",
+"   XX   .XX     ",
+"    XX  XX      ",
+"     XXXX.      ",
+"      XX.       ",
+"       .        ",
+"                ",
+"                "
+};
+
+

 void wxGenericPrintSetupDialog::Init(wxPrintData* data)
 {
     if ( data )
         m_printData = *data;
 
 void wxGenericPrintSetupDialog::Init(wxPrintData* data)
 {
     if ( data )
         m_printData = *data;
 

-    int staticBoxWidth = 300;
+    m_targetData = data;

 
 

-    (void) new wxStaticBox(this, wxPRINTID_STATIC, _("Paper size"), wxPoint(10, 10), wxSize(staticBoxWidth, 60) );
+    wxBoxSizer *main_sizer = new wxBoxSizer( wxVERTICAL );

 
 

-    int xPos = 20;
-    int yPos = 30;
-    m_paperTypeChoice = CreatePaperTypeChoice(&xPos, &yPos);
+    // printer selection
+    
+    wxStaticBoxSizer *printer_sizer = new wxStaticBoxSizer( new wxStaticBox( this, -1, _("Printer") ), wxVERTICAL );
+    main_sizer->Add( printer_sizer, 0, wxALL|wxGROW, 10 );
+    
+    m_printerListCtrl = new wxListCtrl( this, wxPRINTID_PRINTER, 
+        wxDefaultPosition, wxSize(-1,100), wxLC_REPORT|wxLC_SINGLE_SEL|wxSUNKEN_BORDER );
+    wxImageList *image_list = new wxImageList;
+    image_list->Add( wxBitmap(check_xpm) );
+    m_printerListCtrl->AssignImageList( image_list, wxIMAGE_LIST_SMALL );
+        
+    m_printerListCtrl->InsertColumn( 0, wxT(" "), wxLIST_FORMAT_LEFT, 20 );
+    m_printerListCtrl->InsertColumn( 1, wxT("Printer"), wxLIST_FORMAT_LEFT, 150 );
+    m_printerListCtrl->InsertColumn( 2, wxT("Device"), wxLIST_FORMAT_LEFT, 150 );
+    m_printerListCtrl->InsertColumn( 3, wxT("Status"), wxLIST_FORMAT_LEFT, 80 );
+
+    wxListItem item;
+    item.SetMask( wxLIST_MASK_TEXT );
+    item.SetColumn( 1 );
+    item.SetText( _("Default printer") );
+    item.SetId( m_printerListCtrl->InsertItem( item ) );
+
+    if (data->GetPrinterName().IsEmpty())
+    {
+        wxListItem item2;
+        item2.SetId( item.GetId() );
+        item2.SetMask( wxLIST_MASK_IMAGE );
+        item2.SetImage( 0 );
+        m_printerListCtrl->SetItem( item2 );
+    }

 
 

-    wxString *choices =  new wxString[2];
-    choices[0] = _("Portrait");
-    choices[1] = _("Landscape");
+    item.SetId( 1+ item.GetId() );

 
 

-    m_orientationRadioBox = new wxRadioBox(this, wxPRINTID_ORIENTATION, _("Orientation"),
-        wxPoint(10, 80), wxSize(-1, -1), 2, choices, 1, wxRA_VERTICAL );
-    m_orientationRadioBox->SetSelection(0);
+    wxArrayString errors;
+    wxArrayString output;
+    long res = wxExecute( wxT("lpstat -v"), output, errors );
+    if (res >= 0 && errors.GetCount() == 0)
+    {
+        size_t i;
+        for (i = 0; i < output.GetCount(); i++)
+        {
+            wxStringTokenizer tok( output[i], wxT(" ") );
+            wxString tmp = tok.GetNextToken(); // "device"
+            if (tmp != wxT("device"))
+                break;  // the lpstat syntax must have changed.
+            tmp = tok.GetNextToken();          // "for"
+            if (tmp != wxT("for"))
+                break;  // the lpstat syntax must have changed.
+            tmp = tok.GetNextToken();          // "hp_deskjet930c:"
+            if (tmp[tmp.Len()-1] == wxT(':'))
+                tmp.Remove(tmp.Len()-1,1);
+            wxString name = tmp;
+            item.SetText( name );
+            item.SetId( m_printerListCtrl->InsertItem( item ) );
+            tmp = tok.GetNextToken();          // "parallel:/dev/lp0"
+            item.SetColumn( 2 );
+            item.SetText( tmp );
+            m_printerListCtrl->SetItem( item );
+            if (data->GetPrinterName() == name)
+            {
+                wxListItem item2;
+                item2.SetId( item.GetId() );
+                item2.SetMask( wxLIST_MASK_IMAGE );
+                item2.SetImage( 0 );
+                m_printerListCtrl->SetItem( item2 );
+            }
+            
+            wxString command = wxT("lpstat -p ");
+            command += name;
+            wxArrayString errors2;
+            wxArrayString output2;
+            res = wxExecute( command, output2, errors2 );
+            if (res >= 0 && errors2.GetCount() == 0 && output2.GetCount() > 0)
+            {
+                tmp = output2[0]; // "printer hp_deskjet930c is idle. enable since ..."
+                int pos = tmp.Find( wxT('.') );
+                if (pos != -1)
+                    tmp.Remove( (size_t)pos, tmp.Len()-(size_t)pos );
+                wxStringTokenizer tok2( tmp, wxT(" ") );
+                tmp = tok2.GetNextToken();  // "printer"
+                tmp = tok2.GetNextToken();  // "hp_deskjet930c"
+                tmp = wxT("");
+                while (tok2.HasMoreTokens())
+                {
+                    tmp += tok2.GetNextToken();
+                    tmp += wxT(" ");
+                }
+                item.SetColumn( 3 );
+                item.SetText( tmp );
+                m_printerListCtrl->SetItem( item );
+            }
+            
+            item.SetColumn( 1 );
+            item.SetId( 1+ item.GetId() );
+        }
+    }

 
 

-    (void) new wxStaticBox(this, wxPRINTID_STATIC, _("Options"), wxPoint(10, 130), wxSize(staticBoxWidth, 50) );
+    
+    printer_sizer->Add( m_printerListCtrl, 0, wxALL|wxGROW, 5 );

 
 

-    int colourYPos = 145;
+    wxBoxSizer *item1 = new wxBoxSizer( wxHORIZONTAL );
+    main_sizer->Add( item1, 0, wxALL, 5 );

 
 

-#ifdef __WXMOTIF__
-    colourYPos = 150;
-#endif
+    // printer options (on the left)
+
+    wxBoxSizer *item2 = new wxBoxSizer( wxVERTICAL );

 
 

-    m_colourCheckBox = new wxCheckBox(this, wxPRINTID_PRINTCOLOUR, _("Print in colour"), wxPoint(15, colourYPos));
+    wxStaticBox *item4 = new wxStaticBox( this, wxPRINTID_STATIC, _("Paper size") );
+    wxStaticBoxSizer *item3 = new wxStaticBoxSizer( item4, wxVERTICAL );

 
 

-    (void) new wxStaticBox(this, wxPRINTID_STATIC, _("Print spooling"), wxPoint(330, 10), wxSize(200,170) );
+    m_paperTypeChoice = CreatePaperTypeChoice();
+    item3->Add( m_paperTypeChoice, 0, wxALIGN_CENTER|wxALL, 5 );

 
 

-    (void) new wxStaticText(this, wxPRINTID_STATIC, _("Printer command:"), wxPoint(340, 30));
+    item2->Add( item3, 0, wxALIGN_CENTER|wxALL, 5 );

 
 

-    m_printerCommandText = new wxTextCtrl(this, wxPRINTID_COMMAND, wxT(""), wxPoint(360, 55), wxSize(150, -1));
+    wxString strs6[] = 
+    {
+        _("Portrait"), 
+        _("Landscape")
+    };
+    m_orientationRadioBox= new wxRadioBox( this, wxPRINTID_ORIENTATION, _("Orientation"), wxDefaultPosition, wxDefaultSize, 2, strs6, 1, wxRA_SPECIFY_ROWS );
+    item2->Add( m_orientationRadioBox, 0, wxGROW|wxALIGN_CENTER_VERTICAL|wxALL, 5 );

 
 

-    (void) new wxStaticText(this, wxPRINTID_STATIC, _("Printer options:"), wxPoint(340, 110));
+    wxStaticBox *item8 = new wxStaticBox( this, -1, _("Options") );
+    wxStaticBoxSizer *item7 = new wxStaticBoxSizer( item8, wxHORIZONTAL );

 
 

-    m_printerOptionsText = new wxTextCtrl(this, wxPRINTID_OPTIONS, wxT(""), wxPoint(360, 135), wxSize(150, -1));
+    m_colourCheckBox = new wxCheckBox( this, wxPRINTID_PRINTCOLOUR, _("Print in colour") );
+    item7->Add( m_colourCheckBox, 0, wxALIGN_CENTER|wxALL, 5 );
+
+    item2->Add( item7, 0, wxGROW|wxALIGN_CENTER_VERTICAL|wxALL, 5 );
+
+    item1->Add( item2, 0, wxALIGN_CENTER_HORIZONTAL, 5 );
+
+    // spooling options (on the right)
+
+    wxStaticBox *item11 = new wxStaticBox( this, -1, _("Print spooling") );
+    wxStaticBoxSizer *item10 = new wxStaticBoxSizer( item11, wxVERTICAL );
+
+    wxStaticText *item12 = new wxStaticText( this, -1, _("Printer command:") );
+    item10->Add( item12, 0, wxALIGN_CENTER_VERTICAL|wxALL, 5 );
+
+    wxBoxSizer *item13 = new wxBoxSizer( wxHORIZONTAL );
+
+    item13->Add( 20, 20, 0, wxALIGN_CENTER|wxALL, 5 );
+
+    m_printerCommandText = new wxTextCtrl( this, wxPRINTID_COMMAND, wxT(""), wxDefaultPosition, wxSize(160,-1) );
+    item13->Add( m_printerCommandText, 0, wxALIGN_CENTER|wxALL, 5 );
+
+    item10->Add( item13, 0, wxALIGN_CENTER|wxALL, 0 );
+
+    wxStaticText *item15 = new wxStaticText( this, -1, _("Printer options:") );
+    item10->Add( item15, 0, wxALIGN_CENTER_VERTICAL|wxALL, 5 );
+
+    wxBoxSizer *item16 = new wxBoxSizer( wxHORIZONTAL );
+
+    item16->Add( 20, 20, 0, wxALIGN_CENTER|wxALL, 5 );
+
+    m_printerOptionsText = new wxTextCtrl( this, wxPRINTID_OPTIONS, wxT(""), wxDefaultPosition, wxSize(160,-1) );
+    item16->Add( m_printerOptionsText, 0, wxALIGN_CENTER|wxALL, 5 );
+
+    item10->Add( item16, 0, wxALIGN_CENTER|wxALL, 0 );
+
+    item1->Add( item10, 0, wxALIGN_CENTER_HORIZONTAL|wxALL, 5 );
+
+
+#if wxUSE_STATLINE
+    // static line
+    main_sizer->Add( new wxStaticLine( this, -1 ), 0, wxEXPAND | wxLEFT|wxRIGHT|wxTOP, 10 );
+#endif
+
+    // buttons
+
+    main_sizer->Add( CreateButtonSizer( wxOK|wxCANCEL), 0, wxCENTER|wxALL, 10 );
+
+    SetAutoLayout( true );
+    SetSizer( main_sizer );
+
+    main_sizer->Fit( this );
+    Centre(wxBOTH);

 
 

-    wxButton *okButton = new wxButton(this, wxID_OK, _("OK"), wxPoint(130, 200), wxSize(80, -1));
-    (void) new wxButton(this, wxID_CANCEL, _("Cancel"), wxPoint(320, 200), wxSize(80, -1));

 
 

-    okButton->SetDefault();
-    okButton->SetFocus();
-    

     Fit();
     Centre(wxBOTH);
 
     InitDialog();
     Fit();
     Centre(wxBOTH);
 
     InitDialog();

-    delete[] choices;

 }
 
 wxGenericPrintSetupDialog::~wxGenericPrintSetupDialog()
 {
 }
 
 }
 
 wxGenericPrintSetupDialog::~wxGenericPrintSetupDialog()
 {
 }
 

+void wxGenericPrintSetupDialog::OnPrinter(wxListEvent& event)
+{
+    // Delete check mark
+    long item;
+    for (item = 0; item < m_printerListCtrl->GetItemCount(); item++)
+        m_printerListCtrl->SetItemImage( item, -1 );
+    
+    m_printerListCtrl->SetItemImage( event.GetIndex(), 0 );
+    
+    if (event.GetIndex() == 0)
+    {
+        m_printerCommandText->SetValue( wxT("lpr") );
+    }
+    else
+    {
+        wxString tmp = wxT("lpr -P");
+        wxListItem item;
+        item.SetColumn( 1 );
+        item.SetMask( wxLIST_MASK_TEXT );
+        item.SetId( event.GetIndex() );
+        m_printerListCtrl->GetItem( item );
+        tmp += item.GetText();
+        m_printerCommandText->SetValue( tmp );
+    }
+}
+

 bool wxGenericPrintSetupDialog::TransferDataToWindow()
 {
 bool wxGenericPrintSetupDialog::TransferDataToWindow()
 {

-    if (m_printerCommandText && m_printData.GetPrinterCommand())
-        m_printerCommandText->SetValue(m_printData.GetPrinterCommand());
-    if (m_printerOptionsText && m_printData.GetPrinterOptions())
-        m_printerOptionsText->SetValue(m_printData.GetPrinterOptions());
+    wxPostScriptPrintNativeData *data = 
+        (wxPostScriptPrintNativeData *) m_printData.GetNativeData();
+
+    if (m_printerCommandText && data->GetPrinterCommand())
+        m_printerCommandText->SetValue(data->GetPrinterCommand());
+    if (m_printerOptionsText && data->GetPrinterOptions())
+        m_printerOptionsText->SetValue(data->GetPrinterOptions());

     if (m_colourCheckBox)
         m_colourCheckBox->SetValue(m_printData.GetColour());
 
     if (m_colourCheckBox)
         m_colourCheckBox->SetValue(m_printData.GetColour());
 


@@ -482,15 +719,34 @@ bool wxGenericPrintSetupDialog::TransferDataToWindow()
         else
             m_orientationRadioBox->SetSelection(1);
     }
         else
             m_orientationRadioBox->SetSelection(1);
     }

-    return TRUE;
+    return true;

 }
 
 bool wxGenericPrintSetupDialog::TransferDataFromWindow()
 {
 }
 
 bool wxGenericPrintSetupDialog::TransferDataFromWindow()
 {

+    wxPostScriptPrintNativeData *data = 
+        (wxPostScriptPrintNativeData *) m_printData.GetNativeData();
+
+    // find selected printer
+    long id = m_printerListCtrl->GetNextItem( -1, wxLIST_NEXT_ALL, wxLIST_STATE_SELECTED );
+    if (id == 0)
+    {
+        m_printData.SetPrinterName( wxT("") );
+    }
+    else
+    {
+        wxListItem item;
+        item.SetId( id );
+        item.SetMask( wxLIST_MASK_TEXT );
+        item.SetColumn( 1 );
+        m_printerListCtrl->GetItem( item );
+        m_printData.SetPrinterName( item.GetText() );
+    }
+

     if (m_printerCommandText)
     if (m_printerCommandText)

-        m_printData.SetPrinterCommand(m_printerCommandText->GetValue());
+        data->SetPrinterCommand(m_printerCommandText->GetValue());

     if (m_printerOptionsText)
     if (m_printerOptionsText)

-        m_printData.SetPrinterOptions(m_printerOptionsText->GetValue());
+        data->SetPrinterOptions(m_printerOptionsText->GetValue());

     if (m_colourCheckBox)
         m_printData.SetColour(m_colourCheckBox->GetValue());
     if (m_orientationRadioBox)
     if (m_colourCheckBox)
         m_printData.SetColour(m_colourCheckBox->GetValue());
     if (m_orientationRadioBox)


@@ -503,30 +759,30 @@ bool wxGenericPrintSetupDialog::TransferDataFromWindow()
     }
     if (m_paperTypeChoice)
     {
     }
     if (m_paperTypeChoice)
     {

-        wxString val(m_paperTypeChoice->GetStringSelection());
-        if (!val.IsNull() && val != wxT(""))
-            m_printData.SetPaperId(wxThePrintPaperDatabase->ConvertNameToId(val));
+        int selectedItem = m_paperTypeChoice->GetSelection();
+        if (selectedItem != -1)
+        {
+            wxPrintPaperType *paper = wxThePrintPaperDatabase->Item(selectedItem);
+            if (paper != NULL)
+              m_printData.SetPaperId( paper->GetId());
+        }

     }
 
     }
 

-    return TRUE;
+    if (m_targetData)
+        *m_targetData = m_printData;
+
+    return true;

 }
 
 }
 

-wxComboBox *wxGenericPrintSetupDialog::CreatePaperTypeChoice(int *x, int *y)
+wxComboBox *wxGenericPrintSetupDialog::CreatePaperTypeChoice()

 {
 {

-/* Should not be necessary
-    if (!wxThePrintPaperDatabase)
-    {
-        wxThePrintPaperDatabase = new wxPrintPaperDatabase;
-        wxThePrintPaperDatabase->CreateDatabase();
-    }
-*/
-    size_t      n = wxThePrintPaperDatabase->GetCount();
-    wxString   *choices = new wxString [n];
-    size_t      sel = 0;
+    size_t n = wxThePrintPaperDatabase->GetCount();
+    wxString *choices = new wxString [n];
+    size_t sel = 0;

 
     for (size_t i = 0; i < n; i++)
     {
 
     for (size_t i = 0; i < n; i++)
     {

-        wxPrintPaperType *paper = (wxPrintPaperType *)wxThePrintPaperDatabase->Item(i)->GetData();
+        wxPrintPaperType *paper = wxThePrintPaperDatabase->Item(i);

         choices[i] = paper->GetName();
         if (m_printData.GetPaperId() == paper->GetId())
             sel = i;
         choices[i] = paper->GetName();
         if (m_printData.GetPaperId() == paper->GetId())
             sel = i;


@@ -537,23 +793,28 @@ wxComboBox *wxGenericPrintSetupDialog::CreatePaperTypeChoice(int *x, int *y)
     wxComboBox *choice = new wxComboBox( this,
                                          wxPRINTID_PAPERSIZE,
                                          _("Paper Size"),
     wxComboBox *choice = new wxComboBox( this,
                                          wxPRINTID_PAPERSIZE,
                                          _("Paper Size"),

-                                         wxPoint(*x, *y),
-                                         wxSize(width, -1),
+                                         wxDefaultPosition,
+                                         wxSize(width, wxDefaultCoord),

                                          n, choices );
 
                                          n, choices );
 

-    //    SetFont(thisFont);
-

     delete[] choices;
 
     choice->SetSelection(sel);
     return choice;
 }
     delete[] choices;
 
     choice->SetSelection(sel);
     return choice;
 }

+

 #endif // wxUSE_POSTSCRIPT
 
 // ----------------------------------------------------------------------------
 // Generic page setup dialog
 // ----------------------------------------------------------------------------
 
 #endif // wxUSE_POSTSCRIPT
 
 // ----------------------------------------------------------------------------
 // Generic page setup dialog
 // ----------------------------------------------------------------------------
 

+IMPLEMENT_CLASS(wxGenericPageSetupDialog, wxDialog)
+
+BEGIN_EVENT_TABLE(wxGenericPageSetupDialog, wxDialog)
+    EVT_BUTTON(wxPRINTID_SETUP, wxGenericPageSetupDialog::OnPrinter)
+END_EVENT_TABLE()
+

 void wxGenericPageSetupDialog::OnPrinter(wxCommandEvent& WXUNUSED(event))
 {
     // We no longer query GetPrintMode, so we can eliminate the need
 void wxGenericPageSetupDialog::OnPrinter(wxCommandEvent& WXUNUSED(event))
 {
     // We no longer query GetPrintMode, so we can eliminate the need


@@ -570,17 +831,15 @@ void wxGenericPageSetupDialog::OnPrinter(wxCommandEvent& WXUNUSED(event))
     // Transfer the current print settings from this dialog to the page setup dialog.
     wxPrintDialogData data;
     data = GetPageSetupData().GetPrintData();
     // Transfer the current print settings from this dialog to the page setup dialog.
     wxPrintDialogData data;
     data = GetPageSetupData().GetPrintData();

-    data.SetSetupDialog(TRUE);
-    wxPrintDialog *printDialog = new wxPrintDialog(this, & data);
-    printDialog->ShowModal();
+    data.SetSetupDialog(true);
+    wxPrintDialog printDialog(this, & data);
+    printDialog.ShowModal();

 
     // Transfer the page setup print settings from the page dialog to this dialog again, in case
     // the page setup dialog changed something.
 
     // Transfer the page setup print settings from the page dialog to this dialog again, in case
     // the page setup dialog changed something.

-    GetPageSetupData().GetPrintData() = printDialog->GetPrintDialogData().GetPrintData();
+    GetPageSetupData().GetPrintData() = printDialog.GetPrintDialogData().GetPrintData();

     GetPageSetupData().CalculatePaperSizeFromId(); // Make sure page size reflects the id in wxPrintData
 
     GetPageSetupData().CalculatePaperSizeFromId(); // Make sure page size reflects the id in wxPrintData
 

-    printDialog->Destroy();
-

     // Now update the dialog in case the page setup dialog changed some of our settings.
     TransferDataToWindow();
 }
     // Now update the dialog in case the page setup dialog changed some of our settings.
     TransferDataToWindow();
 }


@@ -588,11 +847,11 @@ void wxGenericPageSetupDialog::OnPrinter(wxCommandEvent& WXUNUSED(event))
 wxGenericPageSetupDialog::wxGenericPageSetupDialog( wxWindow *parent,
                                                     wxPageSetupData* data)
     : wxDialog( parent,
 wxGenericPageSetupDialog::wxGenericPageSetupDialog( wxWindow *parent,
                                                     wxPageSetupData* data)
     : wxDialog( parent,

-                -1,
+                wxID_ANY,

                 _("Page Setup"),
                 wxPoint(0, 0),
                 wxSize(600, 600),
                 _("Page Setup"),
                 wxPoint(0, 0),
                 wxSize(600, 600),

-                wxDIALOG_MODAL|wxDEFAULT_DIALOG_STYLE|wxTAB_TRAVERSAL )
+                wxDEFAULT_DIALOG_STYLE|wxTAB_TRAVERSAL )

 {
     if (data)
         m_pageData = *data;
 {
     if (data)
         m_pageData = *data;


@@ -602,7 +861,7 @@ wxGenericPageSetupDialog::wxGenericPageSetupDialog( wxWindow *parent,
     wxBoxSizer *mainsizer = new wxBoxSizer( wxVERTICAL );
 
     // 1) top
     wxBoxSizer *mainsizer = new wxBoxSizer( wxVERTICAL );
 
     // 1) top

-    wxStaticBoxSizer *topsizer = new wxStaticBoxSizer( 
+    wxStaticBoxSizer *topsizer = new wxStaticBoxSizer(

       new wxStaticBox(this,wxPRINTID_STATIC, _("Paper size")), wxHORIZONTAL );
 
     size_t      n = wxThePrintPaperDatabase->GetCount();
       new wxStaticBox(this,wxPRINTID_STATIC, _("Paper size")), wxHORIZONTAL );
 
     size_t      n = wxThePrintPaperDatabase->GetCount();


@@ -610,7 +869,7 @@ wxGenericPageSetupDialog::wxGenericPageSetupDialog( wxWindow *parent,
 
     for (size_t i = 0; i < n; i++)
     {
 
     for (size_t i = 0; i < n; i++)
     {

-        wxPrintPaperType *paper = (wxPrintPaperType *)wxThePrintPaperDatabase->Item(i)->GetData();
+        wxPrintPaperType *paper = wxThePrintPaperDatabase->Item(i);

         choices[i] = paper->GetName();
     }
 
         choices[i] = paper->GetName();
     }
 


@@ -618,7 +877,7 @@ wxGenericPageSetupDialog::wxGenericPageSetupDialog( wxWindow *parent,
                                         wxPRINTID_PAPERSIZE,
                                         _("Paper Size"),
                                         wxDefaultPosition,
                                         wxPRINTID_PAPERSIZE,
                                         _("Paper Size"),
                                         wxDefaultPosition,

-                                        wxSize(300, -1),
+                                        wxSize(300, wxDefaultCoord),

                                         n, choices );
     topsizer->Add( m_paperTypeChoice, 1, wxEXPAND|wxALL, 5 );
 //  m_paperTypeChoice->SetSelection(sel);
                                         n, choices );
     topsizer->Add( m_paperTypeChoice, 1, wxEXPAND|wxALL, 5 );
 //  m_paperTypeChoice->SetSelection(sel);


@@ -644,22 +903,22 @@ wxGenericPageSetupDialog::wxGenericPageSetupDialog( wxWindow *parent,
     column1->Add( new wxStaticText(this, wxPRINTID_STATIC, _("Left margin (mm):")),1,wxALL|wxALIGN_RIGHT,5 );
     column1->Add( new wxStaticText(this, wxPRINTID_STATIC, _("Top margin (mm):")),1,wxALL|wxALIGN_RIGHT,5 );
     table->Add( column1, 0, wxALL | wxEXPAND, 5 );
     column1->Add( new wxStaticText(this, wxPRINTID_STATIC, _("Left margin (mm):")),1,wxALL|wxALIGN_RIGHT,5 );
     column1->Add( new wxStaticText(this, wxPRINTID_STATIC, _("Top margin (mm):")),1,wxALL|wxALIGN_RIGHT,5 );
     table->Add( column1, 0, wxALL | wxEXPAND, 5 );

-    
+

     wxBoxSizer *column2 = new wxBoxSizer( wxVERTICAL );
     wxBoxSizer *column2 = new wxBoxSizer( wxVERTICAL );

-    m_marginLeftText = new wxTextCtrl(this, wxPRINTID_LEFTMARGIN, wxT(""), wxDefaultPosition, wxSize(textWidth, -1));
-    m_marginTopText = new wxTextCtrl(this, wxPRINTID_TOPMARGIN, wxT(""), wxDefaultPosition, wxSize(textWidth, -1));
+    m_marginLeftText = new wxTextCtrl(this, wxPRINTID_LEFTMARGIN, wxEmptyString, wxDefaultPosition, wxSize(textWidth, wxDefaultCoord));
+    m_marginTopText = new wxTextCtrl(this, wxPRINTID_TOPMARGIN, wxEmptyString, wxDefaultPosition, wxSize(textWidth, wxDefaultCoord));

     column2->Add( m_marginLeftText, 1, wxALL, 5 );
     column2->Add( m_marginTopText, 1, wxALL, 5 );
     table->Add( column2, 0, wxRIGHT|wxTOP|wxBOTTOM | wxEXPAND, 5 );
     column2->Add( m_marginLeftText, 1, wxALL, 5 );
     column2->Add( m_marginTopText, 1, wxALL, 5 );
     table->Add( column2, 0, wxRIGHT|wxTOP|wxBOTTOM | wxEXPAND, 5 );

-    
+

     wxBoxSizer *column3 = new wxBoxSizer( wxVERTICAL );
     column3->Add( new wxStaticText(this, wxPRINTID_STATIC, _("Right margin (mm):")),1,wxALL|wxALIGN_RIGHT,5 );
     column3->Add( new wxStaticText(this, wxPRINTID_STATIC, _("Bottom margin (mm):")),1,wxALL|wxALIGN_RIGHT,5 );
     table->Add( column3, 0, wxALL | wxEXPAND, 5 );
     wxBoxSizer *column3 = new wxBoxSizer( wxVERTICAL );
     column3->Add( new wxStaticText(this, wxPRINTID_STATIC, _("Right margin (mm):")),1,wxALL|wxALIGN_RIGHT,5 );
     column3->Add( new wxStaticText(this, wxPRINTID_STATIC, _("Bottom margin (mm):")),1,wxALL|wxALIGN_RIGHT,5 );
     table->Add( column3, 0, wxALL | wxEXPAND, 5 );

-    
+

     wxBoxSizer *column4 = new wxBoxSizer( wxVERTICAL );
     wxBoxSizer *column4 = new wxBoxSizer( wxVERTICAL );

-    m_marginRightText = new wxTextCtrl(this, wxPRINTID_RIGHTMARGIN, wxT(""), wxDefaultPosition, wxSize(textWidth, -1));
-    m_marginBottomText = new wxTextCtrl(this, wxPRINTID_BOTTOMMARGIN, wxT(""), wxDefaultPosition, wxSize(textWidth, -1));
+    m_marginRightText = new wxTextCtrl(this, wxPRINTID_RIGHTMARGIN, wxEmptyString, wxDefaultPosition, wxSize(textWidth, wxDefaultCoord));
+    m_marginBottomText = new wxTextCtrl(this, wxPRINTID_BOTTOMMARGIN, wxEmptyString, wxDefaultPosition, wxSize(textWidth, wxDefaultCoord));

     column4->Add( m_marginRightText, 1, wxALL, 5 );
     column4->Add( m_marginBottomText, 1, wxALL, 5 );
     table->Add( column4, 0, wxRIGHT|wxTOP|wxBOTTOM | wxEXPAND, 5 );
     column4->Add( m_marginRightText, 1, wxALL, 5 );
     column4->Add( m_marginBottomText, 1, wxALL, 5 );
     table->Add( column4, 0, wxRIGHT|wxTOP|wxBOTTOM | wxEXPAND, 5 );


@@ -668,29 +927,29 @@ wxGenericPageSetupDialog::wxGenericPageSetupDialog( wxWindow *parent,
 
 #if wxUSE_STATLINE
     // 5) static line
 
 #if wxUSE_STATLINE
     // 5) static line

-    mainsizer->Add( new wxStaticLine( this, -1 ), 0, wxEXPAND | wxLEFT|wxRIGHT|wxTOP, 10 );
+    mainsizer->Add( new wxStaticLine( this, wxID_ANY ), 0, wxEXPAND | wxLEFT|wxRIGHT|wxTOP, 10 );

 #endif
 
     // 6) buttons
 #endif
 
     // 6) buttons

-    
+

     wxSizer* buttonsizer = CreateButtonSizer( wxOK|wxCANCEL);
     m_printerButton = new wxButton(this, wxPRINTID_SETUP, _("Printer...") );
     buttonsizer->Add( m_printerButton, 0, wxLEFT|wxRIGHT, 10 );
     if ( !m_pageData.GetEnablePrinter() )
     wxSizer* buttonsizer = CreateButtonSizer( wxOK|wxCANCEL);
     m_printerButton = new wxButton(this, wxPRINTID_SETUP, _("Printer...") );
     buttonsizer->Add( m_printerButton, 0, wxLEFT|wxRIGHT, 10 );
     if ( !m_pageData.GetEnablePrinter() )

-        m_printerButton->Enable(FALSE);
+        m_printerButton->Enable(false);

     //  if (m_printData.GetEnableHelp())
     //  if (m_printData.GetEnableHelp())

-    //  wxButton *helpButton = new wxButton(this, (wxFunction)wxGenericPageSetupHelpProc, _("Help"), -1, -1, buttonWidth, buttonHeight);
+    //  wxButton *helpButton = new wxButton(this, (wxFunction)wxGenericPageSetupHelpProc, _("Help"), wxDefaultCoord, wxDefaultCoord, buttonWidth, buttonHeight);

     mainsizer->Add( buttonsizer, 0, wxCENTER|wxALL, 10 );
 
 
     mainsizer->Add( buttonsizer, 0, wxCENTER|wxALL, 10 );
 
 

-    SetAutoLayout( TRUE );
+    SetAutoLayout( true );

     SetSizer( mainsizer );
 
     mainsizer->Fit( this );
     Centre(wxBOTH);
 
     InitDialog();
     SetSizer( mainsizer );
 
     mainsizer->Fit( this );
     Centre(wxBOTH);
 
     InitDialog();

-    
+

     delete[] choices;
     delete [] choices2;
 }
     delete[] choices;
     delete [] choices2;
 }


@@ -702,13 +961,13 @@ wxGenericPageSetupDialog::~wxGenericPageSetupDialog()
 bool wxGenericPageSetupDialog::TransferDataToWindow()
 {
     if (m_marginLeftText)
 bool wxGenericPageSetupDialog::TransferDataToWindow()
 {
     if (m_marginLeftText)

-        m_marginLeftText->SetValue(IntToString((int) m_pageData.GetMarginTopLeft().x));
+        m_marginLeftText->SetValue(wxString::Format(wxT("%d"), m_pageData.GetMarginTopLeft().x));

     if (m_marginTopText)
     if (m_marginTopText)

-        m_marginTopText->SetValue(IntToString((int) m_pageData.GetMarginTopLeft().y));
+        m_marginTopText->SetValue(wxString::Format(wxT("%d"), m_pageData.GetMarginTopLeft().y));

     if (m_marginRightText)
     if (m_marginRightText)

-        m_marginRightText->SetValue(IntToString((int) m_pageData.GetMarginBottomRight().x));
+        m_marginRightText->SetValue(wxString::Format(wxT("%d"), m_pageData.GetMarginBottomRight().x));

     if (m_marginBottomText)
     if (m_marginBottomText)

-        m_marginBottomText->SetValue(IntToString((int) m_pageData.GetMarginBottomRight().y));
+        m_marginBottomText->SetValue(wxString::Format(wxT("%d"), m_pageData.GetMarginBottomRight().y));

 
     if (m_orientationRadioBox)
     {
 
     if (m_orientationRadioBox)
     {


@@ -732,7 +991,7 @@ bool wxGenericPageSetupDialog::TransferDataToWindow()
         m_paperTypeChoice->SetStringSelection(type->GetName());
     }
 
         m_paperTypeChoice->SetStringSelection(type->GetName());
     }
 

-    return TRUE;
+    return true;

 }
 
 bool wxGenericPageSetupDialog::TransferDataFromWindow()
 }
 
 bool wxGenericPageSetupDialog::TransferDataFromWindow()


@@ -762,13 +1021,13 @@ bool wxGenericPageSetupDialog::TransferDataFromWindow()
             m_pageData.GetPrintData().SetOrientation(wxLANDSCAPE);
         }
     }
             m_pageData.GetPrintData().SetOrientation(wxLANDSCAPE);
         }
     }

-    
+

     if (m_paperTypeChoice)
     {
     if (m_paperTypeChoice)
     {

-        wxString val(m_paperTypeChoice->GetStringSelection());
-        if (!val.IsEmpty())
+        int selectedItem = m_paperTypeChoice->GetSelection();
+        if (selectedItem != -1)

         {
         {

-            wxPrintPaperType* paper = wxThePrintPaperDatabase->FindPaperType(val);
+            wxPrintPaperType *paper = wxThePrintPaperDatabase->Item(selectedItem);

             if ( paper )
             {
                 m_pageData.SetPaperSize(wxSize(paper->GetWidth()/10, paper->GetHeight()/10));
             if ( paper )
             {
                 m_pageData.SetPaperSize(wxSize(paper->GetWidth()/10, paper->GetHeight()/10));


@@ -777,7 +1036,7 @@ bool wxGenericPageSetupDialog::TransferDataFromWindow()
         }
     }
 
         }
     }
 

-    return TRUE;
+    return true;

 }
 
 wxComboBox *wxGenericPageSetupDialog::CreatePaperTypeChoice(int *x, int *y)
 }
 
 wxComboBox *wxGenericPageSetupDialog::CreatePaperTypeChoice(int *x, int *y)


@@ -795,7 +1054,7 @@ wxComboBox *wxGenericPageSetupDialog::CreatePaperTypeChoice(int *x, int *y)
 
     for (size_t i = 0; i < n; i++)
     {
 
     for (size_t i = 0; i < n; i++)
     {

-        wxPrintPaperType *paper = (wxPrintPaperType *)wxThePrintPaperDatabase->Item(i)->GetData();
+        wxPrintPaperType *paper = wxThePrintPaperDatabase->Item(i);

         choices[i] = paper->GetName();
     }
 
         choices[i] = paper->GetName();
     }
 


@@ -806,7 +1065,7 @@ wxComboBox *wxGenericPageSetupDialog::CreatePaperTypeChoice(int *x, int *y)
                                          wxPRINTID_PAPERSIZE,
                                          _("Paper Size"),
                                          wxPoint(*x, *y),
                                          wxPRINTID_PAPERSIZE,
                                          _("Paper Size"),
                                          wxPoint(*x, *y),

-                                         wxSize(300, -1),
+                                         wxSize(300, wxDefaultCoord),

                                          n, choices );
     *y += 35;
     delete[] choices;
                                          n, choices );
     *y += 35;
     delete[] choices;