Don't infinitely recurse when setting the child focus. Without

[wxWidgets.git] / include / wx / cocoa / colour.h

diff --git a/include/wx/cocoa/colour.h b/include/wx/cocoa/colour.h
index d0eb9d14f3dc5d6fcd8b00200a0702631849cb36..3b1fe9706a4d6d620793c7eaba5d8ceb94ef0e14 100644 (file)
--- a/include/wx/cocoa/colour.h
+++ b/include/wx/cocoa/colour.h
@@ -21,11 +21,8 @@
 class WXDLLEXPORT wxColour: public wxObject
 {
 public:
-    DECLARE_DYNAMIC_CLASS(wxColour)
-// ------------------------------------------------------------------------
-// initialization
-// ------------------------------------------------------------------------
-    wxColour();
+    wxColour() { Init(); }
+
     // from RGB
     wxColour( unsigned char red, unsigned char green, unsigned char blue )
     :   m_cocoaNSColor(NULL)
@@ -33,26 +30,22 @@ public:
     wxColour( unsigned long colRGB )
     :   m_cocoaNSColor(NULL)
     {   Set(colRGB); }
-  
+
     // implicit conversion from the colour name
     wxColour( const wxString &colourName )
-    :   m_cocoaNSColor(NULL)
     {   InitFromName(colourName); }
     wxColour( const char *colourName )
-    :   m_cocoaNSColor(NULL)
     {   InitFromName(wxString::FromAscii(colourName)); }
 
     // copy ctors and assignment operators
     wxColour( const wxColour& col );
     wxColour& operator = ( const wxColour& col );
 
-    ~wxColour();
+    virtual ~wxColour();
 
-// ------------------------------------------------------------------------
-// Implementation
-// ------------------------------------------------------------------------
     // accessors
     bool Ok() const { return m_cocoaNSColor; }
+    WX_NSColor GetNSColor() { return m_cocoaNSColor; }
 
     unsigned char Red() const { return m_red; }
     unsigned char Green() const { return m_green; }
@@ -61,16 +54,15 @@ public:
     // comparison
     bool operator == (const wxColour& colour) const
     {
-        return (m_cocoaNSColor == colour.m_cocoaNSColor &&
-            m_red == colour.m_red && 
-            m_green == colour.m_green && 
-            m_blue == colour.m_blue);
+        // VZ: sure we want to compare NSColor objects for equality here?
+        return (m_cocoaNSColor == colour.m_cocoaNSColor
+            && m_red == colour.m_red
+            && m_green == colour.m_green
+            && m_blue == colour.m_blue);
     }
     bool operator != (const wxColour& colour) const
     {   return !(*this == colour); }
 
-//  const WXCOLORREF& GetPixel() const { return m_pixel; };
-
     // Set() functions
     void Set( unsigned char red, unsigned char green, unsigned char blue );
     void Set( unsigned long colRGB )
@@ -83,6 +75,10 @@ public:
     }
 
 protected:
+    // puts the object in an invalid, uninitialized state
+    void Init();
+
+    // create the object from name, leaves it uninitialized if it failed
     void InitFromName(const wxString& col);
 
 private:
@@ -90,6 +86,8 @@ private:
     unsigned char m_red;
     unsigned char m_green;
     unsigned char m_blue;
+
+    DECLARE_DYNAMIC_CLASS(wxColour)
 };
 
 #endif // __WX_COCOA_COLOUR_H__