#include "wx/univ/renderer.h"
#endif // __WXUNIVERSAL__
-// there is no src/mgl/popupwin.cpp to put this in, so we do it here - BTW we
-// probably could do it for all ports here just as well
-#if defined(__WXMGL__)
- IMPLEMENT_DYNAMIC_CLASS(wxPopupWindow, wxWindow)
-#endif // __WXMSW__
+#ifdef __WXGTK__
+ #include <gtk/gtk.h>
+#endif
+#ifdef __WXX11__
+#include "wx/x11/private.h"
+#endif
+IMPLEMENT_DYNAMIC_CLASS(wxPopupWindow, wxWindow)
IMPLEMENT_DYNAMIC_CLASS(wxPopupTransientWindow, wxPopupWindow)
#if wxUSE_COMBOBOX && defined(__WXUNIVERSAL__)
class wxPopupWindowHandler : public wxEvtHandler
{
public:
- wxPopupWindowHandler(wxPopupTransientWindow *popup) { m_popup = popup; }
+ wxPopupWindowHandler(wxPopupTransientWindow *popup) : m_popup(popup) {}
+ ~wxPopupWindowHandler();
protected:
// event handlers
class wxPopupFocusHandler : public wxEvtHandler
{
public:
- wxPopupFocusHandler(wxPopupTransientWindow *popup)
- {
- m_popup = popup;
-
-#ifdef __WXGTK__
- // ignore the next few OnKillFocus() calls
- m_creationTime = time(NULL);
-#endif // __WXGTK__
- }
+ wxPopupFocusHandler(wxPopupTransientWindow *popup) : m_popup(popup) {}
+ ~wxPopupFocusHandler();
protected:
- // event handlers
void OnKillFocus(wxFocusEvent& event);
void OnKeyDown(wxKeyEvent& event);
private:
wxPopupTransientWindow *m_popup;
- // hack around wxGTK bug: we always get several kill focus events
- // immediately after creation!
-#ifdef __WXGTK__
- time_t m_creationTime;
-#endif // __WXGTK__
-
DECLARE_EVENT_TABLE()
DECLARE_NO_COPY_CLASS(wxPopupFocusHandler)
};
EVT_KEY_DOWN(wxPopupFocusHandler::OnKeyDown)
END_EVENT_TABLE()
+BEGIN_EVENT_TABLE(wxPopupTransientWindow, wxPopupWindow)
+#ifdef __WXMSW__
+ EVT_IDLE(wxPopupTransientWindow::OnIdle)
+#endif
+END_EVENT_TABLE()
+
// ============================================================================
// implementation
// ============================================================================
bool wxPopupWindowBase::Create(wxWindow* WXUNUSED(parent), int WXUNUSED(flags))
{
- return TRUE;
+ return true;
}
void wxPopupWindowBase::Position(const wxPoint& ptOrigin,
wxPopupTransientWindow::~wxPopupTransientWindow()
{
- PopHandlers();
-#ifndef __WXX11__
+ if (m_handlerPopup && m_handlerPopup->GetNextHandler())
+ PopHandlers();
+
+ wxASSERT(!m_handlerFocus || !m_handlerFocus->GetNextHandler());
+ wxASSERT(!m_handlerPopup || !m_handlerPopup->GetNextHandler());
+
delete m_handlerFocus;
-#endif
delete m_handlerPopup;
}
// handler - so don't risk deleting it second time
m_handlerPopup = NULL;
}
-
- m_child->ReleaseMouse();
+ if (m_child->HasCapture())
+ {
+ m_child->ReleaseMouse();
+ }
m_child = NULL;
}
if ( m_focus )
{
-#ifndef __WXX11__
if ( !m_focus->RemoveEventHandler(m_handlerFocus) )
{
// see above
m_handlerFocus = NULL;
}
-#endif
- m_focus = NULL;
}
+ m_focus = NULL;
}
void wxPopupTransientWindow::Popup(wxWindow *winFocus)
m_child = this;
}
- // we can't capture mouse before the window is shown in wxGTK, so do it
- // first
Show();
- delete m_handlerPopup;
- m_handlerPopup = new wxPopupWindowHandler(this);
+ // There is is a problem if these are still in use
+ wxASSERT(!m_handlerFocus || !m_handlerFocus->GetNextHandler());
+ wxASSERT(!m_handlerPopup || !m_handlerPopup->GetNextHandler());
+
+ if (!m_handlerPopup)
+ m_handlerPopup = new wxPopupWindowHandler(this);
- m_child->CaptureMouse();
m_child->PushEventHandler(m_handlerPopup);
m_focus = winFocus ? winFocus : this;
m_focus->SetFocus();
-#ifndef __WXX11__
-
#ifdef __WXMSW__
// MSW doesn't allow to set focus to the popup window, but we need to
// subclass the window which has the focus, and not winFocus passed in or
// otherwise everything else breaks down
m_focus = FindFocus();
+#elif __WXGTK__
+ // GTK+ catches the activate events from the popup
+ // window, not the focus events from the child window
+ m_focus = this;
+#endif
+
if ( m_focus )
-#endif // __WXMSW__
{
- delete m_handlerFocus;
- m_handlerFocus = new wxPopupFocusHandler(this);
+ if (!m_handlerFocus)
+ m_handlerFocus = new wxPopupFocusHandler(this);
m_focus->PushEventHandler(m_handlerFocus);
}
-#endif // !__WXX11__
+ // catch destroy events, if you close a program with a popup shown in MSW
+ // you get a segfault if m_child or m_focus are deleted before this is
+ m_child->Connect(wxEVT_DESTROY,
+ wxWindowDestroyEventHandler(wxPopupTransientWindow::OnDestroy),
+ NULL, this);
+ if (m_focus)
+ m_focus->Connect(wxEVT_DESTROY,
+ wxWindowDestroyEventHandler(wxPopupTransientWindow::OnDestroy),
+ NULL, this);
}
-void wxPopupTransientWindow::Dismiss()
+bool wxPopupTransientWindow::Show( bool show )
{
- PopHandlers();
+#ifdef __WXGTK__
+ if (!show)
+ {
+ gdk_pointer_ungrab( (guint32)GDK_CURRENT_TIME );
+
+ gtk_grab_remove( m_widget );
+ }
+#endif
+
+#ifdef __WXX11__
+ if (!show)
+ {
+ XUngrabPointer( wxGlobalDisplay(), CurrentTime );
+ }
+#endif
+
+#ifdef __WXMSW__
+ if (!show && m_child && m_child->HasCapture())
+ {
+ m_child->ReleaseMouse();
+ }
+#endif
+
+ bool ret = wxPopupWindow::Show( show );
+
+#ifdef __WXGTK__
+ if (show)
+ {
+ gtk_grab_add( m_widget );
+
+ gdk_pointer_grab( m_widget->window, TRUE,
+ (GdkEventMask)
+ (GDK_BUTTON_PRESS_MASK |
+ GDK_BUTTON_RELEASE_MASK |
+ GDK_POINTER_MOTION_HINT_MASK |
+ GDK_POINTER_MOTION_MASK),
+ (GdkWindow *) NULL,
+ (GdkCursor *) NULL,
+ (guint32)GDK_CURRENT_TIME );
+ }
+#endif
+#ifdef __WXX11__
+ if (show)
+ {
+ Window xwindow = (Window) m_clientWindow;
+
+ /* int res =*/ XGrabPointer(wxGlobalDisplay(), xwindow,
+ True,
+ ButtonPressMask | ButtonReleaseMask | ButtonMotionMask | EnterWindowMask | LeaveWindowMask | PointerMotionMask,
+ GrabModeAsync,
+ GrabModeAsync,
+ None,
+ None,
+ CurrentTime );
+ }
+#endif
+
+#ifdef __WXMSW__
+ if (show && m_child)
+ {
+ // Assume that the mouse is outside the popup to begin with
+ m_child->CaptureMouse();
+ }
+#endif
+
+ return ret;
+}
+
+void wxPopupTransientWindow::Dismiss()
+{
Hide();
+ PopHandlers();
}
void wxPopupTransientWindow::DismissAndNotify()
{
Dismiss();
-
OnDismiss();
}
bool wxPopupTransientWindow::ProcessLeftDown(wxMouseEvent& WXUNUSED(event))
{
// no special processing here
- return FALSE;
+ return false;
+}
+
+void wxPopupTransientWindow::OnDestroy(wxWindowDestroyEvent& event)
+{
+ if (event.GetEventObject() == m_child)
+ m_child = NULL;
+ if (event.GetEventObject() == m_focus)
+ m_focus = NULL;
}
+#ifdef __WXMSW__
+void wxPopupTransientWindow::OnIdle(wxIdleEvent& event)
+{
+ event.Skip();
+
+ if (IsShown() && m_child)
+ {
+ wxPoint pos = ScreenToClient(wxGetMousePosition());
+ wxRect rect(GetSize());
+
+ if ( rect.Inside(pos) )
+ {
+ if ( m_child->HasCapture() )
+ {
+ m_child->ReleaseMouse();
+ }
+ }
+ else
+ {
+ if ( !m_child->HasCapture() )
+ {
+ m_child->CaptureMouse();
+ }
+ }
+ }
+}
+#endif
+
+
#if wxUSE_COMBOBOX && defined(__WXUNIVERSAL__)
// ----------------------------------------------------------------------------
void wxPopupComboWindow::PositionNearCombo()
{
// the origin point must be in screen coords
- wxPoint ptOrigin = m_combo->ClientToScreen(wxPoint(0, 0));
+ wxPoint ptOrigin = m_combo->ClientToScreen(wxPoint(0,0));
#if 0 //def __WXUNIVERSAL__
// account for the fact that (0, 0) is not the top left corner of the
// ----------------------------------------------------------------------------
// wxPopupWindowHandler
// ----------------------------------------------------------------------------
+wxPopupWindowHandler::~wxPopupWindowHandler()
+{
+ if (m_popup && (m_popup->m_handlerPopup == this))
+ m_popup->m_handlerPopup = NULL;
+}
void wxPopupWindowHandler::OnLeftDown(wxMouseEvent& event)
{
wxPoint pos = event.GetPosition();
- // scrollbar on which the click occured
+ // scrollbar on which the click occurred
wxWindow *sbar = NULL;
wxWindow *win = (wxWindow *)event.GetEventObject();
// ----------------------------------------------------------------------------
// wxPopupFocusHandler
// ----------------------------------------------------------------------------
+wxPopupFocusHandler::~wxPopupFocusHandler()
+{
+ if (m_popup && (m_popup->m_handlerFocus == this))
+ m_popup->m_handlerFocus = NULL;
+}
void wxPopupFocusHandler::OnKillFocus(wxFocusEvent& event)
{
-#ifdef __WXGTK__
- // ignore the next OnKillFocus() call
- if ( time(NULL) < m_creationTime + 1 )
- {
- event.Skip();
-
- return;
- }
-#endif // __WXGTK__
-
// when we lose focus we always disappear - unless it goes to the popup (in
// which case we don't really lose it)
wxWindow *win = event.GetWindow();
projects / wxWidgets.git / blobdiff