Add support for wxSL_INVERSE flag. Also uses new inverse logic to make Mac vertical...

[wxWidgets.git] / src / common / gifdecod.cpp

diff --git a/src/common/gifdecod.cpp b/src/common/gifdecod.cpp
index db32b8fa2552c5e04d3bed0fb0eddf8dc1c2e592..c9cfe9b16ec1e2fbea84df6901e7d6a2c77d6ffa 100644 (file)
--- a/src/common/gifdecod.cpp
+++ b/src/common/gifdecod.cpp
@@ -8,7 +8,7 @@
 // Licence:     wxWindows licence
 /////////////////////////////////////////////////////////////////////////////
 
 // Licence:     wxWindows licence
 /////////////////////////////////////////////////////////////////////////////
 

-#ifdef __GNUG__
+#if defined(__GNUG__) && !defined(NO_GCC_PRAGMA)

 #pragma implementation "gifdecod.h"
 #endif
 
 #pragma implementation "gifdecod.h"
 #endif
 


@@ -21,6 +21,7 @@
 
 #ifndef WX_PRECOMP
 #  include "wx/defs.h"
 
 #ifndef WX_PRECOMP
 #  include "wx/defs.h"

+#  include "wx/palette.h"

 #endif
 
 #if wxUSE_STREAMS && wxUSE_GIF
 #endif
 
 #if wxUSE_STREAMS && wxUSE_GIF


@@ -115,7 +116,7 @@ bool wxGIFDecoder::ConvertToImage(wxImage *image) const
     image->Create(GetWidth(), GetHeight());
 
     if (!image->Ok())
     image->Create(GetWidth(), GetHeight());
 
     if (!image->Ok())

-        return FALSE;
+        return false;

 
     pal = GetPalette();
     src = GetData();
 
     pal = GetPalette();
     src = GetData();


@@ -142,7 +143,7 @@ bool wxGIFDecoder::ConvertToImage(wxImage *image) const
         image->SetMaskColour(255, 0, 255);
     }
     else
         image->SetMaskColour(255, 0, 255);
     }
     else

-        image->SetMask(FALSE);
+        image->SetMask(false);

 
 #if wxUSE_PALETTE
     if (pal)
 
 #if wxUSE_PALETTE
     if (pal)


@@ -170,7 +171,7 @@ bool wxGIFDecoder::ConvertToImage(wxImage *image) const
         *(dst++) = pal[3 * (*src) + 2];
     }
 
         *(dst++) = pal[3 * (*src) + 2];
     }
 

-    return TRUE;
+    return true;

 }
 
 
 }
 
 


@@ -207,27 +208,27 @@ bool wxGIFDecoder::IsAnimation() const          { return (m_nimages > 1); }
 bool wxGIFDecoder::GoFirstFrame()
 {
     if (!IsAnimation())
 bool wxGIFDecoder::GoFirstFrame()
 {
     if (!IsAnimation())

-        return FALSE;
+        return false;

 
     m_image = 1;
     m_pimage = m_pfirst;
 
     m_image = 1;
     m_pimage = m_pfirst;

-    return TRUE;
+    return true;

 }
 
 bool wxGIFDecoder::GoLastFrame()
 {
     if (!IsAnimation())
 }
 
 bool wxGIFDecoder::GoLastFrame()
 {
     if (!IsAnimation())

-        return FALSE;
+        return false;

 
     m_image = m_nimages;
     m_pimage = m_plast;
 
     m_image = m_nimages;
     m_pimage = m_plast;

-    return TRUE;
+    return true;

 }
 
 bool wxGIFDecoder::GoNextFrame(bool cyclic)
 {
     if (!IsAnimation())
 }
 
 bool wxGIFDecoder::GoNextFrame(bool cyclic)
 {
     if (!IsAnimation())

-        return FALSE;
+        return false;

 
     if ((m_image < m_nimages) || (cyclic))
     {
 
     if ((m_image < m_nimages) || (cyclic))
     {


@@ -240,16 +241,16 @@ bool wxGIFDecoder::GoNextFrame(bool cyclic)
             m_pimage = m_pfirst;
         }
 
             m_pimage = m_pfirst;
         }
 

-        return TRUE;
+        return true;

     }
     else
     }
     else

-        return FALSE;
+        return false;

 }
 
 bool wxGIFDecoder::GoPrevFrame(bool cyclic)
 {
     if (!IsAnimation())
 }
 
 bool wxGIFDecoder::GoPrevFrame(bool cyclic)
 {
     if (!IsAnimation())

-        return FALSE;
+        return false;

 
     if ((m_image > 1) || (cyclic))
     {
 
     if ((m_image > 1) || (cyclic))
     {


@@ -262,10 +263,10 @@ bool wxGIFDecoder::GoPrevFrame(bool cyclic)
             m_pimage = m_plast;
         }
 
             m_pimage = m_plast;
         }
 

-        return TRUE;
+        return true;

     }
     else
     }
     else

-        return FALSE;
+        return false;

 }
 
 bool wxGIFDecoder::GoFrame(int which)
 }
 
 bool wxGIFDecoder::GoFrame(int which)


@@ -273,19 +274,19 @@ bool wxGIFDecoder::GoFrame(int which)
     int i;
 
     if (!IsAnimation())
     int i;
 
     if (!IsAnimation())

-        return FALSE;
+        return false;

 
     if ((which >= 1) && (which <= m_nimages))
     {
         m_pimage = m_pfirst;
 
 
     if ((which >= 1) && (which <= m_nimages))
     {
         m_pimage = m_pfirst;
 

-        for (i = 1; i < which; i++)
+        for (i = 0; i < which; i++)

             m_pimage = m_pimage->next;
 
             m_pimage = m_pimage->next;
 

-        return TRUE;
+        return true;

     }
     else
     }
     else

-        return FALSE;
+        return false;

 }
 
 
 }
 
 


@@ -456,6 +457,15 @@ int wxGIFDecoder::dgif(GIFImage *img, int interl, int bits)
                 return wxGIF_INVFORMAT;
             }
         }
                 return wxGIF_INVFORMAT;
             }
         }

+
+        if (pos >= allocSize)
+        {
+            delete[] ab_prefix;
+            delete[] ab_tail;
+            delete[] stack;
+            return wxGIF_INVFORMAT;
+        }
+

         stack[pos] = code;              /* push last code into the stack */
         abcabca    = code;              /* save for special case */
 
         stack[pos] = code;              /* push last code into the stack */
         abcabca    = code;              /* save for special case */
 


@@ -473,18 +483,11 @@ int wxGIFDecoder::dgif(GIFImage *img, int interl, int bits)
             }
         }
 
             }
         }
 

-        /* dump stack data to the buffer */
+        /* dump stack data to the image buffer */

         while (pos >= 0)
         {
         while (pos >= 0)
         {

-            if (pos >= allocSize)
-            {
-                delete[] ab_prefix;
-                delete[] ab_tail;
-                delete[] stack;
-                return wxGIF_INVFORMAT;
-            }
-
-            (img->p)[x + (y * (img->w))] = (char)stack[pos--];
+            (img->p)[x + (y * (img->w))] = (char) stack[pos];
+            pos--;

 
             if (++x >= (img->w))
             {
 
             if (++x >= (img->w))
             {


@@ -500,13 +503,50 @@ int wxGIFDecoder::dgif(GIFImage *img, int interl, int bits)
                         case 3: y += 4; break;
                         case 4: y += 2; break;
                     }
                         case 3: y += 4; break;
                         case 4: y += 2; break;
                     }

-                    if (y >= (img->h))
+
+                    /* loop until a valid y coordinate has been
+                    found, Or if the maximum number of passes has
+                    been reached, exit the loop, and stop image
+                    decoding (At this point the image is succesfully
+                    decoded).
+                    If we don't loop, but merely set y to some other
+                    value, that new value might still be invalid depending
+                    on the height of the image. This would cause out of
+                    bounds writing.
+                    */
+                    while (y >= (img->h))

                     {
                         switch (++pass)
                         {
                             case 2: y = 4; break;
                             case 3: y = 2; break;
                             case 4: y = 1; break;
                     {
                         switch (++pass)
                         {
                             case 2: y = 4; break;
                             case 3: y = 2; break;
                             case 4: y = 1; break;

+
+                            default:
+                                /*
+                                It's possible we arrive here. For example this
+                                happens when the image is interlaced, and the
+                                height is 1. Looking at the above cases, the
+                                lowest possible y is 1. While the only valid
+                                one would be 0 for an image of height 1. So
+                                'eventually' the loop will arrive here.
+                                This case makes sure this while loop is
+                                exited, as well as the 2 other ones.
+                                */
+
+                                // Set y to a valid coordinate so the local
+                                // while loop will be exited. (y = 0 always
+                                // is >= img->h since if img->h == 0 the
+                                // image is never decoded)
+                                y = 0;
+
+                                // This will exit the other outer while loop
+                                pos = -1;
+
+                                // This will halt image decoding.
+                                code = ab_fin;
+
+                                break;

                         }
                     }
                 }
                         }
                     }
                 }


@@ -572,16 +612,18 @@ as an End of Information itself)
 
 
 // CanRead:
 
 
 // CanRead:

-//  Returns TRUE if the file looks like a valid GIF, FALSE otherwise.
+//  Returns true if the file looks like a valid GIF, false otherwise.

 //
 bool wxGIFDecoder::CanRead()
 {
     unsigned char buf[3];
 
 //
 bool wxGIFDecoder::CanRead()
 {
     unsigned char buf[3];
 

-    m_f->Read(buf, 3);
-    m_f->SeekI(-3, wxFromCurrent);
+    if ( !m_f->Read(buf, WXSIZEOF(buf)) )
+        return false;
+
+    m_f->SeekI(-(wxFileOffset)WXSIZEOF(buf), wxFromCurrent);

 
 

-    return (memcmp(buf, "GIF", 3) == 0);
+    return memcmp(buf, "GIF", WXSIZEOF(buf)) == 0;

 }
 
 
 }
 
 


@@ -621,7 +663,7 @@ int wxGIFDecoder::ReadGIF()
 
     if (memcmp(buf + 3, "89a", 3) < 0)
     {
 
     if (memcmp(buf + 3, "89a", 3) < 0)
     {

-        m_anim = FALSE;
+        m_anim = false;

     }
 
     /* read logical screen descriptor block (LSDB) */
     }
 
     /* read logical screen descriptor block (LSDB) */


@@ -659,7 +701,7 @@ int wxGIFDecoder::ReadGIF()
     pprev = NULL;
     pimg  = NULL;
 
     pprev = NULL;
     pimg  = NULL;
 

-    bool done = FALSE;
+    bool done = false;

 
     while(!done)
     {
 
     while(!done)
     {


@@ -685,7 +727,7 @@ int wxGIFDecoder::ReadGIF()
         /* end of data? */
         if (type == 0x3B)
         {
         /* end of data? */
         if (type == 0x3B)
         {

-            done = TRUE;
+            done = true;

         }
         else
         /* extension block? */
         }
         else
         /* extension block? */


@@ -720,7 +762,7 @@ int wxGIFDecoder::ReadGIF()
                     m_f->SeekI(i, wxFromCurrent);
                     if (m_f->Eof())
                     {
                     m_f->SeekI(i, wxFromCurrent);
                     if (m_f->Eof())
                     {

-                        done = TRUE;
+                        done = true;

                         break;
                     }
                 }
                         break;
                     }
                 }


@@ -815,7 +857,7 @@ int wxGIFDecoder::ReadGIF()
 
             /* if this is not an animated GIF, exit after first image */
             if (!m_anim)
 
             /* if this is not an animated GIF, exit after first image */
             if (!m_anim)

-                done = TRUE;
+                done = true;

         }
     }
 
         }
     }
 


@@ -864,8 +906,8 @@ int wxGIFDecoder::ReadGIF()
             if ((buf[8] & 0x80) == 0x80)
             {
                 ncolors = 2 << (buf[8] & 0x07);
             if ((buf[8] & 0x80) == 0x80)
             {
                 ncolors = 2 << (buf[8] & 0x07);

-                off_t pos = m_f->TellI();
-                off_t numBytes = 3 * ncolors;
+                wxFileOffset pos = m_f->TellI();
+                wxFileOffset numBytes = 3 * ncolors;

                 m_f->SeekI(numBytes, wxFromCurrent);
                 if (m_f->TellI() != (pos + numBytes))
                 {
                 m_f->SeekI(numBytes, wxFromCurrent);
                 if (m_f->TellI() != (pos + numBytes))
                 {