erase separators shown behind the controls added to the toolbar

[wxWidgets.git] / src / msw / statbmp.cpp

diff --git a/src/msw/statbmp.cpp b/src/msw/statbmp.cpp
index 7c5c1397d601d27a3582279b023a8ec684863385..a93d50a7a5077e4e815e3327b83f08ecf15e64e7 100644 (file)
--- a/src/msw/statbmp.cpp
+++ b/src/msw/statbmp.cpp
@@ -28,20 +28,23 @@
     #pragma hdrstop
 #endif
 
     #pragma hdrstop
 #endif
 

+#if wxUSE_STATBMP
+
+#include "wx/window.h"
+#include "wx/msw/private.h"
+

 #ifndef WX_PRECOMP
 #ifndef WX_PRECOMP

+    #include "wx/icon.h"

     #include "wx/statbmp.h"
 #endif
 
 #include <stdio.h>
     #include "wx/statbmp.h"
 #endif
 
 #include <stdio.h>

-#include "wx/msw/private.h"

 
 // ---------------------------------------------------------------------------
 // macors
 // ---------------------------------------------------------------------------
 
 
 // ---------------------------------------------------------------------------
 // macors
 // ---------------------------------------------------------------------------
 

-#if !USE_SHARED_LIBRARY
-    IMPLEMENT_DYNAMIC_CLASS(wxStaticBitmap, wxControl)
-#endif
+IMPLEMENT_DYNAMIC_CLASS(wxStaticBitmap, wxControl)

 
 // ===========================================================================
 // implementation
 
 // ===========================================================================
 // implementation


@@ -51,8 +54,44 @@
 // wxStaticBitmap
 // ---------------------------------------------------------------------------
 
 // wxStaticBitmap
 // ---------------------------------------------------------------------------
 

+// we may have either bitmap or icon: if a bitmap with mask is passed, we
+// will transform it to an icon ourselves because otherwise the mask will
+// be ignored by Windows
+// note that this function will create a new object every time
+// it is called even if the image needs no conversion
+
+#ifndef __WIN16__
+
+static wxGDIImage* ConvertImage( const wxGDIImage& bitmap )
+{
+    bool isIcon = bitmap.IsKindOf( CLASSINFO(wxIcon) );
+
+    if( !isIcon )
+    {
+        wxASSERT_MSG( wxDynamicCast(&bitmap, wxBitmap),
+                      _T("not an icon and not a bitmap?") );
+
+        const wxBitmap& bmp = (const wxBitmap&)bitmap;
+        wxMask *mask = bmp.GetMask();
+        if ( mask && mask->GetMaskBitmap() )
+        {
+            wxIcon* icon = new wxIcon;
+            icon->CopyFromBitmap(bmp);
+
+            return icon;
+        }
+
+        return new wxBitmap( bmp );
+    }
+
+    // copying a bitmap is a cheap operation
+    return new wxIcon( (const wxIcon&)bitmap );
+}
+
+#endif
+

 bool wxStaticBitmap::Create(wxWindow *parent, wxWindowID id,
 bool wxStaticBitmap::Create(wxWindow *parent, wxWindowID id,

-                            const wxBitmap& bitmap,
+                            const wxGDIImage& bitmap,

                             const wxPoint& pos,
                             const wxSize& size,
                             long style,
                             const wxPoint& pos,
                             const wxSize& size,
                             long style,


@@ -79,23 +118,42 @@ bool wxStaticBitmap::Create(wxWindow *parent, wxWindowID id,
 
     m_windowStyle = style;
 
 
     m_windowStyle = style;
 

+    // we may have either bitmap or icon: if a bitmap with mask is passed, we
+    // will transform it to an icon ourselves because otherwise the mask will
+    // be ignored by Windows
+    wxGDIImage *image = (wxGDIImage *)NULL;

     m_isIcon = bitmap.IsKindOf(CLASSINFO(wxIcon));
 
     m_isIcon = bitmap.IsKindOf(CLASSINFO(wxIcon));
 

+#ifdef __WIN16__
+    wxASSERT_MSG( !m_isIcon, "Icons are not supported in wxStaticBitmap under WIN16." );
+    image = &bitmap;
+#endif
+
+#ifndef __WIN16__
+    image = ConvertImage( bitmap );
+    m_isIcon = image->IsKindOf( CLASSINFO(wxIcon) );
+#endif
+

 #ifdef __WIN32__
     // create a static control with either SS_BITMAP or SS_ICON style depending
     // on what we have here
 #ifdef __WIN32__
     // create a static control with either SS_BITMAP or SS_ICON style depending
     // on what we have here

-    const char *classname = "STATIC";
+    const wxChar *classname = wxT("STATIC");

     int winstyle = m_isIcon ? SS_ICON : SS_BITMAP;
 #else // Win16
     int winstyle = m_isIcon ? SS_ICON : SS_BITMAP;
 #else // Win16

-    const char *classname = "BUTTON";
+    const wxChar *classname = wxT("BUTTON");

     int winstyle = BS_OWNERDRAW;
 #endif // Win32
 
     int winstyle = BS_OWNERDRAW;
 #endif // Win32
 

+    if ( m_windowStyle & wxCLIP_SIBLINGS )
+        winstyle |= WS_CLIPSIBLINGS;
+
+

     m_hWnd = (WXHWND)::CreateWindow
                        (
                         classname,
     m_hWnd = (WXHWND)::CreateWindow
                        (
                         classname,

-                        "",
-                        winstyle | WS_CHILD | WS_VISIBLE,
+                        wxT(""),
+                        // NOT DISABLED!!! We want to move it in Dialog Editor.
+                        winstyle | WS_CHILD | WS_VISIBLE /* | WS_CLIPSIBLINGS */ , // | WS_DISABLED,

                         0, 0, 0, 0,
                         (HWND)parent->GetHWND(),
                         (HMENU)m_windowId,
                         0, 0, 0, 0,
                         (HWND)parent->GetHWND(),
                         (HMENU)m_windowId,


@@ -103,9 +161,10 @@ bool wxStaticBitmap::Create(wxWindow *parent, wxWindowID id,
                         NULL
                        );
 
                         NULL
                        );
 

-    wxCHECK_MSG( m_hWnd, FALSE, "Failed to create static bitmap" );
+    wxCHECK_MSG( m_hWnd, FALSE, wxT("Failed to create static bitmap") );

 
 

-    SetBitmap(bitmap);
+    // no need to delete the new image
+    SetImageNoCopy( image );

 
     // Subclass again for purposes of dialog editing mode
     SubclassWin(m_hWnd);
 
     // Subclass again for purposes of dialog editing mode
     SubclassWin(m_hWnd);


@@ -119,93 +178,70 @@ bool wxStaticBitmap::Create(wxWindow *parent, wxWindowID id,
 
 bool wxStaticBitmap::ImageIsOk() const
 {
 
 bool wxStaticBitmap::ImageIsOk() const
 {

-    if ( m_isIcon && m_image.icon )
-        return m_image.icon->Ok();
-    else if ( m_image.bitmap )
-        return m_image.bitmap->Ok();
-    else
-        return FALSE;
+    return m_image && m_image->Ok();

 }
 
 void wxStaticBitmap::Free()
 {
 }
 
 void wxStaticBitmap::Free()
 {

-    if ( m_isIcon )
-        delete m_image.icon;
-    else
-        delete m_image.bitmap;
+    delete m_image;

 
 

-    m_image.icon = NULL;
+    m_image = NULL;

 }
 
 }
 

-void wxStaticBitmap::DoSetSize(int x, int y, int width, int height, int sizeFlags)
+wxSize wxStaticBitmap::DoGetBestSize() const

 {
 {

-    int currentX, currentY;
-    GetPosition(&currentX, &currentY);
-    int x1 = x;
-    int y1 = y;
-
-    if (x == -1 || (sizeFlags & wxSIZE_ALLOW_MINUS_ONE))
-        x1 = currentX;
-    if (y == -1 || (sizeFlags & wxSIZE_ALLOW_MINUS_ONE))
-        y1 = currentY;
-
-    AdjustForParentClientOrigin(x1, y1, sizeFlags);
-
-    int actualWidth = width;
-    int actualHeight = height;
-
-    int ww, hh;
-    GetSize(&ww, &hh);
-
-    // If we're prepared to use the existing width, then...
-    if (width == -1 && ((sizeFlags & wxSIZE_AUTO_WIDTH) != wxSIZE_AUTO_WIDTH))
-        actualWidth = ww;
-    else
-        actualWidth = width;
-
-    // If we're prepared to use the existing height, then...
-    if (height == -1 && ((sizeFlags & wxSIZE_AUTO_HEIGHT) != wxSIZE_AUTO_HEIGHT))
-        actualHeight = hh;
-    else
-        actualHeight = height;
+    // reuse the current size (as wxWindow does) instead of using some
+    // arbitrary default size (as wxControl, our immediate base class, does)
+    return wxWindow::DoGetBestSize();
+}

 
 

-    MoveWindow((HWND) GetHWND(), x1, y1, actualWidth, actualHeight, TRUE);
+void wxStaticBitmap::SetImage( const wxGDIImage* image )
+{
+    wxGDIImage* convertedImage = ConvertImage( *image );
+    SetImageNoCopy( convertedImage );

 }
 
 }
 

-void wxStaticBitmap::SetBitmap(const wxBitmap& bitmap)
+void wxStaticBitmap::SetImageNoCopy( wxGDIImage* image)

 {
     Free();
 
 {
     Free();
 

-    m_isIcon = bitmap.IsKindOf(CLASSINFO(wxIcon));
-    if ( m_isIcon )
-        m_image.icon = new wxIcon((const wxIcon&)bitmap);
-    else
-        m_image.bitmap = new wxBitmap(bitmap);
+    m_isIcon = image->IsKindOf( CLASSINFO(wxIcon) );
+    // the image has already been copied
+    m_image = image;

 
     int x, y;
     int w, h;
     GetPosition(&x, &y);
     GetSize(&w, &h);
 
     int x, y;
     int w, h;
     GetPosition(&x, &y);
     GetSize(&w, &h);

-    RECT rect = { x, y, x + w, y + h };

 
 #ifdef __WIN32__
 
 #ifdef __WIN32__

-    HANDLE handle = m_isIcon ? (HANDLE)m_image.icon->GetHICON()
-                             : (HANDLE)m_image.bitmap->GetHBITMAP();
-    ::SendMessage((HWND)m_hWnd, STM_SETIMAGE,
+    HANDLE handle = (HANDLE)m_image->GetHandle();
+    LONG style = ::GetWindowLong( (HWND)GetHWND(), GWL_STYLE ) ;
+    ::SetWindowLong( (HWND)GetHWND(), GWL_STYLE, ( style & ~( SS_BITMAP|SS_ICON ) ) |
+                     ( m_isIcon ? SS_ICON : SS_BITMAP ) );
+    ::SendMessage(GetHwnd(), STM_SETIMAGE,

                   m_isIcon ? IMAGE_ICON : IMAGE_BITMAP, (LPARAM)handle);
 #endif // Win32
 
     if ( ImageIsOk() )
     {
                   m_isIcon ? IMAGE_ICON : IMAGE_BITMAP, (LPARAM)handle);
 #endif // Win32
 
     if ( ImageIsOk() )
     {

-        int width = bitmap.GetWidth(),
-            height = bitmap.GetHeight();
+        int width = image->GetWidth(),
+            height = image->GetHeight();

         if ( width && height )
         {
         if ( width && height )
         {

-            ::MoveWindow((HWND)GetHWND(), x, y, width, height, FALSE);
+            w = width;
+            h = height;
+
+            ::MoveWindow(GetHwnd(), x, y, width, height, FALSE);

         }
     }
 
         }
     }
 

-    InvalidateRect((HWND)GetParent()->GetHWND(), &rect, TRUE);
+    RECT rect;
+    rect.left   = x;
+    rect.top    = y;
+    rect.right  = x + w;
+    rect.bottom = y + h;
+    InvalidateRect(GetHwndOf(GetParent()), &rect, TRUE);

 }
 
 // under Win32 we use the standard static control style for this
 }
 
 // under Win32 we use the standard static control style for this


@@ -214,7 +250,9 @@ bool wxStaticBitmap::MSWOnDraw(WXDRAWITEMSTRUCT *item)
 {
     LPDRAWITEMSTRUCT lpDIS = (LPDRAWITEMSTRUCT) item;
 
 {
     LPDRAWITEMSTRUCT lpDIS = (LPDRAWITEMSTRUCT) item;
 

-    wxBitmap* bitmap = m_image.bitmap;
+    wxCHECK_MSG( !m_isIcon, FALSE, _T("icons not supported in wxStaticBitmap") );
+
+    wxBitmap* bitmap = (wxBitmap *)m_image;

     if ( !bitmap->Ok() )
         return FALSE;
 
     if ( !bitmap->Ok() )
         return FALSE;
 


@@ -243,7 +281,9 @@ bool wxStaticBitmap::MSWOnDraw(WXDRAWITEMSTRUCT *item)
 
     return TRUE;
 }
 
     return TRUE;
 }

+#endif // Win16

 
 

+// We need this or the control can never be moved e.g. in Dialog Editor.

 long wxStaticBitmap::MSWWindowProc(WXUINT nMsg,
                                    WXWPARAM wParam,
                                    WXLPARAM lParam)
 long wxStaticBitmap::MSWWindowProc(WXUINT nMsg,
                                    WXWPARAM wParam,
                                    WXLPARAM lParam)


@@ -255,4 +295,5 @@ long wxStaticBitmap::MSWWindowProc(WXUINT nMsg,
 
     return wxWindow::MSWWindowProc(nMsg, wParam, lParam);
 }
 
     return wxWindow::MSWWindowProc(nMsg, wParam, lParam);
 }

-#endif // Win16
+
+#endif // wxUSE_STATBMP