warning fix for BSD

[wxWidgets.git] / src / gtk1 / radiobox.cpp

diff --git a/src/gtk1/radiobox.cpp b/src/gtk1/radiobox.cpp
index 7463243d03c322c1c8c093391f54cabafd4dde66..37c9f529f2ea800779d6bbcc102239402925b545 100644 (file)
--- a/src/gtk1/radiobox.cpp
+++ b/src/gtk1/radiobox.cpp
@@ -243,29 +243,16 @@ bool wxRadioBox::Create( wxWindow *parent, wxWindowID id, const wxString& title,
 
     m_parent->DoAddChild( this );
 
 
     m_parent->DoAddChild( this );
 

-    PostCreation();
-    InheritAttributes();
-
-    ApplyWidgetStyle();
+    bool wasShown = IsShown();
+    if ( wasShown )
+        Hide(); // prevent PostCreation() from showing us

 
     SetLabel( title );
 
 
     SetLabel( title );
 

-    SetFont( parent->GetFont() );
-
-    wxSize ls = LayoutItems();
-
-    GtkRequisition req;
-    req.width = 2;
-    req.height = 2;
-    (* GTK_WIDGET_CLASS( GTK_OBJECT_GET_CLASS(m_widget) )->size_request ) (m_widget, &req );
-    if (req.width > ls.x) ls.x = req.width;
+    PostCreation(size);

 
 

-    wxSize newSize = size;
-    if (newSize.x == -1) newSize.x = ls.x;
-    if (newSize.y == -1) newSize.y = ls.y;
-    SetSize( newSize.x, newSize.y );
-
-    Show( TRUE );
+    if ( wasShown )
+        Show();

 
     return TRUE;
 }
 
     return TRUE;
 }


@@ -285,25 +272,34 @@ void wxRadioBox::DoSetSize( int x, int y, int width, int height, int sizeFlags )
 {
     wxWindow::DoSetSize( x, y, width, height, sizeFlags );
 
 {
     wxWindow::DoSetSize( x, y, width, height, sizeFlags );
 

-    LayoutItems();
+    LayoutItems(false);

 }
 
 }
 

-wxSize wxRadioBox::LayoutItems()
+wxSize wxRadioBox::DoGetBestSize() const

 {
 {

-    int x = 7;
-    int y = 15;
+    wxSize size = LayoutItems(true);

 
 

-    if ( m_majorDim == 0 )
-    {
-        // avoid dividing by 0 below
-        wxFAIL_MSG( wxT("dimension of radiobox should not be 0!") );
+    GtkRequisition req;
+    req.width = 2;
+    req.height = 2;
+    (* GTK_WIDGET_CLASS( GTK_OBJECT_GET_CLASS(m_widget) )->size_request ) (m_widget, &req );
+    if (req.width > size.x)
+        size.x = req.width;

 
 

-        m_majorDim = 1;
-    }
+    return size;
+}
+
+wxSize wxRadioBox::LayoutItems(bool justCalc) const
+{
+    wxSize res( 0, 0 );
+
+    // avoid dividing by 0 below
+    wxCHECK_MSG( m_majorDim, res, wxT("dimension of radiobox should not be 0!") );

 
     int num_per_major = (m_boxes.GetCount() - 1) / m_majorDim +1;
 
 
     int num_per_major = (m_boxes.GetCount() - 1) / m_majorDim +1;
 

-    wxSize res( 0, 0 );
+    int x = 7;
+    int y = 15;

 
     int num_of_cols = 0;
     int num_of_rows = 0;
 
     int num_of_cols = 0;
     int num_of_rows = 0;


@@ -317,13 +313,16 @@ wxSize wxRadioBox::LayoutItems()
         num_of_cols = num_per_major;
         num_of_rows = m_majorDim;
     }
         num_of_cols = num_per_major;
         num_of_rows = m_majorDim;
     }

-
+    
+    int lineheight = GetCharHeight()+2;
+    

     if ( HasFlag(wxRA_SPECIFY_COLS) ||
          (HasFlag(wxRA_SPECIFY_ROWS) && (num_of_cols > 1)) )
     {
         for (int j = 0; j < num_of_cols; j++)
         {
     if ( HasFlag(wxRA_SPECIFY_COLS) ||
          (HasFlag(wxRA_SPECIFY_ROWS) && (num_of_cols > 1)) )
     {
         for (int j = 0; j < num_of_cols; j++)
         {

-            y = 15;
+            y = 3;
+            y += lineheight;

 
             int max_len = 0;
             wxList::compatibility_iterator node = m_boxes.Item( j*num_of_rows );
 
             int max_len = 0;
             wxList::compatibility_iterator node = m_boxes.Item( j*num_of_rows );


@@ -336,10 +335,11 @@ wxSize wxRadioBox::LayoutItems()
                 req.height = 2;
                 (* GTK_WIDGET_CLASS( GTK_OBJECT_GET_CLASS(button) )->size_request )
                       (button, &req );
                 req.height = 2;
                 (* GTK_WIDGET_CLASS( GTK_OBJECT_GET_CLASS(button) )->size_request )
                       (button, &req );

-
+                      

                 if (req.width > max_len) max_len = req.width;
 
                 if (req.width > max_len) max_len = req.width;
 

-                gtk_pizza_move( GTK_PIZZA(m_parent->m_wxwindow), button, m_x+x, m_y+y );
+                if ( !justCalc )
+                    gtk_pizza_move( GTK_PIZZA(m_parent->m_wxwindow), button, m_x+x, m_y+y );

                 y += req.height;
 
                 node = node->GetNext();
                 y += req.height;
 
                 node = node->GetNext();


@@ -353,7 +353,8 @@ wxSize wxRadioBox::LayoutItems()
             {
                 GtkWidget *button = GTK_WIDGET( node->GetData() );
 
             {
                 GtkWidget *button = GTK_WIDGET( node->GetData() );
 

-                gtk_pizza_resize( GTK_PIZZA(m_parent->m_wxwindow), button, max_len, 20 );
+                if ( !justCalc )
+                    gtk_pizza_resize( GTK_PIZZA(m_parent->m_wxwindow), button, max_len, lineheight );

 
                 node = node->GetNext();
                 if (!node) break;
 
                 node = node->GetNext();
                 if (!node) break;


@@ -392,7 +393,8 @@ wxSize wxRadioBox::LayoutItems()
         {
             GtkWidget *button = GTK_WIDGET( node->GetData() );
 
         {
             GtkWidget *button = GTK_WIDGET( node->GetData() );
 

-            gtk_pizza_set_size( GTK_PIZZA(m_parent->m_wxwindow), button, m_x+x, m_y+y, max, 20 );
+            if ( !justCalc )
+                gtk_pizza_set_size( GTK_PIZZA(m_parent->m_wxwindow), button, m_x+x, m_y+y, max, lineheight );

             x += max;
 
             node = node->GetNext();
             x += max;
 
             node = node->GetNext();


@@ -414,7 +416,7 @@ bool wxRadioBox::Show( bool show )
         return FALSE;
     }
 
         return FALSE;
     }
 

-    if ((m_windowStyle & wxNO_BORDER) != 0)
+    if ( HasFlag(wxNO_BORDER) )

         gtk_widget_hide( m_widget );
 
     wxList::compatibility_iterator node = m_boxes.GetFirst();
         gtk_widget_hide( m_widget );
 
     wxList::compatibility_iterator node = m_boxes.GetFirst();