no changes, just added a TODO comment

[wxWidgets.git] / src / gtk / scrolwin.cpp

diff --git a/src/gtk/scrolwin.cpp b/src/gtk/scrolwin.cpp
index 20c4d1594d2009454e1ff08fdef31ae760447c75..2f9bc568fa66cc6bedc1a9d6da3383a138c91040 100644 (file)
--- a/src/gtk/scrolwin.cpp
+++ b/src/gtk/scrolwin.cpp
@@ -85,62 +85,69 @@ void wxScrollHelperNative::DoAdjustScrollbar(GtkRange* range,
                                              int pixelsPerLine,
                                              int winSize,
                                              int virtSize,
+                                             int *pos,
                                              int *lines,
                                              int *linesPerPage)
 {
+    int upper;
+    int page_size;
     if (pixelsPerLine > 0 && winSize > 0 && winSize < virtSize)
     {
-        int upper = (virtSize + pixelsPerLine - 1) / pixelsPerLine;
-        int page_size = winSize / pixelsPerLine;
-        
+        upper = (virtSize + pixelsPerLine - 1) / pixelsPerLine;
+        page_size = winSize / pixelsPerLine;
         *lines = upper;
         *linesPerPage = page_size;
-
-        GtkAdjustment* adj = range->adjustment;
-        adj->step_increment = 1;
-        adj->page_increment =
-        adj->page_size = page_size;
-        gtk_range_set_range(range, 0, upper);
     }
     else
     {
         // GtkRange won't allow upper == lower, so for disabled state use [0,1]
         //   with a page size of 1. This will also clamp position to 0.
-        int upper = 1;
-        int page_size = 1;
-
+        upper = 1;
+        page_size = 1;
         *lines = 0;
         *linesPerPage = 0;
-
-        GtkAdjustment* adj = range->adjustment;
-        adj->step_increment = 1;
-        adj->page_increment =
-        adj->page_size = page_size;
-        gtk_range_set_range(range, 0, upper);
     }
+
+    GtkAdjustment* adj = range->adjustment;
+    adj->step_increment = 1;
+    adj->page_increment =
+    adj->page_size = page_size;
+    gtk_range_set_range(range, 0, upper);
+
+    // ensure that the scroll position is always in valid range
+    if (*pos > *lines)
+        *pos = *lines;
 }
 
 void wxScrollHelperNative::AdjustScrollbars()
 {
-    int w, h;
     int vw, vh;
+    m_targetWindow->GetVirtualSize(&vw, &vh);
 
-    m_targetWindow->m_hasScrolling = m_xScrollPixelsPerLine != 0 || m_yScrollPixelsPerLine != 0;
+    int w, h;
+    const wxSize availSize = GetSizeAvailableForScrollTarget(
+        m_win->GetSize() - m_win->GetWindowBorderSize());
+    if ( availSize.x >= vw && availSize.y >= vh )
+    {
+        w = availSize.x;
+        h = availSize.y;
+
+        // we know that the scrollbars will be removed
+        DoAdjustHScrollbar(w, vw);
+        DoAdjustVScrollbar(h, vh);
 
-    m_targetWindow->GetVirtualSize( &vw, &vh );
+        return;
+    }
 
     m_targetWindow->GetClientSize(&w, NULL);
-    DoAdjustScrollbar(
-        m_win->m_scrollBar[wxWindow::ScrollDir_Horz], m_xScrollPixelsPerLine,
-        w, vw, &m_xScrollLines, &m_xScrollLinesPerPage);
+    DoAdjustHScrollbar(w, vw);
+
     m_targetWindow->GetClientSize(NULL, &h);
-    DoAdjustScrollbar(
-        m_win->m_scrollBar[wxWindow::ScrollDir_Vert], m_yScrollPixelsPerLine,
-        h, vh, &m_yScrollLines, &m_yScrollLinesPerPage);
+    DoAdjustVScrollbar(h, vh);
 
     const int w_old = w;
     m_targetWindow->GetClientSize(&w, NULL);
-    if (w != w_old)
+    if ( w != w_old )
     {
         // It is necessary to repeat the calculations in this case to avoid an
         // observed infinite series of size events, involving alternating
@@ -149,13 +156,10 @@ void wxScrollHelperNative::AdjustScrollbars()
         // AdjustScrollbars() to be called again. If the scrollbar visibility
         // is not correct before then, yet another resize will occur, possibly
         // leading to an unending series if the sizes are just right.
-        DoAdjustScrollbar(
-            m_win->m_scrollBar[wxWindow::ScrollDir_Horz], m_xScrollPixelsPerLine,
-            w, vw, &m_xScrollLines, &m_xScrollLinesPerPage);
+        DoAdjustHScrollbar(w, vw);
+
         m_targetWindow->GetClientSize(NULL, &h);
-        DoAdjustScrollbar(
-            m_win->m_scrollBar[wxWindow::ScrollDir_Vert], m_yScrollPixelsPerLine,
-            h, vh, &m_yScrollLines, &m_yScrollLinesPerPage);
+        DoAdjustVScrollbar(h, vh);
     }
 }