Applied patch from Neil Robinson to allow manipulation of unattached menubars

[wxWidgets.git] / src / msw / taskbar.cpp

diff --git a/src/msw/taskbar.cpp b/src/msw/taskbar.cpp
index 9c2d0342604232903f6d268cc5b49074a77ffb2a..c5b9b9b5c1bd0c5b3d746b1f7804222676eeaffe 100644 (file)
--- a/src/msw/taskbar.cpp
+++ b/src/msw/taskbar.cpp
@@ -1,19 +1,15 @@
 /////////////////////////////////////////////////////////////////////////
 /////////////////////////////////////////////////////////////////////////

-// File:        taskbar.cpp
-// Purpose:        Implements wxTaskBarIcon class for manipulating icons on
+// File:        src/msw/taskbar.cpp
+// Purpose:     Implements wxTaskBarIcon class for manipulating icons on

 //              the Windows task bar.
 // Author:      Julian Smart
 //              the Windows task bar.
 // Author:      Julian Smart

-// Modified by:
+// Modified by: Vaclav Slavik

 // Created:     24/3/98
 // RCS-ID:      $Id$
 // Copyright:   (c)
 // Created:     24/3/98
 // RCS-ID:      $Id$
 // Copyright:   (c)

-// Licence:    wxWindows licence
+// Licence:     wxWindows licence

 /////////////////////////////////////////////////////////////////////////
 
 /////////////////////////////////////////////////////////////////////////
 

-#ifdef __GNUG__
-#pragma implementation "taskbar.h"
-#endif
-

 // For compilers that support precompilation, includes "wx.h".
 #include "wx/wxprec.h"
 
 // For compilers that support precompilation, includes "wx.h".
 #include "wx/wxprec.h"
 


@@ -23,291 +19,307 @@
 
 #ifndef WX_PRECOMP
 #include "wx/defs.h"
 
 #ifndef WX_PRECOMP
 #include "wx/defs.h"

+#include "wx/window.h"
+#include "wx/frame.h"
+#include "wx/utils.h"
+#include "wx/menu.h"

 #endif
 
 #endif
 

-#ifdef __WIN95__
+#include "wx/msw/private.h"
+#include "wx/msw/winundef.h"

 
 

-#include <wx/msw/taskbar.h>

 #include <string.h>
 #include <string.h>

-#include <windows.h>
-#include <wx/msw/private.h>
+#include "wx/taskbar.h"

 
 

-#ifdef __GNUWIN32__
-#include <wx/msw/gnuwin32/extra.h>
+#ifdef __WXWINCE__
+    #include <winreg.h>
+    #include <shellapi.h>

 #endif
 
 #endif
 

-LRESULT APIENTRY _EXPORT wxTaskBarIconWindowProc( HWND hWnd, unsigned msg,
-                                    UINT wParam, LONG lParam );
+// initialized on demand
+UINT   gs_msgTaskbar = 0;
+UINT   gs_msgRestartTaskbar = 0;
+
+#if WXWIN_COMPATIBILITY_2_4
+BEGIN_EVENT_TABLE(wxTaskBarIcon, wxTaskBarIconBase)
+    EVT_TASKBAR_MOVE         (wxTaskBarIcon::_OnMouseMove)
+    EVT_TASKBAR_LEFT_DOWN    (wxTaskBarIcon::_OnLButtonDown)
+    EVT_TASKBAR_LEFT_UP      (wxTaskBarIcon::_OnLButtonUp)
+    EVT_TASKBAR_RIGHT_DOWN   (wxTaskBarIcon::_OnRButtonDown)
+    EVT_TASKBAR_RIGHT_UP     (wxTaskBarIcon::_OnRButtonUp)
+    EVT_TASKBAR_LEFT_DCLICK  (wxTaskBarIcon::_OnLButtonDClick)
+    EVT_TASKBAR_RIGHT_DCLICK (wxTaskBarIcon::_OnRButtonDClick)
+END_EVENT_TABLE()
+#endif

 
 

-char *wxTaskBarWindowClass = "wxTaskBarWindowClass";

 
 

-wxList wxTaskBarIcon::sm_taskBarIcons;
-bool   wxTaskBarIcon::sm_registeredClass = FALSE;
-UINT   wxTaskBarIcon::sm_taskbarMsg = 0;
+IMPLEMENT_DYNAMIC_CLASS(wxTaskBarIcon, wxEvtHandler)

 
 

+// ============================================================================
+// implementation
+// ============================================================================

 
 

-#if !USE_SHARED_LIBRARY
-BEGIN_EVENT_TABLE(wxTaskBarIcon, wxEvtHandler)
-    EVT_TASKBAR_MOVE         (wxTaskBarIcon::OnMouseMove)
-    EVT_TASKBAR_LEFT_DOWN    (wxTaskBarIcon::OnLButtonDown)
-    EVT_TASKBAR_LEFT_UP      (wxTaskBarIcon::OnLButtonUp)
-    EVT_TASKBAR_RIGHT_DOWN   (wxTaskBarIcon::OnRButtonDown)
-    EVT_TASKBAR_RIGHT_UP     (wxTaskBarIcon::OnRButtonUp)
-    EVT_TASKBAR_LEFT_DCLICK  (wxTaskBarIcon::OnLButtonDClick)
-    EVT_TASKBAR_RIGHT_DCLICK (wxTaskBarIcon::OnRButtonDClick)
-END_EVENT_TABLE()
+// ----------------------------------------------------------------------------
+// wxTaskBarIconWindow: helper window
+// ----------------------------------------------------------------------------

 
 

+// NB: this class serves two purposes:
+//     1. win32 needs a HWND associated with taskbar icon, this provides it
+//     2. we need wxTopLevelWindow so that the app doesn't exit when
+//        last frame is closed but there still is a taskbar icon
+class wxTaskBarIconWindow : public wxFrame
+{
+public:
+    wxTaskBarIconWindow(wxTaskBarIcon *icon)
+        : wxFrame(NULL, wxID_ANY, wxEmptyString, wxDefaultPosition, wxDefaultSize, 0),
+          m_icon(icon)
+    {
+    }
+
+    WXLRESULT MSWWindowProc(WXUINT msg,
+                            WXWPARAM wParam, WXLPARAM lParam)
+    {
+        if (msg == gs_msgRestartTaskbar || msg == gs_msgTaskbar)
+        {
+            return m_icon->WindowProc(msg, wParam, lParam);
+        }
+        else
+        {
+            return wxFrame::MSWWindowProc(msg, wParam, lParam);
+        }
+    }
+
+private:
+    wxTaskBarIcon *m_icon;
+};

 
 

-IMPLEMENT_DYNAMIC_CLASS(wxTaskBarIcon, wxEvtHandler)
-#endif

 
 

+// ----------------------------------------------------------------------------
+// NotifyIconData: wrapper around NOTIFYICONDATA
+// ----------------------------------------------------------------------------

 
 

-wxTaskBarIcon::wxTaskBarIcon(void)
+struct NotifyIconData : public NOTIFYICONDATA

 {
 {

-    m_hWnd = 0;
-    m_iconAdded = FALSE;
+    NotifyIconData(WXHWND hwnd)
+    {
+        memset(this, 0, sizeof(NOTIFYICONDATA));
+        cbSize = sizeof(NOTIFYICONDATA);
+        hWnd = (HWND) hwnd;
+        uCallbackMessage = gs_msgTaskbar;
+        uFlags = NIF_MESSAGE;
+
+        // we use the same id for all taskbar icons as we don't need it to
+        // distinguish between them
+        uID = 99;
+    }
+};

 
 

-    AddObject(this);
+// ----------------------------------------------------------------------------
+// wxTaskBarIcon
+// ----------------------------------------------------------------------------

 
 

-    if (RegisterWindowClass())
-        m_hWnd = CreateTaskBarWindow();
+wxTaskBarIcon::wxTaskBarIcon()
+{
+    m_win = NULL;
+    m_iconAdded = false;
+    RegisterWindowMessages();

 }
 
 }
 

-wxTaskBarIcon::~wxTaskBarIcon(void)
+wxTaskBarIcon::~wxTaskBarIcon()

 {
 {

-    RemoveObject(this);
-

     if (m_iconAdded)
     if (m_iconAdded)

-    {

         RemoveIcon();
         RemoveIcon();

-    }

 
 

-    if (m_hWnd)
-    {
-        ::DestroyWindow((HWND) m_hWnd);
-        m_hWnd = 0;
-    }
+    if (m_win)
+        m_win->Destroy();

 }
 
 // Operations
 bool wxTaskBarIcon::SetIcon(const wxIcon& icon, const wxString& tooltip)
 {
 }
 
 // Operations
 bool wxTaskBarIcon::SetIcon(const wxIcon& icon, const wxString& tooltip)
 {

-    if (!IsOK())
-        return FALSE;
+    // NB: we have to create the window lazily because of backward compatibility,
+    //     old applications may create a wxTaskBarIcon instance before wxApp
+    //     is initialized (as samples/taskbar used to do)
+    if (!m_win)
+    {
+        m_win = new wxTaskBarIconWindow(this);
+    }
+
+    m_icon = icon;
+    m_strTooltip = tooltip;

 
 

-    NOTIFYICONDATA notifyData;
+    NotifyIconData notifyData((HWND)m_win->GetHWND());

 
 

-    memset(&notifyData, 0, sizeof(notifyData));
-       notifyData.cbSize = sizeof(notifyData);
-       notifyData.hWnd = (HWND) m_hWnd;
-       notifyData.uCallbackMessage = sm_taskbarMsg;
-       notifyData.uFlags = NIF_MESSAGE ;
-       if (icon.Ok())
+    if (icon.Ok())

     {
     {

-               notifyData.uFlags |= NIF_ICON;
-           notifyData.hIcon = (HICON) icon.GetHICON();
+        notifyData.uFlags |= NIF_ICON;
+        notifyData.hIcon = GetHiconOf(icon);

     }
 
     }
 

-    if (((const char*) tooltip != NULL) && (tooltip != ""))
+    if ( !tooltip.empty() )

     {
     {

-        notifyData.uFlags |= NIF_TIP ;
-               lstrcpyn(notifyData.szTip, (char*) (const char*) tooltip, sizeof(notifyData.szTip));
+        notifyData.uFlags |= NIF_TIP;
+//        lstrcpyn(notifyData.szTip, tooltip.c_str(), WXSIZEOF(notifyData.szTip));
+        wxStrncpy(notifyData.szTip, tooltip.c_str(), WXSIZEOF(notifyData.szTip));

     }
 
     }
 

-    notifyData.uID = 99;
+    bool ok = Shell_NotifyIcon(m_iconAdded ? NIM_MODIFY
+                                           : NIM_ADD, &notifyData) != 0;

 
 

-    if (m_iconAdded)
-        return (Shell_NotifyIcon(NIM_MODIFY, & notifyData) != 0);
-    else
-    {
-        m_iconAdded = (Shell_NotifyIcon(NIM_ADD, & notifyData) != 0);
-        return m_iconAdded;
-    }
+    if ( !m_iconAdded && ok )
+        m_iconAdded = true;
+
+    return ok;

 }
 
 }
 

-bool wxTaskBarIcon::RemoveIcon(void)
+bool wxTaskBarIcon::RemoveIcon()

 {
     if (!m_iconAdded)
 {
     if (!m_iconAdded)

-        return FALSE;
+        return false;

 
 

-    NOTIFYICONDATA notifyData;
+    m_iconAdded = false;

 
 

-    memset(&notifyData, 0, sizeof(notifyData));
-       notifyData.cbSize = sizeof(notifyData);
-       notifyData.hWnd = (HWND) m_hWnd;
-       notifyData.uCallbackMessage = sm_taskbarMsg;
-       notifyData.uFlags = NIF_MESSAGE;
-       notifyData.hIcon = 0 ; // hIcon;
-    notifyData.uID = 99;
-    m_iconAdded = FALSE;
+    NotifyIconData notifyData((HWND)m_win->GetHWND());

 
 

-    return (Shell_NotifyIcon(NIM_DELETE, & notifyData) != 0);
+    return Shell_NotifyIcon(NIM_DELETE, &notifyData) != 0;

 }
 
 }
 

-// Overridables
-void wxTaskBarIcon::OnMouseMove(wxEvent&)
+bool wxTaskBarIcon::PopupMenu(wxMenu *menu)

 {
 {

-}
+    wxASSERT_MSG( m_win != NULL, _T("taskbar icon not initialized") );

 
 

-void wxTaskBarIcon::OnLButtonDown(wxEvent&)
-{
-}
+    static bool s_inPopup = false;

 
 

-void wxTaskBarIcon::OnLButtonUp(wxEvent&)
-{
-}
+    if (s_inPopup)
+        return false;

 
 

-void wxTaskBarIcon::OnRButtonDown(wxEvent&)
-{
-}
+    s_inPopup = true;

 
 

-void wxTaskBarIcon::OnRButtonUp(wxEvent&)
-{
-}
+    int         x, y;
+    wxGetMousePosition(&x, &y);

 
 

-void wxTaskBarIcon::OnLButtonDClick(wxEvent&)
-{
-}
+    m_win->Move(x, y);

 
 

-void wxTaskBarIcon::OnRButtonDClick(wxEvent&)
-{
-}
+    m_win->PushEventHandler(this);

 
 

-wxTaskBarIcon* wxTaskBarIcon::FindObjectForHWND(WXHWND hWnd)
-{
-    wxNode*node = sm_taskBarIcons.First();
-    while (node)
-    {
-        wxTaskBarIcon* obj = (wxTaskBarIcon*) node->Data();
-        if (obj->GetHWND() == hWnd)
-            return obj;
-        node = node->Next();
-    }
-    return NULL;
-}
+    menu->UpdateUI();

 
 

-void wxTaskBarIcon::AddObject(wxTaskBarIcon* obj)
-{
-    sm_taskBarIcons.Append(obj);
-}
+    // Work around a WIN32 bug
+    ::SetForegroundWindow((HWND)m_win->GetHWND());

 
 

-void wxTaskBarIcon::RemoveObject(wxTaskBarIcon* obj)
-{
-    sm_taskBarIcons.DeleteObject(obj);
-}
+    bool rval = m_win->PopupMenu(menu, 0, 0);

 
 

-bool wxTaskBarIcon::RegisterWindowClass()
-{
-    if (sm_registeredClass)
-        return TRUE;
-
-    // Also register the taskbar message here
-    sm_taskbarMsg = ::RegisterWindowMessage("wxTaskBarIconMessage");
-
-    WNDCLASS   wc;
-    bool       rc;
-
-    HINSTANCE hInstance = GetModuleHandle(NULL);
-
-    /*
-     * set up and register window class
-     */
-    wc.style = CS_HREDRAW | CS_VREDRAW;
-    wc.lpfnWndProc = (WNDPROC) wxTaskBarIconWindowProc;
-    wc.cbClsExtra = 0;
-    wc.cbWndExtra = 0;
-    wc.hInstance = hInstance;
-    wc.hIcon = 0;
-    wc.hCursor = 0;
-    wc.hbrBackground = 0;
-    wc.lpszMenuName = NULL;
-    wc.lpszClassName = wxTaskBarWindowClass ;
-    rc = (::RegisterClass( &wc ) != 0);
-
-    sm_registeredClass = (rc != 0);
-
-    return( (rc != 0) );
+    // Work around a WIN32 bug
+    ::PostMessage((HWND)m_win->GetHWND(), WM_NULL, 0, 0L);
+
+    m_win->PopEventHandler(false);
+
+    s_inPopup = false;
+
+    return rval;

 }
 
 }
 

-WXHWND wxTaskBarIcon::CreateTaskBarWindow()
+#if WXWIN_COMPATIBILITY_2_4
+// Overridables
+void wxTaskBarIcon::OnMouseMove(wxEvent& e)         { e.Skip(); }
+void wxTaskBarIcon::OnLButtonDown(wxEvent& e)       { e.Skip(); }
+void wxTaskBarIcon::OnLButtonUp(wxEvent& e)         { e.Skip(); }
+void wxTaskBarIcon::OnRButtonDown(wxEvent& e)       { e.Skip(); }
+void wxTaskBarIcon::OnRButtonUp(wxEvent& e)         { e.Skip(); }
+void wxTaskBarIcon::OnLButtonDClick(wxEvent& e)     { e.Skip(); }
+void wxTaskBarIcon::OnRButtonDClick(wxEvent& e)     { e.Skip(); }
+
+void wxTaskBarIcon::_OnMouseMove(wxTaskBarIconEvent& e)
+    { OnMouseMove(e);     }
+void wxTaskBarIcon::_OnLButtonDown(wxTaskBarIconEvent& e)
+    { OnLButtonDown(e);   }
+void wxTaskBarIcon::_OnLButtonUp(wxTaskBarIconEvent& e)
+    { OnLButtonUp(e);     }
+void wxTaskBarIcon::_OnRButtonDown(wxTaskBarIconEvent& e)
+    { OnRButtonDown(e);   }
+void wxTaskBarIcon::_OnRButtonUp(wxTaskBarIconEvent& e)
+    { OnRButtonUp(e);     }
+void wxTaskBarIcon::_OnLButtonDClick(wxTaskBarIconEvent& e)
+    { OnLButtonDClick(e); }
+void wxTaskBarIcon::_OnRButtonDClick(wxTaskBarIconEvent& e)
+    { OnRButtonDClick(e); }
+#endif
+
+void wxTaskBarIcon::RegisterWindowMessages()

 {
 {

-    HINSTANCE hInstance = GetModuleHandle(NULL);
-
-    HWND hWnd = CreateWindowEx (0, wxTaskBarWindowClass,
-            "wxTaskBarWindow",
-            WS_OVERLAPPED,
-            0,
-            0,
-            10,
-            10,
-            NULL,
-            (HMENU) 0,
-            hInstance,
-            NULL);
-
-    return (WXHWND) hWnd;
+    static bool s_registered = false;
+
+    if ( !s_registered )
+    {
+        // Taskbar restart msg will be sent to us if the icon needs to be redrawn
+        gs_msgRestartTaskbar = RegisterWindowMessage(wxT("TaskbarCreated"));
+
+        // Also register the taskbar message here
+        gs_msgTaskbar = ::RegisterWindowMessage(wxT("wxTaskBarIconMessage"));
+
+        s_registered = true;
+    }

 }
 
 }
 

-long wxTaskBarIcon::WindowProc( WXHWND hWnd, unsigned int msg, unsigned int wParam, long lParam )
+// ----------------------------------------------------------------------------
+// wxTaskBarIcon window proc
+// ----------------------------------------------------------------------------
+
+long wxTaskBarIcon::WindowProc(unsigned int msg,
+                               unsigned int WXUNUSED(wParam),
+                               long lParam)

 {
     wxEventType eventType = 0;
 
 {
     wxEventType eventType = 0;
 

-    if (msg != sm_taskbarMsg)
-        return DefWindowProc((HWND) hWnd, msg, wParam, lParam);
+    if (msg == gs_msgRestartTaskbar)   // does the icon need to be redrawn?
+    {
+        m_iconAdded = false;
+        SetIcon(m_icon, m_strTooltip);
+    }
+
+    // this function should only be called for gs_msg(Restart)Taskbar messages
+    wxASSERT(msg == gs_msgTaskbar);

 
     switch (lParam)
     {
 
     switch (lParam)
     {

-       case WM_LBUTTONDOWN:
+        case WM_LBUTTONDOWN:

             eventType = wxEVT_TASKBAR_LEFT_DOWN;
             break;
 
             eventType = wxEVT_TASKBAR_LEFT_DOWN;
             break;
 

-       case WM_LBUTTONUP:
+        case WM_LBUTTONUP:

             eventType = wxEVT_TASKBAR_LEFT_UP;
             break;
 
             eventType = wxEVT_TASKBAR_LEFT_UP;
             break;
 

-       case WM_RBUTTONDOWN:
+        case WM_RBUTTONDOWN:

             eventType = wxEVT_TASKBAR_RIGHT_DOWN;
             break;
 
             eventType = wxEVT_TASKBAR_RIGHT_DOWN;
             break;
 

-       case WM_RBUTTONUP:
+        case WM_RBUTTONUP:

             eventType = wxEVT_TASKBAR_RIGHT_UP;
             break;
 
             eventType = wxEVT_TASKBAR_RIGHT_UP;
             break;
 

-       case WM_LBUTTONDBLCLK:
+        case WM_LBUTTONDBLCLK:

             eventType = wxEVT_TASKBAR_LEFT_DCLICK;
             break;
 
             eventType = wxEVT_TASKBAR_LEFT_DCLICK;
             break;
 

-       case WM_RBUTTONDBLCLK:
+        case WM_RBUTTONDBLCLK:

             eventType = wxEVT_TASKBAR_RIGHT_DCLICK;
             break;
 
             eventType = wxEVT_TASKBAR_RIGHT_DCLICK;
             break;
 

-       case WM_MOUSEMOVE:
+        case WM_MOUSEMOVE:

             eventType = wxEVT_TASKBAR_MOVE;
             break;
 
             eventType = wxEVT_TASKBAR_MOVE;
             break;
 

-       default:
+        default:

             break;
             break;

-       }
+    }

 
 

-    if (eventType) {
-        wxEvent event;
-        event.SetEventType(eventType);
-        event.SetEventObject(this);
+    if (eventType)
+    {
+        wxTaskBarIconEvent event(eventType, this);

 
         ProcessEvent(event);
     }
 
         ProcessEvent(event);
     }

-    return 0;
-}

 
 

-LRESULT APIENTRY _EXPORT wxTaskBarIconWindowProc( HWND hWnd, unsigned msg,
-                                    UINT wParam, LONG lParam )
-{
-    wxTaskBarIcon* obj = wxTaskBarIcon::FindObjectForHWND((WXHWND) hWnd);
-    if (obj)
-        return obj->WindowProc((WXHWND) hWnd, msg, wParam, lParam);
-    else
-        return DefWindowProc(hWnd, msg, wParam, lParam);
+    return 0;

 }
 }

-
-#endif
-    // __WIN95__