Sun warning and Unicode fixes

[wxWidgets.git] / src / generic / filedlgg.cpp

diff --git a/src/generic/filedlgg.cpp b/src/generic/filedlgg.cpp
index f0f9ad244c29a2c86e7272b81a19dc4b6916f863..5630801c60932f99306ab2f3b9b615f02f03a268 100644 (file)
--- a/src/generic/filedlgg.cpp
+++ b/src/generic/filedlgg.cpp
@@ -22,8 +22,8 @@
 
 #if wxUSE_FILEDLG
 
 
 #if wxUSE_FILEDLG
 

-#ifndef __UNIX__
-#error wxFileDialog currently only supports unix
+#if !defined(__UNIX__) && !defined(__DOS__)
+#error wxFileDialog currently only supports Unix and DOS

 #endif
 
 #include "wx/checkbox.h"
 #endif
 
 #include "wx/checkbox.h"


@@ -45,6 +45,7 @@
 #include "wx/module.h"
 #include "wx/config.h"
 #include "wx/imaglist.h"
 #include "wx/module.h"
 #include "wx/config.h"
 #include "wx/imaglist.h"

+#include "wx/dir.h"

 
 #if wxUSE_TOOLTIPS
     #include "wx/tooltip.h"
 
 #if wxUSE_TOOLTIPS
     #include "wx/tooltip.h"


@@ -52,15 +53,28 @@
 
 #include <sys/types.h>
 #include <sys/stat.h>
 
 #include <sys/types.h>
 #include <sys/stat.h>

-#include <dirent.h>
-#include <pwd.h>
-#ifndef __VMS
-# include <grp.h>
+
+#ifdef __UNIX__
+    #include <dirent.h>
+    #include <pwd.h>
+    #ifndef __VMS
+    # include <grp.h>
+    #endif
+#endif
+
+#ifdef __WATCOMC__
+    #include <direct.h>

 #endif
 #endif

+

 # include <time.h>
 #include <unistd.h>
 
 # include <time.h>
 #include <unistd.h>
 

+// XPM hack: make the arrays const
+#define static static const
+
+#ifndef __DOS__

 #include "wx/generic/home.xpm"
 #include "wx/generic/home.xpm"

+#endif

 #include "wx/generic/listview.xpm"
 #include "wx/generic/repview.xpm"
 #include "wx/generic/new_dir.xpm"
 #include "wx/generic/listview.xpm"
 #include "wx/generic/repview.xpm"
 #include "wx/generic/new_dir.xpm"


@@ -69,26 +83,14 @@
 #include "wx/generic/deffile.xpm"
 #include "wx/generic/exefile.xpm"
 
 #include "wx/generic/deffile.xpm"
 #include "wx/generic/exefile.xpm"
 

+#undef static
+

 //-----------------------------------------------------------------------------
 //  wxFileData
 //-----------------------------------------------------------------------------
 
 class wxFileData : public wxObject
 {
 //-----------------------------------------------------------------------------
 //  wxFileData
 //-----------------------------------------------------------------------------
 
 class wxFileData : public wxObject
 {

-private:
-    wxString m_name;
-    wxString m_fileName;
-    long     m_size;
-    int      m_hour;
-    int      m_minute;
-    int      m_year;
-    int      m_month;
-    int      m_day;
-    wxString m_permissions;
-    bool     m_isDir;
-    bool     m_isLink;
-    bool     m_isExe;
-

 public:
     wxFileData() { }
     wxFileData( const wxString &name, const wxString &fname );
 public:
     wxFileData() { }
     wxFileData( const wxString &name, const wxString &fname );


@@ -104,6 +106,19 @@ public:
     void SetNewName( const wxString &name, const wxString &fname );
 
 private:
     void SetNewName( const wxString &name, const wxString &fname );
 
 private:

+    wxString m_name;
+    wxString m_fileName;
+    long     m_size;
+    int      m_hour;
+    int      m_minute;
+    int      m_year;
+    int      m_month;
+    int      m_day;
+    wxString m_permissions;
+    bool     m_isDir;
+    bool     m_isLink;
+    bool     m_isExe;
+

     DECLARE_DYNAMIC_CLASS(wxFileData);
 };
 
     DECLARE_DYNAMIC_CLASS(wxFileData);
 };
 


@@ -113,11 +128,6 @@ private:
 
 class wxFileCtrl : public wxListCtrl
 {
 
 class wxFileCtrl : public wxListCtrl
 {

-private:
-    wxString      m_dirName;
-    bool          m_showHidden;
-    wxString      m_wild;
-

 public:
     wxFileCtrl();
     wxFileCtrl( wxWindow *win,
 public:
     wxFileCtrl();
     wxFileCtrl( wxWindow *win,


@@ -145,8 +155,21 @@ public:
     void OnListDeleteItem( wxListEvent &event );
     void OnListDeleteAllItems( wxListEvent &event );
     void OnListEndLabelEdit( wxListEvent &event );
     void OnListDeleteItem( wxListEvent &event );
     void OnListDeleteAllItems( wxListEvent &event );
     void OnListEndLabelEdit( wxListEvent &event );

+    
+    // Associate commonly used UI controls with wxFileCtrl so that they can be
+    // disabled when they cannot be used (e.g. can't go to parent directory
+    // if wxFileCtrl already is in the root dir):
+    void SetGoToParentControl(wxWindow *ctrl) { m_goToParentControl = ctrl; }
+    void SetNewDirControl(wxWindow *ctrl) { m_newDirControl = ctrl; }

 
 private:
 
 private:

+    wxString      m_dirName;
+    bool          m_showHidden;
+    wxString      m_wild;
+    
+    wxWindow     *m_goToParentControl;
+    wxWindow     *m_newDirControl;
+

     DECLARE_DYNAMIC_CLASS(wxFileCtrl);
     DECLARE_EVENT_TABLE()
 };
     DECLARE_DYNAMIC_CLASS(wxFileCtrl);
     DECLARE_EVENT_TABLE()
 };


@@ -203,6 +226,10 @@ wxFileIconsTable::wxFileIconsTable() :
 
 
 
 
 
 

+#if wxUSE_MIMETYPE
+// VS: we don't need this function w/o wxMimeTypesManager because we'll only have
+//     one icon and we won't resize it
+

 static wxBitmap CreateAntialiasedBitmap(const wxImage& img)
 {
     wxImage small(16, 16);
 static wxBitmap CreateAntialiasedBitmap(const wxImage& img)
 {
     wxImage small(16, 16);


@@ -251,7 +278,6 @@ static wxBitmap CreateAntialiasedBitmap(const wxImage& img)
     return small.ConvertToBitmap();
 }
 
     return small.ConvertToBitmap();
 }
 

-

 // finds empty borders and return non-empty area of image:
 static wxImage CutEmptyBorders(const wxImage& img)
 {
 // finds empty borders and return non-empty area of image:
 static wxImage CutEmptyBorders(const wxImage& img)
 {


@@ -295,11 +321,13 @@ static wxImage CutEmptyBorders(const wxImage& img)
 
     return img.GetSubImage(wxRect(left, top, right - left + 1, bottom - top + 1));
 }
 
     return img.GetSubImage(wxRect(left, top, right - left + 1, bottom - top + 1));
 }

+#endif // wxUSE_MIMETYPE

 
 
 
 int wxFileIconsTable::GetIconID(const wxString& extension, const wxString& mime)
 {
 
 
 
 int wxFileIconsTable::GetIconID(const wxString& extension, const wxString& mime)
 {

+#if wxUSE_MIMETYPE

     if (!extension.IsEmpty())
     {
         wxFileIconEntry *entry = (wxFileIconEntry*) m_HashTable.Get(extension);
     if (!extension.IsEmpty())
     {
         wxFileIconEntry *entry = (wxFileIconEntry*) m_HashTable.Get(extension);


@@ -331,6 +359,14 @@ int wxFileIconsTable::GetIconID(const wxString& extension, const wxString& mime)
     }
     m_HashTable.Put(extension, new wxFileIconEntry(id));
     return id;
     }
     m_HashTable.Put(extension, new wxFileIconEntry(id));
     return id;

+
+#else // !wxUSE_MIMETYPE
+
+    if (extension == wxT("exe"))
+        return FI_EXECUTABLE;
+    else
+        return FI_UNKNOWN;
+#endif // wxUSE_MIMETYPE/!wxUSE_MIMETYPE

 }
 
 
 }
 
 


@@ -351,6 +387,18 @@ int ListCompare( long data1, long data2, long WXUNUSED(data) )
      return wxStrcmp( fd1->GetName(), fd2->GetName() );
 }
 
      return wxStrcmp( fd1->GetName(), fd2->GetName() );
 }
 

+#ifdef __UNIX__
+#define IsTopMostDir(dir)   (dir == wxT("/"))
+#endif
+
+#if defined(__DOS__) || defined(__WINDOWS__)
+#define IsTopMostDir(dir)   (dir.IsEmpty())
+#endif
+
+#if defined(__DOS__) || defined(__WINDOWS__)
+extern bool wxIsDriveAvailable(const wxString& dirName);
+#endif
+

 //-----------------------------------------------------------------------------
 //  wxFileData
 //-----------------------------------------------------------------------------
 //-----------------------------------------------------------------------------
 //  wxFileData
 //-----------------------------------------------------------------------------


@@ -361,11 +409,23 @@ wxFileData::wxFileData( const wxString &name, const wxString &fname )
 {
     m_name = name;
     m_fileName = fname;
 {
     m_name = name;
     m_fileName = fname;

+    
+#if defined(__DOS__) || defined(__WINDOWS__)
+    // VS: In case the file is root directory of a volume (e.g. "C:"),
+    //     we don't want it stat()ed, since the drive may not be in:
+    if (name.length() == 2 && name[1u] == wxT(':'))
+    {
+        m_isDir = TRUE;
+        m_isExe = m_isLink = FALSE;
+        m_size = 0;
+        return;
+    }
+#endif

 
     struct stat buff;
 
     struct stat buff;

-    stat( m_fileName.fn_str(), &buff );
+    wxStat( m_fileName.fn_str(), &buff );

 
 

-#if !defined( __EMX__ ) && !defined(__VMS)
+#if defined(__UNIX__) && (!defined( __EMX__ ) && !defined(__VMS))

     struct stat lbuff;
     lstat( m_fileName.fn_str(), &lbuff );
     m_isLink = S_ISLNK( lbuff.st_mode );
     struct stat lbuff;
     lstat( m_fileName.fn_str(), &lbuff );
     m_isLink = S_ISLNK( lbuff.st_mode );


@@ -516,7 +576,7 @@ void wxFileData::MakeItem( wxListItem &item )
     else if (IsExe())
         item.m_image = FI_EXECUTABLE;
     else if (m_name.Find(wxT('.')) != wxNOT_FOUND)
     else if (IsExe())
         item.m_image = FI_EXECUTABLE;
     else if (m_name.Find(wxT('.')) != wxNOT_FOUND)

-        item.m_image = g_IconsTable -> GetIconID(m_name.AfterLast(wxT('.')));
+        item.m_image = g_IconsTable->GetIconID(m_name.AfterLast(wxT('.')));

     else
         item.m_image = FI_UNKNOWN;
 
     else
         item.m_image = FI_UNKNOWN;
 


@@ -543,21 +603,29 @@ END_EVENT_TABLE()
 
 wxFileCtrl::wxFileCtrl()
 {
 
 wxFileCtrl::wxFileCtrl()
 {

+#if defined(__UNIX__)

     m_dirName = wxT("/");
     m_dirName = wxT("/");

+#elif defined(__DOS__)
+    m_dirName = wxT("");
+#endif

     m_showHidden = FALSE;
 }
 
     m_showHidden = FALSE;
 }
 

-wxFileCtrl::wxFileCtrl( wxWindow *win, wxWindowID id,
-    const wxString &dirName, const wxString &wild,
-    const wxPoint &pos, const wxSize &size,
-    long style, const wxValidator &validator, const wxString &name ) :
-  wxListCtrl( win, id, pos, size, style, validator, name )
+wxFileCtrl::wxFileCtrl(wxWindow *win, wxWindowID id,
+                       const wxString &dirName, const wxString &wild,
+                       const wxPoint &pos, const wxSize &size,
+                       long style, const wxValidator &validator, 
+                       const wxString &name)
+        : wxListCtrl(win, id, pos, size, style, validator, name)

 {
 {

-    if (! g_IconsTable) g_IconsTable = new wxFileIconsTable;
-    wxImageList *imageList = g_IconsTable -> GetImageList();
+    if (! g_IconsTable) 
+        g_IconsTable = new wxFileIconsTable;
+    wxImageList *imageList = g_IconsTable->GetImageList();

 
     SetImageList( imageList, wxIMAGE_LIST_SMALL );
 
 
     SetImageList( imageList, wxIMAGE_LIST_SMALL );
 

+    m_goToParentControl = m_newDirControl = NULL;
+

     m_dirName = dirName;
     m_wild = wild;
     m_showHidden = FALSE;
     m_dirName = dirName;
     m_wild = wild;
     m_showHidden = FALSE;


@@ -596,8 +664,14 @@ long wxFileCtrl::Add( wxFileData *fd, wxListItem &item )
     long my_style = GetWindowStyleFlag();
     if (my_style & wxLC_REPORT)
     {
     long my_style = GetWindowStyleFlag();
     if (my_style & wxLC_REPORT)
     {

+#ifdef __UNIX__
+        const int noEntries = 5;
+#else
+        const int noEntries = 4;
+#endif

         ret = InsertItem( item );
         ret = InsertItem( item );

-        for (int i = 1; i < 5; i++) SetItem( item.m_itemId, i, fd->GetEntry( i) );
+        for (int i = 1; i < noEntries; i++) 
+            SetItem( item.m_itemId, i, fd->GetEntry( i) );

     }
     else if (my_style & wxLC_LIST)
     {
     }
     else if (my_style & wxLC_LIST)
     {


@@ -608,6 +682,8 @@ long wxFileCtrl::Add( wxFileData *fd, wxListItem &item )
 
 void wxFileCtrl::Update()
 {
 
 void wxFileCtrl::Update()
 {

+    wxBusyCursor bcur; // this may take a while...
+    

     long my_style = GetWindowStyleFlag();
     int name_col_width = 0;
     if (my_style & wxLC_REPORT)
     long my_style = GetWindowStyleFlag();
     int name_col_width = 0;
     if (my_style & wxLC_REPORT)


@@ -624,66 +700,106 @@ void wxFileCtrl::Update()
         InsertColumn( 1, _("Size"), wxLIST_FORMAT_LEFT, 60 );
         InsertColumn( 2, _("Date"), wxLIST_FORMAT_LEFT, 65 );
         InsertColumn( 3, _("Time"), wxLIST_FORMAT_LEFT, 50 );
         InsertColumn( 1, _("Size"), wxLIST_FORMAT_LEFT, 60 );
         InsertColumn( 2, _("Date"), wxLIST_FORMAT_LEFT, 65 );
         InsertColumn( 3, _("Time"), wxLIST_FORMAT_LEFT, 50 );

+#ifdef __UNIX__

         InsertColumn( 4, _("Permissions"), wxLIST_FORMAT_LEFT, 120 );
         InsertColumn( 4, _("Permissions"), wxLIST_FORMAT_LEFT, 120 );

+#endif

     }
     wxFileData *fd = (wxFileData *) NULL;
     wxListItem item;
     item.m_itemId = 0;
     item.m_col = 0;
 
     }
     wxFileData *fd = (wxFileData *) NULL;
     wxListItem item;
     item.m_itemId = 0;
     item.m_col = 0;
 

-    if (m_dirName != wxT("/"))
-    {
-        wxString p( wxPathOnly(m_dirName) );
-        if (p.IsEmpty()) p = wxT("/");
-        fd = new wxFileData( wxT(".."), p );
-        Add( fd, item );
-        item.m_itemId++;
+#if defined(__DOS__) || defined(__WINDOWS__)
+    if ( IsTopMostDir(m_dirName) )
+    {   
+        // Pseudo-directory with all available drives listed...
+        for (int drive = 1; drive <= 26; drive++)
+        {
+            wxString path;
+            path.Printf(wxT("%c:\\"), (char)(drive + 'A' - 1));
+            if ( wxIsDriveAvailable(path) )
+            {
+                path.RemoveLast();
+                fd = new wxFileData(path, path);
+                Add(fd, item);
+                item.m_itemId++;
+            }
+        }

     }
     }

-
-    wxString res = m_dirName + wxT("/*");
-    wxString f( wxFindFirstFile( res.GetData(), wxDIR ) );
-    while (!f.IsEmpty())
+    else
+#endif

     {
     {

-        res = wxFileNameFromPath( f );
-        fd = new wxFileData( res, f );
-        wxString s = fd->GetName();
-        if (m_showHidden || (s[0u] != wxT('.')))
+        // Real directory...
+        if ( !IsTopMostDir(m_dirName) )

         {
         {

-            Add( fd, item );
+            wxString p(wxPathOnly(m_dirName));
+#ifdef __UNIX__
+            if (p.IsEmpty()) p = wxT("/");
+#endif
+            fd = new wxFileData( wxT(".."), p );
+            Add(fd, item);

             item.m_itemId++;
         }
             item.m_itemId++;
         }

-        f = wxFindNextFile();
-    }

 
 

-    // Tokenize the wildcard string, so we can handle more than 1 
-    // search pattern in a wildcard.
-    wxStringTokenizer tokenWild( m_wild, ";" );
-    while ( tokenWild.HasMoreTokens() )
-    {
-        res = m_dirName + wxT("/") + tokenWild.GetNextToken();
-        f = wxFindFirstFile( res.GetData(), wxFILE );
-        while (!f.IsEmpty())
+        wxString dirname(m_dirName);
+#if defined(__DOS__) || defined(__WINDOWS__)
+        if (dirname.length() == 2 && dirname[1u] == wxT(':'))
+            dirname << wxT('\\');
+#endif
+        wxDir dir(dirname);
+
+        if ( dir.IsOpened() )

         {
         {

-            res = wxFileNameFromPath( f );
-            fd = new wxFileData( res, f );
-            wxString s = fd->GetName();
-            if (m_showHidden || (s[0u] != wxT('.')))
+            wxString dirPrefix(dirname + wxFILE_SEP_PATH);
+            int hiddenFlag = m_showHidden ? wxDIR_HIDDEN : 0;
+            
+            bool cont;
+            wxString f;
+
+            // Get the directories first (not matched against wildcards):
+            cont = dir.GetFirst(&f, wxEmptyString, wxDIR_DIRS | hiddenFlag);
+            while (cont)

             {
             {

-                Add( fd, item );
+                fd = new wxFileData(f, dirPrefix + f);
+                Add(fd, item);

                 item.m_itemId++;
                 item.m_itemId++;

+                cont = dir.GetNext(&f);
+            }
+
+            // Tokenize the wildcard string, so we can handle more than 1 
+            // search pattern in a wildcard.
+            wxStringTokenizer tokenWild(m_wild, wxT(";"));
+            while ( tokenWild.HasMoreTokens() )
+            {
+                cont = dir.GetFirst(&f, tokenWild.GetNextToken(), 
+                                        wxDIR_FILES | hiddenFlag);
+                while (cont)
+                {
+                    fd = new wxFileData(f, dirPrefix + f);
+                    Add(fd, item);
+                    item.m_itemId++;
+                    cont = dir.GetNext(&f);
+                }

             }
             }

-            f = wxFindNextFile();

         }
     }
 
         }
     }
 

-    SortItems( ListCompare, 0 );
+    SortItems(ListCompare, 0);

 
 

-    if (my_style & wxLC_REPORT)
+    if ( my_style & wxLC_REPORT )

     {
     {

-       SetColumnWidth( 1, wxLIST_AUTOSIZE );
-       SetColumnWidth( 2, wxLIST_AUTOSIZE );
-       SetColumnWidth( 3, wxLIST_AUTOSIZE );
+       SetColumnWidth(1, wxLIST_AUTOSIZE);
+       SetColumnWidth(2, wxLIST_AUTOSIZE);
+       SetColumnWidth(3, wxLIST_AUTOSIZE);

     }
     }

+    
+    // Finally, enable/disable context-dependent controls:
+    if ( m_goToParentControl )
+        m_goToParentControl->Enable(!IsTopMostDir(m_dirName));
+#if defined(__DOS__) || defined(__WINDOWS__)
+    if ( m_newDirControl )
+        m_newDirControl->Enable(!IsTopMostDir(m_dirName));
+#endif

 }
 
 void wxFileCtrl::SetWild( const wxString &wild )
 }
 
 void wxFileCtrl::SetWild( const wxString &wild )


@@ -694,9 +810,9 @@ void wxFileCtrl::SetWild( const wxString &wild )
 
 void wxFileCtrl::MakeDir()
 {
 
 void wxFileCtrl::MakeDir()
 {

-    wxString new_name( wxT("NewName") );
+    wxString new_name( _("NewName") );

     wxString path( m_dirName );
     wxString path( m_dirName );

-    path += wxT("/");
+    path += wxFILE_SEP_PATH;

     path += new_name;
     if (wxFileExists(path))
     {
     path += new_name;
     if (wxFileExists(path))
     {


@@ -709,7 +825,7 @@ void wxFileCtrl::MakeDir()
             new_name += num;
 
             path = m_dirName;
             new_name += num;
 
             path = m_dirName;

-            path += wxT("/");
+            path += wxFILE_SEP_PATH;

             path += new_name;
             i++;
         } while (wxFileExists(path));
             path += new_name;
             i++;
         } while (wxFileExists(path));


@@ -740,11 +856,17 @@ void wxFileCtrl::MakeDir()
 
 void wxFileCtrl::GoToParentDir()
 {
 
 void wxFileCtrl::GoToParentDir()
 {

-    if (m_dirName != wxT("/"))
+    if (!IsTopMostDir(m_dirName))

     {
     {

+        size_t len = m_dirName.Len();
+        if (m_dirName[len-1] == wxFILE_SEP_PATH)
+            m_dirName.Remove( len-1, 1 );

         wxString fname( wxFileNameFromPath(m_dirName) );
         m_dirName = wxPathOnly( m_dirName );
         wxString fname( wxFileNameFromPath(m_dirName) );
         m_dirName = wxPathOnly( m_dirName );

-        if (m_dirName.IsEmpty()) m_dirName = wxT("/");
+#ifdef __UNIX__
+        if (m_dirName.IsEmpty()) 
+            m_dirName = wxT("/");
+#endif

         Update();
         long id = FindItem( 0, fname );
         if (id != -1)
         Update();
         long id = FindItem( 0, fname );
         if (id != -1)


@@ -758,10 +880,7 @@ void wxFileCtrl::GoToParentDir()
 void wxFileCtrl::GoToHomeDir()
 {
     wxString s = wxGetUserHome( wxString() );
 void wxFileCtrl::GoToHomeDir()
 {
     wxString s = wxGetUserHome( wxString() );

-    m_dirName = s;
-    Update();
-    SetItemState( 0, wxLIST_STATE_SELECTED, wxLIST_STATE_SELECTED );
-    EnsureVisible( 0 );
+    GoToDir(s);

 }
 
 void wxFileCtrl::GoToDir( const wxString &dir )
 }
 
 void wxFileCtrl::GoToDir( const wxString &dir )


@@ -808,7 +927,7 @@ void wxFileCtrl::OnListEndLabelEdit( wxListEvent &event )
     if ((event.GetLabel().IsEmpty()) ||
         (event.GetLabel() == _(".")) ||
         (event.GetLabel() == _("..")) ||
     if ((event.GetLabel().IsEmpty()) ||
         (event.GetLabel() == _(".")) ||
         (event.GetLabel() == _("..")) ||

-        (event.GetLabel().First( wxT("/") ) != wxNOT_FOUND))
+        (event.GetLabel().First( wxFILE_SEP_PATH ) != wxNOT_FOUND))

     {
         wxMessageDialog dialog(this, _("Illegal directory name."), _("Error"), wxOK | wxICON_ERROR );
         dialog.ShowModal();
     {
         wxMessageDialog dialog(this, _("Illegal directory name."), _("Error"), wxOK | wxICON_ERROR );
         dialog.ShowModal();


@@ -817,7 +936,7 @@ void wxFileCtrl::OnListEndLabelEdit( wxListEvent &event )
     }
 
     wxString new_name( wxPathOnly( fd->GetFullName() ) );
     }
 
     wxString new_name( wxPathOnly( fd->GetFullName() ) );

-    new_name += wxT("/");
+    new_name += wxFILE_SEP_PATH;

     new_name += event.GetLabel();
 
     wxLogNull log;
     new_name += event.GetLabel();
 
     wxLogNull log;


@@ -847,16 +966,16 @@ void wxFileCtrl::OnListEndLabelEdit( wxListEvent &event )
 // wxFileDialog
 //-----------------------------------------------------------------------------
 
 // wxFileDialog
 //-----------------------------------------------------------------------------
 

-#define  ID_LIST_MODE     wxID_FILEDLGG
-#define  ID_REPORT_MODE   wxID_FILEDLGG + 1
-#define  ID_UP_DIR        wxID_FILEDLGG + 5
-#define  ID_PARENT_DIR    wxID_FILEDLGG + 6
-#define  ID_NEW_DIR       wxID_FILEDLGG + 7
-#define  ID_CHOICE        wxID_FILEDLGG + 8
-#define  ID_TEXT          wxID_FILEDLGG + 9
-#define  ID_LIST_CTRL     wxID_FILEDLGG + 10
-#define  ID_ACTIVATED     wxID_FILEDLGG + 11
-#define  ID_CHECK         wxID_FILEDLGG + 12
+#define  ID_LIST_MODE     (wxID_FILEDLGG    )
+#define  ID_REPORT_MODE   (wxID_FILEDLGG + 1)
+#define  ID_UP_DIR        (wxID_FILEDLGG + 5)
+#define  ID_PARENT_DIR    (wxID_FILEDLGG + 6)
+#define  ID_NEW_DIR       (wxID_FILEDLGG + 7)
+#define  ID_CHOICE        (wxID_FILEDLGG + 8)
+#define  ID_TEXT          (wxID_FILEDLGG + 9)
+#define  ID_LIST_CTRL     (wxID_FILEDLGG + 10)
+#define  ID_ACTIVATED     (wxID_FILEDLGG + 11)
+#define  ID_CHECK         (wxID_FILEDLGG + 12)

 
 IMPLEMENT_DYNAMIC_CLASS(wxFileDialog,wxDialog)
 
 
 IMPLEMENT_DYNAMIC_CLASS(wxFileDialog,wxDialog)
 


@@ -886,12 +1005,14 @@ wxFileDialog::wxFileDialog(wxWindow *parent,
                  const wxPoint& pos ) :
   wxDialog( parent, -1, message, pos, wxDefaultSize, wxDEFAULT_DIALOG_STYLE | wxRESIZE_BORDER )
 {
                  const wxPoint& pos ) :
   wxDialog( parent, -1, message, pos, wxDefaultSize, wxDEFAULT_DIALOG_STYLE | wxRESIZE_BORDER )
 {

-    wxBeginBusyCursor();
+    wxBusyCursor bcur;

 
     if (wxConfig::Get(FALSE))
     {
 
     if (wxConfig::Get(FALSE))
     {

-        wxConfig::Get() -> Read(wxT("/wxWindows/wxFileDialog/ViewStyle"), &s_lastViewStyle);
-        wxConfig::Get() -> Read(wxT("/wxWindows/wxFileDialog/ShowHidden"), &s_lastShowHidden);
+        wxConfig::Get()->Read(wxT("/wxWindows/wxFileDialog/ViewStyle"), 
+                              &s_lastViewStyle);
+        wxConfig::Get()->Read(wxT("/wxWindows/wxFileDialog/ShowHidden"), 
+                              &s_lastShowHidden);

     }
 
     m_message = message;
     }
 
     m_message = message;


@@ -902,13 +1023,17 @@ wxFileDialog::wxFileDialog(wxWindow *parent,
         m_dialogStyle |= wxOPEN;
 
     m_dir = defaultDir;
         m_dialogStyle |= wxOPEN;
 
     m_dir = defaultDir;

-    if ((m_dir.IsEmpty()) || (m_dir == wxT(".")))
+    if ((m_dir.empty()) || (m_dir == wxT(".")))

     {
     {

-        char buf[200];
-        m_dir = getcwd( buf, sizeof(buf) );
+        m_dir = wxGetCwd();

     }
     }

-    m_path = defaultDir;
-    m_path += wxT("/");
+    
+    size_t len = m_dir.Len();
+    if ((len > 1) && (m_dir[len-1] == wxFILE_SEP_PATH))
+        m_dir.Remove( len-1, 1 );
+
+    m_path = m_dir;
+    m_path += wxFILE_SEP_PATH;

     m_path += defaultFile;
     m_fileName = defaultFile;
     m_wildCard = wildCard;
     m_path += defaultFile;
     m_fileName = defaultFile;
     m_wildCard = wildCard;


@@ -960,12 +1085,14 @@ wxFileDialog::wxFileDialog(wxWindow *parent,
 
     buttonsizer->Add( 30, 5, 1 );
 
 
     buttonsizer->Add( 30, 5, 1 );
 

-    but = new wxBitmapButton( this, ID_UP_DIR, wxBitmap( dir_up_xpm ) );
+    wxWindow *butDirUp = 
+        new wxBitmapButton( this, ID_UP_DIR, wxBitmap( dir_up_xpm ) );

 #if wxUSE_TOOLTIPS
 #if wxUSE_TOOLTIPS

-    but->SetToolTip( _("Go to parent directory") );
+    butDirUp->SetToolTip( _("Go to parent directory") );

 #endif
 #endif

-    buttonsizer->Add( but, 0, wxALL, 5 );
+    buttonsizer->Add( butDirUp, 0, wxALL, 5 );

 
 

+#ifndef __DOS__ // VS: Home directory is meaningless in MS-DOS...

     but = new wxBitmapButton( this, ID_PARENT_DIR, wxBitmap(home_xpm) );
 #if wxUSE_TOOLTIPS
     but->SetToolTip( _("Go to home directory") );
     but = new wxBitmapButton( this, ID_PARENT_DIR, wxBitmap(home_xpm) );
 #if wxUSE_TOOLTIPS
     but->SetToolTip( _("Go to home directory") );


@@ -973,12 +1100,14 @@ wxFileDialog::wxFileDialog(wxWindow *parent,
     buttonsizer->Add( but, 0, wxALL, 5);
 
     buttonsizer->Add( 20, 20 );
     buttonsizer->Add( but, 0, wxALL, 5);
 
     buttonsizer->Add( 20, 20 );

+#endif //!__DOS__

 
 

-    but = new wxBitmapButton( this, ID_NEW_DIR, wxBitmap(new_dir_xpm) );
+    wxWindow *butNewDir = 
+        new wxBitmapButton( this, ID_NEW_DIR, wxBitmap(new_dir_xpm) );

 #if wxUSE_TOOLTIPS
 #if wxUSE_TOOLTIPS

-    but->SetToolTip( _("Create new directory") );
+    butNewDir->SetToolTip( _("Create new directory") );

 #endif
 #endif

-    buttonsizer->Add( but, 0, wxALL, 5 );
+    buttonsizer->Add( butNewDir, 0, wxALL, 5 );

 
     mainsizer->Add( buttonsizer, 0, wxALL | wxEXPAND, 5 );
 
 
     mainsizer->Add( buttonsizer, 0, wxALL | wxEXPAND, 5 );
 


@@ -990,11 +1119,14 @@ wxFileDialog::wxFileDialog(wxWindow *parent,
 
     if (m_dialogStyle & wxMULTIPLE)
         m_list = new wxFileCtrl( this, ID_LIST_CTRL, m_dir, firstWild, wxDefaultPosition,
 
     if (m_dialogStyle & wxMULTIPLE)
         m_list = new wxFileCtrl( this, ID_LIST_CTRL, m_dir, firstWild, wxDefaultPosition,

-                                 wxSize(440,180), s_lastViewStyle | wxSUNKEN_BORDER );
+                                 wxSize(540,200), s_lastViewStyle | wxSUNKEN_BORDER );

     else
         m_list = new wxFileCtrl( this, ID_LIST_CTRL, m_dir, firstWild, wxDefaultPosition,
     else
         m_list = new wxFileCtrl( this, ID_LIST_CTRL, m_dir, firstWild, wxDefaultPosition,

-                                 wxSize(440,180), s_lastViewStyle | wxSUNKEN_BORDER | wxLC_SINGLE_SEL );
-    m_list -> ShowHidden(s_lastShowHidden);
+                                 wxSize(540,200), s_lastViewStyle | wxSUNKEN_BORDER | wxLC_SINGLE_SEL );
+    m_list->ShowHidden(s_lastShowHidden);
+    m_list->SetNewDirControl(butNewDir);
+    m_list->SetGoToParentControl(butDirUp);
+    

     mainsizer->Add( m_list, 1, wxEXPAND | wxLEFT|wxRIGHT, 10 );
 
     wxBoxSizer *textsizer = new wxBoxSizer( wxHORIZONTAL );
     mainsizer->Add( m_list, 1, wxEXPAND | wxLEFT|wxRIGHT, 10 );
 
     wxBoxSizer *textsizer = new wxBoxSizer( wxHORIZONTAL );


@@ -1035,16 +1167,16 @@ wxFileDialog::wxFileDialog(wxWindow *parent,
     else
 */
         m_text->SetFocus();
     else
 */
         m_text->SetFocus();

-
-    wxEndBusyCursor();

 }
 
 wxFileDialog::~wxFileDialog()
 {
     if (wxConfig::Get(FALSE))
     {
 }
 
 wxFileDialog::~wxFileDialog()
 {
     if (wxConfig::Get(FALSE))
     {

-        wxConfig::Get() -> Write(wxT("/wxWindows/wxFileDialog/ViewStyle"), s_lastViewStyle);
-        wxConfig::Get() -> Write(wxT("/wxWindows/wxFileDialog/ShowHidden"), s_lastShowHidden);
+        wxConfig::Get()->Write(wxT("/wxWindows/wxFileDialog/ViewStyle"),
+                               s_lastViewStyle);
+        wxConfig::Get()->Write(wxT("/wxWindows/wxFileDialog/ShowHidden"),
+                               s_lastShowHidden);

     }
 }
 
     }
 }
 


@@ -1089,7 +1221,8 @@ void wxFileDialog::OnSelected( wxListEvent &event )
 
     wxString dir;
     m_list->GetDir( dir );
 
     wxString dir;
     m_list->GetDir( dir );

-    if (dir != wxT("/")) dir += wxT("/");
+    if (!IsTopMostDir(dir))
+        dir += wxFILE_SEP_PATH;

     dir += filename;
     if (wxDirExists(dir)) return;
 
     dir += filename;
     if (wxDirExists(dir)) return;
 


@@ -1113,6 +1246,7 @@ void wxFileDialog::HandleAction( const wxString &fn )
         return;
     }
 
         return;
     }
 

+#ifdef __UNIX__

     if (filename == wxT("~"))
     {
         m_list->GoToHomeDir();
     if (filename == wxT("~"))
     {
         m_list->GoToHomeDir();


@@ -1130,11 +1264,12 @@ void wxFileDialog::HandleAction( const wxString &fn )
         tmp += filename;
         filename = tmp;
     }
         tmp += filename;
         filename = tmp;
     }

+#endif // __UNIX__

 
     if ((filename.Find(wxT('*')) != wxNOT_FOUND) ||
         (filename.Find(wxT('?')) != wxNOT_FOUND))
     {
 
     if ((filename.Find(wxT('*')) != wxNOT_FOUND) ||
         (filename.Find(wxT('?')) != wxNOT_FOUND))
     {

-        if (filename.Find(wxT('/')) != wxNOT_FOUND)
+        if (filename.Find(wxFILE_SEP_PATH) != wxNOT_FOUND)

         {
             wxMessageBox(_("Illegal file specification."), _("Error"), wxOK | wxICON_ERROR );
             return;
         {
             wxMessageBox(_("Illegal file specification."), _("Error"), wxOK | wxICON_ERROR );
             return;


@@ -1143,8 +1278,9 @@ void wxFileDialog::HandleAction( const wxString &fn )
         return;
     }
 
         return;
     }
 

-    if (dir != wxT("/")) dir += wxT("/");
-    if (filename[0u] != wxT('/'))
+    if (!IsTopMostDir(dir))
+        dir += wxFILE_SEP_PATH;
+    if (!wxIsAbsolutePath(filename))

     {
         dir += filename;
         filename = dir;
     {
         dir += filename;
         filename = dir;


@@ -1162,7 +1298,7 @@ void wxFileDialog::HandleAction( const wxString &fn )
     if ( (m_dialogStyle & wxSAVE) && (m_dialogStyle & wxOVERWRITE_PROMPT) )
     {
         if (filename.Find( wxT('.') ) == wxNOT_FOUND ||
     if ( (m_dialogStyle & wxSAVE) && (m_dialogStyle & wxOVERWRITE_PROMPT) )
     {
         if (filename.Find( wxT('.') ) == wxNOT_FOUND ||

-                filename.AfterLast( wxT('.') ).Find( wxT('/') ) != wxNOT_FOUND)
+                filename.AfterLast( wxT('.') ).Find( wxFILE_SEP_PATH ) != wxNOT_FOUND)

             filename << m_filterExtension;
         if (wxFileExists( filename ))
         {
             filename << m_filterExtension;
         if (wxFileExists( filename ))
         {


@@ -1178,7 +1314,7 @@ void wxFileDialog::HandleAction( const wxString &fn )
     {
         if ( !wxFileExists( filename ) )
             if (filename.Find( wxT('.') ) == wxNOT_FOUND ||
     {
         if ( !wxFileExists( filename ) )
             if (filename.Find( wxT('.') ) == wxNOT_FOUND ||

-                  filename.AfterLast( wxT('.') ).Find( wxT('/') ) != wxNOT_FOUND)
+                  filename.AfterLast( wxT('.') ).Find( wxFILE_SEP_PATH ) != wxNOT_FOUND)

                 filename << m_filterExtension;
 
         if ( m_dialogStyle & wxFILE_MUST_EXIST )
                 filename << m_filterExtension;
 
         if ( m_dialogStyle & wxFILE_MUST_EXIST )


@@ -1280,7 +1416,10 @@ void wxFileDialog::GetPaths( wxArrayString& paths ) const
 
     wxString dir;
     m_list->GetDir( dir );
 
     wxString dir;
     m_list->GetDir( dir );

-    if (dir != wxT("/")) dir += wxT("/");
+#ifdef __UNIX__
+    if (dir != wxT("/")) 
+#endif
+        dir += wxFILE_SEP_PATH;

 
     wxListItem item;
     item.m_mask = wxLIST_MASK_TEXT;
 
     wxListItem item;
     item.m_mask = wxLIST_MASK_TEXT;