]> git.saurik.com Git - wxWidgets.git/blobdiff - src/mac/control.cpp
formatting
[wxWidgets.git] / src / mac / control.cpp
index d570e2c5a1ee02a7a0129150830ca9e1cffc83d0..8c19e3cec28ee9585c8508cd60fa0213d8038fde 100644 (file)
 #pragma implementation "control.h"
 #endif
 
+#include "wx/defs.h"
+
 #include "wx/control.h"
+#include "wx/panel.h"
+#include "wx/app.h"
+#include "wx/dc.h"
 #include "wx/notebook.h"
 #include "wx/tabctrl.h"
+#include "wx/radiobox.h"
 #include "wx/spinbutt.h"
+#include "wx/scrolbar.h"
+#include "wx/button.h"
+#include "wx/dialog.h"
+#include "wx/statbox.h"
+#include "wx/sizer.h"
+#include "wx/stattext.h"
 
 #if !USE_SHARED_LIBRARY
 IMPLEMENT_ABSTRACT_CLASS(wxControl, wxWindow)
@@ -28,12 +40,13 @@ BEGIN_EVENT_TABLE(wxControl, wxWindow)
 END_EVENT_TABLE()
 #endif
 
-#include <wx/mac/uma.h>
+#include "wx/mac/uma.h"
 
 // Item members
 
 ControlActionUPP wxMacLiveScrollbarActionUPP = NULL ;
 
+pascal void wxMacLiveScrollbarActionProc( ControlHandle control , ControlPartCode partCode ) ;
 pascal void wxMacLiveScrollbarActionProc( ControlHandle control , ControlPartCode partCode )
 {
        if ( partCode != 0)
@@ -48,101 +61,154 @@ pascal void wxMacLiveScrollbarActionProc( ControlHandle control , ControlPartCod
 
 wxControl::wxControl()
 {
-               m_macControl = NULL ;
-               m_macHorizontalBorder = 0 ; // additional pixels around the real control
-               m_macVerticalBorder = 0 ;
+       m_macControl = NULL ;
+       m_macHorizontalBorder = 0 ; // additional pixels around the real control
+       m_macVerticalBorder = 0 ;
     m_backgroundColour = *wxWHITE;
     m_foregroundColour = *wxBLACK;
-    m_callback = 0;
+#if WXWIN_COMPATIBILITY
+  m_callback = 0;
+#endif // WXWIN_COMPATIBILITY
 
        if ( wxMacLiveScrollbarActionUPP == NULL )
        {
+#if defined(UNIVERSAL_INTERFACES_VERSION) && (UNIVERSAL_INTERFACES_VERSION >= 0x0340)
+        wxMacLiveScrollbarActionUPP = NewControlActionUPP( wxMacLiveScrollbarActionProc );
+#else
                wxMacLiveScrollbarActionUPP = NewControlActionProc( wxMacLiveScrollbarActionProc ) ;
+#endif
        }
 }
 
+bool wxControl::Create(wxWindow *parent, wxWindowID id,
+                       const wxPoint& pos,
+                       const wxSize& size, long style,
+                       const wxValidator& validator,
+                       const wxString& name)
+{
+       m_macControl = NULL ;
+       m_macHorizontalBorder = 0 ; // additional pixels around the real control
+       m_macVerticalBorder = 0 ;
+    bool rval = wxWindow::Create(parent, id, pos, size, style, name);
+    if (rval) {
+#if wxUSE_VALIDATORS
+        SetValidator(validator);
+#endif
+    }
+    return rval;
+}
+
 wxControl::~wxControl()
 {
+    m_isBeingDeleted = TRUE;
     // If we delete an item, we should initialize the parent panel,
     // because it could now be invalid.
-    wxWindow *parent = (wxWindow *)GetParent();
-    if (parent)
+    wxPanel *panel = wxDynamicCast(GetParent(), wxPanel);
+    if ( panel )
     {
-        if (parent->GetDefaultItem() == (wxButton*) this)
-            parent->SetDefaultItem(NULL);
+        if (panel->GetDefaultItem() == (wxButton*) this)
+            panel->SetDefaultItem(NULL);
     }
     if ( m_macControl )
     {
-       UMADisposeControl( m_macControl ) ;
+       ::DisposeControl( m_macControl ) ;
        m_macControl = NULL ;
     }
 }
 
-void wxControl::SetLabel(const wxString& label)
+void wxControl::SetLabel(const wxString& title)
 {
-       m_label = label ;
+       m_label = title ;
 
        if ( m_macControl )
        {
                Str255 maclabel ;
-               
-               strcpy( (char*) maclabel , label ) ;
-               c2pstr( (char*) maclabel ) ;
+               wxString label ;
        
+               if( wxApp::s_macDefaultEncodingIsPC )
+                       label = wxMacMakeMacStringFromPC( title ) ;
+               else
+                       label = title ;
+               
+#if TARGET_CARBON
+               c2pstrcpy( (StringPtr) maclabel , label ) ;
+#else
+               strcpy( (char *) maclabel , label ) ;
+               c2pstr( (char *) maclabel ) ;
+#endif
                ::SetControlTitle( m_macControl , maclabel ) ;
        }
+       Refresh() ;
 }
 
-wxString wxControl::GetLabel() const
+wxSize wxControl::DoGetBestSize() const
 {
-    return m_label ;
+       Rect    bestsize = { 0 , 0 , 0 , 0 } ;
+       short   baselineoffset ;
+       int bestWidth, bestHeight ;
+       ::GetBestControlRect( m_macControl , &bestsize , &baselineoffset ) ;
+
+       if ( EmptyRect( &bestsize ) )
+       {
+               baselineoffset = 0;
+               bestsize.left = bestsize.top = 0 ;
+               bestsize.right = 16 ;
+               bestsize.bottom = 16 ;
+               if ( IsKindOf( CLASSINFO( wxScrollBar ) ) )
+               {
+                       bestsize.bottom = 16 ;
+               }
+               else if ( IsKindOf( CLASSINFO( wxSpinButton ) ) )
+               {
+                       bestsize.bottom = 24 ; 
+               }
+       }
+
+       if ( IsKindOf( CLASSINFO( wxButton ) ) )
+       {
+               bestWidth = m_label.Length() * 8 + 12 ;
+               if ( bestWidth < 70 )
+                 bestWidth = 70 ;
+       }
+       else if ( IsKindOf( CLASSINFO( wxStaticText ) ) )
+       {
+               bestWidth = m_label.Length() * 8 ;
+       }
+       else
+               bestWidth = bestsize.right - bestsize.left ;
+               
+       bestWidth += 2 * m_macHorizontalBorder ;
+
+       bestHeight = bestsize.bottom - bestsize.top ;
+       if ( bestHeight < 10 )
+               bestHeight = 13 ;
+
+       bestHeight += 2 * m_macVerticalBorder;
+
+               
+    return wxSize(bestWidth, bestHeight);
 }
 
-void wxControl::ProcessCommand (wxCommandEvent & event)
+bool wxControl::ProcessCommand (wxCommandEvent & event)
 {
   // Tries:
   // 1) A callback function (to become obsolete)
   // 2) OnCommand, starting at this window and working up parent hierarchy
   // 3) OnCommand then calls ProcessEvent to search the event tables.
-  if (m_callback)
+#if WXWIN_COMPATIBILITY
+    if ( m_callback )
     {
-      (void) (*(m_callback)) (*this, event);
+        (void)(*m_callback)(this, event);
+
+        return TRUE;
     }
     else
+#endif // WXWIN_COMPATIBILITY
     {
-      GetEventHandler()->OnCommand(*this, event);
+      return GetEventHandler()->ProcessEvent(event);
     }
 }
 
-void wxControl::Centre (int direction)
-{
-  int x, y, width, height, panel_width, panel_height, new_x, new_y;
-
-  wxWindow *parent = (wxWindow *) GetParent ();
-  if (!parent)
-    return;
-
-  parent->GetClientSize (&panel_width, &panel_height);
-  GetSize (&width, &height);
-  GetPosition (&x, &y);
-
-  new_x = x;
-  new_y = y;
-
-  if (direction & wxHORIZONTAL)
-    new_x = (int) ((panel_width - width) / 2);
-
-  if (direction & wxVERTICAL)
-    new_y = (int) ((panel_height - height) / 2);
-
-  SetSize (new_x, new_y, width, height);
-}
-
-void wxControl::SetClientSize (int width, int height)
-{
-  SetSize (-1, -1, width, height);
-}
-
 // ------------------------
 wxList *wxWinMacControlList = NULL;
 wxControl *wxFindControlFromMacControl(ControlHandle inControl )
@@ -180,7 +246,7 @@ void wxControl::MacPreControlCreate( wxWindow *parent, wxWindowID id, wxString l
        SetValidator(validator);
 
   m_windowStyle = style;
-  parent->AddChild((wxButton *)this);
+  parent->AddChild(this);
 
   m_backgroundColour = parent->GetBackgroundColour() ;
   m_foregroundColour = parent->GetForegroundColour() ;
@@ -190,31 +256,31 @@ void wxControl::MacPreControlCreate( wxWindow *parent, wxWindowID id, wxString l
   else
       m_windowId = id;
 
+   // These sizes will be adjusted in MacPostControlCreate
+
        m_width = size.x ;
        m_height = size.y ;
-       int x = pos.x ;
-       int y = pos.y ;
-       AdjustForParentClientOrigin(x, y, wxSIZE_USE_EXISTING);
-       m_x = x ;
-       m_y = y ;
+       m_x = pos.x ;
+       m_y = pos.y ;
                
+       outBounds->top = -10;
+       outBounds->left = -10;
+       outBounds->bottom = 0;
+       outBounds->right = 0;
 
-       Point localOrigin ;
-       Rect    clipRect ;
-       
-       parent->MacClientToRootWindow( &x , &y ) ;
-       outBounds->top = y + m_macVerticalBorder ;
-       outBounds->left = x + m_macHorizontalBorder ;
-       outBounds->bottom = outBounds->top + m_height - 2 * m_macVerticalBorder;
-       outBounds->right = outBounds->left + m_width - 2 * m_macHorizontalBorder ;
-
-       strcpy( (char*) maclabel , label ) ;
+       char c_text[255];
+       strcpy( c_text , label ) ;
        if( wxApp::s_macDefaultEncodingIsPC )
        {
-               wxMacConvertFromPCForControls( (char*) maclabel ) ;
+               wxMacConvertFromPCForControls( c_text ) ;
        }
 
-       c2pstr( (char*) maclabel ) ;
+#if TARGET_CARBON
+       c2pstrcpy( (StringPtr) maclabel , c_text ) ;
+#else
+       strcpy( (char *) maclabel , c_text ) ;
+       c2pstr( (char *) maclabel ) ;
+#endif
 }
 
 void wxControl::MacPostControlCreate()
@@ -225,13 +291,13 @@ void wxControl::MacPostControlCreate()
        {
                // no font
        }
-       else if ( IsKindOf( CLASSINFO( wxStaticBox ) ) )
+       else if ( IsKindOf( CLASSINFO( wxStaticBox ) ) || IsKindOf( CLASSINFO( wxRadioBox ) ) || IsKindOf( CLASSINFO( wxButton ) ) )
        {
                ControlFontStyleRec             controlstyle ;
                controlstyle.flags = kControlUseFontMask ;
                controlstyle.font = kControlFontSmallBoldSystemFont ;
                
-               ::UMASetControlFontStyle( m_macControl , &controlstyle ) ;
+               ::SetControlFontStyle( m_macControl , &controlstyle ) ;
        }
        else
        {
@@ -239,24 +305,44 @@ void wxControl::MacPostControlCreate()
                controlstyle.flags = kControlUseFontMask ;
                controlstyle.font = kControlFontSmallSystemFont ;
                
-               ::UMASetControlFontStyle( m_macControl , &controlstyle ) ;
+               ::SetControlFontStyle( m_macControl , &controlstyle ) ;
        }
        ControlHandle container = GetParent()->MacGetContainerForEmbedding() ;
-       wxASSERT_MSG( container != NULL , "No valid mac container control" ) ;
-       ::UMAEmbedControl( m_macControl , container ) ;
-       MacAdjustControlRect() ;
+       wxASSERT_MSG( container != NULL , wxT("No valid mac container control") ) ;
+       ::EmbedControl( m_macControl , container ) ;
+       m_macControlIsShown  = true ;
+
        wxAssociateControlWithMacControl( m_macControl , this ) ;
+
+     // Adjust the controls size and position
+     wxPoint pos(m_x, m_y);
+     wxSize best_size( DoGetBestSize() );
+     wxSize new_size( m_width, m_height );
+     m_x = m_y = m_width = m_height = -1;  // Forces SetSize to move/size the control
+     if (new_size.x == -1) {
+        new_size.x = best_size.x;
+     }
+     if (new_size.y == -1) {
+         new_size.y = best_size.y;
+     }
+     SetSize(pos.x, pos.y, new_size.x, new_size.y);
+     UMAShowControl( m_macControl ) ;
 }
 
 void wxControl::MacAdjustControlRect() 
 {
-       wxASSERT_MSG( m_macControl != NULL , "No valid mac control" ) ;
+       wxASSERT_MSG( m_macControl != NULL , wxT("No valid mac control") ) ;
        if ( m_width == -1 || m_height == -1 )
        {
                Rect    bestsize = { 0 , 0 , 0 , 0 } ;
                short   baselineoffset ;
                
-               UMAGetBestControlRect( m_macControl , &bestsize , &baselineoffset ) ;
+               ::GetBestControlRect( m_macControl , &bestsize , &baselineoffset ) ;
 
                if ( EmptyRect( &bestsize ) )
                {
@@ -278,14 +364,18 @@ void wxControl::MacAdjustControlRect()
                {
                        if ( IsKindOf( CLASSINFO( wxButton ) ) )
                        {
-                               m_width = m_label.Length() * 8 + 12 + 2 * m_macHorizontalBorder;
+                               m_width = m_label.Length() * 8 + 12 ;
+                               if ( m_width < 70 )
+                                 m_width = 70 ;
                        }
                        else if ( IsKindOf( CLASSINFO( wxStaticText ) ) )
                        {
                                m_width = m_label.Length() * 8 ;
                        }
                        else
-                               m_width = bestsize.right - bestsize.left + 2 * m_macHorizontalBorder;
+                               m_width = bestsize.right - bestsize.left ;
+                       
+                       m_width += 2 * m_macHorizontalBorder ;
                }
                if ( m_height == -1 )
                {
@@ -299,7 +389,7 @@ void wxControl::MacAdjustControlRect()
                wxMacDrawingHelper helper ( wxFindWinFromMacWindow( GetMacRootWindow() ) ) ;
                if ( helper.Ok() )
                {
-           UMASizeControl( m_macControl , m_width - 2 * m_macHorizontalBorder, m_height -  2 * m_macVerticalBorder ) ;
+               UMASizeControl( m_macControl , m_width - 2 * m_macHorizontalBorder, m_height -  2 * m_macVerticalBorder ) ;
                }
        }
 }
@@ -315,35 +405,37 @@ void wxControl::MacSuperChangedPosition()
 {
        if ( m_macControl )
        {
-               int former_mac_x = (**m_macControl).contrlRect.left ;
-               int former_mac_y = (**m_macControl).contrlRect.top ;
+               Rect contrlRect ;               
+               GetControlBounds( m_macControl , &contrlRect ) ; 
+               int former_mac_x = contrlRect.left ;
+               int former_mac_y = contrlRect.top ;
                int mac_x = m_x ;
                int mac_y = m_y ;
                GetParent()->MacClientToRootWindow( & mac_x , & mac_y ) ;
                
                WindowRef rootwindow = GetMacRootWindow() ;
                wxWindow* wxrootwindow = wxFindWinFromMacWindow( rootwindow ) ;
-               UMASetThemeWindowBackground( rootwindow , kThemeBrushDialogBackgroundActive , false ) ;
+               ::SetThemeWindowBackground( rootwindow , kThemeBrushDialogBackgroundActive , false ) ;
                wxMacDrawingHelper focus( wxrootwindow ) ;
        
                if ( mac_x != former_mac_x || mac_y != former_mac_y )
                {
-                       {
-                               Rect inval = { former_mac_y , former_mac_x , former_mac_y + m_height , former_mac_x + m_width } ;
-                               InvalRect( &inval ) ;
-                       }
-               UMAMoveControl( m_macControl , mac_x + m_macHorizontalBorder , mac_y + m_macVerticalBorder ) ;
-                       {
-                               Rect inval = { mac_y , mac_x , mac_y + m_height , mac_x + m_width } ;
-                               InvalRect( &inval ) ;
-                       }
+                       {
+                               Rect inval = { former_mac_y , former_mac_x , former_mac_y + m_height , former_mac_x + m_width } ;
+                               InvalWindowRect( rootwindow , &inval ) ;
+                       }
+                       UMAMoveControl( m_macControl , mac_x + m_macHorizontalBorder , mac_y + m_macVerticalBorder ) ;
+                       {
+                               Rect inval = { mac_y , mac_x , mac_y + m_height , mac_x + m_width } ;
+                               InvalWindowRect( rootwindow , &inval ) ;
+                       }
                }
                if ( wxrootwindow->IsKindOf( CLASSINFO( wxDialog ) ) )
                {
                }
                else
                {
-                       UMASetThemeWindowBackground( rootwindow , kThemeBrushDocumentWindowBackground , false ) ;
+                       ::SetThemeWindowBackground( rootwindow , kThemeBrushDocumentWindowBackground , false ) ;
                }
        }
 
@@ -352,6 +444,7 @@ void wxControl::MacSuperChangedPosition()
 
 void wxControl::MacSuperEnabled( bool enabled ) 
 {
+/*
        if ( m_macControl )
        {
                if ( UMAHasAppearance() )
@@ -380,6 +473,7 @@ void wxControl::MacSuperEnabled( bool enabled )
                }
        }
        wxWindow::MacSuperEnabled( enabled ) ;
+*/
 }
 
 void  wxControl::MacSuperShown( bool show ) 
@@ -388,12 +482,19 @@ void  wxControl::MacSuperShown( bool show )
        {
                if ( !show )
                {
-                       ::UMAHideControl( m_macControl ) ;
+                       if ( m_macControlIsShown )
+                       {
+                               ::HideControl( m_macControl ) ;
+                               m_macControlIsShown = false ;
+                       }
                }
                else
                {
-                       if ( m_macShown )
+                       if ( MacIsReallyShown() && !m_macControlIsShown )
+                       {
                                ::UMAShowControl( m_macControl ) ;
+                               m_macControlIsShown = true ;
+                       }
                }
        }
                
@@ -410,144 +511,170 @@ void  wxControl::DoSetSize(int x, int y,
                return ;
        }
 
-       WindowRef rootwindow = GetMacRootWindow() ;
-       wxWindow* wxrootwindow = wxFindWinFromMacWindow( rootwindow ) ;
-       UMASetThemeWindowBackground( rootwindow , kThemeBrushDialogBackgroundActive , false ) ;
-               
-       int former_x = m_x ;
-       int former_y = m_y ;
-       int former_w = m_width ;
-       int former_h = m_height ;
-       
-       int former_mac_x = (**m_macControl).contrlRect.left ;
-       int former_mac_y = (**m_macControl).contrlRect.top ;
-       
-  int currentX, currentY;
-  GetPosition(&currentX, &currentY);
-  int currentW,currentH;
-  GetSize(&currentW, &currentH);
-
-  int actualWidth = width;
-  int actualHeight = height;
-  int actualX = x;
-  int actualY = y;
-  if (x == -1 || (sizeFlags & wxSIZE_ALLOW_MINUS_ONE))
-      actualX = currentX;
-  if (y == -1 || (sizeFlags & wxSIZE_ALLOW_MINUS_ONE))
-      actualY = currentY;
-  if (width == -1)
-      actualWidth = currentW ;
-  if (height == -1)
-      actualHeight = currentH ;
-
-       if ( actualX == currentX && actualY == currentY && actualWidth == currentW && actualHeight == currentH)
-               return ;
-               
-       AdjustForParentClientOrigin(actualX, actualY, sizeFlags);
-       wxMacDrawingHelper focus( wxFindWinFromMacWindow( GetMacRootWindow() ) ) ;
-
-       int mac_x = actualX ;
-       int mac_y = actualY ;
-       GetParent()->MacClientToRootWindow( & mac_x , & mac_y ) ;
-       
-       if ( mac_x != former_mac_x || mac_y != former_mac_y )
-       {
-               {
-                       Rect inval = { former_mac_y , former_mac_x , former_mac_y + m_height , former_mac_x + m_width } ;
-                       InvalRect( &inval ) ;
-               }
-       UMAMoveControl( m_macControl , mac_x + m_macHorizontalBorder , mac_y  + m_macVerticalBorder ) ;
-               {
-                       Rect inval = { mac_y , mac_x , mac_y + m_height , mac_x + m_width } ;
-                       InvalRect( &inval ) ;
-               }
-       }
+     Rect oldbounds, newbounds;
+     int new_x, new_y, new_width, new_height;
+     int mac_x, mac_y;
+     new_x = m_x;
+     new_y = m_y;
+     new_width  = m_width;
+     new_height = m_height;
+     if (sizeFlags & wxSIZE_ALLOW_MINUS_ONE)
+     {
+         new_x      = x;
+         new_y      = y;
+         new_width  = width;
+         new_height = height;
+     }
+     else
+     {
+         if (x != -1)      new_x      = x;
+         if (y != -1)      new_y      = y;
+         if (width != -1)  new_width  = width;
+         if (height != -1) new_height = height;
+     }
+     if(sizeFlags & wxSIZE_AUTO)
+     {
+         wxSize size = GetBestSize();
+         if (sizeFlags & wxSIZE_AUTO_WIDTH)
+         {
+             if (width == -1)   new_width = size.x;
+         }
+         if (sizeFlags & wxSIZE_AUTO_HEIGHT)
+         {
+             if (height == -1)   new_height = size.y;
+         }
+     }
+     AdjustForParentClientOrigin(new_x, new_y, sizeFlags);
+     mac_x = new_x;
+     mac_y = new_y;
+     if(GetParent()) {
+         GetParent()->MacClientToRootWindow(&mac_x, &mac_y);
+     }
+     GetControlBounds(m_macControl, &oldbounds);
+     oldbounds.right = oldbounds.left + m_width;
+     oldbounds.bottom = oldbounds.top + m_height;
+     bool doMove = false;
+     bool doResize = false;
+     if ( mac_x != (oldbounds.left - m_macHorizontalBorder) ||
+          mac_y != (oldbounds.top - m_macVerticalBorder) )
+     {
+         doMove = true ;
+     }
+     if ( new_width != oldbounds.right - oldbounds.left - 2 * m_macHorizontalBorder ||
+          new_height != oldbounds.bottom - oldbounds.top - 2 * m_macVerticalBorder)
+     {
+         doResize = true ;
+     }
+     if ( doMove || doResize )
+     {
+         // Ensure resize is within constraints
+         if ((m_minWidth != -1) && (new_width < m_minWidth)) {
+             new_width = m_minWidth;
+         }
+         if ((m_minHeight != -1) && (new_height < m_minHeight)) {
+             new_height = m_minHeight;
+         }
+         if ((m_maxWidth != -1) && (new_width > m_maxWidth)) {
+             new_width = m_maxWidth;
+         }
+         if ((m_maxHeight != -1) && (new_height > m_maxHeight)) {
+             new_height = m_maxHeight;
+         }
+         if ( doMove )
+         {
+             m_x = new_x;
+             m_y = new_y;
+             UMAMoveControl(m_macControl,
+                            mac_x + m_macHorizontalBorder, mac_y + m_macVerticalBorder);
+             wxMoveEvent event(wxPoint(m_x, m_y), m_windowId);
+             event.SetEventObject(this);
+             GetEventHandler()->ProcessEvent(event) ;
+         }
+         if ( doResize )
+         {
+             m_width = new_width;
+             m_height = new_height;
+             UMASizeControl( m_macControl,
+                             m_width - 2 * m_macHorizontalBorder,
+                             m_height -  2 * m_macVerticalBorder ) ;
+             wxSizeEvent event(wxSize(m_width, m_height), m_windowId);
+             event.SetEventObject(this);
+             GetEventHandler()->ProcessEvent(event);
+         }
+         // Set up port
+         WindowRef rootwindow = GetMacRootWindow() ;
+         wxWindow* wxrootwindow = wxFindWinFromMacWindow( rootwindow ) ;
+         wxMacDrawingHelper focus( wxrootwindow );
+         ::SetThemeWindowBackground( rootwindow , kThemeBrushDialogBackgroundActive , false ) ;
+         // Update window at old and new positions
+         SetRect(&newbounds, m_x, m_y, m_x + m_width, m_y + m_height);
+         InvalWindowRect( rootwindow , &oldbounds );
+         InvalWindowRect( rootwindow , &newbounds );
+         MacRepositionScrollBars() ;
+         if ( !wxrootwindow->IsKindOf( CLASSINFO( wxDialog ) ) )
+         {
+             ::SetThemeWindowBackground( rootwindow, kThemeBrushDocumentWindowBackground, false );
+         }
+     }
+}
 
-       if ( actualX != former_x || actualY != former_y )
-       {
-               m_x = actualX ;
-               m_y = actualY ;
-
-               MacRepositionScrollBars() ;
-               // To consider -> should the parameters be the effective or the virtual coordinates (AdjustForParent..)
-    wxMoveEvent event(wxPoint(m_x, m_y), m_windowId);
-    event.SetEventObject(this);
-    GetEventHandler()->ProcessEvent(event);
-       }               
-       if ( actualWidth != former_w || actualHeight != former_h )
+bool  wxControl::Show(bool show) 
+{
+       if ( !wxWindow::Show( show ) )
+               return FALSE ;
+               
+       if ( m_macControl )
        {
+               if ( !show )
                {
-                       Rect inval = { mac_y , mac_x , mac_y + former_h , mac_x + former_w } ;
-                       InvalRect( &inval ) ;
+                       if ( m_macControlIsShown )
+                       {
+                               ::HideControl( m_macControl ) ;
+                               m_macControlIsShown = false ;
+                       }
                }
-               m_width = actualWidth ;
-               m_height = actualHeight ;
-
-       UMASizeControl( m_macControl ,  m_width - 2 * m_macHorizontalBorder, m_height -  2 * m_macVerticalBorder ) ;
+               else
                {
-                       Rect inval = { mac_y , mac_x , mac_y + m_height , mac_x + m_width } ;
-                       InvalRect( &inval ) ;
+                       if ( MacIsReallyShown() && !m_macControlIsShown )
+                       {
+                               ::UMAShowControl( m_macControl ) ;
+                               m_macControlIsShown = true ;
+                       }
                }
-
-               MacRepositionScrollBars() ;
-    wxSizeEvent event(wxSize(m_width, m_height), m_windowId);
-    event.SetEventObject(this);
-    GetEventHandler()->ProcessEvent(event);
-       }
-       if ( wxrootwindow->IsKindOf( CLASSINFO( wxDialog ) ) )
-       {
        }
-       else
-       {
-               UMASetThemeWindowBackground( rootwindow , kThemeBrushDocumentWindowBackground , false ) ;
-       }
-}
-
-void  wxControl::DoSetClientSize(int width, int height)
-{
-       DoSetSize( -1 , -1 , width , height ) ;
+       return TRUE ;
 }
 
-bool  wxControl::Show(bool show
+bool  wxControl::Enable(bool enable
 {
-       if ( m_macControl == NULL )
-               return wxWindow::Show( show ) ;
-       
-       if ( m_macShown == show )
-               return TRUE ;
+    if ( !wxWindow::Enable(enable) )
+        return FALSE;
 
-       if ( show )
-               ::UMAShowControl( m_macControl ) ;
-       else
-               ::UMAHideControl( m_macControl ) ;
-
-       return wxWindow::Show( show ) ;
-}
-
-void  wxControl::Enable(bool enable) 
-{
-       if ( m_macControl == NULL )
-               return wxWindow::Enable( enable ) ;
-       
-       if ( m_macEnabled == enable )
-               return ;
-
-       if ( UMAHasAppearance() )
-       {
-               if ( enable )
-                       ::ActivateControl( m_macControl ) ;
-               else
-                       ::DeactivateControl( m_macControl ) ;
-       }
-       else
+       if ( m_macControl )
        {
                if ( enable )
-                       ::HiliteControl( m_macControl , 0 ) ;
+                   UMAActivateControl( m_macControl ) ;
                else
-                       ::HiliteControl( m_macControl , 255 ) ;
+                   UMADeactivateControl( m_macControl ) ;
        }
-
-       return wxWindow::Enable( enable ) ;
+       return TRUE ;
 }
 
 void wxControl::Refresh(bool eraseBack, const wxRect *rect)
@@ -562,7 +689,7 @@ void wxControl::Refresh(bool eraseBack, const wxRect *rect)
   }
 }
 
-void wxControl::OnPaint(wxPaintEvent& event)
+void wxControl::MacRedrawControl()
 {
        if ( m_macControl )
        {
@@ -573,15 +700,15 @@ void wxControl::OnPaint(wxPaintEvent& event)
                        if ( win )
                        {
                                wxMacDrawingHelper help( win ) ;
+                               // the mac control manager always assumes to have the origin at 0,0
                                SetOrigin( 0 , 0 ) ;
                                
-                               bool                    hasTabBehind = false ;
                                wxWindow* parent = GetParent() ;
                                while ( parent )
                                {
-                                       if( parent->m_macWindowData )
+                                       if( parent->MacGetWindowData() )
                                        {
-                                               UMASetThemeWindowBackground( win->m_macWindowData->m_macWindow , kThemeBrushDialogBackgroundActive , false ) ;
+                                               ::SetThemeWindowBackground( win->MacGetWindowData()->m_macWindow , kThemeBrushDialogBackgroundActive , false ) ;
                                                break ;
                                        }
                                        
@@ -596,15 +723,63 @@ void wxControl::OnPaint(wxPaintEvent& event)
                                } 
                                
                                UMADrawControl( m_macControl ) ;
-                               UMASetThemeWindowBackground( win->m_macWindowData->m_macWindow , win->m_macWindowData->m_macWindowBackgroundTheme , false ) ;
+                               ::SetThemeWindowBackground( win->MacGetWindowData()->m_macWindow , win->MacGetWindowData()->m_macWindowBackgroundTheme , false ) ;
+                       }
+               }
+       }
+}
+
+void wxControl::OnPaint(wxPaintEvent& event)
+{
+       if ( m_macControl )
+       {
+               WindowRef window = GetMacRootWindow() ;
+               if ( window )
+               {
+                       wxWindow* win = wxFindWinFromMacWindow( window ) ;
+                       if ( win )
+                       {
+                               wxMacDrawingHelper help( win ) ;
+                               // the mac control manager always assumes to have the origin at 0,0
+                               SetOrigin( 0 , 0 ) ;
+
+                               wxWindow* parent = GetParent() ;
+                               while ( parent )
+                               {
+                                       if( parent->MacGetWindowData() )
+                                       {
+                                               ::SetThemeWindowBackground( win->MacGetWindowData()->m_macWindow , kThemeBrushDialogBackgroundActive , false ) ;
+                                               break ;
+                                       }
+                                       
+                                       if( parent->IsKindOf( CLASSINFO( wxNotebook ) ) ||  parent->IsKindOf( CLASSINFO( wxTabCtrl ) ))
+                                       {
+                                               if ( ((wxControl*)parent)->m_macControl )
+                                                       SetUpControlBackground( ((wxControl*)parent)->m_macControl , -1 , true ) ;
+                                               break ;
+                                       }
+                                       
+                                       parent = parent->GetParent() ;
+                               } 
+
+                               UMADrawControl( m_macControl ) ;
+                               ::SetThemeWindowBackground( win->MacGetWindowData()->m_macWindow , win->MacGetWindowData()->m_macWindowBackgroundTheme , false ) ;
                        }
                }
        }
        else
        {
-               wxWindow::OnPaint( event ) ;
+               // wxWindow::OnPaint( event ) ;
        }
 }
+void wxControl::OnEraseBackground(wxEraseEvent& event)
+{
+    // In general, you don't want to erase the background of a control,
+    // or you'll get a flicker.
+    // TODO: move this 'null' function into each control that
+    // might flicker.
+}
+
 
 void  wxControl::OnKeyDown( wxKeyEvent &event ) 
 {
@@ -617,7 +792,7 @@ void  wxControl::OnKeyDown( wxKeyEvent &event )
        keychar = short(ev->message & charCodeMask);
        keycode = short(ev->message & keyCodeMask) >> 8 ;
 
-       UMAHandleControlKey( m_macControl , keycode , keychar , ev->modifiers ) ;
+       ::HandleControlKey( m_macControl , keycode , keychar , ev->modifiers ) ;
 }
 
 void  wxControl::OnMouseEvent( wxMouseEvent &event ) 
@@ -628,7 +803,7 @@ void  wxControl::OnMouseEvent( wxMouseEvent &event )
                return ;
        }
                
-       if (event.GetEventType() == wxEVT_LEFT_DOWN )
+       if (event.GetEventType() == wxEVT_LEFT_DOWN || event.GetEventType() == wxEVT_LEFT_DCLICK )
        {
                        
                int x = event.m_x ;
@@ -638,7 +813,6 @@ void  wxControl::OnMouseEvent( wxMouseEvent &event )
                        
                ControlHandle   control ;
                Point           localwhere ;
-               GrafPtr         port ;
                SInt16          controlpart ;
                WindowRef       window = GetMacRootWindow() ;
                
@@ -661,25 +835,31 @@ void  wxControl::OnMouseEvent( wxMouseEvent &event )
        
                if ( event.m_metaDown )
                        modifiers |= cmdKey ;
-       
+/*
+#if TARGET_CARBON
+        control = FindControlUnderMouse( localwhere , window , &controlpart ) ;
+#else
                controlpart = FindControl( localwhere , window , &control ) ;
+#endif
+*/
                {
+               /*
                        if ( AcceptsFocus() && FindFocus() != this )
                        {
                                SetFocus() ;
                        }
-                       if ( control && UMAIsControlActive( control ) )
+               */
+                   control = m_macControl ;
+                       if ( control && ::IsControlActive( control ) )
                        {
                                {
-                                       if ( controlpart == kControlIndicatorPart && !UMAHasAppearance() )
-                                               controlpart = UMAHandleControlClick( control , localwhere , modifiers , (ControlActionUPP) NULL ) ;
-                                       else
-                                               controlpart = UMAHandleControlClick( control , localwhere , modifiers , (ControlActionUPP) -1 ) ;
+                                       controlpart = ::HandleControlClick( control , localwhere , modifiers , (ControlActionUPP) -1 ) ;
                                        wxTheApp->s_lastMouseDown = 0 ;
-                                       if ( controlpart && ! ( ( UMAHasAppearance() || (controlpart != kControlIndicatorPart) ) 
-                                               && (IsKindOf( CLASSINFO( wxScrollBar ) ) ) ) ) // otherwise we will get the event twice
+                                       if ( control && controlpart != kControlNoPart && 
+                                           ! IsKindOf( CLASSINFO( wxScrollBar ) ) 
+                                       ) // otherwise we will get the event twice for scrollbar
                                        {
-                                               MacHandleControlClick( control , controlpart ) ;
+                                           MacHandleControlClick( control , controlpart ) ;
                                        }
                                }
                        }