wxWindowBase::wxWindowBase()
{
// no window yet, no parent nor children
- m_parent = (wxWindow *)NULL;
+ m_parent = NULL;
m_windowId = wxID_ANY;
// no constraints on the minimal window size
#if wxUSE_VALIDATORS
// no validator
- m_windowValidator = (wxValidator *) NULL;
+ m_windowValidator = NULL;
#endif // wxUSE_VALIDATORS
// the colours/fonts are default for now, so leave m_font,
#if wxUSE_CONSTRAINTS
// no constraints whatsoever
- m_constraints = (wxLayoutConstraints *) NULL;
- m_constraintsInvolvedIn = (wxWindowList *) NULL;
+ m_constraints = NULL;
+ m_constraintsInvolvedIn = NULL;
#endif // wxUSE_CONSTRAINTS
- m_windowSizer = (wxSizer *) NULL;
- m_containingSizer = (wxSizer *) NULL;
+ m_windowSizer = NULL;
+ m_containingSizer = NULL;
m_autoLayout = false;
#if wxUSE_DRAG_AND_DROP
- m_dropTarget = (wxDropTarget *)NULL;
+ m_dropTarget = NULL;
#endif // wxUSE_DRAG_AND_DROP
#if wxUSE_TOOLTIPS
- m_tooltip = (wxToolTip *)NULL;
+ m_tooltip = NULL;
#endif // wxUSE_TOOLTIPS
#if wxUSE_CARET
- m_caret = (wxCaret *)NULL;
+ m_caret = NULL;
#endif // wxUSE_CARET
#if wxUSE_PALETTE
m_virtualSize = wxDefaultSize;
- m_scrollHelper = (wxScrollHelper *) NULL;
+ m_scrollHelper = NULL;
m_windowVariant = wxWINDOW_VARIANT_NORMAL;
#if wxUSE_SYSTEM_OPTIONS
// Whether we're using the current theme for this window (wxGTK only for now)
m_themeEnabled = false;
- // VZ: this one shouldn't exist...
+ // This is set to true by SendDestroyEvent() which should be called by the
+ // most derived class to ensure that the destruction event is sent as soon
+ // as possible to allow its handlers to still see the undestroyed window
m_isBeingDeleted = false;
m_freezeCount = 0;
void wxWindowBase::SendDestroyEvent()
{
+ if ( m_isBeingDeleted )
+ {
+ // we could have been already called from a more derived class dtor,
+ // e.g. ~wxTLW calls us and so does ~wxWindow and the latter call
+ // should be simply ignored
+ return;
+ }
+
+ m_isBeingDeleted = true;
+
wxWindowDestroyEvent event;
event.SetEventObject(this);
event.SetId(GetId());
bool wxWindowBase::Destroy()
{
+ SendDestroyEvent();
+
delete this;
return true;
wxWindow *child = node->GetData();
- // note that we really want to call delete and not ->Destroy() here
- // because we want to delete the child immediately, before we are
- // deleted, and delayed deletion would result in problems as our (top
- // level) child could outlive its parent
- delete child;
+ // note that we really want to delete it immediately so don't call the
+ // possible overridden Destroy() version which might not delete the
+ // child immediately resulting in problems with our (top level) child
+ // outliving its parent
+ child->wxWindowBase::Destroy();
wxASSERT_MSG( !GetChildren().Find(child),
wxT("child didn't remove itself using RemoveChild()") );
// event handler stuff
// ----------------------------------------------------------------------------
-void wxWindowBase::PushEventHandler(wxEvtHandler *handler)
+void wxWindowBase::SetEventHandler(wxEvtHandler *handler)
+{
+ wxCHECK_RET(handler != NULL, "SetEventHandler(NULL) called");
+
+ m_eventHandler = handler;
+}
+
+void wxWindowBase::SetNextHandler(wxEvtHandler *WXUNUSED(handler))
+{
+ // disable wxEvtHandler chain mechanism for wxWindows:
+ // wxWindow uses its own stack mechanism which doesn't mix well with wxEvtHandler's one
+
+ wxFAIL_MSG("wxWindow cannot be part of a wxEvtHandler chain");
+}
+void wxWindowBase::SetPreviousHandler(wxEvtHandler *WXUNUSED(handler))
{
+ // we can't simply wxFAIL here as in SetNextHandler: in fact the last
+ // handler of our stack when is destroyed will be Unlink()ed and thus
+ // will call this function to update the pointer of this window...
+
+ //wxFAIL_MSG("wxWindow cannot be part of a wxEvtHandler chain");
+}
+
+void wxWindowBase::PushEventHandler(wxEvtHandler *handlerToPush)
+{
+ wxCHECK_RET( handlerToPush != NULL, "PushEventHandler(NULL) called" );
+
+ // the new handler is going to be part of the wxWindow stack of event handlers:
+ // it can't be part also of an event handler double-linked chain:
+ wxASSERT_MSG(handlerToPush->IsUnlinked(),
+ "The handler being pushed in the wxWindow stack shouldn't be part of "
+ "a wxEvtHandler chain; call Unlink() on it first");
+
wxEvtHandler *handlerOld = GetEventHandler();
+ wxCHECK_RET( handlerOld, "an old event handler is NULL?" );
- handler->SetNextHandler(handlerOld);
+ // now use wxEvtHandler double-linked list to implement a stack:
+ handlerToPush->SetNextHandler(handlerOld);
- if ( handlerOld )
- GetEventHandler()->SetPreviousHandler(handler);
+ if (handlerOld != this)
+ handlerOld->SetPreviousHandler(handlerToPush);
- SetEventHandler(handler);
+ SetEventHandler(handlerToPush);
+
+#ifdef __WXDEBUG__
+ // final checks of the operations done above:
+ wxASSERT_MSG( handlerToPush->GetPreviousHandler() == NULL,
+ "the first handler of the wxWindow stack should have no previous handlers set" );
+ wxASSERT_MSG( handlerToPush->GetNextHandler() != NULL,
+ "the first handler of the wxWindow stack should have non-NULL next handler" );
+
+ wxEvtHandler* pLast = handlerToPush;
+ while (pLast && pLast != this)
+ pLast = pLast->GetNextHandler();
+ wxASSERT_MSG( pLast->GetNextHandler() == NULL,
+ "the last handler of the wxWindow stack should have this window as next handler" );
+#endif
}
wxEvtHandler *wxWindowBase::PopEventHandler(bool deleteHandler)
{
- wxEvtHandler *handlerA = GetEventHandler();
- if ( handlerA )
- {
- wxEvtHandler *handlerB = handlerA->GetNextHandler();
- handlerA->SetNextHandler((wxEvtHandler *)NULL);
+ // we need to pop the wxWindow stack, i.e. we need to remove the first handler
- if ( handlerB )
- handlerB->SetPreviousHandler((wxEvtHandler *)NULL);
- SetEventHandler(handlerB);
+ wxEvtHandler *firstHandler = GetEventHandler();
+ wxCHECK_MSG( firstHandler != NULL, NULL, "wxWindow cannot have a NULL event handler" );
+ wxCHECK_MSG( firstHandler != this, NULL, "cannot pop the wxWindow itself" );
+ wxCHECK_MSG( firstHandler->GetPreviousHandler() == NULL, NULL,
+ "the first handler of the wxWindow stack should have no previous handlers set" );
- if ( deleteHandler )
- {
- delete handlerA;
- handlerA = (wxEvtHandler *)NULL;
- }
+ wxEvtHandler *secondHandler = firstHandler->GetNextHandler();
+ wxCHECK_MSG( secondHandler != NULL, NULL,
+ "the first handler of the wxWindow stack should have non-NULL next handler" );
+
+ firstHandler->SetNextHandler(NULL);
+ secondHandler->SetPreviousHandler(NULL);
+
+ // now firstHandler is completely unlinked; set secondHandler as the new window event handler
+ SetEventHandler(secondHandler);
+
+ if ( deleteHandler )
+ {
+ delete firstHandler;
+ firstHandler = NULL;
}
- return handlerA;
+ return firstHandler;
}
-bool wxWindowBase::RemoveEventHandler(wxEvtHandler *handler)
+bool wxWindowBase::RemoveEventHandler(wxEvtHandler *handlerToRemove)
{
- wxCHECK_MSG( handler, false, _T("RemoveEventHandler(NULL) called") );
+ wxCHECK_MSG( handlerToRemove != NULL, false, "RemoveEventHandler(NULL) called" );
+ wxCHECK_MSG( handlerToRemove != this, false, "Cannot remove the window itself" );
- wxEvtHandler *handlerPrev = NULL,
- *handlerCur = GetEventHandler();
- while ( handlerCur )
+ if (handlerToRemove == GetEventHandler())
+ {
+ // removing the first event handler is equivalent to "popping" the stack
+ PopEventHandler(false);
+ return true;
+ }
+
+ // NOTE: the wxWindow event handler list is always terminated with "this" handler
+ wxEvtHandler *handlerCur = GetEventHandler()->GetNextHandler();
+ while ( handlerCur != this )
{
wxEvtHandler *handlerNext = handlerCur->GetNextHandler();
- if ( handlerCur == handler )
+ if ( handlerCur == handlerToRemove )
{
- if ( handlerPrev )
- {
- handlerPrev->SetNextHandler(handlerNext);
- }
- else
- {
- SetEventHandler(handlerNext);
- }
-
- if ( handlerNext )
- {
- handlerNext->SetPreviousHandler ( handlerPrev );
- }
-
- handler->SetNextHandler(NULL);
- handler->SetPreviousHandler(NULL);
+ handlerCur->Unlink();
+ wxASSERT_MSG( handlerCur != GetEventHandler(),
+ "the case Remove == Pop should was already handled" );
return true;
}
- handlerPrev = handlerCur;
handlerCur = handlerNext;
}
bool wxWindowBase::HandleWindowEvent(wxEvent& event) const
{
+ // SafelyProcessEvent() will handle exceptions nicely
return GetEventHandler()->SafelyProcessEvent(event);
}
if ( id == m_windowId )
return (wxWindow *)this;
- wxWindowBase *res = (wxWindow *)NULL;
+ wxWindowBase *res = NULL;
wxWindowList::compatibility_iterator node;
for ( node = m_children.GetFirst(); node && !res; node = node->GetNext() )
{
if ( name == m_windowName )
return (wxWindow *)this;
- wxWindowBase *res = (wxWindow *)NULL;
+ wxWindowBase *res = NULL;
wxWindowList::compatibility_iterator node;
for ( node = m_children.GetFirst(); node && !res; node = node->GetNext() )
{
}
// setting empty tooltip text does not remove the tooltip any more - use
- // SetToolTip((wxToolTip *)NULL) for this
+ // SetToolTip(NULL) for this
}
void wxWindowBase::DoSetToolTip(wxToolTip *tooltip)
}
delete m_constraintsInvolvedIn;
- m_constraintsInvolvedIn = (wxWindowList *) NULL;
+ m_constraintsInvolvedIn = NULL;
}
}
gs_popupMenuSelection = event.GetId();
}
+void wxWindowBase::InternalOnPopupMenuUpdate(wxUpdateUIEvent& WXUNUSED(event))
+{
+ // nothing to do but do not skip it
+}
+
int
wxWindowBase::DoGetPopupMenuSelectionFromUser(wxMenu& menu, int x, int y)
{
NULL,
this);
+ // it is common to construct the menu passed to this function dynamically
+ // using some fixed range of ids which could clash with the ids used
+ // elsewhere in the program, which could result in some menu items being
+ // unintentionally disabled or otherwise modified by update UI handlers
+ // elsewhere in the program code and this is difficult to avoid in the
+ // program itself, so instead we just temporarily suspend UI updating while
+ // this menu is shown
+ Connect(wxEVT_UPDATE_UI,
+ wxUpdateUIEventHandler(wxWindowBase::InternalOnPopupMenuUpdate),
+ NULL,
+ this);
+
PopupMenu(&menu, x, y);
+ Disconnect(wxEVT_UPDATE_UI,
+ wxUpdateUIEventHandler(wxWindowBase::InternalOnPopupMenuUpdate),
+ NULL,
+ this);
Disconnect(wxEVT_COMMAND_MENU_SELECTED,
wxCommandEventHandler(wxWindowBase::InternalOnPopupMenu),
NULL,
projects / wxWidgets.git / blobdiff