{
static void
-wxgtk_webview_webkit_load_status(GtkWidget* widget,
+wxgtk_webview_webkit_load_status(GtkWidget* widget,
GParamSpec*,
wxWebViewWebKit *webKitCtrl)
{
- if (!webKitCtrl->m_ready) return;
+ // We can be called from webkit_web_view_dispose() during the window
+ // destruction, don't use half-destroyed object in this case.
+ if ( webKitCtrl->IsBeingDeleted() )
+ return;
wxString url = webKitCtrl->GetCurrentURL();
if(webKitCtrl->m_guard)
{
webKitCtrl->m_guard = false;
- //We set this to make sure that we don't try to load the page again from
+ //We set this to make sure that we don't try to load the page again from
//the resource request callback
webKitCtrl->m_vfsurl = webkit_network_request_get_uri(request);
webkit_web_policy_decision_use(policy_decision);
handler = (*it);
}
}
- //If we found a handler we can then use it to load the file directly
+ //If we found a handler we can then use it to load the file directly
//ourselves
if(handler)
{
wxWebViewWebKit *webKitCtrl)
{
wxString uri = webkit_network_request_get_uri(request);
-
+
wxSharedPtr<wxWebViewHandler> handler;
wxVector<wxSharedPtr<wxWebViewHandler> > hanlders = webKitCtrl->GetHandlers();
-
+
//We are not vetoed so see if we match one of the additional handlers
for(wxVector<wxSharedPtr<wxWebViewHandler> >::iterator it = hanlders.begin();
it != hanlders.end(); ++it)
handler = (*it);
}
}
- //If we found a handler we can then use it to load the file directly
+ //If we found a handler we can then use it to load the file directly
//ourselves
if(handler)
{
//Then we can redirect the call
webkit_network_request_set_uri(request, path.utf8_str());
}
-
+
}
}
long style,
const wxString& name)
{
- m_ready = false;
m_busy = false;
m_guard = false;
+ // We currently unconditionally impose scrolling in both directions as it's
+ // necessary to show arbitrary pages.
+ style |= wxHSCROLL | wxVSCROLL;
+
if (!PreCreation( parent, pos, size ) ||
!CreateBase( parent, id, pos, size, style, wxDefaultValidator, name ))
{
return false;
}
- m_widget = gtk_scrolled_window_new(NULL, NULL);
- g_object_ref(m_widget);
m_web_view = WEBKIT_WEB_VIEW(webkit_web_view_new());
+ GTKCreateScrolledWindowWith(GTK_WIDGET(m_web_view));
+ g_object_ref(m_widget);
- /* Place the WebKitWebView in the GtkScrolledWindow */
- gtk_container_add(GTK_CONTAINER(m_widget), GTK_WIDGET(m_web_view));
- gtk_widget_show(GTK_WIDGET(m_web_view));
-
- g_signal_connect_after(m_web_view, "notify::load-status",
- G_CALLBACK(wxgtk_webview_webkit_load_status),
- this);
g_signal_connect_after(m_web_view, "navigation-policy-decision-requested",
G_CALLBACK(wxgtk_webview_webkit_navigation),
this);
- g_signal_connect_after(m_web_view, "load-error",
+ g_signal_connect_after(m_web_view, "load-error",
G_CALLBACK(wxgtk_webview_webkit_error),
this);
history = webkit_web_view_get_back_forward_list(m_web_view);
m_historyLimit = webkit_web_back_forward_list_get_limit(history);
- m_ready = true;
+ // last to avoid getting signal too early
+ g_signal_connect_after(m_web_view, "notify::load-status",
+ G_CALLBACK(wxgtk_webview_webkit_load_status),
+ this);
return true;
}
+wxWebViewWebKit::~wxWebViewWebKit()
+{
+ // The main goal here is to set m_isBeingDeleted to true to avoid the use
+ // of this -- already half-destroyed -- object from WebKit callbacks, but
+ // just setting it would prevent wxWindowDestroyEvent from being sent, so
+ // send it now instead.
+ SendDestroyEvent();
+}
+
bool wxWebViewWebKit::Enable( bool enable )
{
if (!wxControl::Enable(enable))
return false;
- gtk_widget_set_sensitive(GTK_BIN(m_widget)->child, enable);
+ gtk_widget_set_sensitive(gtk_bin_get_child(GTK_BIN(m_widget)), enable);
//if (enable)
// GTKFixSensitivity();
wxVector<wxSharedPtr<wxWebViewHistoryItem> > wxWebViewWebKit::GetBackwardHistory()
{
- wxVector<wxSharedPtr<wxWebViewHistoryItem> > backhist;
+ wxVector<wxSharedPtr<wxWebViewHistoryItem> > backhist;
WebKitWebBackForwardList* history;
history = webkit_web_view_get_back_forward_list(m_web_view);
- GList* list = webkit_web_back_forward_list_get_back_list_with_limit(history,
+ GList* list = webkit_web_back_forward_list_get_back_list_with_limit(history,
m_historyLimit);
//We need to iterate in reverse to get the order we desire
for(int i = g_list_length(list) - 1; i >= 0 ; i--)
wxVector<wxSharedPtr<wxWebViewHistoryItem> > wxWebViewWebKit::GetForwardHistory()
{
- wxVector<wxSharedPtr<wxWebViewHistoryItem> > forwardhist;
+ wxVector<wxSharedPtr<wxWebViewHistoryItem> > forwardhist;
WebKitWebBackForwardList* history;
history = webkit_web_view_get_back_forward_list(m_web_view);
- GList* list = webkit_web_back_forward_list_get_forward_list_with_limit(history,
+ GList* list = webkit_web_back_forward_list_get_forward_list_with_limit(history,
m_historyLimit);
for(guint i = 0; i < g_list_length(list); i++)
{
WebKitWebHistoryItem* gtkitem = (WebKitWebHistoryItem*)item->m_histItem;
if(gtkitem)
{
- webkit_web_view_go_to_back_forward_item(m_web_view,
+ webkit_web_view_go_to_back_forward_item(m_web_view,
WEBKIT_WEB_HISTORY_ITEM(gtkitem));
}
}
return true;
}
-void wxWebViewWebKit::SetPage(const wxString& html, const wxString& baseUri)
+void wxWebViewWebKit::DoSetPage(const wxString& html, const wxString& baseUri)
{
webkit_web_view_load_string (m_web_view,
html.mb_str(wxConvUTF8),
wxString wxWebViewWebKit::GetSelectedText() const
{
- WebKitDOMDocument* doc;
+ WebKitDOMDocument* doc;
WebKitDOMDOMWindow* win;
WebKitDOMDOMSelection* sel;
WebKitDOMRange* range;
doc = webkit_web_view_get_dom_document(m_web_view);
win = webkit_dom_document_get_default_view(WEBKIT_DOM_DOCUMENT(doc));
sel = webkit_dom_dom_window_get_selection(WEBKIT_DOM_DOM_WINDOW(win));
- range = webkit_dom_dom_selection_get_range_at(WEBKIT_DOM_DOM_SELECTION(sel),
+ range = webkit_dom_dom_selection_get_range_at(WEBKIT_DOM_DOM_SELECTION(sel),
0, NULL);
- return wxString(webkit_dom_range_get_text(WEBKIT_DOM_RANGE(range)),
+ return wxString(webkit_dom_range_get_text(WEBKIT_DOM_RANGE(range)),
wxConvUTF8);
}
wxString wxWebViewWebKit::GetSelectedSource() const
{
- WebKitDOMDocument* doc;
+ WebKitDOMDocument* doc;
WebKitDOMDOMWindow* win;
WebKitDOMDOMSelection* sel;
WebKitDOMRange* range;
doc = webkit_web_view_get_dom_document(m_web_view);
win = webkit_dom_document_get_default_view(WEBKIT_DOM_DOCUMENT(doc));
sel = webkit_dom_dom_window_get_selection(WEBKIT_DOM_DOM_WINDOW(win));
- range = webkit_dom_dom_selection_get_range_at(WEBKIT_DOM_DOM_SELECTION(sel),
+ range = webkit_dom_dom_selection_get_range_at(WEBKIT_DOM_DOM_SELECTION(sel),
0, NULL);
div = webkit_dom_document_create_element(WEBKIT_DOM_DOCUMENT(doc), "div", NULL);
webkit_dom_node_append_child(&div->parent_instance, &clone->parent_instance, NULL);
html = (WebKitDOMHTMLElement*)div;
- return wxString(webkit_dom_html_element_get_inner_html(WEBKIT_DOM_HTML_ELEMENT(html)),
+ return wxString(webkit_dom_html_element_get_inner_html(WEBKIT_DOM_HTML_ELEMENT(html)),
wxConvUTF8);
}
void wxWebViewWebKit::ClearSelection()
{
- WebKitDOMDocument* doc;
+ WebKitDOMDocument* doc;
WebKitDOMDOMWindow* win;
WebKitDOMDOMSelection* sel;
wxString wxWebViewWebKit::GetPageText() const
{
- WebKitDOMDocument* doc;
+ WebKitDOMDocument* doc;
WebKitDOMHTMLElement* body;
doc = webkit_web_view_get_dom_document(m_web_view);
body = webkit_dom_document_get_body(WEBKIT_DOM_DOCUMENT(doc));
- return wxString(webkit_dom_html_element_get_inner_text(WEBKIT_DOM_HTML_ELEMENT(body)),
+ return wxString(webkit_dom_html_element_get_inner_text(WEBKIT_DOM_HTML_ELEMENT(body)),
wxConvUTF8);
}
void wxWebViewWebKit::RunScript(const wxString& javascript)
{
- webkit_web_view_execute_script(m_web_view,
+ webkit_web_view_execute_script(m_web_view,
javascript.mb_str(wxConvUTF8));
}