just added a comment

[wxWidgets.git] / src / mac / carbon / spinbutt.cpp

diff --git a/src/mac/carbon/spinbutt.cpp b/src/mac/carbon/spinbutt.cpp
index 30d3076417770100db2e77ca232375ad40b2d1bb..2b900c19fd9e83f3fd644ce0756bd054a9d6c6bc 100644 (file)
--- a/src/mac/carbon/spinbutt.cpp
+++ b/src/mac/carbon/spinbutt.cpp
@@ -9,10 +9,9 @@
 // Licence:       wxWindows licence
 /////////////////////////////////////////////////////////////////////////////
 
 // Licence:       wxWindows licence
 /////////////////////////////////////////////////////////////////////////////
 

-#ifdef __GNUG__
-#pragma implementation "spinbutt.h"
-#pragma implementation "spinbuttbase.h"
-#endif
+#include "wx/wxprec.h"
+
+#if wxUSE_SPINBTN

 
 #include "wx/spinbutt.h"
 #include "wx/mac/uma.h"
 
 #include "wx/spinbutt.h"
 #include "wx/mac/uma.h"


@@ -25,10 +24,8 @@
 // wxWin macros
 // ----------------------------------------------------------------------------
 
 // wxWin macros
 // ----------------------------------------------------------------------------
 

-#if !USE_SHARED_LIBRARY
-    IMPLEMENT_DYNAMIC_CLASS(wxSpinButton, wxControl)
-    IMPLEMENT_DYNAMIC_CLASS(wxSpinEvent, wxScrollEvent)
-#endif
+IMPLEMENT_DYNAMIC_CLASS(wxSpinButton, wxControl)
+IMPLEMENT_DYNAMIC_CLASS(wxSpinEvent, wxScrollEvent)

 
 wxSpinButton::wxSpinButton()
    : wxSpinButtonBase()
 
 wxSpinButton::wxSpinButton()
    : wxSpinButtonBase()


@@ -38,28 +35,30 @@ wxSpinButton::wxSpinButton()
 bool wxSpinButton::Create(wxWindow *parent, wxWindowID id, const wxPoint& pos, const wxSize& size,
         long style, const wxString& name)
 {
 bool wxSpinButton::Create(wxWindow *parent, wxWindowID id, const wxPoint& pos, const wxSize& size,
         long style, const wxString& name)
 {

-    m_macIsUserPane = FALSE ;
-    
+    m_macIsUserPane = false ;
+

     if ( !wxSpinButtonBase::Create(parent, id, pos, size,
                                    style, wxDefaultValidator, name) )
         return false;
 
     m_min = 0;
     m_max = 100;
     if ( !wxSpinButtonBase::Create(parent, id, pos, size,
                                    style, wxDefaultValidator, name) )
         return false;
 
     m_min = 0;
     m_max = 100;

-    
+

     if (!parent)
     if (!parent)

-        return FALSE;
-    
+        return false;
+

     Rect bounds = wxMacGetBoundsForControl( this , pos , size ) ;
     Rect bounds = wxMacGetBoundsForControl( this , pos , size ) ;

-        
+
+    m_peer = new wxMacControl(this) ;

     verify_noerr ( CreateLittleArrowsControl( MAC_WXHWND(parent->MacGetTopLevelWindowRef()) , &bounds , 0 , m_min , m_max , 1 ,
     verify_noerr ( CreateLittleArrowsControl( MAC_WXHWND(parent->MacGetTopLevelWindowRef()) , &bounds , 0 , m_min , m_max , 1 ,

-     (ControlRef*) &m_macControl ) ) ;
-    
+     m_peer->GetControlRefAddr() ) );
+
+    m_peer->SetActionProc( GetwxMacLiveScrollbarActionProc() ) ;

     MacPostControlCreate(pos,size) ;
     MacPostControlCreate(pos,size) ;

-    
-    return TRUE;
+
+    return true;

 }
 }

-    
+

 wxSpinButton::~wxSpinButton()
 {
 }
 wxSpinButton::~wxSpinButton()
 {
 }


@@ -79,7 +78,12 @@ int wxSpinButton::GetMax() const
 
 int wxSpinButton::GetValue() const
 {
 
 int wxSpinButton::GetValue() const
 {

-    return m_value;
+    int n = m_value;
+
+    if (n < m_min) n = m_min;
+    if (n > m_max) n = m_max;
+
+    return n;

 }
 
 void wxSpinButton::SetValue(int val)
 }
 
 void wxSpinButton::SetValue(int val)


@@ -91,18 +95,18 @@ void wxSpinButton::SetRange(int minVal, int maxVal)
 {
     m_min = minVal;
     m_max = maxVal;
 {
     m_min = minVal;
     m_max = maxVal;

-    SetControl32BitMaximum( (ControlRef) m_macControl , maxVal ) ;
-    SetControl32BitMinimum((ControlRef) m_macControl , minVal ) ;
+    m_peer->SetMaximum( maxVal ) ;
+    m_peer->SetMinimum( minVal ) ;

 }
 
 void wxSpinButton::MacHandleValueChanged( int inc )
 {
 }
 
 void wxSpinButton::MacHandleValueChanged( int inc )
 {

-    
+

     wxEventType scrollEvent = wxEVT_NULL;
     int oldValue = m_value ;
     wxEventType scrollEvent = wxEVT_NULL;
     int oldValue = m_value ;

-    
+

     m_value = oldValue + inc;
     m_value = oldValue + inc;

-    
+

     if (m_value < m_min)
     {
         if ( m_windowStyle & wxSP_WRAP )
     if (m_value < m_min)
     {
         if ( m_windowStyle & wxSP_WRAP )


@@ -110,7 +114,7 @@ void wxSpinButton::MacHandleValueChanged( int inc )
         else
             m_value = m_min;
     }
         else
             m_value = m_min;
     }

-    
+

     if (m_value > m_max)
     {
         if ( m_windowStyle & wxSP_WRAP )
     if (m_value > m_max)
     {
         if ( m_windowStyle & wxSP_WRAP )


@@ -118,16 +122,16 @@ void wxSpinButton::MacHandleValueChanged( int inc )
         else
             m_value = m_max;
     }
         else
             m_value = m_max;
     }

-    
+

     if ( m_value - oldValue == -1 )
         scrollEvent = wxEVT_SCROLL_LINEDOWN ;
     else if ( m_value - oldValue == 1 )
         scrollEvent = wxEVT_SCROLL_LINEUP ;
     else
         scrollEvent = wxEVT_SCROLL_THUMBTRACK ;
     if ( m_value - oldValue == -1 )
         scrollEvent = wxEVT_SCROLL_LINEDOWN ;
     else if ( m_value - oldValue == 1 )
         scrollEvent = wxEVT_SCROLL_LINEUP ;
     else
         scrollEvent = wxEVT_SCROLL_THUMBTRACK ;

-    
+

     wxSpinEvent event(scrollEvent, m_windowId);
     wxSpinEvent event(scrollEvent, m_windowId);

-    
+

     event.SetPosition(m_value);
     event.SetEventObject( this );
     if ((GetEventHandler()->ProcessEvent( event )) &&
     event.SetPosition(m_value);
     event.SetEventObject( this );
     if ((GetEventHandler()->ProcessEvent( event )) &&


@@ -135,8 +139,8 @@ void wxSpinButton::MacHandleValueChanged( int inc )
     {
         m_value = oldValue ;
     }
     {
         m_value = oldValue ;
     }

-    SetControl32BitValue( (ControlRef) m_macControl , m_value ) ;
-    
+    m_peer->SetValue( m_value ) ;
+

     /* always send a thumbtrack event */
     if (scrollEvent != wxEVT_SCROLL_THUMBTRACK)
     {
     /* always send a thumbtrack event */
     if (scrollEvent != wxEVT_SCROLL_THUMBTRACK)
     {


@@ -148,11 +152,29 @@ void wxSpinButton::MacHandleValueChanged( int inc )
     }
 }
 
     }
 }
 

-wxInt32 wxSpinButton::MacControlHit(WXEVENTHANDLERREF WXUNUSED(handler) , WXEVENTREF event )  
+void wxSpinButton::MacHandleControlClick( WXWidget control , wxInt16 controlpart , bool mouseStillDown )

 {
     int nScrollInc = 0;
 {
     int nScrollInc = 0;

+
+    switch( controlpart )
+    {
+    case kControlUpButtonPart :
+        nScrollInc = 1;
+        break ;
+    case kControlDownButtonPart :
+        nScrollInc = -1;
+        break ;
+    }
+    MacHandleValueChanged( nScrollInc ) ;
+}
+
+wxInt32 wxSpinButton::MacControlHit(WXEVENTHANDLERREF WXUNUSED(handler) , WXEVENTREF event )
+{
+    /*
+    // these have been handled by the live action proc already
+    int nScrollInc = 0;

     wxMacCarbonEvent cEvent( (EventRef) event ) ;
     wxMacCarbonEvent cEvent( (EventRef) event ) ;

-    
+

     switch( cEvent.GetParameter<ControlPartCode>(kEventParamControlPart,typeControlPartCode) )
     {
     case kControlUpButtonPart :
     switch( cEvent.GetParameter<ControlPartCode>(kEventParamControlPart,typeControlPartCode) )
     {
     case kControlUpButtonPart :


@@ -163,6 +185,7 @@ wxInt32 wxSpinButton::MacControlHit(WXEVENTHANDLERREF WXUNUSED(handler) , WXEVEN
         break ;
     }
     MacHandleValueChanged( nScrollInc ) ;
         break ;
     }
     MacHandleValueChanged( nScrollInc ) ;

+    */

     return noErr ;
 }
 
     return noErr ;
 }
 


@@ -175,3 +198,4 @@ wxSize wxSpinButton::DoGetBestSize() const
     return wxSize(16,24);
 }
 
     return wxSize(16,24);
 }
 

+#endif // wxUSE_SPINBTN