cleanup - more reformatting; fixed bug introduced in prior commit

[wxWidgets.git] / src / msw / slider95.cpp

diff --git a/src/msw/slider95.cpp b/src/msw/slider95.cpp
index b6c68e1628cb4f4f22e9b859882c88ef2d02e34c..193017c84ab3678af047944e2fd083aca2703b74 100644 (file)
--- a/src/msw/slider95.cpp
+++ b/src/msw/slider95.cpp
@@ -1,42 +1,63 @@
 /////////////////////////////////////////////////////////////////////////////
 /////////////////////////////////////////////////////////////////////////////

-// Name:        slider95.cpp
-// Purpose:     wxSlider95, using the Win95 trackbar control
+// Name:        msw/slider.cpp
+// Purpose:     wxSlider, using the Win95 (and later) trackbar control

 // Author:      Julian Smart
 // Modified by:
 // Created:     04/01/98
 // RCS-ID:      $Id$
 // Author:      Julian Smart
 // Modified by:
 // Created:     04/01/98
 // RCS-ID:      $Id$

-// Copyright:   (c) Julian Smart
+// Copyright:   (c) Julian Smart 1998
+//                  Vadim Zeitlin 2004

 // Licence:     wxWindows licence
 /////////////////////////////////////////////////////////////////////////////
 
 // Licence:     wxWindows licence
 /////////////////////////////////////////////////////////////////////////////
 

-#if defined(__GNUG__) && !defined(NO_GCC_PRAGMA)
-#pragma implementation "slider95.h"
-#endif
+// ============================================================================
+// declarations
+// ============================================================================
+
+// ----------------------------------------------------------------------------
+// headers
+// ----------------------------------------------------------------------------

 
 // For compilers that support precompilation, includes "wx.h".
 #include "wx/wxprec.h"
 
 #ifdef __BORLANDC__
 
 // For compilers that support precompilation, includes "wx.h".
 #include "wx/wxprec.h"
 
 #ifdef __BORLANDC__

-#pragma hdrstop
+    #pragma hdrstop

 #endif
 
 #if wxUSE_SLIDER
 
 #ifndef WX_PRECOMP
 #endif
 
 #if wxUSE_SLIDER
 
 #ifndef WX_PRECOMP

-#include "wx/utils.h"
-#include "wx/brush.h"
-#include "wx/slider.h"
+    #include "wx/brush.h"

 #endif
 
 #endif
 

-#ifdef __WIN95__
-
-#include "wx/msw/slider95.h"
-#include "wx/msw/private.h"
+#include "wx/slider.h"
+#include "wx/msw/subwin.h"

 
 

-#if defined(__WIN95__) && !(defined(__GNUWIN32_OLD__) && !defined(__CYGWIN10__))
+#if !(defined(__GNUWIN32_OLD__) && !defined(__CYGWIN10__))

     #include <commctrl.h>
 #endif
 
     #include <commctrl.h>
 #endif
 

+// ----------------------------------------------------------------------------
+// constants
+// ----------------------------------------------------------------------------
+
+// indices of labels in wxSlider::m_labels
+enum
+{
+    SliderLabel_Min,
+    SliderLabel_Max,
+    SliderLabel_Value,
+    SliderLabel_Last
+};
+
+// the gap between the slider and the labels, in pixels
+static const int HGAP = 5;
+
+// ----------------------------------------------------------------------------
+// XTI
+// ----------------------------------------------------------------------------
+

 #if wxUSE_EXTENDED_RTTI
 WX_DEFINE_FLAGS( wxSliderStyle )
 
 #if wxUSE_EXTENDED_RTTI
 WX_DEFINE_FLAGS( wxSliderStyle )
 


@@ -78,13 +99,14 @@ wxBEGIN_FLAGS( wxSliderStyle )
     wxFLAGS_MEMBER(wxSL_BOTTOM)
     wxFLAGS_MEMBER(wxSL_BOTH)
     wxFLAGS_MEMBER(wxSL_SELRANGE)
     wxFLAGS_MEMBER(wxSL_BOTTOM)
     wxFLAGS_MEMBER(wxSL_BOTH)
     wxFLAGS_MEMBER(wxSL_SELRANGE)

+    wxFLAGS_MEMBER(wxSL_INVERSE)

 
 wxEND_FLAGS( wxSliderStyle )
 
 
 wxEND_FLAGS( wxSliderStyle )
 

-IMPLEMENT_DYNAMIC_CLASS_XTI(wxSlider95, wxControl,"wx/scrolbar.h")
+IMPLEMENT_DYNAMIC_CLASS_XTI(wxSlider, wxControl,"wx/scrolbar.h")

 
 

-wxBEGIN_PROPERTIES_TABLE(wxSlider95)
-    wxEVENT_RANGE_PROPERTY( Scroll , wxEVT_SCROLL_TOP , wxEVT_SCROLL_ENDSCROLL , wxScrollEvent )
+wxBEGIN_PROPERTIES_TABLE(wxSlider)
+    wxEVENT_RANGE_PROPERTY( Scroll , wxEVT_SCROLL_TOP , wxEVT_SCROLL_CHANGED , wxScrollEvent )

     wxEVENT_PROPERTY( Updated , wxEVT_COMMAND_SLIDER_UPDATED , wxCommandEvent )
 
     wxPROPERTY( Value , int , SetValue, GetValue , 0, 0 /*flags*/ , wxT("Helpstring") , wxT("group"))
     wxEVENT_PROPERTY( Updated , wxEVT_COMMAND_SLIDER_UPDATED , wxCommandEvent )
 
     wxPROPERTY( Value , int , SetValue, GetValue , 0, 0 /*flags*/ , wxT("Helpstring") , wxT("group"))


@@ -96,190 +118,182 @@ wxBEGIN_PROPERTIES_TABLE(wxSlider95)
     wxPROPERTY_FLAGS( WindowStyle , wxSliderStyle , long , SetWindowStyleFlag , GetWindowStyleFlag , EMPTY_MACROVALUE , 0 /*flags*/ , wxT("Helpstring") , wxT("group")) // style
 wxEND_PROPERTIES_TABLE()
 
     wxPROPERTY_FLAGS( WindowStyle , wxSliderStyle , long , SetWindowStyleFlag , GetWindowStyleFlag , EMPTY_MACROVALUE , 0 /*flags*/ , wxT("Helpstring") , wxT("group")) // style
 wxEND_PROPERTIES_TABLE()
 

-wxBEGIN_HANDLERS_TABLE(wxSlider95)
+wxBEGIN_HANDLERS_TABLE(wxSlider)

 wxEND_HANDLERS_TABLE()
 
 wxEND_HANDLERS_TABLE()
 

-wxCONSTRUCTOR_8( wxSlider95 , wxWindow* , Parent , wxWindowID , Id , int , Value , int , Minimum , int , Maximum , wxPoint , Position , wxSize , Size , long , WindowStyle )
+wxCONSTRUCTOR_8( wxSlider , wxWindow* , Parent , wxWindowID , Id , int , Value , int , Minimum , int , Maximum , wxPoint , Position , wxSize , Size , long , WindowStyle )

 #else
 #else

-IMPLEMENT_DYNAMIC_CLASS(wxSlider95, wxControl)
+IMPLEMENT_DYNAMIC_CLASS(wxSlider, wxControl)

 #endif
 
 #endif
 

-// Slider
-wxSlider95::wxSlider95()
+// ============================================================================
+// wxSlider implementation
+// ============================================================================
+
+// ----------------------------------------------------------------------------
+// construction
+// ----------------------------------------------------------------------------
+
+void wxSlider::Init()

 {
 {

-    m_staticValue = (WXHWND) NULL;
-    m_staticMin = (WXHWND) NULL;
-    m_staticMax = (WXHWND) NULL;
+    m_labels = NULL;
+

     m_pageSize = 1;
     m_lineSize = 1;
     m_rangeMax = 0;
     m_rangeMin = 0;
     m_tickFreq = 0;
     m_pageSize = 1;
     m_lineSize = 1;
     m_rangeMax = 0;
     m_rangeMin = 0;
     m_tickFreq = 0;

+
+    m_isDragging = false;

 }
 
 }
 

-bool wxSlider95::Create(wxWindow *parent, wxWindowID id,
-           int value, int minValue, int maxValue,
-           const wxPoint& pos,
-           const wxSize& size, long style,
-           const wxValidator& validator,
-           const wxString& name)
+bool
+wxSlider::Create(wxWindow *parent,
+                 wxWindowID id,
+                 int value,
+                 int minValue,
+                 int maxValue,
+                 const wxPoint& pos,
+                 const wxSize& size,
+                 long style,
+                 const wxValidator& validator,
+                 const wxString& name)

 {
 {

-    // default is no border
-    if ( (style & wxBORDER_MASK) == wxBORDER_DEFAULT )
-        style |= wxBORDER_NONE;
-
-    if ( !CreateBase(parent, id, pos, size, style, validator, name) )
-        return false;
-
-    if (parent) parent->AddChild(this);
-
-    InheritAttributes();
-
-    m_staticValue = (WXHWND) NULL;;
-    m_staticMin = (WXHWND) NULL;;
-    m_staticMax = (WXHWND) NULL;;
-    m_pageSize = 1;
-    m_lineSize = 1;
-    m_windowStyle = style;
-    m_tickFreq = 0;
-
-    long msStyle = 0;
-
-    if ( m_windowStyle & wxSL_LABELS )
+    // our styles are redundant: wxSL_LEFT/RIGHT imply wxSL_VERTICAL and
+    // wxSL_TOP/BOTTOM imply wxSL_HORIZONTAL, but for backwards compatibility
+    // reasons we can't really change it, instead try to infer the orientation
+    // from the flags given to us here
+    switch ( style & (wxSL_LEFT | wxSL_RIGHT | wxSL_TOP | wxSL_BOTTOM) )

     {
     {

-        msStyle |= SS_CENTER|WS_VISIBLE;
-
-        WXDWORD exStyle = 0;
-        long valueStyle = m_windowStyle & ~wxBORDER_MASK;
-        valueStyle |= wxBORDER_SUNKEN;
-        msStyle |= MSWGetStyle(valueStyle, & exStyle) ;
-
-        m_staticValue = (WXHWND) CreateWindowEx
-            (
-                exStyle, wxT("STATIC"), NULL,
-                msStyle,
-                0, 0, 0, 0, (HWND) parent->GetHWND(), (HMENU)NewControlId(),
-                wxGetInstance(), NULL
-            );
-
-        // Now create min static control
-        wxString minLabel;
-        minLabel.Printf(wxT("%d"), minValue);
-        long wstyle = STATIC_FLAGS;
-        if ( m_windowStyle & wxCLIP_SIBLINGS )
-            wstyle |= WS_CLIPSIBLINGS;
-        m_staticMin = (WXHWND) CreateWindowEx
-            (
-                0, wxT("STATIC"), minLabel,
-                wstyle,
-                0, 0, 0, 0, (HWND) parent->GetHWND(), (HMENU)NewControlId(),
-                wxGetInstance(), NULL
-            );
-    }
+        case wxSL_LEFT:
+        case wxSL_RIGHT:
+            style |= wxSL_VERTICAL;
+            break;

 
 

-    WXDWORD exStyle = 0;
+        case wxSL_TOP:
+        case wxSL_BOTTOM:
+            style |= wxSL_HORIZONTAL;
+            break;

 
 

-    msStyle = MSWGetStyle(GetWindowStyle(), & exStyle) ;
+        case 0:
+            // no specific direction, do we have at least the orientation?
+            if ( !(style & (wxSL_HORIZONTAL | wxSL_VERTICAL)) )
+            {
+                // no, choose default
+                style |= wxSL_BOTTOM | wxSL_HORIZONTAL;
+            }
+    };

 
 

-    wxUnusedVar(msStyle);
+    wxASSERT_MSG( !(style & wxSL_VERTICAL) || !(style & wxSL_HORIZONTAL),
+                    _T("incompatible slider direction and orientation") );

 
 

-    if (m_windowStyle & wxSL_VERTICAL)
-        msStyle = TBS_VERT | WS_CHILD | WS_VISIBLE | WS_TABSTOP ;
-    else
-        msStyle = TBS_HORZ | WS_CHILD | WS_VISIBLE | WS_TABSTOP ;
-
-    if ( m_windowStyle & wxSL_AUTOTICKS )
-        msStyle |= TBS_AUTOTICKS ;
-
-    if ( m_windowStyle & wxSL_LEFT )
-        msStyle |= TBS_LEFT;
-    else if ( m_windowStyle & wxSL_RIGHT )
-        msStyle |= TBS_RIGHT;
-    else if ( m_windowStyle & wxSL_TOP )
-        msStyle |= TBS_TOP;
-    else if ( m_windowStyle & wxSL_BOTTOM )
-        msStyle |= TBS_BOTTOM;
-    else if ( m_windowStyle & wxSL_BOTH )
-        msStyle |= TBS_BOTH;
-    else if ( ! (m_windowStyle & wxSL_AUTOTICKS) )
-        msStyle |= TBS_NOTICKS;

 
 

-    if ( m_windowStyle & wxSL_SELRANGE )
-        msStyle |= TBS_ENABLESELRANGE;
-
-    HWND scroll_bar = CreateWindowEx
-        (
-            exStyle, TRACKBAR_CLASS, wxEmptyString,
-            msStyle,
-            0, 0, 0, 0, (HWND) parent->GetHWND(), (HMENU)m_windowId,
-            wxGetInstance(), NULL
-        );
+    // initialize everything
+    if ( !CreateControl(parent, id, pos, size, style, validator, name) )
+        return false;

 
 

-    m_rangeMax = maxValue;
+    // ensure that we have correct values for GetLabelsSize()

     m_rangeMin = minValue;
     m_rangeMin = minValue;

+    m_rangeMax = maxValue;

 
 

-    m_pageSize = (int)((maxValue-minValue)/10);
+    // create the labels first, so that our DoGetBestSize() could take them
+    // into account
+    //
+    // note that we could simply create 3 wxStaticTexts here but it could
+    // result in some observable side effects at wx level (e.g. the parent of
+    // wxSlider would have 3 more children than expected) and so we prefer not
+    // to do it like this
+    if ( m_windowStyle & wxSL_LABELS )
+    {
+        m_labels = new wxSubwindows(SliderLabel_Last);

 
 

-    ::SendMessage(scroll_bar, TBM_SETRANGE, TRUE, MAKELONG(minValue, maxValue));
-    ::SendMessage(scroll_bar, TBM_SETPOS, TRUE, (LPARAM)value);
-    ::SendMessage(scroll_bar, TBM_SETPAGESIZE, 0, (LPARAM)m_pageSize);
+        HWND hwndParent = GetHwndOf(parent);
+        for ( size_t n = 0; n < SliderLabel_Last; n++ )
+        {
+            (*m_labels)[n] = ::CreateWindow
+                               (
+                                    wxT("STATIC"),
+                                    NULL,
+                                    WS_CHILD | WS_VISIBLE | SS_CENTER,
+                                    0, 0, 0, 0,
+                                    hwndParent,
+                                    (HMENU)NewControlId(),
+                                    wxGetInstance(),
+                                    NULL
+                               );
+        }

 
 

-    m_hWnd = (WXHWND)scroll_bar;
+        m_labels->SetFont(GetFont());
+    }

 
 

-    SubclassWin(GetHWND());
+    // now create the main control too
+    if ( !MSWCreateControl(TRACKBAR_CLASS, wxEmptyString, pos, size) )
+        return false;

 
 

-    ::SetWindowText((HWND) m_hWnd, wxEmptyString);
+    // and initialize everything
+    SetRange(minValue, maxValue);
+    SetValue(value);
+    SetPageSize((maxValue - minValue)/10);

 
 

-    if ( m_windowStyle & wxSL_LABELS )
+    // we need to position the labels correctly if we have them and if
+    // SetSize() hadn't been called before (when best size was determined by
+    // MSWCreateControl()) as in this case they haven't been put in place yet
+    if ( m_labels && size.x != wxDefaultCoord && size.y != wxDefaultCoord )

     {
     {

-        // Finally, create max value static item
-        wxString maxLabel;
-        maxLabel.Printf(wxT("%d"), maxValue);
-        long wstyle = STATIC_FLAGS;
-
-        if ( m_windowStyle & wxCLIP_SIBLINGS )
-            wstyle |= WS_CLIPSIBLINGS;
-
-        m_staticMax = (WXHWND) CreateWindowEx
-            (
-                0, wxT("STATIC"), maxLabel,
-                wstyle,
-                0, 0, 0, 0, (HWND) parent->GetHWND(), (HMENU)NewControlId(),
-                wxGetInstance(), NULL
-            );
+        SetSize(size);
+    }

 
 

+    return true;
+}

 
 

-        if (GetFont().Ok())
-        {
-            if (GetFont().GetResourceHandle())
-            {
-                if ( m_staticMin )
-                    ::SendMessage((HWND) m_staticMin, WM_SETFONT,
-                          (WPARAM) GetFont().GetResourceHandle(), 0L);
+WXDWORD wxSlider::MSWGetStyle(long style, WXDWORD *exstyle) const
+{
+    WXDWORD msStyle = wxControl::MSWGetStyle(style, exstyle);

 
 

-                if ( m_staticMax )
-                    ::SendMessage((HWND) m_staticMax, WM_SETFONT,
-                        (WPARAM) GetFont().GetResourceHandle(), 0L);
+    // TBS_HORZ, TBS_RIGHT and TBS_BOTTOM are 0 but do include them for clarity
+    msStyle |= style & wxSL_VERTICAL ? TBS_VERT : TBS_HORZ;

 
 

-                if (m_staticValue)
-                    ::SendMessage((HWND) m_staticValue, WM_SETFONT,
-                        (WPARAM) GetFont().GetResourceHandle(), 0L);
-            }
-        }
+    if ( style & wxSL_BOTH )
+    {
+        // this fully specifies the style combined with TBS_VERT/HORZ above
+        msStyle |= TBS_BOTH;
+    }
+    else // choose one direction
+    {
+        if ( style & wxSL_LEFT )
+            msStyle |= TBS_LEFT;
+        else if ( style & wxSL_RIGHT )
+            msStyle |= TBS_RIGHT;
+        else if ( style & wxSL_TOP )
+            msStyle |= TBS_TOP;
+        else if ( style & wxSL_BOTTOM )
+            msStyle |= TBS_BOTTOM;

     }
 
     }
 

-    SetSize(pos.x, pos.y, size.x, size.y);
-    SetValue(value);
+    if ( style & wxSL_AUTOTICKS )
+        msStyle |= TBS_AUTOTICKS;
+    else
+        msStyle |= TBS_NOTICKS;

 
 

-    // SetInitialBestSize is not called since we don't call MSWCreateControl
-    // for this control, so call SetBestSize here instead.
-    SetBestSize(size);
+    if ( style & wxSL_SELRANGE )
+        msStyle |= TBS_ENABLESELRANGE;

 
 

-    return true;
+    return msStyle;

 }
 
 }
 

-bool wxSlider95::MSWOnScroll(int WXUNUSED(orientation), WXWORD wParam,
-                             WXWORD WXUNUSED(pos), WXHWND control)
+wxSlider::~wxSlider()
+{
+    delete m_labels;
+}
+
+// ----------------------------------------------------------------------------
+// event handling
+// ----------------------------------------------------------------------------
+
+bool wxSlider::MSWOnScroll(int WXUNUSED(orientation),
+                           WXWORD wParam,
+                           WXWORD WXUNUSED(pos),
+                           WXHWND control)

 {
     wxEventType scrollEvent;
     switch ( wParam )
 {
     wxEventType scrollEvent;
     switch ( wParam )


@@ -310,14 +324,29 @@ bool wxSlider95::MSWOnScroll(int WXUNUSED(orientation), WXWORD wParam,
 
         case SB_THUMBTRACK:
             scrollEvent = wxEVT_SCROLL_THUMBTRACK;
 
         case SB_THUMBTRACK:
             scrollEvent = wxEVT_SCROLL_THUMBTRACK;

+            m_isDragging = true;

             break;
 
         case SB_THUMBPOSITION:
             break;
 
         case SB_THUMBPOSITION:

-            scrollEvent = wxEVT_SCROLL_THUMBRELEASE;
+            if ( m_isDragging )
+            {
+                scrollEvent = wxEVT_SCROLL_THUMBRELEASE;
+                m_isDragging = false;
+            }
+            else
+            {
+                // this seems to only happen when the mouse wheel is used: in
+                // this case, as it might be unexpected to get THUMBRELEASE
+                // without preceding THUMBTRACKs, we don't generate it at all
+                // but generate CHANGED event because the control itself does
+                // not send us SB_ENDSCROLL for whatever reason when mouse
+                // wheel is used
+                scrollEvent = wxEVT_SCROLL_CHANGED;
+            }

             break;
 
         case SB_ENDSCROLL:
             break;
 
         case SB_ENDSCROLL:

-            scrollEvent = wxEVT_SCROLL_ENDSCROLL;
+            scrollEvent = wxEVT_SCROLL_CHANGED;

             break;
 
         default:
             break;
 
         default:


@@ -325,7 +354,7 @@ bool wxSlider95::MSWOnScroll(int WXUNUSED(orientation), WXWORD wParam,
             return false;
     }
 
             return false;
     }
 

-    int newPos = (int) ::SendMessage((HWND) control, TBM_GETPOS, 0, 0);
+    int newPos = ValueInvertOrNot((int) ::SendMessage((HWND) control, TBM_GETPOS, 0, 0));

     if ( (newPos < GetMin()) || (newPos > GetMax()) )
     {
         // out of range - but we did process it
     if ( (newPos < GetMin()) || (newPos > GetMax()) )
     {
         // out of range - but we did process it


@@ -346,491 +375,314 @@ bool wxSlider95::MSWOnScroll(int WXUNUSED(orientation), WXWORD wParam,
     return GetEventHandler()->ProcessEvent( cevent );
 }
 
     return GetEventHandler()->ProcessEvent( cevent );
 }
 

-wxSlider95::~wxSlider95()
+void wxSlider::Command (wxCommandEvent & event)

 {
 {

-    if (m_staticMin)
-    {
-        ::DestroyWindow((HWND) m_staticMin);
-        m_staticMin = (WXHWND) NULL;
-    }
-
-    if (m_staticMax)
-    {
-        ::DestroyWindow((HWND) m_staticMax);
-        m_staticMax = (WXHWND) NULL;
-    }
-
-    if (m_staticValue)
-    {
-        ::DestroyWindow((HWND) m_staticValue);
-        m_staticValue = (WXHWND) NULL;
-    }
+    SetValue (event.GetInt());
+    ProcessCommand (event);

 }
 
 }
 

-int wxSlider95::GetValue() const
-{
-    return ::SendMessage(GetHwnd(), TBM_GETPOS, 0, 0);
-}
+// ----------------------------------------------------------------------------
+// geometry stuff
+// ----------------------------------------------------------------------------

 
 

-void wxSlider95::SetValue(int value)
+wxRect wxSlider::GetBoundingBox() const

 {
 {

-    ::SendMessage(GetHwnd(), TBM_SETPOS, (WPARAM)TRUE, (LPARAM)value);
+    // take care not to call our own functions which would call us recursively
+    int x, y, w, h;
+    wxSliderBase::DoGetPosition(&x, &y);
+    wxSliderBase::DoGetSize(&w, &h);

 
 

-    if (m_staticValue)
+    wxRect rect(x, y, w, h);
+    if ( m_labels )

     {
     {

-        wxString str;
-        str.Printf(wxT("%d"), value);
-        ::SetWindowText((HWND) m_staticValue, str);
+        wxRect lrect = m_labels->GetBoundingBox();
+        GetParent()->ScreenToClient(&lrect.x, &lrect.y);
+        rect.Union(lrect);

     }
     }

+
+    return rect;

 }
 
 }
 

-void wxSlider95::DoGetSize(int *width, int *height) const
+void wxSlider::DoGetSize(int *width, int *height) const

 {
 {

-    RECT rect;
-    rect.left = -1; rect.right = -1; rect.top = -1; rect.bottom = -1;
-
-    wxFindMaxSize(GetHWND(), &rect);
-
-    if (m_staticMin)
-        wxFindMaxSize(m_staticMin, &rect);
-
-    if (m_staticMax)
-        wxFindMaxSize(m_staticMax, &rect);
-
-    if (m_staticValue)
-        wxFindMaxSize(m_staticValue, &rect);
+    wxRect rect = GetBoundingBox();

 
     if ( width )
 
     if ( width )

-        *width = rect.right - rect.left;
+        *width = rect.width;

     if ( height )
     if ( height )

-        *height = rect.bottom - rect.top;
+        *height = rect.height;

 }
 
 }
 

-void wxSlider95::GetPosition(int *x, int *y) const
-{
-    wxWindow *parent = GetParent();
-    RECT rect;
-    rect.left = -1; rect.right = -1; rect.top = -1; rect.bottom = -1;
-
-    wxFindMaxSize(GetHWND(), &rect);
-
-    if (m_staticMin)
-        wxFindMaxSize(m_staticMin, &rect);
-    if (m_staticMax)
-        wxFindMaxSize(m_staticMax, &rect);
-    if (m_staticValue)
-        wxFindMaxSize(m_staticValue, &rect);
-
-    // Since we now have the absolute screen coords,
-    // if there's a parent we must subtract its top left corner
-    POINT point;
-    point.x = rect.left;
-    point.y = rect.top;
-    if (parent)
-        ::ScreenToClient((HWND) parent->GetHWND(), &point);
-
-    // We may be faking the client origin.
-    // So a window that's really at (0, 30) may appear
-    // (to wxWin apps) to be at (0, 0).
-    if (GetParent())
-    {
-        wxPoint pt(GetParent()->GetClientAreaOrigin());
-        point.x -= pt.x;
-        point.y -= pt.y;
-    }
+void wxSlider::DoGetPosition(int *x, int *y) const
+{
+    wxRect rect = GetBoundingBox();

 
 

-    *x = point.x;
-    *y = point.y;
+    if ( x )
+        *x = rect.x;
+    if ( y )
+        *y = rect.y;

 }
 
 }
 

-// TODO one day, make sense of all this horros and replace it with a readable
-//      DoGetBestSize()
-void wxSlider95::DoSetSize(int x, int y, int width, int height, int sizeFlags)
+int wxSlider::GetLabelsSize(int *width) const

 {
 {

-    int x1 = x;
-    int y1 = y;
-    int w1 = width;
-    int h1 = height;
-
-    int currentX, currentY;
-    GetPosition(&currentX, &currentY);
-    if (x == wxDefaultCoord && !(sizeFlags & wxSIZE_ALLOW_MINUS_ONE))
-       x1 = currentX;
-    if (y == wxDefaultCoord && !(sizeFlags & wxSIZE_ALLOW_MINUS_ONE))
-        y1 = currentY;
-
-    AdjustForParentClientOrigin(x1, y1, sizeFlags);
-
-    wxChar buf[300];
-
-    int x_offset = x;
-    int y_offset = y;
-
-    int cx;     // slider,min,max sizes

     int cy;
     int cy;

-    int cyf;
-
-    wxGetCharSize(GetHWND(), &cx, &cy, this->GetFont());

 
 

-    if ((m_windowStyle & wxSL_VERTICAL) != wxSL_VERTICAL)
+    if ( width )

     {
     {

-        if ( m_windowStyle & wxSL_LABELS )
-        {
-            int min_len = 0;
-
-            ::GetWindowText((HWND) m_staticMin, buf, 300);
-            GetTextExtent(buf, &min_len, &cyf);
-
-            int max_len = 0;
-
-            ::GetWindowText((HWND) m_staticMax, buf, 300);
-            GetTextExtent(buf, &max_len, &cyf);
-            if (m_staticValue)
-            {
-                int new_width = (int)(wxMax(min_len, max_len));
-                int valueHeight = (int)cyf;
-#ifdef __WIN32__
-                // For some reason, under Win95, the text edit control has
-                // a lot of space before the first character
-                new_width += 3*cx;
-#endif
-                // The height needs to be a bit bigger under Win95 if
-                // using native 3D effects.
-                valueHeight = (int) (valueHeight * 1.5) ;
-                ::MoveWindow((HWND) m_staticValue, x_offset, y_offset,
-                    new_width, valueHeight, TRUE);
-                x_offset += new_width + cx;
-            }
-
-            ::MoveWindow((HWND) m_staticMin, x_offset, y_offset,
-                (int) min_len, cy, TRUE);
-            x_offset += (int)(min_len + cx);
+        // find the max label width
+        int wLabelMin, wLabelMax;
+        GetTextExtent(Format(m_rangeMin), &wLabelMin, &cy);
+        GetTextExtent(Format(m_rangeMax), &wLabelMax, &cy);

 
 

-            // slider_length = (total width available) - (width used so far)
-            //                   - (width of max label) - (border)
-            int slider_length = (int)(w1 - (x_offset-x) - max_len - cx);
-
-            int slider_height = h1;
-            if (slider_height < 0 )
-                slider_height = 20;
-
-            // Slider must have a minimum/default length/height
-            if (slider_length < 100)
-                slider_length = 100;
-
-            ::MoveWindow(GetHwnd(), x_offset, y_offset,
-                slider_length, slider_height, TRUE);
-            x_offset += slider_length + cx;
-
-            ::MoveWindow((HWND) m_staticMax, x_offset, y_offset,
-                (int) max_len, cy, TRUE);
-        }
-        else
-        {
-            // No labels
-            // If we're prepared to use the existing size, then...
-            if
-            (
-                width == wxDefaultCoord
-                && height == wxDefaultCoord
-                && ((sizeFlags & wxSIZE_AUTO) != wxSIZE_AUTO)
-            )
-            {
-                GetSize(&w1, &h1);
-            }
-
-            if ( w1 < 0 )
-                w1 = 100;
-            if ( h1 < 0 )
-                h1 = 20;
-
-            ::MoveWindow(GetHwnd(), x1, y1, w1, h1, TRUE);
-        }
+        *width = wxMax(wLabelMin, wLabelMax);

     }
     else
     {
     }
     else
     {

-        if ( m_windowStyle & wxSL_LABELS )
-        {
-            int min_len;
-            ::GetWindowText((HWND) m_staticMin, buf, 300);
-            GetTextExtent(buf, &min_len, &cyf);
+        cy = GetCharHeight();
+    }

 
 

-            int max_len;
-            ::GetWindowText((HWND) m_staticMax, buf, 300);
-            GetTextExtent(buf, &max_len, &cyf);
+    return EDIT_HEIGHT_FROM_CHAR_HEIGHT(cy);
+}

 
 

-            if (m_staticValue)
-            {
-                int new_width = (int)(wxMax(min_len, max_len));
-                int valueHeight = (int)cyf;
-                new_width += cx;
+void wxSlider::DoMoveWindow(int x, int y, int width, int height)
+{
+    // all complications below are because we need to position the labels,
+    // without them everything is easy
+    if ( !m_labels )
+    {
+        wxSliderBase::DoMoveWindow(x, y, width, height);
+        return;
+    }

 
 

-                // The height needs to be a bit bigger under Win95 if
-                // using native 3D effects.
-                valueHeight = (int) (valueHeight * 1.5) ;
+    // be careful to position the slider itself after moving the labels as
+    // otherwise our GetBoundingBox(), which is called from WM_SIZE handler,
+    // would return a wrong result and wrong size would be cached internally
+    if ( HasFlag(wxSL_VERTICAL) )
+    {
+        int wLabel;
+        int hLabel = GetLabelsSize(&wLabel);

 
 

-                ::MoveWindow((HWND) m_staticValue, x_offset, y_offset,
-                    new_width, valueHeight, TRUE);
-                y_offset += valueHeight;
-            }
+        int xLabel = HasFlag(wxSL_LEFT) ? x + width - wLabel : x;
+
+        // position all labels: min at the top, value in the middle and max at
+        // the bottom
+        DoMoveSibling((HWND)(*m_labels)[SliderLabel_Min],
+                     xLabel, y, wLabel, hLabel);

 
 

-            ::MoveWindow((HWND) m_staticMin, x_offset, y_offset,
-                (int) min_len, cy, TRUE);
-            y_offset += cy;
+        DoMoveSibling((HWND)(*m_labels)[SliderLabel_Value],
+                     xLabel, y + (height - hLabel)/2, wLabel, hLabel);

 
 

-            //  slider_length = (total height available) - (height used so far)
-            //                              - (height of max label) - (border)
-            int slider_length = (int)(h1 - (y_offset-y) - cy - cy);
+        DoMoveSibling((HWND)(*m_labels)[SliderLabel_Max],
+                      xLabel, y + height - hLabel, wLabel, hLabel);

 
 

-            int slider_width = w1;
-            if (slider_width < 0 )
-                slider_width = 20;
+        // position the slider itself along the left/right edge
+        wxSliderBase::DoMoveWindow(HasFlag(wxSL_LEFT) ? x : x + wLabel + HGAP,
+                                   y + hLabel/2,
+                                   width - wLabel - HGAP,
+                                   height - hLabel);
+    }
+    else // horizontal
+    {
+        int wLabel;
+        int hLabel = GetLabelsSize(&wLabel);

 
 

-            // Slider must have a minimum/default length
-            if (slider_length < 100)
-                slider_length = 100;
+        int yLabel = HasFlag(wxSL_TOP) ? y + height - hLabel : y;

 
 

-            ::MoveWindow(GetHwnd(), x_offset, y_offset,
-                slider_width, slider_length, TRUE);
-            y_offset += slider_length;
+        // position all labels: min on the left, value in the middle and max to
+        // the right
+        DoMoveSibling((HWND)(*m_labels)[SliderLabel_Min],
+                      x, yLabel, wLabel, hLabel);

 
 

-            ::MoveWindow((HWND) m_staticMax, x_offset, y_offset,
-                (int)max_len, cy, TRUE);
-        }
-        else
-        {
-            // No labels
-            // If we're prepared to use the existing size, then...
-            if
-            (
-                width == wxDefaultCoord && height == wxDefaultCoord
-                && ((sizeFlags & wxSIZE_AUTO) != wxSIZE_AUTO)
-            )
-            {
-                GetSize(&w1, &h1);
-            }
+        DoMoveSibling((HWND)(*m_labels)[SliderLabel_Value],
+                      x + (width - wLabel)/2, yLabel, wLabel, hLabel);

 
 

-            if ( w1 < 0 )
-                w1 = 20;
-            if ( h1 < 0 )
-                h1 = 100;
+        DoMoveSibling((HWND)(*m_labels)[SliderLabel_Max],
+                      x + width - wLabel, yLabel, wLabel, hLabel);

 
 

-            ::MoveWindow(GetHwnd(), x1, y1, w1, h1, TRUE);
-        }
+        // position the slider itself along the top/bottom edge
+        wxSliderBase::DoMoveWindow(x,
+                                   HasFlag(wxSL_TOP) ? y : y + hLabel,
+                                   width,
+                                   height - hLabel);

     }
 }
 
     }
 }
 

-
-// A reimplementaion of the mess above changed a bit to just determine the min
-// size needed.  It would certainly be nice to refactor this and DoSetSize
-// somehow.
-wxSize wxSlider95::DoGetBestSize() const
+wxSize wxSlider::DoGetBestSize() const

 {
 {

-    wxSize rv;
-    wxChar buf[300];
-    int cx;
-    int cy;
-    int cyf;
-    int min_len = 0;
-    int max_len = 0;
-
-    wxGetCharSize(GetHWND(), &cx, &cy, this->GetFont());
-
-    if ( !HasFlag(wxSL_VERTICAL))
+    // these values are arbitrary
+    static const int length = 100;
+    static const int thumb = 24;
+    static const int ticks = 8;
+
+    int *width;
+    wxSize size;
+    if ( HasFlag(wxSL_VERTICAL) )

     {
     {

-        rv = wxSize(100, 20);  // default size for the slider itself
+        size.x = thumb;
+        size.y = length;
+        width = &size.x;

 
 

-        if (HasFlag(wxSL_LABELS))  // do we need to add more for the labels?
+        if ( m_labels )

         {
         {

-            ::GetWindowText((HWND) m_staticMin, buf, 300);
-            GetTextExtent(buf, &min_len, &cyf);
-            rv.x += min_len + cx;
+            int wLabel;
+            int hLabel = GetLabelsSize(&wLabel);

 
 

-            ::GetWindowText((HWND) m_staticMax, buf, 300);
-            GetTextExtent(buf, &max_len, &cyf);
-            rv.x += max_len + cx;
+            // account for the labels
+            size.x += HGAP + wLabel;

 
 

-            if (m_staticValue)
-            {
-                int new_width = (int)(wxMax(min_len, max_len));
-                int valueHeight = (int)cyf;
-
-#ifdef __WIN32__
-                // For some reason, under Win95, the text edit control has
-                // a lot of space before the first character
-                new_width += 3*cx;
-#endif
-                // The height needs to be a bit bigger under Win95 if
-                // using native 3D effects.
-                valueHeight = (int) (valueHeight * 1.5) ;
-
-                rv.x += new_width + cx;
-                rv.y = wxMax(valueHeight, rv.y);
-            }
+            // labels are indented relative to the slider itself
+            size.y += hLabel;

         }
     }
         }
     }

-    else // ! wxSL_HORIZONTAL
+    else // horizontal

     {
     {

-        rv = wxSize(20, 100);  // default size for the slider itself
+        size.x = length;
+        size.y = thumb;
+        width = &size.y;

 
 

-        if (HasFlag(wxSL_LABELS)) // do we need to add more for the labels?
+        if ( m_labels )

         {
         {

-            ::GetWindowText((HWND) m_staticMin, buf, 300);
-            GetTextExtent(buf, &min_len, &cyf);
-            rv.y += cy;
+            // labels add extra height
+            size.y += GetLabelsSize();
+        }
+    }

 
 

-            ::GetWindowText((HWND) m_staticMax, buf, 300);
-            GetTextExtent(buf, &max_len, &cyf);
-            rv.y += cy;
+    // need extra space to show ticks
+    if ( HasFlag(wxSL_TICKS) )
+    {
+        *width += ticks;

 
 

-            if (m_staticValue)
-            {
-                int new_width = (int)(wxMax(min_len, max_len));
-                int valueHeight = (int)cyf;
-                new_width += cx;
-
-                // The height needs to be a bit bigger under Win95 if
-                // using native 3D effects.
-                valueHeight = (int) (valueHeight * 1.5) ;
-                rv.y += valueHeight;
-                rv.x = wxMax(new_width, rv.x);
-            }
-        }
+        // and maybe twice as much if we show them on both sides
+        if ( HasFlag(wxSL_BOTH) )
+            *width += ticks;

     }
     }

-    return rv;
+
+    return size;

 }
 
 }
 

+// ----------------------------------------------------------------------------
+// slider-specific methods
+// ----------------------------------------------------------------------------

 
 

-void wxSlider95::SetRange(int minValue, int maxValue)
+int wxSlider::GetValue() const

 {
 {

-    m_rangeMin = minValue;
-    m_rangeMax = maxValue;
+    return ValueInvertOrNot(::SendMessage(GetHwnd(), TBM_GETPOS, 0, 0));
+}

 
 

-    ::SendMessage(GetHwnd(), TBM_SETRANGE, TRUE, MAKELONG(minValue, maxValue));
+void wxSlider::SetValue(int value)
+{
+    ::SendMessage(GetHwnd(), TBM_SETPOS, (WPARAM)TRUE, (LPARAM)ValueInvertOrNot(value));

 
 

-    wxChar buf[40];
-    if ( m_staticMin )
+    if ( m_labels )

     {
     {

-        wxSprintf(buf, wxT("%d"), m_rangeMin);
-        ::SetWindowText((HWND) m_staticMin, buf);
+        ::SetWindowText((*m_labels)[SliderLabel_Value], Format(value));

     }
     }

+}
+
+void wxSlider::SetRange(int minValue, int maxValue)
+{
+    m_rangeMin = minValue;
+    m_rangeMax = maxValue;
+
+    ::SendMessage(GetHwnd(), TBM_SETRANGEMIN, TRUE, m_rangeMin);
+    ::SendMessage(GetHwnd(), TBM_SETRANGEMAX, TRUE, m_rangeMax);

 
 

-    if ( m_staticMax )
+    if ( m_labels )

     {
     {

-        wxSprintf(buf, wxT("%d"), m_rangeMax);
-        ::SetWindowText((HWND) m_staticMax, buf);
+        ::SetWindowText((*m_labels)[SliderLabel_Min], Format(ValueInvertOrNot(m_rangeMin)));
+        ::SetWindowText((*m_labels)[SliderLabel_Max], Format(ValueInvertOrNot(m_rangeMax)));

     }
 }
 
     }
 }
 

-// For trackbars only
-void wxSlider95::SetTickFreq(int n, int pos)
+void wxSlider::SetTickFreq(int n, int pos)

 {
 {

-  m_tickFreq = n;
-  ::SendMessage( GetHwnd(), TBM_SETTICFREQ, (WPARAM) n, (LPARAM) pos );
+    m_tickFreq = n;
+    ::SendMessage( GetHwnd(), TBM_SETTICFREQ, (WPARAM) n, (LPARAM) pos );

 }
 
 }
 

-void wxSlider95::SetPageSize(int pageSize)
+void wxSlider::SetPageSize(int pageSize)

 {
 {

-  ::SendMessage( GetHwnd(), TBM_SETPAGESIZE, (WPARAM) 0, (LPARAM) pageSize );
-  m_pageSize = pageSize;
+    ::SendMessage( GetHwnd(), TBM_SETPAGESIZE, (WPARAM) 0, (LPARAM) pageSize );
+    m_pageSize = pageSize;

 }
 
 }
 

-int wxSlider95::GetPageSize() const
+int wxSlider::GetPageSize() const

 {
 {

-  return m_pageSize;
+    return m_pageSize;

 }
 
 }
 

-void wxSlider95::ClearSel()
+void wxSlider::ClearSel()

 {
 {

-  ::SendMessage( GetHwnd(), TBM_CLEARSEL, (WPARAM) TRUE, (LPARAM) 0 );
+    ::SendMessage(GetHwnd(), TBM_CLEARSEL, (WPARAM) TRUE, (LPARAM) 0);

 }
 
 }
 

-void wxSlider95::ClearTicks()
+void wxSlider::ClearTicks()

 {
 {

-  ::SendMessage( GetHwnd(), TBM_CLEARTICS, (WPARAM) TRUE, (LPARAM) 0 );
+    ::SendMessage(GetHwnd(), TBM_CLEARTICS, (WPARAM) TRUE, (LPARAM) 0);

 }
 
 }
 

-void wxSlider95::SetLineSize(int lineSize)
+void wxSlider::SetLineSize(int lineSize)

 {
     m_lineSize = lineSize;
 {
     m_lineSize = lineSize;

-    ::SendMessage( GetHwnd(), TBM_SETLINESIZE, (WPARAM) 0, (LPARAM) lineSize );
+    ::SendMessage(GetHwnd(), TBM_SETLINESIZE, (WPARAM) 0, (LPARAM) lineSize);

 }
 
 }
 

-int wxSlider95::GetLineSize() const
+int wxSlider::GetLineSize() const

 {
 {

-    return (int) ::SendMessage( GetHwnd(), TBM_GETLINESIZE,
-        (WPARAM) 0, (LPARAM) 0 );
+    return (int)::SendMessage(GetHwnd(), TBM_GETLINESIZE, 0, 0);

 }
 
 }
 

-int wxSlider95::GetSelEnd() const
+int wxSlider::GetSelEnd() const

 {
 {

-    return (int) ::SendMessage( GetHwnd(), TBM_SETSELEND,
-        (WPARAM) 0, (LPARAM) 0 );
+    return (int)::SendMessage(GetHwnd(), TBM_GETSELEND, 0, 0);

 }
 
 }
 

-int wxSlider95::GetSelStart() const
+int wxSlider::GetSelStart() const

 {
 {

-    return (int) ::SendMessage( GetHwnd(), TBM_GETSELSTART,
-        (WPARAM) 0, (LPARAM) 0 );
+    return (int)::SendMessage(GetHwnd(), TBM_GETSELSTART, 0, 0);

 }
 
 }
 

-void wxSlider95::SetSelection(int minPos, int maxPos)
+void wxSlider::SetSelection(int minPos, int maxPos)

 {
     ::SendMessage(GetHwnd(), TBM_SETSEL,
 {
     ::SendMessage(GetHwnd(), TBM_SETSEL,

-        (WPARAM) TRUE, (LPARAM) MAKELONG( minPos, maxPos) );
+                  (WPARAM) TRUE /* redraw */,
+                  (LPARAM) MAKELONG( minPos, maxPos) );

 }
 
 }
 

-void wxSlider95::SetThumbLength(int len)
+void wxSlider::SetThumbLength(int len)

 {
 {

-    ::SendMessage( GetHwnd(), TBM_SETTHUMBLENGTH, (WPARAM) len, (LPARAM) 0 );
+    ::SendMessage(GetHwnd(), TBM_SETTHUMBLENGTH, (WPARAM) len, (LPARAM) 0);

 }
 
 }
 

-int wxSlider95::GetThumbLength() const
+int wxSlider::GetThumbLength() const

 {
 {

-  return (int) ::SendMessage( GetHwnd(), TBM_GETTHUMBLENGTH,
-      (WPARAM) 0, (LPARAM) 0 );
+    return (int)::SendMessage( GetHwnd(), TBM_GETTHUMBLENGTH, 0, 0);

 }
 
 }
 

-void wxSlider95::SetTick(int tickPos)
+void wxSlider::SetTick(int tickPos)

 {
 {

-  ::SendMessage( GetHwnd(), TBM_SETTIC, (WPARAM) 0, (LPARAM) tickPos );
+    ::SendMessage( GetHwnd(), TBM_SETTIC, (WPARAM) 0, (LPARAM) tickPos );

 }
 
 }
 

-bool wxSlider95::ContainsHWND(WXHWND hWnd) const
+// ----------------------------------------------------------------------------
+// composite control methods
+// ----------------------------------------------------------------------------
+
+WXHWND wxSlider::GetStaticMin() const

 {
 {

-    return
-    (
-        hWnd == GetStaticMin()
-        || hWnd == GetStaticMax()
-        || hWnd == GetEditValue()
-    );
+    return m_labels ? (WXHWND)(*m_labels)[SliderLabel_Min] : NULL;

 }
 
 }
 

-void wxSlider95::Command (wxCommandEvent & event)
+WXHWND wxSlider::GetStaticMax() const

 {
 {

-    SetValue (event.GetInt());
-    ProcessCommand (event);
+    return m_labels ? (WXHWND)(*m_labels)[SliderLabel_Max] : NULL;

 }
 
 }
 

-bool wxSlider95::Show(bool show)
+WXHWND wxSlider::GetEditValue() const

 {
 {

-    wxWindow::Show(show);
-
-    int cshow = show ? SW_SHOW : SW_HIDE;
-
-    if(m_staticValue)
-        ShowWindow((HWND) m_staticValue, cshow);
-
-    if(m_staticMin)
-        ShowWindow((HWND) m_staticMin, cshow);
-
-    if(m_staticMax)
-        ShowWindow((HWND) m_staticMax, cshow);
-
-    return true;
+    return m_labels ? (WXHWND)(*m_labels)[SliderLabel_Value] : NULL;

 }
 
 }
 

-#endif
-  // __WIN95__
+WX_FORWARD_STD_METHODS_TO_SUBWINDOWS(wxSlider, wxSliderBase, m_labels)

 
 #endif // wxUSE_SLIDER
 
 #endif // wxUSE_SLIDER