docs corrections and docs for Chris' wxImage::SaveFile(filename_only) patch

[wxWidgets.git] / src / gtk1 / region.cpp

diff --git a/src/gtk1/region.cpp b/src/gtk1/region.cpp
index 2159fea32e336bae5f94261d6e5da4aa8d4fd62c..f184e4d7955844f4793692316588e021b00153b1 100644 (file)
--- a/src/gtk1/region.cpp
+++ b/src/gtk1/region.cpp
@@ -20,12 +20,11 @@
 // headers
 // ----------------------------------------------------------------------------
 
 // headers
 // ----------------------------------------------------------------------------
 

-#include "wx/region.h"
+#include "wx/log.h"

 
 

-#include <gdk/gdk.h>
-#include <gtk/gtk.h>
+#include "wx/region.h"

 
 

-#include "wx/log.h"
+#include "wx/gtk/private.h"

 
 // ----------------------------------------------------------------------------
 // wxRegionRefData: private class containing the information about the region
 
 // ----------------------------------------------------------------------------
 // wxRegionRefData: private class containing the information about the region


@@ -87,7 +86,7 @@ void wxRegion::InitRect(wxCoord x, wxCoord y, wxCoord w, wxCoord h)
     m_refData = new wxRegionRefData();
     
 #ifdef __WXGTK20__
     m_refData = new wxRegionRefData();
     
 #ifdef __WXGTK20__

-    M_REGIONDATA->m_region = gdk_region_rectangle( rect );
+    M_REGIONDATA->m_region = gdk_region_rectangle( &rect );

 #else
     GdkRegion *reg = gdk_region_new();
     M_REGIONDATA->m_region = gdk_region_union_with_rect( reg, &rect );
 #else
     GdkRegion *reg = gdk_region_new();
     M_REGIONDATA->m_region = gdk_region_union_with_rect( reg, &rect );


@@ -133,22 +132,22 @@ wxObjectRefData *wxRegion::CloneRefData(const wxObjectRefData *data) const
 {
     return new wxRegionRefData(*(wxRegionRefData *)data);
 }
 {
     return new wxRegionRefData(*(wxRegionRefData *)data);
 }

+

 // ----------------------------------------------------------------------------
 // wxRegion comparison
 // ----------------------------------------------------------------------------
 
 bool wxRegion::operator==( const wxRegion& region )
 {
 // ----------------------------------------------------------------------------
 // wxRegion comparison
 // ----------------------------------------------------------------------------
 
 bool wxRegion::operator==( const wxRegion& region )
 {

+    if (m_refData == region.m_refData) return TRUE;
+
+    if (!m_refData || !region.m_refData) return FALSE;
+    

     // compare the regions themselves, not the pointers to ref data!
     return gdk_region_equal(M_REGIONDATA->m_region,
                             M_REGIONDATA_OF(region)->m_region);
 }
 
     // compare the regions themselves, not the pointers to ref data!
     return gdk_region_equal(M_REGIONDATA->m_region,
                             M_REGIONDATA_OF(region)->m_region);
 }
 

-bool wxRegion::operator != ( const wxRegion& region )
-{
-    return !(*this == region);
-}
-

 // ----------------------------------------------------------------------------
 // wxRegion operations
 // ----------------------------------------------------------------------------
 // ----------------------------------------------------------------------------
 // wxRegion operations
 // ----------------------------------------------------------------------------


@@ -170,7 +169,7 @@ bool wxRegion::Union( wxCoord x, wxCoord y, wxCoord width, wxCoord height )
     {
         m_refData = new wxRegionRefData();
 #ifdef __WXGTK20__
     {
         m_refData = new wxRegionRefData();
 #ifdef __WXGTK20__

-        M_REGIONDATA->m_region = gdk_region_rectangle( rect );
+        M_REGIONDATA->m_region = gdk_region_rectangle( &rect );

 #else
         GdkRegion *reg = gdk_region_new();
         M_REGIONDATA->m_region = gdk_region_union_with_rect( reg, &rect );
 #else
         GdkRegion *reg = gdk_region_new();
         M_REGIONDATA->m_region = gdk_region_union_with_rect( reg, &rect );


@@ -498,9 +497,9 @@ void wxRIRefData::CreateRects( const wxRegion& region )
     if (!gdkregion) return;
     
 #ifdef __WXGTK20__
     if (!gdkregion) return;
     
 #ifdef __WXGTK20__

-    GdkRectangles *gdkrects = NULL;
+    GdkRectangle *gdkrects = NULL;

     gint numRects = 0;
     gint numRects = 0;

-    gdk_region_get_rectangles( gdkregion, &gdkrect, &numRects );
+    gdk_region_get_rectangles( gdkregion, &gdkrects, &numRects );

     
     m_numRects = numRects;
     if (numRects)
     
     m_numRects = numRects;
     if (numRects)


@@ -516,8 +515,8 @@ void wxRIRefData::CreateRects( const wxRegion& region )
             wr.height = gr.height;
         }
     }
             wr.height = gr.height;
         }
     }

-    g_delete( gdkrects ); // delete []
-#else
+    g_free( gdkrects );
+#else // GTK+ 1.x

     Region r = ((GdkRegionPrivate *)gdkregion)->xregion;
     if (r)
     {
     Region r = ((GdkRegionPrivate *)gdkregion)->xregion;
     if (r)
     {


@@ -536,7 +535,7 @@ void wxRIRefData::CreateRects( const wxRegion& region )
             }
         }
     }
             }
         }
     }

-#endif
+#endif // GTK+ 2.0/1.x

 }
 
 wxRegionIterator::wxRegionIterator()
 }
 
 wxRegionIterator::wxRegionIterator()