/////////////////////////////////////////////////////////////////////////////
-// Name: msw/datectrl.cpp
+// Name: src/msw/datectrl.cpp
// Purpose: wxDatePickerCtrl implementation
// Author: Vadim Zeitlin
// Modified by:
#pragma hdrstop
#endif
+#if wxUSE_DATEPICKCTRL
+
#ifndef WX_PRECOMP
+ #include "wx/msw/wrapwin.h"
+ #include "wx/msw/wrapcctl.h" // include <commctrl.h> "properly"
+ #include "wx/app.h"
+ #include "wx/intl.h"
+ #include "wx/dcclient.h"
+ #include "wx/settings.h"
+ #include "wx/msw/private.h"
#endif
#include "wx/datectrl.h"
-#define _WX_DEFINE_DATE_EVENTS_
+#include "wx/msw/private/datecontrols.h"
+
#include "wx/dateevt.h"
-#include "wx/msw/wrapwin.h"
-#include "wx/msw/wrapcctl.h"
-#include "wx/msw/private.h"
+// apparently some versions of mingw define these macros erroneously
+#ifndef DateTime_GetSystemtime
+ #define DateTime_GetSystemtime DateTime_GetSystemTime
+#endif
+
+#ifndef DateTime_SetSystemtime
+ #define DateTime_SetSystemtime DateTime_SetSystemTime
+#endif
+
+IMPLEMENT_DYNAMIC_CLASS(wxDatePickerCtrl, wxControl)
// ============================================================================
// implementation
// ============================================================================
-// ----------------------------------------------------------------------------
-// helpers for wxDateTime <-> SYSTEMTIME conversion
-// ----------------------------------------------------------------------------
-
-static inline void wxFromSystemTime(wxDateTime *dt, const SYSTEMTIME& st)
-{
- dt->Set(st.wDay,
- wx_static_cast(wxDateTime::Month, wxDateTime::Jan + st.wMonth - 1),
- st.wYear,
- 0, 0, 0);
-}
-
-static inline void wxToSystemTime(SYSTEMTIME *st, const wxDateTime& dt)
-{
- const wxDateTime::Tm tm(dt.GetTm());
-
- st->wYear = tm.year;
- st->wMonth = tm.mon - wxDateTime::Jan + 1;
- st->wDay = tm.mday;
-
- st->wDayOfWeek =
- st->wHour =
- st->wMinute =
- st->wSecond =
- st->wMilliseconds = 0;
-}
-
// ----------------------------------------------------------------------------
// wxDatePickerCtrl creation
// ----------------------------------------------------------------------------
const wxValidator& validator,
const wxString& name)
{
+ if ( !wxMSWDateControls::CheckInitialization() )
+ return false;
+
+ // use wxDP_SPIN if wxDP_DEFAULT (0) was given as style
+ if ( !(style & wxDP_DROPDOWN) )
+ style |= wxDP_SPIN;
+
// initialize the base class
if ( !CreateControl(parent, id, pos, size, style, validator, name) )
return false;
// create the native control
- if ( !MSWCreateControl(DATETIMEPICK_CLASS, _T(""), pos, size) )
+ if ( !MSWCreateControl(DATETIMEPICK_CLASS, wxEmptyString, pos, size) )
return false;
- if ( dt.IsValid() )
+ if ( dt.IsValid() || (style & wxDP_ALLOWNONE) )
SetValue(dt);
+ else
+ SetValue(wxDateTime::Today());
return true;
}
{
WXDWORD styleMSW = wxDatePickerCtrlBase::MSWGetStyle(style, exstyle);
- // for now this is unconditional, but we should support drop down control
- // style as well later
- styleMSW |= DTS_UPDOWN | DTS_SHORTDATEFORMAT;
+ // although MSDN doesn't mention it, DTS_UPDOWN doesn't work with
+ // comctl32.dll 4.72
+ if ( wxApp::GetComCtl32Version() > 472 && (style & wxDP_SPIN) )
+ styleMSW |= DTS_UPDOWN;
+ //else: drop down by default
+
+#ifdef DTS_SHORTDATECENTURYFORMAT
+ if ( style & wxDP_SHOWCENTURY )
+ styleMSW |= DTS_SHORTDATECENTURYFORMAT;
+ else
+#endif // DTS_SHORTDATECENTURYFORMAT
+ styleMSW |= DTS_SHORTDATEFORMAT;
+
+ if ( style & wxDP_ALLOWNONE )
+ styleMSW |= DTS_SHOWNONE;
return styleMSW;
}
wxSize wxDatePickerCtrl::DoGetBestSize() const
{
- const int y = GetCharHeight();
+ wxClientDC dc(const_cast<wxDatePickerCtrl *>(this));
+
+ // we can't use FormatDate() here as the CRT doesn't always use the same
+ // format as the date picker control
+ wxString s;
+ for ( int len = 100; ; len *= 2 )
+ {
+ if ( ::GetDateFormat
+ (
+ LOCALE_USER_DEFAULT, // the control should use the same
+ DATE_SHORTDATE, // the format used by the control
+ NULL, // use current date (we don't care)
+ NULL, // no custom format
+ wxStringBuffer(s, len), // output buffer
+ len // and its length
+ ) )
+ {
+ // success
+ break;
+ }
+
+ const DWORD rc = ::GetLastError();
+ if ( rc != ERROR_INSUFFICIENT_BUFFER )
+ {
+ wxLogApiError(wxT("GetDateFormat"), rc);
+
+ // fall back on wxDateTime, what else to do?
+ s = wxDateTime::Today().FormatDate();
+ break;
+ }
+ }
+
+ // the best size for the control is bigger than just the string
+ // representation of todays date because the control must accommodate any
+ // date and while the widths of all digits are usually about the same, the
+ // width of the month string varies a lot, so try to account for it
+ s += wxT("WW");
+
+ int x, y;
+ dc.GetTextExtent(s, &x, &y);
- return wxSize(DEFAULT_ITEM_WIDTH, EDIT_HEIGHT_FROM_CHAR_HEIGHT(y));
+ // account for the drop-down arrow or spin arrows
+ x += wxSystemSettings::GetMetric(wxSYS_HSCROLL_ARROW_X);
+
+ // and for the checkbox if we have it
+ if ( HasFlag(wxDP_ALLOWNONE) )
+ x += 3*GetCharWidth();
+
+ wxSize best(x, EDIT_HEIGHT_FROM_CHAR_HEIGHT(y));
+ CacheBestSize(best);
+ return best;
}
// ----------------------------------------------------------------------------
void wxDatePickerCtrl::SetValue(const wxDateTime& dt)
{
- // as we don't support DTS_SHOWNONE style so far, we don't allow setting
- // the control to an invalid date, but this restriction may be lifted in
- // the future
- wxCHECK_RET( dt.IsValid(), _T("invalid date") );
+ wxCHECK_RET( dt.IsValid() || HasFlag(wxDP_ALLOWNONE),
+ wxT("this control requires a valid date") );
SYSTEMTIME st;
- wxToSystemTime(&st, dt);
- if ( !DateTime_SetSystemtime(GetHwnd(), GDT_VALID, &st) )
+ if ( dt.IsValid() )
{
- wxLogDebug(_T("DateTime_SetSystemtime() failed"));
+ // Don't try setting the date if it's out of range: calendar control
+ // under XP (and presumably all the other pre-Vista Windows versions)
+ // doesn't return false from DateTime_SetSystemtime() in this case but
+ // doesn't actually change the date, so we can't update our m_date
+ // unconditionally and would need to check whether it was changed
+ // before doing it. It looks simpler to just check whether it's in
+ // range here instead.
+ //
+ // If we ever drop support for XP we could rely on the return value of
+ // DateTime_SetSystemtime() but this probably won't happen in near
+ // future.
+ wxDateTime dtStart, dtEnd;
+ GetRange(&dtStart, &dtEnd);
+ if ( (dtStart.IsValid() && dt < dtStart) ||
+ (dtEnd.IsValid() && dt > dtEnd) )
+ {
+ // Fail silently, some existing code relies on SetValue() with an
+ // out of range value simply doing nothing -- so don't.
+ return;
+ }
+
+ dt.GetAsMSWSysTime(&st);
}
+
+ if ( !DateTime_SetSystemtime(GetHwnd(),
+ dt.IsValid() ? GDT_VALID : GDT_NONE,
+ &st) )
+ {
+ // The only expected failure is when the date is out of range but we
+ // already checked for this above.
+ wxFAIL_MSG( wxT("Setting the calendar date unexpectedly failed.") );
+
+ // In any case, skip updating m_date below.
+ return;
+ }
+
+ // we need to keep only the date part, times don't make sense for this
+ // control (in particular, comparisons with other dates would fail)
+ m_date = dt;
+ if ( m_date.IsValid() )
+ m_date.ResetTime();
}
wxDateTime wxDatePickerCtrl::GetValue() const
{
+#if wxDEBUG_LEVEL
wxDateTime dt;
SYSTEMTIME st;
if ( DateTime_GetSystemtime(GetHwnd(), &st) == GDT_VALID )
{
- wxFromSystemTime(&dt, st);
+ dt.SetFromMSWSysDate(st);
}
- return dt;
+ wxASSERT_MSG( m_date.IsValid() == dt.IsValid() &&
+ (!dt.IsValid() || dt == m_date),
+ wxT("bug in wxDatePickerCtrl: m_date not in sync") );
+#endif // wxDEBUG_LEVEL
+
+ return m_date;
}
void wxDatePickerCtrl::SetRange(const wxDateTime& dt1, const wxDateTime& dt2)
DWORD flags = 0;
if ( dt1.IsValid() )
{
- wxToSystemTime(&st[0], dt1);
+ dt1.GetAsMSWSysTime(st + 0);
flags |= GDTR_MIN;
}
if ( dt2.IsValid() )
{
- wxToSystemTime(&st[1], dt2);
+ dt2.GetAsMSWSysTime(st + 1);
flags |= GDTR_MAX;
}
if ( !DateTime_SetRange(GetHwnd(), flags, st) )
{
- wxLogDebug(_T("DateTime_SetRange() failed"));
+ wxLogDebug(wxT("DateTime_SetRange() failed"));
}
}
if ( dt1 )
{
if ( flags & GDTR_MIN )
- wxFromSystemTime(dt1, st[0]);
+ dt1->SetFromMSWSysDate(st[0]);
else
*dt1 = wxDefaultDateTime;
}
if ( dt2 )
{
if ( flags & GDTR_MAX )
- wxFromSystemTime(dt2, st[1]);
+ dt2->SetFromMSWSysDate(st[1]);
else
*dt2 = wxDefaultDateTime;
}
switch ( hdr->code )
{
case DTN_DATETIMECHANGE:
+ {
NMDATETIMECHANGE *dtch = (NMDATETIMECHANGE *)hdr;
wxDateTime dt;
if ( dtch->dwFlags == GDT_VALID )
- wxFromSystemTime(&dt, dtch->st);
+ dt.SetFromMSWSysDate(dtch->st);
- wxDateEvent event(this, dt, wxEVT_DATE_CHANGED);
- if ( GetEventHandler()->ProcessEvent(event) )
+ // filter out duplicate DTN_DATETIMECHANGE events which the native
+ // control sends us when using wxDP_DROPDOWN style
+ if ( (m_date.IsValid() != dt.IsValid()) ||
+ (m_date.IsValid() && dt != m_date) )
{
- *result = 0;
- return true;
+ m_date = dt;
+ wxDateEvent event(this, dt, wxEVT_DATE_CHANGED);
+ if ( HandleWindowEvent(event) )
+ {
+ *result = 0;
+ return true;
+ }
}
+ //else: both the old and new values are invalid, nothing changed
+ }
}
return wxDatePickerCtrlBase::MSWOnNotify(idCtrl, lParam, result);
}
+#endif // wxUSE_DATEPICKCTRL
projects / wxWidgets.git / blobdiff