Backed-out PNG8 patch (no time to look at why

[wxWidgets.git] / src / cocoa / listbox.mm

diff --git a/src/cocoa/listbox.mm b/src/cocoa/listbox.mm
index fe928079ffeae034ed70427e72b2627e6051f0e5..2da7df8afea596b37180ac13c83044de3d995753 100644 (file)
--- a/src/cocoa/listbox.mm
+++ b/src/cocoa/listbox.mm
@@ -6,7 +6,7 @@
 // Created:     2003/03/18
 // RCS-ID:      $Id: 
 // Copyright:   (c) 2003 David Elliott
-// Licence:    wxWindows license
+// Licence:    wxWidgets licence
 /////////////////////////////////////////////////////////////////////////////
 
 #include "wx/wxprec.h"
@@ -17,6 +17,7 @@
 #endif //WX_PRECOMP
 
 #include "wx/cocoa/string.h"
+#include "wx/cocoa/autorelease.h"
 #include "wx/cocoa/NSTableDataSource.h"
 
 #import <Foundation/NSArray.h>
@@ -29,6 +30,20 @@ BEGIN_EVENT_TABLE(wxListBox, wxListBoxBase)
 END_EVENT_TABLE()
 WX_IMPLEMENT_COCOA_OWNER(wxListBox,NSTableView,NSControl,NSView)
 
+bool wxListBox::Create(wxWindow *parent, wxWindowID winid,
+            const wxPoint& pos,
+            const wxSize& size,
+            const wxArrayString& choices,
+            long style,
+            const wxValidator& validator,
+            const wxString& name)
+{
+    wxCArrayString chs(choices);
+
+    return Create(parent, winid, pos, size, chs.GetCount(), chs.GetStrings(),
+                  style, validator, name);
+}
+
 bool wxListBox::Create(wxWindow *parent, wxWindowID winid,
             const wxPoint& pos,
             const wxSize& size,
@@ -37,6 +52,7 @@ bool wxListBox::Create(wxWindow *parent, wxWindowID winid,
             const wxValidator& validator,
             const wxString& name)
 {
+    wxAutoNSAutoreleasePool pool;
     if(!CreateControl(parent,winid,pos,size,style,validator,name))
         return false;
 
@@ -47,9 +63,9 @@ bool wxListBox::Create(wxWindow *parent, wxWindowID winid,
         [m_cocoaItems addObject: wxNSStringWithWxString(choices[i])];
     }
     // Remove everything
-    m_clientData.Clear();
+    m_itemClientData.Clear();
     // Initialize n elements to NULL
-    m_clientData.SetCount(n,NULL);
+    m_itemClientData.SetCount(n,NULL);
 
     SetNSTableView([[NSTableView alloc] initWithFrame: MakeDefaultNSRect(size)]);
     [m_cocoaNSView release];
@@ -81,7 +97,7 @@ wxListBox::~wxListBox()
     [GetNSTableView() setDataSource: nil];
     [m_cocoaDataSource release];
     [m_cocoaItems release];
-    DisassociateNSTableView(m_cocoaNSView);
+    DisassociateNSTableView(GetNSTableView());
 }
 
 int wxListBox::CocoaDataSource_numberOfRows()
@@ -126,7 +142,7 @@ void wxListBox::DoInsertItems(const wxArrayString& items, int pos)
     {
         [m_cocoaItems insertObject: wxNSStringWithWxString(items[i])
             atIndex: pos];
-        m_clientData.Insert(NULL,pos);
+        m_itemClientData.Insert(NULL,pos);
     }
     [GetNSTableView() reloadData];
 }
@@ -135,12 +151,12 @@ void wxListBox::DoSetItems(const wxArrayString& items, void **clientData)
 {
     // Remove everything
     [m_cocoaItems removeAllObjects];
-    m_clientData.Clear();
+    m_itemClientData.Clear();
     // Provide the data
     for(size_t i=0; i < items.GetCount(); i++)
     {
         [m_cocoaItems addObject: wxNSStringWithWxString(items[i])];
-        m_clientData.Add(clientData[i]);
+        m_itemClientData.Add(clientData[i]);
     }
     [GetNSTableView() reloadData];
 }