synchronize GTK2 minimum version in docs

[wxWidgets.git] / include / wx / weakref.h

diff --git a/include/wx/weakref.h b/include/wx/weakref.h
index df31c2fdc4abd612c3d8c9859d1c5d07935857b2..e612db81b29d7299a8de0eeb38585f115261a1ea 100644 (file)
--- a/include/wx/weakref.h
+++ b/include/wx/weakref.h
@@ -17,7 +17,7 @@
 // Some compilers (VC6, Borland, g++ < 3.3) have problem with template specialization.
 // However, this is only used for optimization purposes (a smaller wxWeakRef pointer)
 // (and the corner case of wxWeakRef<wxObject>). So for those compilers, we can fall
 // Some compilers (VC6, Borland, g++ < 3.3) have problem with template specialization.
 // However, this is only used for optimization purposes (a smaller wxWeakRef pointer)
 // (and the corner case of wxWeakRef<wxObject>). So for those compilers, we can fall

-// back to the non-optimal case, where we use a the same type of weak ref (static one)
+// back to the non-optimal case, where we use the same type of weak ref (static one)

 // in all cases. See defs.h for various setting these defines depending on compiler.
 
 #if !defined(HAVE_PARTIAL_SPECIALIZATION) || \
 // in all cases. See defs.h for various setting these defines depending on compiler.
 
 #if !defined(HAVE_PARTIAL_SPECIALIZATION) || \


@@ -149,7 +149,7 @@ protected:
         DoAssign( pobj, ptbase );
     }
 
         DoAssign( pobj, ptbase );
     }
 

-#ifdef HAVE_DYNAMIC_CAST
+#ifndef wxNO_RTTI

     void AssignHelper(T* pobj, wxInt2Type<false>)
     {
         // A last way to get a trackable pointer
     void AssignHelper(T* pobj, wxInt2Type<false>)
     {
         // A last way to get a trackable pointer


@@ -165,7 +165,7 @@ protected:
             Release();
         }
     }
             Release();
         }
     }

-#endif // HAVE_DYNAMIC_CAST
+#endif // RTTI enabled

 
     void AssignCopy(const wxWeakRefImpl& wr)
     {
 
     void AssignCopy(const wxWeakRefImpl& wr)
     {


@@ -211,31 +211,35 @@ public:
     // Default ctor
     wxWeakRef() { }
 
     // Default ctor
     wxWeakRef() { }
 

+    // Enabling this ctor for VC6 results in mysterious compilation failures in
+    // wx/window.h when assigning wxWindow pointers (FIXME-VC6)
+#ifndef __VISUALC6__

     // Ctor from the object of this type: this is needed as the template ctor
     // below is not used by at least g++4 when a literal NULL is used
     wxWeakRef(T *pobj)
     {
     // Ctor from the object of this type: this is needed as the template ctor
     // below is not used by at least g++4 when a literal NULL is used
     wxWeakRef(T *pobj)
     {

-        Assign(pobj);
+        this->Assign(pobj);

     }
     }

+#endif // !__VISUALC6__

 
     // When we have the full type here, static_cast<> will always work
     // (or give a straight compiler error).
     template <class TDerived>
     wxWeakRef(TDerived* pobj)
     {
 
     // When we have the full type here, static_cast<> will always work
     // (or give a straight compiler error).
     template <class TDerived>
     wxWeakRef(TDerived* pobj)
     {

-        Assign(pobj);
+        this->Assign(pobj);

     }
 
     // We need this copy ctor, since otherwise a default compiler (binary) copy
     // happens (if embedded as an object member).
     wxWeakRef(const wxWeakRef<T>& wr)
     {
     }
 
     // We need this copy ctor, since otherwise a default compiler (binary) copy
     // happens (if embedded as an object member).
     wxWeakRef(const wxWeakRef<T>& wr)
     {

-        Assign(wr.get());
+        this->Assign(wr.get());

     }
 
     wxWeakRef<T>& operator=(const wxWeakRef<T>& wr)
     {
     }
 
     wxWeakRef<T>& operator=(const wxWeakRef<T>& wr)
     {

-        AssignCopy(wr);
+        this->AssignCopy(wr);

         return *this;
     }
 
         return *this;
     }
 


@@ -250,7 +254,7 @@ public:
 };
 
 
 };
 
 

-#ifdef HAVE_DYNAMIC_CAST
+#ifndef wxNO_RTTI

 
 // Weak ref implementation assign objects are queried for wxTrackable
 // using dynamic_cast<>
 
 // Weak ref implementation assign objects are queried for wxTrackable
 // using dynamic_cast<>


@@ -334,7 +338,7 @@ protected:
     T *m_pobj;
 };
 
     T *m_pobj;
 };
 

-#endif // #ifdef HAVE_DYNAMIC_CAST
+#endif // RTTI enabled

 
 
 // Provide some basic types of weak references
 
 
 // Provide some basic types of weak references