reducing key event handling complexity

[wxWidgets.git] / src / osx / cocoa / nonownedwnd.mm

diff --git a/src/osx/cocoa/nonownedwnd.mm b/src/osx/cocoa/nonownedwnd.mm
index ac233c8e19cac51c9d10f5e2f102a5e620640e45..6e617f9bfdbb6a81983d20f1a4705700e75f96ff 100644 (file)
--- a/src/osx/cocoa/nonownedwnd.mm
+++ b/src/osx/cocoa/nonownedwnd.mm
@@ -23,18 +23,18 @@ NSRect wxToNSRect( NSView* parent, const wxRect& r )
     int y = r.y;
     int x = r.x ;
     if ( parent == NULL || ![ parent isFlipped ] )
     int y = r.y;
     int x = r.x ;
     if ( parent == NULL || ![ parent isFlipped ] )

-        y = frame.size.height - ( r.y + r.height );
+        y = (int)(frame.size.height - ( r.y + r.height ));

     return NSMakeRect(x, y, r.width , r.height);
 }
 
 wxRect wxFromNSRect( NSView* parent, const NSRect& rect )
 {
     NSRect frame = parent ? [parent bounds] : [[NSScreen mainScreen] frame];
     return NSMakeRect(x, y, r.width , r.height);
 }
 
 wxRect wxFromNSRect( NSView* parent, const NSRect& rect )
 {
     NSRect frame = parent ? [parent bounds] : [[NSScreen mainScreen] frame];

-    int y = rect.origin.y;
-    int x = rect.origin.x;
+    int y = (int)rect.origin.y;
+    int x = (int)rect.origin.x;

     if ( parent == NULL || ![ parent isFlipped ] )
     if ( parent == NULL || ![ parent isFlipped ] )

-        y = frame.size.height - (rect.origin.y + rect.size.height);
-    return wxRect( x, y, rect.size.width, rect.size.height );
+        y = (int)(frame.size.height - (rect.origin.y + rect.size.height));
+    return wxRect( x, y, (int)rect.size.width, (int)rect.size.height );

 }
 
 NSPoint wxToNSPoint( NSView* parent, const wxPoint& p )
 }
 
 NSPoint wxToNSPoint( NSView* parent, const wxPoint& p )


@@ -43,33 +43,54 @@ NSPoint wxToNSPoint( NSView* parent, const wxPoint& p )
     int x = p.x ;
     int y = p.y;
     if ( parent == NULL || ![ parent isFlipped ] )
     int x = p.x ;
     int y = p.y;
     if ( parent == NULL || ![ parent isFlipped ] )

-        y = frame.size.height - ( p.y );
+        y = (int)(frame.size.height - ( p.y ));

     return NSMakePoint(x, y);
 }
 
 wxPoint wxFromNSPoint( NSView* parent, const NSPoint& p )
 {
     NSRect frame = parent ? [parent bounds] : [[NSScreen mainScreen] frame];
     return NSMakePoint(x, y);
 }
 
 wxPoint wxFromNSPoint( NSView* parent, const NSPoint& p )
 {
     NSRect frame = parent ? [parent bounds] : [[NSScreen mainScreen] frame];

-    int x = p.x;
-    int y = p.y;
+    int x = (int)p.x;
+    int y = (int)p.y;

     if ( parent == NULL || ![ parent isFlipped ] )
     if ( parent == NULL || ![ parent isFlipped ] )

-        y = frame.size.height - ( p.y );
+        y = (int)(frame.size.height - ( p.y ));

     return wxPoint( x, y);
 }
 
     return wxPoint( x, y);
 }
 

+bool shouldHandleSelector(SEL selector)
+{
+    if (selector == @selector(noop:)
+            || selector == @selector(complete:)
+            || selector == @selector(deleteBackward:)
+            || selector == @selector(deleteForward:)
+            || selector == @selector(insertNewline:)
+            || selector == @selector(insertTab:)
+            || selector == @selector(keyDown:)
+            || selector == @selector(keyUp:)
+            || selector == @selector(scrollPageUp:)
+            || selector == @selector(scrollPageDown:)
+            || selector == @selector(scrollToBeginningOfDocument:)
+            || selector == @selector(scrollToEndOfDocument:))
+        return false;
+
+    return true;
+
+}
+

 //
 // wx native implementation classes
 //
 
 //
 // wx native implementation classes
 //
 

-@interface wxNSWindow : NSWindow
+typedef void (*wxOSX_NoResponderHandlerPtr)(NSView* self, SEL _cmd, SEL selector);

 
 

+@interface wxNSWindow : NSWindow

 {
     wxNonOwnedWindowCocoaImpl* impl;
 }
 
 - (void)setImplementation: (wxNonOwnedWindowCocoaImpl *) theImplementation;
 - (wxNonOwnedWindowCocoaImpl*) implementation;
 {
     wxNonOwnedWindowCocoaImpl* impl;
 }
 
 - (void)setImplementation: (wxNonOwnedWindowCocoaImpl *) theImplementation;
 - (wxNonOwnedWindowCocoaImpl*) implementation;

-
+- (void)noResponderFor: (SEL) selector;

 @end
 
 @implementation wxNSWindow
 @end
 
 @implementation wxNSWindow


@@ -84,17 +105,71 @@ wxPoint wxFromNSPoint( NSView* parent, const NSPoint& p )
     return impl;
 }
 
     return impl;
 }
 

+- (void)doCommandBySelector:(SEL)selector
+{
+    if (shouldHandleSelector(selector) &&
+        !(selector == @selector(cancel:) || selector == @selector(cancelOperation:)) )
+        [super doCommandBySelector:selector];
+}
+
+
+// NB: if we don't do this, all key downs that get handled lead to a NSBeep
+- (void)noResponderFor: (SEL) selector
+{
+    if (selector != @selector(keyDown:) && selector != @selector(keyUp:))
+    {
+        [super noResponderFor:selector];
+//        wxOSX_NoResponderHandlerPtr superimpl = (wxOSX_NoResponderHandlerPtr) [[self superclass] instanceMethodForSelector:@selector(noResponderFor:)];
+//        superimpl(self, @selector(noResponderFor:), selector);
+    }
+}

 
 @end
 
 
 @end
 

-@interface wxNSPanel : wxNSWindow
+@interface wxNSPanel : NSPanel

 
 {
 
 {

+    wxNonOwnedWindowCocoaImpl* impl;

 }
 
 }
 

+- (void)setImplementation: (wxNonOwnedWindowCocoaImpl *) theImplementation;
+- (wxNonOwnedWindowCocoaImpl*) implementation;
+- (void)noResponderFor: (SEL) selector;

 @end
 
 @end
 

-@implementation wxNSPanel 
+@implementation wxNSPanel
+
+- (void)setImplementation: (wxNonOwnedWindowCocoaImpl *) theImplementation
+{
+    impl = theImplementation;
+}
+
+- (BOOL)canBecomeKeyWindow
+{
+    return YES;
+}
+
+- (wxNonOwnedWindowCocoaImpl*) implementation
+{
+    return impl;
+}
+
+- (void)doCommandBySelector:(SEL)selector
+{
+    if (shouldHandleSelector(selector))
+        [super doCommandBySelector:selector];
+}
+
+// NB: if we don't do this, it seems that all events that end here lead to a NSBeep
+- (void)noResponderFor: (SEL) selector
+{
+    if (selector != @selector(keyDown:) && selector != @selector(keyUp:))
+    {
+        [super noResponderFor:selector];
+//        wxOSX_NoResponderHandlerPtr superimpl = (wxOSX_NoResponderHandlerPtr) [[self superclass] instanceMethodForSelector:@selector(noResponderFor:)];
+//        superimpl(self, @selector(noResponderFor:), selector);
+    }
+}

 
 @end
 
 
 @end
 


@@ -109,8 +184,8 @@ wxPoint wxFromNSPoint( NSView* parent, const NSPoint& p )
 
 - (void)windowDidResize:(NSNotification *)notification;
 - (NSSize)windowWillResize:(NSWindow *)window toSize:(NSSize)proposedFrameSize;
 
 - (void)windowDidResize:(NSNotification *)notification;
 - (NSSize)windowWillResize:(NSWindow *)window toSize:(NSSize)proposedFrameSize;

-- (void)windowDidResignMain:(NSNotification *)notification;
-- (void)windowDidBecomeMain:(NSNotification *)notification;
+- (void)windowDidResignKey:(NSNotification *)notification;
+- (void)windowDidBecomeKey:(NSNotification *)notification;

 - (void)windowDidMove:(NSNotification *)notification;
 - (BOOL)windowShouldClose:(id)window;
 
 - (void)windowDidMove:(NSNotification *)notification;
 - (BOOL)windowShouldClose:(id)window;
 


@@ -142,8 +217,8 @@ wxPoint wxFromNSPoint( NSView* parent, const NSPoint& p )
 {
     NSRect frame = [win frame];
     wxRect wxframe = wxFromNSRect( NULL, frame );
 {
     NSRect frame = [win frame];
     wxRect wxframe = wxFromNSRect( NULL, frame );

-    wxframe.SetWidth( proposedFrameSize.width );
-    wxframe.SetHeight( proposedFrameSize.height );
+    wxframe.SetWidth( (int)proposedFrameSize.width );
+    wxframe.SetHeight( (int)proposedFrameSize.height );

     wxNSWindow* window = (wxNSWindow*) win;
     wxNonOwnedWindowCocoaImpl* windowimpl = [window implementation];
     if ( windowimpl )
     wxNSWindow* window = (wxNSWindow*) win;
     wxNonOwnedWindowCocoaImpl* windowimpl = [window implementation];
     if ( windowimpl )


@@ -184,7 +259,7 @@ wxPoint wxFromNSPoint( NSView* parent, const NSPoint& p )
     }
 }
 
     }
 }
 

-- (void)windowDidBecomeMain:(NSNotification *)notification
+- (void)windowDidBecomeKey:(NSNotification *)notification

 {
     wxNSWindow* window = (wxNSWindow*) [notification object];
     wxNonOwnedWindowCocoaImpl* windowimpl = [window implementation];
 {
     wxNSWindow* window = (wxNSWindow*) [notification object];
     wxNonOwnedWindowCocoaImpl* windowimpl = [window implementation];


@@ -196,7 +271,7 @@ wxPoint wxFromNSPoint( NSView* parent, const NSPoint& p )
     }
 }
 
     }
 }
 

-- (void)windowDidResignMain:(NSNotification *)notification
+- (void)windowDidResignKey:(NSNotification *)notification

 {
     wxNSWindow* window = (wxNSWindow*) [notification object];
     wxNonOwnedWindowCocoaImpl* windowimpl = [window implementation];
 {
     wxNSWindow* window = (wxNSWindow*) [notification object];
     wxNonOwnedWindowCocoaImpl* windowimpl = [window implementation];


@@ -204,29 +279,58 @@ wxPoint wxFromNSPoint( NSView* parent, const NSPoint& p )
     {
         wxNonOwnedWindow* wxpeer = windowimpl->GetWXPeer();
         if ( wxpeer )
     {
         wxNonOwnedWindow* wxpeer = windowimpl->GetWXPeer();
         if ( wxpeer )

+        {

             wxpeer->HandleActivated(0, false);
             wxpeer->HandleActivated(0, false);

+            // Needed for popup window since the firstResponder
+            // (focus in wx) doesn't change when this
+            // TLW becomes inactive.
+            wxFocusEvent event( wxEVT_KILL_FOCUS, wxpeer->GetId());
+            event.SetEventObject(wxpeer);
+            wxpeer->HandleWindowEvent(event);
+        }

     }
 }
 
     }
 }
 

+- (id)windowWillReturnFieldEditor:(NSWindow *)sender toObject:(id)anObject
+{
+    wxUnusedVar(sender);
+
+    if ([anObject isKindOfClass:[wxNSTextField class]])
+    {
+        wxNSTextField* tf = (wxNSTextField*) anObject;
+        wxNSTextFieldEditor* editor = [tf fieldEditor];
+        if ( editor == nil )
+        {
+            editor = [[wxNSTextFieldEditor alloc] init];
+            [editor setFieldEditor:YES];
+            [tf setFieldEditor:editor];
+        }
+        return editor;
+    }
+
+    return nil;
+}
+

 @end
 
 IMPLEMENT_DYNAMIC_CLASS( wxNonOwnedWindowCocoaImpl , wxNonOwnedWindowImpl )
 
 @end
 
 IMPLEMENT_DYNAMIC_CLASS( wxNonOwnedWindowCocoaImpl , wxNonOwnedWindowImpl )
 

-wxNonOwnedWindowCocoaImpl::wxNonOwnedWindowCocoaImpl( wxNonOwnedWindow* nonownedwnd) : 
+wxNonOwnedWindowCocoaImpl::wxNonOwnedWindowCocoaImpl( wxNonOwnedWindow* nonownedwnd) :

     wxNonOwnedWindowImpl(nonownedwnd)
 {
     m_macWindow = NULL;
     m_macFullScreenData = NULL;
 }
     wxNonOwnedWindowImpl(nonownedwnd)
 {
     m_macWindow = NULL;
     m_macFullScreenData = NULL;
 }

-    
-wxNonOwnedWindowCocoaImpl::wxNonOwnedWindowCocoaImpl() 
+
+wxNonOwnedWindowCocoaImpl::wxNonOwnedWindowCocoaImpl()

 {
     m_macWindow = NULL;
     m_macFullScreenData = NULL;
 }
 {
     m_macWindow = NULL;
     m_macFullScreenData = NULL;
 }

-    
+

 wxNonOwnedWindowCocoaImpl::~wxNonOwnedWindowCocoaImpl()
 {
 wxNonOwnedWindowCocoaImpl::~wxNonOwnedWindowCocoaImpl()
 {

+    [m_macWindow setImplementation:nil];

     [m_macWindow setDelegate:nil];
     [m_macWindow release];
 }
     [m_macWindow setDelegate:nil];
     [m_macWindow release];
 }


@@ -236,31 +340,35 @@ void wxNonOwnedWindowCocoaImpl::Destroy()
     wxPendingDelete.Append( new wxDeferredObjectDeleter( this ) );
 }
 
     wxPendingDelete.Append( new wxDeferredObjectDeleter( this ) );
 }
 

-void wxNonOwnedWindowCocoaImpl::Create( wxWindow* parent, const wxPoint& pos, const wxSize& size,
-long style, long extraStyle, const wxString& name )
+void wxNonOwnedWindowCocoaImpl::Create( wxWindow* WXUNUSED(parent), const wxPoint& pos, const wxSize& size,
+long style, long extraStyle, const wxString& WXUNUSED(name) )

 {
     static wxNonOwnedWindowController* controller = NULL;
 {
     static wxNonOwnedWindowController* controller = NULL;

-    
+

     if ( !controller )
         controller =[[wxNonOwnedWindowController alloc] init];
 
 
     int windowstyle = NSBorderlessWindowMask;
     if ( !controller )
         controller =[[wxNonOwnedWindowController alloc] init];
 
 
     int windowstyle = NSBorderlessWindowMask;

-    
-    if ( style & wxFRAME_TOOL_WINDOW )
+
+    if ( style & wxFRAME_TOOL_WINDOW || ( style & wxPOPUP_WINDOW ) ||
+            GetWXPeer()->GetExtraStyle() & wxTOPLEVEL_EX_DIALOG )
+    {

         m_macWindow = [wxNSPanel alloc];
         m_macWindow = [wxNSPanel alloc];

+    }

     else
         m_macWindow = [wxNSWindow alloc];
     else
         m_macWindow = [wxNSWindow alloc];

-    
+

     CGWindowLevel level = kCGNormalWindowLevel;
     CGWindowLevel level = kCGNormalWindowLevel;

-    
+

     if ( style & wxFRAME_TOOL_WINDOW )
     {
     if ( style & wxFRAME_TOOL_WINDOW )
     {

-        if ( ( style & wxSTAY_ON_TOP ) )
-            level = kCGUtilityWindowLevel;
-        else
-            level = kCGFloatingWindowLevel ;
-        
+        windowstyle |= NSUtilityWindowMask;
+        if ( ( style & wxMINIMIZE_BOX ) || ( style & wxMAXIMIZE_BOX ) ||
+            ( style & wxCLOSE_BOX ) || ( style & wxSYSTEM_MENU ) )
+        {
+            windowstyle |= NSTitledWindowMask ;
+        }

     }
     else if ( ( style & wxPOPUP_WINDOW ) )
     {
     }
     else if ( ( style & wxPOPUP_WINDOW ) )
     {


@@ -324,28 +432,27 @@ long style, long extraStyle, const wxString& name )
     if ( extraStyle & wxFRAME_EX_METAL)
         windowstyle |= NSTexturedBackgroundWindowMask;
 
     if ( extraStyle & wxFRAME_EX_METAL)
         windowstyle |= NSTexturedBackgroundWindowMask;
 

+    if ( ( style & wxFRAME_FLOAT_ON_PARENT ) || ( style & wxFRAME_TOOL_WINDOW ) )
+        level = kCGFloatingWindowLevel;
+

     if ( ( style & wxSTAY_ON_TOP ) )
         level = kCGUtilityWindowLevel;
     if ( ( style & wxSTAY_ON_TOP ) )
         level = kCGUtilityWindowLevel;

-/*
-    if ( ( style & wxFRAME_FLOAT_ON_PARENT ) )
-        group = GetWindowGroupOfClass(kFloatingWindowClass);
-        */
-    
+

     NSRect r = wxToNSRect( NULL, wxRect( pos, size) );
     NSRect r = wxToNSRect( NULL, wxRect( pos, size) );

-    
+

     [m_macWindow setImplementation:this];
     [m_macWindow setImplementation:this];

-    
+

     [m_macWindow initWithContentRect:r
         styleMask:windowstyle
         backing:NSBackingStoreBuffered
     [m_macWindow initWithContentRect:r
         styleMask:windowstyle
         backing:NSBackingStoreBuffered

-        defer:NO 
+        defer:NO

         ];
         ];

-        
+

     [m_macWindow setLevel:level];
 
     [m_macWindow setDelegate:controller];
     [m_macWindow setLevel:level];
 
     [m_macWindow setDelegate:controller];

-    
-    // [m_macWindow makeKeyAndOrderFront:nil];
+
+    [m_macWindow setAcceptsMouseMovedEvents: YES];

 }
 
 
 }
 
 


@@ -358,7 +465,7 @@ void wxNonOwnedWindowCocoaImpl::Raise()
 {
     [m_macWindow orderWindow:NSWindowAbove relativeTo:0];
 }
 {
     [m_macWindow orderWindow:NSWindowAbove relativeTo:0];
 }

-    
+

 void wxNonOwnedWindowCocoaImpl::Lower()
 {
     [m_macWindow orderWindow:NSWindowBelow relativeTo:0];
 void wxNonOwnedWindowCocoaImpl::Lower()
 {
     [m_macWindow orderWindow:NSWindowBelow relativeTo:0];


@@ -368,15 +475,20 @@ bool wxNonOwnedWindowCocoaImpl::Show(bool show)
 {
     if ( show )
     {
 {
     if ( show )
     {

-        [m_macWindow orderFront:nil];
+        wxNonOwnedWindow* wxpeer = GetWXPeer(); 
+        if (wxpeer && !(wxpeer->GetWindowStyle() & wxFRAME_TOOL_WINDOW)) 
+            [m_macWindow makeKeyAndOrderFront:nil]; 
+        else 
+            [m_macWindow orderFront:nil]; 
+

         [[m_macWindow contentView] setNeedsDisplay:YES];
     }
         [[m_macWindow contentView] setNeedsDisplay:YES];
     }

-    else 
+    else

         [m_macWindow orderOut:nil];
     return true;
 }
         [m_macWindow orderOut:nil];
     return true;
 }

-    
-bool wxNonOwnedWindowCocoaImpl::ShowWithEffect(bool show, wxShowEffect effect, unsigned timeout)
+
+bool wxNonOwnedWindowCocoaImpl::ShowWithEffect(bool show, wxShowEffect WXUNUSED(effect), unsigned WXUNUSED(timeout))

 {
     return Show(show);
 }
 {
     return Show(show);
 }


@@ -392,7 +504,7 @@ bool wxNonOwnedWindowCocoaImpl::SetTransparent(wxByte alpha)
     return true;
 }
 
     return true;
 }
 

-bool wxNonOwnedWindowCocoaImpl::SetBackgroundColour(const wxColour& col )
+bool wxNonOwnedWindowCocoaImpl::SetBackgroundColour(const wxColour& WXUNUSED(col) )

 {
     return true;
 }
 {
     return true;
 }


@@ -405,20 +517,20 @@ void wxNonOwnedWindowCocoaImpl::SetExtraStyle( long exStyle )
         int windowStyle = [ m_macWindow styleMask];
         if ( metal && !(windowStyle & NSTexturedBackgroundWindowMask) )
         {
         int windowStyle = [ m_macWindow styleMask];
         if ( metal && !(windowStyle & NSTexturedBackgroundWindowMask) )
         {

-            wxFAIL_MSG( _T("Metal Style cannot be changed after creation") );
+            wxFAIL_MSG( wxT("Metal Style cannot be changed after creation") );

         }
         else if ( !metal && (windowStyle & NSTexturedBackgroundWindowMask ) )
         {
         }
         else if ( !metal && (windowStyle & NSTexturedBackgroundWindowMask ) )
         {

-            wxFAIL_MSG( _T("Metal Style cannot be changed after creation") );
-        }        
+            wxFAIL_MSG( wxT("Metal Style cannot be changed after creation") );
+        }

     }
 }
     }
 }

-    
-bool wxNonOwnedWindowCocoaImpl::SetBackgroundStyle(wxBackgroundStyle style)
+
+bool wxNonOwnedWindowCocoaImpl::SetBackgroundStyle(wxBackgroundStyle WXUNUSED(style))

 {
     return true;
 }
 {
     return true;
 }

-    
+

 bool wxNonOwnedWindowCocoaImpl::CanSetTransparent()
 {
     return true;
 bool wxNonOwnedWindowCocoaImpl::CanSetTransparent()
 {
     return true;


@@ -441,39 +553,41 @@ void wxNonOwnedWindowCocoaImpl::GetPosition( int &x, int &y ) const
 void wxNonOwnedWindowCocoaImpl::GetSize( int &width, int &height ) const
 {
     NSRect rect = [m_macWindow frame];
 void wxNonOwnedWindowCocoaImpl::GetSize( int &width, int &height ) const
 {
     NSRect rect = [m_macWindow frame];

-    width = rect.size.width;
-    height = rect.size.height;
+    width = (int)rect.size.width;
+    height = (int)rect.size.height;

 }
 
 }
 

-void wxNonOwnedWindowCocoaImpl::GetContentArea( int& left, int &right, int &width, int &height ) const
+void wxNonOwnedWindowCocoaImpl::GetContentArea( int& left, int &top, int &width, int &height ) const

 {
     NSRect outer = NSMakeRect(100,100,100,100);
     NSRect content = [NSWindow contentRectForFrameRect:outer styleMask:[m_macWindow styleMask] ];
     NSRect rect = [[m_macWindow contentView] frame];
 {
     NSRect outer = NSMakeRect(100,100,100,100);
     NSRect content = [NSWindow contentRectForFrameRect:outer styleMask:[m_macWindow styleMask] ];
     NSRect rect = [[m_macWindow contentView] frame];

-    width = rect.size.width;
-    height = rect.size.height;
+    left = (int)rect.origin.x;
+    top = (int)rect.origin.y;
+    width = (int)rect.size.width;
+    height = (int)rect.size.height;

 }
 }

-    
-bool wxNonOwnedWindowCocoaImpl::SetShape(const wxRegion& region)
+
+bool wxNonOwnedWindowCocoaImpl::SetShape(const wxRegion& WXUNUSED(region))

 {
     return false;
 }
 
 {
     return false;
 }
 

-void wxNonOwnedWindowCocoaImpl::SetTitle( const wxString& title, wxFontEncoding encoding ) 
+void wxNonOwnedWindowCocoaImpl::SetTitle( const wxString& title, wxFontEncoding encoding )

 {
     [m_macWindow setTitle:wxCFStringRef( title , encoding ).AsNSString()];
 }
 {
     [m_macWindow setTitle:wxCFStringRef( title , encoding ).AsNSString()];
 }

-    
+

 bool wxNonOwnedWindowCocoaImpl::IsMaximized() const
 {
     return [m_macWindow isZoomed];
 }
 bool wxNonOwnedWindowCocoaImpl::IsMaximized() const
 {
     return [m_macWindow isZoomed];
 }

-    
+

 bool wxNonOwnedWindowCocoaImpl::IsIconized() const
 {
     return [m_macWindow isMiniaturized];
 }
 bool wxNonOwnedWindowCocoaImpl::IsIconized() const
 {
     return [m_macWindow isMiniaturized];
 }

-    
+

 void wxNonOwnedWindowCocoaImpl::Iconize( bool iconize )
 {
     if ( iconize )
 void wxNonOwnedWindowCocoaImpl::Iconize( bool iconize )
 {
     if ( iconize )


@@ -481,12 +595,12 @@ void wxNonOwnedWindowCocoaImpl::Iconize( bool iconize )
     else
         [m_macWindow deminiaturize:nil];
 }
     else
         [m_macWindow deminiaturize:nil];
 }

-    
-void wxNonOwnedWindowCocoaImpl::Maximize(bool maximize)
+
+void wxNonOwnedWindowCocoaImpl::Maximize(bool WXUNUSED(maximize))

 {
     [m_macWindow zoom:nil];
 }
 {
     [m_macWindow zoom:nil];
 }

-    
+

 
 // http://cocoadevcentral.com/articles/000028.php
 
 
 // http://cocoadevcentral.com/articles/000028.php
 


@@ -500,8 +614,8 @@ bool wxNonOwnedWindowCocoaImpl::IsFullScreen() const
 {
     return m_macFullScreenData != NULL ;
 }
 {
     return m_macFullScreenData != NULL ;
 }

-    
-bool wxNonOwnedWindowCocoaImpl::ShowFullScreen(bool show, long style)
+
+bool wxNonOwnedWindowCocoaImpl::ShowFullScreen(bool show, long WXUNUSED(style))

 {
     if ( show )
     {
 {
     if ( show )
     {


@@ -525,7 +639,7 @@ bool wxNonOwnedWindowCocoaImpl::ShowFullScreen(bool show, long style)
         delete data ;
         m_macFullScreenData = NULL ;
     }
         delete data ;
         m_macFullScreenData = NULL ;
     }

-    
+

     return true;
 }
 
     return true;
 }
 


@@ -541,7 +655,7 @@ void wxNonOwnedWindowCocoaImpl::ScreenToWindow( int *x, int *y )
     nspt = [[m_macWindow contentView] convertPoint:nspt fromView:nil];
     p = wxFromNSPoint([m_macWindow contentView], nspt);
     if ( x )
     nspt = [[m_macWindow contentView] convertPoint:nspt fromView:nil];
     p = wxFromNSPoint([m_macWindow contentView], nspt);
     if ( x )

-        *x = p.x; 
+        *x = p.x;

     if ( y )
         *y = p.y;
 }
     if ( y )
         *y = p.y;
 }