[attempt to] fix a warning

[wxWidgets.git] / samples / ipc / server.cpp

diff --git a/samples/ipc/server.cpp b/samples/ipc/server.cpp
index 46909bfed1f8b511b7d05b989c40bc57cecb6aa5..5d9b0cf1aa1fa7cc93ba01ad4ce20c724204a5a9 100644 (file)
--- a/samples/ipc/server.cpp
+++ b/samples/ipc/server.cpp
@@ -32,7 +32,7 @@
 // we're using TCP/IP or real DDE.
 #include "ddesetup.h"
 
-#if defined(__WXGTK__) || defined(__WXMOTIF__) || defined(__WXMAC__)
+#if defined(__WXGTK__) || defined(__WXX11__) || defined(__WXMOTIF__) || defined(__WXMAC__)
     #include "mondrian.xpm"
 #endif
 
@@ -57,7 +57,6 @@ END_EVENT_TABLE()
 // global variables
 // ----------------------------------------------------------------------------
 
-char ipc_buffer[4000];
 MyConnection *the_connection = NULL;
 
 // ============================================================================
@@ -71,10 +70,10 @@ MyConnection *the_connection = NULL;
 bool MyApp::OnInit()
 {
     // Create the main frame window
-    (new MyFrame(NULL, "Server"))->Show(TRUE);
+    (new MyFrame(NULL, _T("Server")))->Show(TRUE);
 
     // service name (DDE classes) or port number (TCP/IP based classes)
-    wxString service = "4242";
+    wxString service = IPC_SERVICE;
 
     if (argc > 1)
         service = argv[1];
@@ -99,10 +98,8 @@ int MyApp::OnExit()
 
 // Define my frame constructor
 MyFrame::MyFrame(wxFrame *frame, const wxString& title)
-       : wxFrame(frame, -1, title)
+       : wxFrame(frame, -1, title, wxDefaultPosition, wxSize(350, 250))
 {
-    panel = NULL;
-
     CreateStatusBar();
 
     // Give it an icon
@@ -111,38 +108,37 @@ MyFrame::MyFrame(wxFrame *frame, const wxString& title)
     // Make a menubar
     wxMenu *file_menu = new wxMenu;
 
-    file_menu->Append(SERVER_EXIT, "&Exit");
+    file_menu->Append(SERVER_EXIT, _T("&Quit\tCtrl-Q"));
 
     wxMenuBar *menu_bar = new wxMenuBar;
 
-    menu_bar->Append(file_menu, "&File");
+    menu_bar->Append(file_menu, _T("&File"));
 
     // Associate the menu bar with the frame
     SetMenuBar(menu_bar);
 
-    // Make a panel
-    panel = new wxPanel(this);
-    wxListBox *list = new wxListBox(panel, SERVER_LISTBOX, wxPoint(5, 5));
-    list->Append("Apple");
-    list->Append("Pear");
-    list->Append("Orange");
-    list->Append("Banana");
-    list->Append("Fruit");
-
-    panel->Fit();
-    Fit();
+    // Make a listbox
+    wxListBox *list = new wxListBox(this, SERVER_LISTBOX, wxPoint(5, 5));
+    list->Append(_T("Apple"));
+    list->Append(_T("Pear"));
+    list->Append(_T("Orange"));
+    list->Append(_T("Banana"));
+    list->Append(_T("Fruit"));
 }
 
 // Set the client process's listbox to this item
 void MyFrame::OnListBoxClick(wxCommandEvent& WXUNUSED(event))
 {
-    wxListBox* listBox = (wxListBox*) panel->FindWindow(SERVER_LISTBOX);
+    wxListBox* listBox = (wxListBox*) FindWindow(SERVER_LISTBOX);
     if (listBox)
     {
         wxString value = listBox->GetStringSelection();
+
+        /* Because the_connection only holds one connection, in this sample only
+           one connection can receive advise messages */
         if (the_connection)
         {
-            the_connection->Advise("Item", (wxChar *)value.c_str());
+            the_connection->Advise(IPC_ADVISE_NAME, (wxChar*)value.c_str());
         }
     }
 }
@@ -162,11 +158,19 @@ IPCDialogBox::IPCDialogBox(wxWindow *parent, const wxString& title,
             : wxDialog(parent, -1, title, pos, size)
 {
     m_connection = connection;
-    (void)new wxButton(this, SERVER_QUIT_BUTTON, "Quit this connection",
+    (void)new wxButton(this, SERVER_QUIT_BUTTON, _T("Quit this connection"),
                        wxPoint(5, 5));
     Fit();
 }
 
+IPCDialogBox::~IPCDialogBox( )
+{
+    // wxWindows exit code destroys dialog before destroying the connection in
+    // OnExit, so make sure connection won't try to delete the dialog later.
+    if (m_connection)
+        m_connection->dialog = NULL;
+}
+
 void IPCDialogBox::OnQuit(wxCommandEvent& event)
 {
     m_connection->Disconnect();
@@ -179,20 +183,21 @@ void IPCDialogBox::OnQuit(wxCommandEvent& event)
 
 wxConnectionBase *MyServer::OnAcceptConnection(const wxString& topic)
 {
-    if (strcmp(topic, "STDIO") != 0 && strcmp(topic, "IPC TEST") == 0)
-        return new MyConnection(ipc_buffer, WXSIZEOF(ipc_buffer));
-    else
-        return NULL;
+    if ( topic == IPC_TOPIC )
+        return new MyConnection();
+
+    // unknown topic
+    return NULL;
 }
 
 // ----------------------------------------------------------------------------
 // MyConnection
 // ----------------------------------------------------------------------------
 
-MyConnection::MyConnection(char *buf, int size)
-            : wxConnection(buf, size)
+MyConnection::MyConnection()
+            : wxConnection()
 {
-    dialog = new IPCDialogBox(wxTheApp->GetTopWindow(), "Connection",
+    dialog = new IPCDialogBox(wxTheApp->GetTopWindow(), _T("Connection"),
                               wxPoint(100, 100), wxSize(500, 500), this);
     dialog->Show(TRUE);
     the_connection = this;
@@ -202,36 +207,40 @@ MyConnection::~MyConnection()
 {
     if (the_connection)
     {
-        dialog->Destroy();
+        if (dialog)
+        {
+            dialog->m_connection = NULL;
+            dialog->Destroy();
+        }
         the_connection = NULL;
     }
 }
 
 bool MyConnection::OnExecute(const wxString& WXUNUSED(topic),
-                             char *data,
+                             wxChar *data,
                              int WXUNUSED(size),
                              wxIPCFormat WXUNUSED(format))
 {
-    wxLogStatus("Execute command: %s", data);
+    wxLogStatus(wxT("Execute command: %s"), data);
     return TRUE;
 }
 
 bool MyConnection::OnPoke(const wxString& WXUNUSED(topic),
                           const wxString& item,
-                          char *data,
+                          wxChar *data,
                           int WXUNUSED(size),
                           wxIPCFormat WXUNUSED(format))
 {
-    wxLogStatus("Poke command: %s = %s", item.c_str(), data);
+    wxLogStatus(wxT("Poke command: %s = %s"), item.c_str(), data);
     return TRUE;
 }
 
-char *MyConnection::OnRequest(const wxString& WXUNUSED(topic),
+wxChar *MyConnection::OnRequest(const wxString& WXUNUSED(topic),
                               const wxString& WXUNUSED(item),
                               int * WXUNUSED(size),
                               wxIPCFormat WXUNUSED(format))
 {
-    return "Here, have your data, client!";
+    return _T("Here, have your data, client!");
 }
 
 bool MyConnection::OnStartAdvise(const wxString& WXUNUSED(topic),