fixed handling of the accelerators of menu items added to already attached submenus

[wxWidgets.git] / src / html / htmltag.cpp

diff --git a/src/html/htmltag.cpp b/src/html/htmltag.cpp
index 1b9b7bd784006de5e7bc9337c34b547afdd5af39..f5e93ffa033914e5fe09e94cf0d7f6f554d29b3f 100644 (file)
--- a/src/html/htmltag.cpp
+++ b/src/html/htmltag.cpp
@@ -114,9 +114,14 @@ wxHtmlTagsCache::wxHtmlTagsCache(const wxString& source)
             else
             {
                 m_Cache[tg].End1 = m_Cache[tg].End2 = -1;
             else
             {
                 m_Cache[tg].End1 = m_Cache[tg].End2 = -1;

-
+                

                 if (wxIsCDATAElement(tagBuffer))
                 {
                 if (wxIsCDATAElement(tagBuffer))
                 {

+                    // store the orig pos in case we are missing the closing
+                    // tag (see below)
+                    wxInt32 old_pos = pos; 
+                    bool foundCloseTag = false;
+                    

                     // find next matching tag
                     int tag_len = wxStrlen(tagBuffer);
                     while (pos < lng)
                     // find next matching tag
                     int tag_len = wxStrlen(tagBuffer);
                     while (pos < lng)


@@ -147,14 +152,25 @@ wxHtmlTagsCache::wxHtmlTagsCache(const wxString& source)
                         }
 
                         // found a match
                         }
 
                         // found a match

-                        if (match_pos == tag_len) {
+                        if (match_pos == tag_len) 
+                        {

                             pos = pos - tag_len - 3;
                             pos = pos - tag_len - 3;

+                            foundCloseTag = true;

                             break;
                         }
                             break;
                         }

-                        else {
+                        else // keep looking for the closing tag
+                        {

                             ++pos;
                         }
                     }
                             ++pos;
                         }
                     }

+                    if (!foundCloseTag)
+                    {
+                        // we didn't find closing tag; this means the markup
+                        // is incorrect and the best thing we can do is to
+                        // ignore the unclosed tag and continue parsing as if
+                        // it didn't exist:
+                        pos = old_pos;
+                    }

                 }
             }
         }
                 }
             }
         }


@@ -392,7 +408,7 @@ bool wxHtmlTag::GetParamAsColour(const wxString& par, wxColour *clr) const
 {
     wxString str = GetParam(par);
 
 {
     wxString str = GetParam(par);
 

-    if (str.IsEmpty()) return false;
+    if (str.empty()) return false;

     if (str.GetChar(0) == wxT('#'))
     {
         unsigned long tmp;
     if (str.GetChar(0) == wxT('#'))
     {
         unsigned long tmp;


@@ -442,7 +458,7 @@ bool wxHtmlTag::GetParamAsInt(const wxString& par, int *clr) const
 
 wxString wxHtmlTag::GetAllParams() const
 {
 
 wxString wxHtmlTag::GetAllParams() const
 {

-    // VS: this function is for backward compatiblity only,
+    // VS: this function is for backward compatibility only,

     //     never used by wxHTML
     wxString s;
     size_t cnt = m_ParamNames.GetCount();
     //     never used by wxHTML
     wxString s;
     size_t cnt = m_ParamNames.GetCount();


@@ -495,4 +511,13 @@ wxHtmlTag *wxHtmlTag::GetNextTag() const
     return cur->m_Next;
 }
 
     return cur->m_Next;
 }
 

+#if WXWIN_COMPATIBILITY_2_2
+
+bool wxHtmlTag::IsEnding() const
+{
+    return false;
+}
+
+#endif // WXWIN_COMPATIBILITY_2_2
+

 #endif
 #endif