fix for assert when setting tooltip for a readonly combo

[wxWidgets.git] / src / os2 / window.cpp

diff --git a/src/os2/window.cpp b/src/os2/window.cpp
index 6073949ccb570fde65976aab780e999975beeb31..76ab3ba44081eb04b069c73614fcaef591b6681b 100644 (file)
--- a/src/os2/window.cpp
+++ b/src/os2/window.cpp
@@ -306,8 +306,11 @@ wxWindow::~wxWindow()
     if (m_parent)
         m_parent->RemoveChild(this);
     DestroyChildren();
     if (m_parent)
         m_parent->RemoveChild(this);
     DestroyChildren();

+

     if (m_hWnd)
     {
     if (m_hWnd)
     {

+//      UnsubclassWin();
+

         if(!::WinDestroyWindow(GetHWND()))
             wxLogLastError(wxT("DestroyWindow"));
         //
         if(!::WinDestroyWindow(GetHWND()))
             wxLogLastError(wxT("DestroyWindow"));
         //


@@ -382,6 +385,7 @@ bool wxWindow::Create(
               ,NULLHANDLE
               ,m_windowId
              );
               ,NULLHANDLE
               ,m_windowId
              );

+

     return(TRUE);
 } // end of wxWindow::Create
 
     return(TRUE);
 } // end of wxWindow::Create
 


@@ -714,28 +718,28 @@ void wxWindow::SubclassWin(
 
     wxCHECK_RET(::WinIsWindow(vHabmain, hwnd), wxT("invalid HWND in SubclassWin") );
 
 
     wxCHECK_RET(::WinIsWindow(vHabmain, hwnd), wxT("invalid HWND in SubclassWin") );
 

-    wxAssociateWinWithHandle(hwnd, this);
+//  wxAssociateWinWithHandle(hwnd, this);

 
     m_fnOldWndProc = (WXFARPROC) ::WinSubclassWindow(hwnd, (PFNWP)wxWndProc);
 
     m_fnOldWndProc = (WXFARPROC) ::WinSubclassWindow(hwnd, (PFNWP)wxWndProc);

-    ::WinSetWindowULong(hwnd, QWS_USER, (ULONG)wxWndProc);
+//    ::WinSetWindowULong(hwnd, QWL_USER, (ULONG)wxWndProc);

 } // end of wxWindow::SubclassWin
 
 void wxWindow::UnsubclassWin()
 {
 } // end of wxWindow::SubclassWin
 
 void wxWindow::UnsubclassWin()
 {

-    wxRemoveHandleAssociation(this);
+//    wxRemoveHandleAssociation(this);

 
     //
     // Restore old Window proc
     //
 
     //
     // Restore old Window proc
     //

-    HWND                            hwnd = GetHwnd();
+    HWND                            hwnd = GetHWND();

 
 

-    if (hwnd)
+    if (m_hWnd)

     {
     {

-        m_hWnd = 0;
+//        m_hWnd = 0;

 
         wxCHECK_RET( ::WinIsWindow(vHabmain, hwnd), wxT("invalid HWND in UnsubclassWin") );
 
 
         wxCHECK_RET( ::WinIsWindow(vHabmain, hwnd), wxT("invalid HWND in UnsubclassWin") );
 

-        PFNWP                       fnProc = (PFNWP)::WinQueryWindowULong(hwnd, QWS_USER);
+        PFNWP                       fnProc = (PFNWP)::WinQueryWindowPtr(hwnd, QWP_PFNWP);

         if ( (m_fnOldWndProc != 0) && (fnProc != (PFNWP) m_fnOldWndProc))
         {
             WinSubclassWindow(hwnd, (PFNWP)m_fnOldWndProc);
         if ( (m_fnOldWndProc != 0) && (fnProc != (PFNWP) m_fnOldWndProc))
         {
             WinSubclassWindow(hwnd, (PFNWP)m_fnOldWndProc);


@@ -1502,9 +1506,9 @@ MRESULT wxWindow::OS2DefWindowProc(
 )
 {
     if (m_fnOldWndProc)
 )
 {
     if (m_fnOldWndProc)

-        return ((MRESULT)m_fnOldWndProc());
+        return (MRESULT)m_fnOldWndProc(GetHWND(), (ULONG)uMsg, (MPARAM)wParam, (MPARAM)lParam);

     else
     else

-        return (::WinDefWindowProc(GetHwnd(), (ULONG)uMsg, (MPARAM)wParam, (MPARAM)lParam));
+        return ::WinDefWindowProc(GetHWND(), (ULONG)uMsg, (MPARAM)wParam, (MPARAM)lParam);

 } // end of wxWindow::OS2DefWindowProc
 
 bool wxWindow::OS2ProcessMessage(
 } // end of wxWindow::OS2DefWindowProc
 
 bool wxWindow::OS2ProcessMessage(


@@ -1699,7 +1703,7 @@ bool wxWindow::OS2TranslateMessage(
   WXMSG*                            pMsg
 )
 {
   WXMSG*                            pMsg
 )
 {

-    return m_acceleratorTable.Translate(this, pMsg);
+    return m_acceleratorTable.Translate(m_hWnd, pMsg);

 } // end of wxWindow::OS2TranslateMessage
 
 // ---------------------------------------------------------------------------
 } // end of wxWindow::OS2TranslateMessage
 
 // ---------------------------------------------------------------------------


@@ -1714,9 +1718,14 @@ void wxWindow::UnpackCommand(
 , WORD*                             pCmd
 )
 {
 , WORD*                             pCmd
 )
 {

+/*

     *pId = LOWORD(wParam);
     *phWnd = (WXHWND)lParam;
     *pCmd = HIWORD(wParam);
     *pId = LOWORD(wParam);
     *phWnd = (WXHWND)lParam;
     *pCmd = HIWORD(wParam);

+*/
+    *pId = LOWORD(wParam);
+    *phWnd = NULL;  // or may be GetHWND() ?
+    *pCmd = LOWORD(lParam);

 } // end of wxWindow::UnpackCommand
 
 void wxWindow::UnpackActivate(
 } // end of wxWindow::UnpackCommand
 
 void wxWindow::UnpackActivate(


@@ -1798,7 +1807,8 @@ MRESULT EXPENTRY wxWndProc(
         pWnd->SetHWND((WXHWND)hWnd);
     }
 
         pWnd->SetHWND((WXHWND)hWnd);
     }
 

-    MRESULT                         rc;
+    MRESULT                         rc = (MRESULT)0;
+

 
     //
     // Stop right here if we don't have a valid handle in our wxWindow object.
 
     //
     // Stop right here if we don't have a valid handle in our wxWindow object.


@@ -1816,6 +1826,7 @@ MRESULT EXPENTRY wxWndProc(
         else
             rc = ::WinDefWindowProc(hWnd, ulMsg, wParam, lParam);
     }
         else
             rc = ::WinDefWindowProc(hWnd, ulMsg, wParam, lParam);
     }

+

     return rc;
 } // end of wxWndProc
 
     return rc;
 } // end of wxWndProc
 


@@ -1833,22 +1844,26 @@ MRESULT wxWindow::OS2WindowProc(
     // Did we process the uMsg?
     //
     bool                            bProcessed = FALSE;
     // Did we process the uMsg?
     //
     bool                            bProcessed = FALSE;

+    bool                            bAllow;
+    MRESULT                         mResult;
+    WXHICON                         hIcon;
+    WXHBRUSH                        hBrush;

 
     //
     // The return value
     //
 
     //
     // The return value
     //

-    union
-    {
-        bool                        bAllow;
-        MRESULT                     mResult;
-        WXHICON                     hIcon;
-        WXHBRUSH                    hBrush;
-    } vRc;
+//  union
+//  {
+//      bool                        bAllow;
+//      MRESULT                     mResult;
+//      WXHICON                     hIcon;
+//      WXHBRUSH                    hBrush;
+//  } vRc;

 
     //
     // For most messages we should return 0 when we do process the message
     //
 
     //
     // For most messages we should return 0 when we do process the message
     //

-    vRc.mResult = (MRESULT)0;
+    mResult = (MRESULT)0;

 
     switch (uMsg)
     {
 
     switch (uMsg)
     {


@@ -1864,14 +1879,15 @@ MRESULT wxWindow::OS2WindowProc(
                     //
                     // Return 0 to bAllow window creation
                     //
                     //
                     // Return 0 to bAllow window creation
                     //

-                    vRc.mResult = (MRESULT)(bMayCreate ? 0 : -1);
+                    mResult = (MRESULT)(bMayCreate ? 0 : -1);

                 }
             }
             break;
 
         case WM_DESTROY:
                 }
             }
             break;
 
         case WM_DESTROY:

-            bProcessed = HandleDestroy();
-            break;
+             HandleDestroy();
+             bProcessed = TRUE;
+             break;

 
         case WM_MOVE:
             bProcessed = HandleMove( LOWORD(lParam)
 
         case WM_MOVE:
             bProcessed = HandleMove( LOWORD(lParam)


@@ -1900,6 +1916,7 @@ MRESULT wxWindow::OS2WindowProc(
                 bProcessed = HandleActivate( wState
                                             ,(WXHWND)hWnd
                                            );
                 bProcessed = HandleActivate( wState
                                             ,(WXHWND)hWnd
                                            );

+                bProcessed = FALSE;

             }
             break;
 
             }
             break;
 


@@ -1920,7 +1937,7 @@ MRESULT wxWindow::OS2WindowProc(
             // ourselves in ~wxWindow
             //
             bProcessed = TRUE;
             // ourselves in ~wxWindow
             //
             bProcessed = TRUE;

-            vRc.mResult = (MRESULT)TRUE;
+            mResult = (MRESULT)TRUE;

             break;
 
         case WM_SHOW:
             break;
 
         case WM_SHOW:


@@ -1954,7 +1971,6 @@ MRESULT wxWindow::OS2WindowProc(
                 bProcessed = HandleMouseEvent(uMsg, x, y, (WXUINT)wParam);
             }
             break;
                 bProcessed = HandleMouseEvent(uMsg, x, y, (WXUINT)wParam);
             }
             break;

-

         case WM_SYSCOMMAND:
             bProcessed = HandleSysCommand(wParam, lParam);
             break;
         case WM_SYSCOMMAND:
             bProcessed = HandleSysCommand(wParam, lParam);
             break;


@@ -1988,14 +2004,14 @@ MRESULT wxWindow::OS2WindowProc(
                 }
 
                 if ( bProcessed )
                 }
 
                 if ( bProcessed )

-                    vRc.mResult = (MRESULT)TRUE;
+                    mResult = (MRESULT)TRUE;

             }
             break;
 
         case WM_QUERYDLGCODE:
             if ( m_lDlgCode )
             {
             }
             break;
 
         case WM_QUERYDLGCODE:
             if ( m_lDlgCode )
             {

-                vRc.mResult = (MRESULT)m_lDlgCode;
+                mResult = (MRESULT)m_lDlgCode;

                 bProcessed = TRUE;
             }
             //
                 bProcessed = TRUE;
             }
             //


@@ -2094,7 +2110,7 @@ MRESULT wxWindow::OS2WindowProc(
 #if defined(__VISAGECPP__) && (__IBMCPP__ >= 400)
         case WM_CTLCOLORCHANGE:
             {
 #if defined(__VISAGECPP__) && (__IBMCPP__ >= 400)
         case WM_CTLCOLORCHANGE:
             {

-                bProcessed = HandleCtlColor(&vRc.hBrush);
+                bProcessed = HandleCtlColor(&hBrush);

             }
             break;
 #endif
             }
             break;
 #endif


@@ -2133,7 +2149,7 @@ MRESULT wxWindow::OS2WindowProc(
                 //
                 // We processed the message, i.e. erased the background
                 //
                 //
                 // We processed the message, i.e. erased the background
                 //

-                vRc.mResult = (MRESULT)TRUE;
+                mResult = (MRESULT)TRUE;

             }
             break;
 
             }
             break;
 


@@ -2148,18 +2164,18 @@ MRESULT wxWindow::OS2WindowProc(
             if ( bProcessed )
             {
                 // we never set focus from here
             if ( bProcessed )
             {
                 // we never set focus from here

-                vRc.mResult = FALSE;
+                mResult = FALSE;

             }
             break;
 
         // wxFrame specific message
         case WM_MINMAXFRAME:
             }
             break;
 
         // wxFrame specific message
         case WM_MINMAXFRAME:

-            bProcessed = HandleGetMinMaxInfo((PSWP)lParam);
+            bProcessed = HandleGetMinMaxInfo((PSWP)wParam);

             break;
 
         case WM_SYSVALUECHANGED:
             // TODO: do something
             break;
 
         case WM_SYSVALUECHANGED:
             // TODO: do something

-            vRc.mResult = (MRESULT)TRUE;
+            mResult = (MRESULT)TRUE;

             break;
 
         //
             break;
 
         //


@@ -2176,7 +2192,7 @@ MRESULT wxWindow::OS2WindowProc(
                 // processing this message - exactly what we need because we've
                 // just set the cursor.
                 //
                 // processing this message - exactly what we need because we've
                 // just set the cursor.
                 //

-                vRc.mResult = (MRESULT)TRUE;
+                mResult = (MRESULT)TRUE;

             }
             break;
     }
             }
             break;
     }


@@ -2187,9 +2203,9 @@ MRESULT wxWindow::OS2WindowProc(
         wxLogTrace(wxTraceMessages, wxT("Forwarding %s to DefWindowProc."),
                    wxGetMessageName(uMsg));
 #endif // __WXDEBUG__
         wxLogTrace(wxTraceMessages, wxT("Forwarding %s to DefWindowProc."),
                    wxGetMessageName(uMsg));
 #endif // __WXDEBUG__

-        vRc.mResult = OS2DefWindowProc(uMsg, wParam, lParam);
+        mResult = OS2DefWindowProc(uMsg, wParam, lParam);

     }
     }

-    return vRc.mResult;
+    return mResult;

 } // end of wxWindow::OS2WindowProc
 
 //
 } // end of wxWindow::OS2WindowProc
 
 //


@@ -2326,10 +2342,10 @@ bool wxWindow::OS2Create(
 {
     ERRORID                         vError;
     wxString                        sError;
 {
     ERRORID                         vError;
     wxString                        sError;

-    long                            lX1      = (long)CW_USEDEFAULT;
+    long                            lX1      = 0L;

     long                            lY1      = 0L;
     long                            lY1      = 0L;

-    long                            lWidth1  = (long)CW_USEDEFAULT;
-    long                            lHeight1 = 100L;
+    long                            lWidth1  = 20L;
+    long                            lHeight1 = 20L;

     int                             nControlId = 0;
 
     //
     int                             nControlId = 0;
 
     //


@@ -2395,6 +2411,7 @@ bool wxWindow::OS2Create(
         wxLogError("Can't create window of class %s!. Error: %s\n", zClass, sError);
         return FALSE;
     }
         wxLogError("Can't create window of class %s!. Error: %s\n", zClass, sError);
         return FALSE;
     }

+    ::WinSetWindowULong(m_hWnd, QWL_USER, (ULONG) this);

     wxWndHook = NULL;
 
 #ifdef __WXDEBUG__
     wxWndHook = NULL;
 
 #ifdef __WXDEBUG__


@@ -2414,6 +2431,12 @@ bool wxWindow::OS2Create(
     wxAssociateWinWithHandle((HWND)m_hWnd
                              ,this
                             );
     wxAssociateWinWithHandle((HWND)m_hWnd
                              ,this
                             );

+    //
+    // Now need to subclass window.
+    //
+
+    SubclassWin(GetHWND());
+

     return TRUE;
 } // end of wxWindow::OS2Create
 
     return TRUE;
 } // end of wxWindow::OS2Create
 


@@ -2806,11 +2829,11 @@ bool wxWindow::HandlePaint()
          return FALSE;
     }
     m_updateRegion = wxRegion(hRgn);
          return FALSE;
     }
     m_updateRegion = wxRegion(hRgn);

-
-    hPS = WinBeginPaint(GetHwnd(), 0L, &vRect);
+/*
+    hPS = WinBeginPaint(GetHWND(), 0L, &vRect);

     WinFillRect(hPS, &vRect, SYSCLR_WINDOW);
     WinEndPaint(hPS);
     WinFillRect(hPS, &vRect, SYSCLR_WINDOW);
     WinEndPaint(hPS);

-
+*/

     vEvent.SetEventObject(this);
     return (GetEventHandler()->ProcessEvent(vEvent));
 } // end of wxWindow::HandlePaint
     vEvent.SetEventObject(this);
     return (GetEventHandler()->ProcessEvent(vEvent));
 } // end of wxWindow::HandlePaint


@@ -3950,3 +3973,43 @@ static void TranslateKbdEventToMouse(
     pWin->ScreenToClient(pX, pY);
 } // end of TranslateKbdEventToMouse
 
     pWin->ScreenToClient(pX, pY);
 } // end of TranslateKbdEventToMouse
 

+// Find the wxWindow at the current mouse position, returning the mouse
+// position.
+wxWindow* wxFindWindowAtPointer(wxPoint& pt)
+{
+    return wxFindWindowAtPoint(wxGetMousePosition());
+}
+
+wxWindow* wxFindWindowAtPoint(const wxPoint& pt)
+{
+#if 0
+    POINT pt2;
+    pt2.x = pt.x;
+    pt2.y = pt.y;
+    HWND hWndHit = ::WindowFromPoint(pt2);
+
+    wxWindow* win = wxFindWinFromHandle((WXHWND) hWndHit) ;
+    HWND hWnd = hWndHit;
+
+    // Try to find a window with a wxWindow associated with it
+    while (!win && (hWnd != 0))
+    {
+        hWnd = ::GetParent(hWnd);
+        win = wxFindWinFromHandle((WXHWND) hWnd) ;
+    }
+    return win;
+#endif
+    return (wxWindow*)NULL;
+}
+
+// Get the current mouse position.
+wxPoint wxGetMousePosition()
+{
+#if 0
+    POINT pt;
+    GetCursorPos( & pt );
+    return wxPoint(pt.x, pt.y);
+#endif
+    return wxPoint(0,0);
+}
+