check whether the string is non-empty before accessing its first element

[wxWidgets.git] / src / common / treebase.cpp

diff --git a/src/common/treebase.cpp b/src/common/treebase.cpp
index bf992729d44a2538fef190dc122a63b8fbfd3770..f10e2af927b24c6b40ecdf0924b6bead4fb33566 100644 (file)
--- a/src/common/treebase.cpp
+++ b/src/common/treebase.cpp
@@ -106,16 +106,20 @@ wxTreeCtrlBase::~wxTreeCtrlBase()
         delete m_imageListState;
 }
 
         delete m_imageListState;
 }
 

-static void wxGetBestTreeSize(const wxTreeCtrlBase* treeCtrl, const wxTreeItemId& id, wxSize& size)
+static void
+wxGetBestTreeSize(const wxTreeCtrlBase* treeCtrl, wxTreeItemId id, wxSize& size)

 {
     wxRect rect;
 
 {
     wxRect rect;
 

-    if ( treeCtrl->GetBoundingRect(id, rect, true) )
+    if ( treeCtrl->GetBoundingRect(id, rect, true /* just the item */) )

     {
     {

-        if ( size.x < rect.x + rect.width )
-            size.x = rect.x + rect.width;
-        if ( size.y < rect.y + rect.height )
-            size.y = rect.y + rect.height;
+        // Translate to logical position so we get the full extent
+#if defined(__WXMSW__) && !defined(__WXUNIVERSAL__)
+        rect.x += treeCtrl->GetScrollPos(wxHORIZONTAL);
+        rect.y += treeCtrl->GetScrollPos(wxVERTICAL);
+#endif
+
+        size.IncTo(wxSize(rect.GetRight(), rect.GetBottom()));

     }
 
     wxTreeItemIdValue cookie;
     }
 
     wxTreeItemIdValue cookie;


@@ -155,20 +159,33 @@ wxSize wxTreeCtrlBase::DoGetBestSize() const
             }
         }
     }
             }
         }
     }

-    else
-        wxGetBestTreeSize(this, GetRootItem(), size);
+    else // use precise, if potentially slow, size computation method
+    {
+        // iterate over all items recursively
+        wxTreeItemId idRoot = GetRootItem();
+        if ( idRoot.IsOk() )
+            wxGetBestTreeSize(this, idRoot, size);
+    }

 
     // need some minimal size even for empty tree
     if ( !size.x || !size.y )
         size = wxControl::DoGetBestSize();
     else
 
     // need some minimal size even for empty tree
     if ( !size.x || !size.y )
         size = wxControl::DoGetBestSize();
     else

+    {
+        // Add border size
+        size += GetWindowBorderSize();
+

         CacheBestSize(size);
         CacheBestSize(size);

+    }

 
     return size;
 }
 
 void wxTreeCtrlBase::ExpandAll()
 {
 
     return size;
 }
 
 void wxTreeCtrlBase::ExpandAll()
 {

+    if ( IsEmpty() )
+        return;
+

     ExpandAllChildren(GetRootItem());
 }
 
     ExpandAllChildren(GetRootItem());
 }
 


@@ -188,5 +205,33 @@ void wxTreeCtrlBase::ExpandAllChildren(const wxTreeItemId& item)
     }
 }
 
     }
 }
 

+void wxTreeCtrlBase::CollapseAll()
+{
+    if ( IsEmpty() )
+        return;
+
+    CollapseAllChildren(GetRootItem());
+}
+
+void wxTreeCtrlBase::CollapseAllChildren(const wxTreeItemId& item)
+{
+    // first (recursively) collapse all the children
+    wxTreeItemIdValue cookie;
+    for ( wxTreeItemId idCurr = GetFirstChild(item, cookie);
+          idCurr.IsOk();
+          idCurr = GetNextChild(item, cookie) )
+    {
+        CollapseAllChildren(idCurr);
+    }
+
+    // then collapse this element too
+    Collapse(item);
+}
+
+bool wxTreeCtrlBase::IsEmpty() const
+{
+    return !GetRootItem().IsOk();
+}
+

 #endif // wxUSE_TREECTRL
 
 #endif // wxUSE_TREECTRL