sometimes unused parameter warnings are really worth paying attention to

[wxWidgets.git] / src / gtk / timer.cpp

diff --git a/src/gtk/timer.cpp b/src/gtk/timer.cpp
index c5e8bd37add140f03a8b4ebbc29f69811547ede3..628ede1a184036807f7cbd8b4351ab92b56e0cdd 100644 (file)
--- a/src/gtk/timer.cpp
+++ b/src/gtk/timer.cpp
@@ -12,28 +12,23 @@
 
 #if wxUSE_TIMER
 
 
 #if wxUSE_TIMER
 

-#include "wx/timer.h"
+#include "wx/gtk/private/timer.h"

 
 

-#include "gtk/gtk.h"
+#include <gtk/gtk.h>

 
 // ----------------------------------------------------------------------------
 
 // ----------------------------------------------------------------------------

-// wxTimer
+// wxTimerImpl

 // ----------------------------------------------------------------------------
 
 // ----------------------------------------------------------------------------
 

-IMPLEMENT_ABSTRACT_CLASS(wxTimer, wxEvtHandler)
-

 extern "C" {
 extern "C" {

-static gint timeout_callback( gpointer data )
-{
-    wxTimer *timer = (wxTimer*)data;

 
 

-    // Don't change the order of anything in this callback!
+static gboolean timeout_callback(gpointer data)
+{
+    wxGTKTimerImpl *timer = (wxGTKTimerImpl*)data;

 
 

-    if (timer->IsOneShot())
-    {
-        // This sets m_tag to -1
+    const bool keepGoing = !timer->IsOneShot();
+    if ( !keepGoing )

         timer->Stop();
         timer->Stop();

-    }

 
     // When getting called from GDK's timer handler we
     // are no longer within GDK's grab on the GUI
 
     // When getting called from GDK's timer handler we
     // are no longer within GDK's grab on the GUI


@@ -45,43 +40,29 @@ static gint timeout_callback( gpointer data )
     // Release lock again.
     gdk_threads_leave();
 
     // Release lock again.
     gdk_threads_leave();
 

-    if (timer->IsOneShot())
-        return FALSE;
-
-    return TRUE;
-}
+    return keepGoing;

 }
 
 }
 

-void wxTimer::Init()
-{
-    m_tag = -1;
-    m_milli = 1000;
-}
+} // extern "C"

 
 

-wxTimer::~wxTimer()
+bool wxGTKTimerImpl::Start(int millisecs, bool oneShot)

 {
 {

-    wxTimer::Stop();
-}
+    if ( !wxTimerImpl::Start(millisecs, oneShot) )
+        return false;

 
 

-bool wxTimer::Start( int millisecs, bool oneShot )
-{
-    (void)wxTimerBase::Start(millisecs, oneShot);
+    wxASSERT_MSG( !m_sourceId, _T("shouldn't be still running") );

 
 

-    if (m_tag != -1)
-        gtk_timeout_remove( m_tag );
+    m_sourceId = g_timeout_add(m_milli, timeout_callback, this);

 
 

-    m_tag = gtk_timeout_add( m_milli, timeout_callback, this );
-
-    return TRUE;
+    return true;

 }
 
 }
 

-void wxTimer::Stop()
+void wxGTKTimerImpl::Stop()

 {
 {

-    if (m_tag != -1)
-    {
-        gtk_timeout_remove( m_tag );
-        m_tag = -1;
-    }
+    wxASSERT_MSG( m_sourceId, _T("should be running") );
+
+    g_source_remove(m_sourceId);
+    m_sourceId = 0;

 }
 
 #endif // wxUSE_TIMER
 }
 
 #endif // wxUSE_TIMER