// created in resopnse to WM_PAINT message - doing this from elsewhere is a
// common programming error among wxWindows programmers and might lead to
// very subtle and difficult to debug refresh/repaint bugs.
- extern bool g_isPainting = FALSE;
+ int g_isPainting = 0;
#endif // __WXDEBUG__
// ===========================================================================
{
SelectOldObjects(m_hDC);
- ::ReleaseDC(GetWinHwnd(m_canvas), GetHdc());
+ if ( !::ReleaseDC(GetWinHwnd(m_canvas), GetHdc()) )
+ {
+ wxLogLastError("ReleaseDC");
+ }
+
m_hDC = 0;
}
// So we store a list of windows for which we already have the DC and not
// just one single hDC. This seems to work, but I'm really not sure about
// the usefullness of the whole idea - IMHO it's much better to not call
-// base class OnPaint() at all, or, if we realyl want to allow it, add a
+// base class OnPaint() at all, or, if we really want to allow it, add a
// "wxPaintDC *" parameter to wxPaintEvent which should be used if it's
// !NULL instead of creating a new DC.
wxPaintDC::wxPaintDC(wxWindow *canvas)
{
- wxCHECK_RET( canvas, "NULL canvas in wxPaintDC ctor" );
+ wxCHECK_RET( canvas, _T("NULL canvas in wxPaintDC ctor") );
#ifdef __WXDEBUG__
- if ( !g_isPainting )
+ if ( g_isPainting <= 0 )
{
wxFAIL_MSG( _T("wxPaintDC may be created only in EVT_PAINT handler!") );
{
if ( m_hDC )
{
+ SelectOldObjects(m_hDC);
+
size_t index;
wxPaintDCInfo *info = FindInCache(&index);
ms_cache.Remove(index);
}
//else: cached DC entry is still in use
+
+ // prevent the base class dtor from ReleaseDC()ing it again
+ m_hDC = 0;
}
}