Fix wxOwnerDrawnComboBox keyboard navigation with duplicate items.

[wxWidgets.git] / src / generic / datectlg.cpp

diff --git a/src/generic/datectlg.cpp b/src/generic/datectlg.cpp
index 847109b2b89e82f009277af5f00690e3dcfa8bb3..0d67a6c6ecf21268659c9d9974ee7cea178d7b89 100644 (file)
--- a/src/generic/datectlg.cpp
+++ b/src/generic/datectlg.cpp
@@ -1,6 +1,6 @@
 /////////////////////////////////////////////////////////////////////////////
 /////////////////////////////////////////////////////////////////////////////

-// Name:        generic/datectrl.cpp
-// Purpose:     generic wxDatePickerCtrl implementation
+// Name:        src/generic/datectlg.cpp
+// Purpose:     generic wxDatePickerCtrlGeneric implementation

 // Author:      Andreas Pflug
 // Modified by:
 // Created:     2005-01-19
 // Author:      Andreas Pflug
 // Modified by:
 // Created:     2005-01-19


@@ -23,498 +23,487 @@
     #pragma hdrstop
 #endif
 
     #pragma hdrstop
 #endif
 

+#if wxUSE_DATEPICKCTRL
+
+#ifndef WX_PRECOMP
+    #include "wx/dialog.h"
+    #include "wx/dcmemory.h"
+    #include "wx/panel.h"
+    #include "wx/textctrl.h"
+    #include "wx/valtext.h"
+#endif
+

 #include "wx/datectrl.h"
 #include "wx/datectrl.h"

+#include "wx/generic/datectrl.h"
+

 
 // ----------------------------------------------------------------------------
 // constants
 // ----------------------------------------------------------------------------
 
 
 // ----------------------------------------------------------------------------
 // constants
 // ----------------------------------------------------------------------------
 

-enum
-{
-    CTRLID_TXT = 101,
-    CTRLID_CAL
-    CTRLID_BTN
-    CTRLID_PAN
-};
-
-#ifndef DEFAULT_ITEM_WIDTH
-    #define DEFAULT_ITEM_WIDTH 100
-#endif
-
-// ============================================================================
-// wxDatePickerCtrl implementation
-// ============================================================================
-
-BEGIN_EVENT_TABLE(wxDatePickerCtrl, wxDatePickerCtrlBase)
-    EVT_BUTTON(CTRLID_BTN, wxDatePickerCtrl::OnClick)
-    EVT_TEXT(CTRLID_TXT, wxDatePickerCtrl::OnText)
-    EVT_CHILD_FOCUS(wxDatePickerCtrl::OnChildSetFocus)
-END_EVENT_TABLE()
-
-IMPLEMENT_DYNAMIC_CLASS(wxDatePickerCtrl, wxDatePickerCtrlBase)

 
 // ----------------------------------------------------------------------------
 
 // ----------------------------------------------------------------------------

-// creation
+// global variables

 // ----------------------------------------------------------------------------
 
 // ----------------------------------------------------------------------------
 

-wxDatePickerCtrl::wxDatePickerCtrl(wxWindow *parent,
-                            wxWindowID id,
-                            const wxDateTime& date,
-                            const wxPoint& pos,
-                            const wxSize& size,
-                            long style,
-                            const wxString& name)
-{
-    Init();
-    Create(parent, id, date, pos, size, style, name);
-}

 
 

+// ----------------------------------------------------------------------------
+// local classes
+// ----------------------------------------------------------------------------

 
 

-bool wxDatePickerCtrl::Create(wxWindow *parent,
-                            wxWindowID id,
-                            const wxDateTime& date,
-                            const wxPoint& pos,
-                            const wxSize& size,
-                            long style,
-                            const wxString& name)
+class wxCalendarComboPopup : public wxCalendarCtrl,
+                             public wxComboPopup

 {
 {

-    wxString txt;
-    if (date.IsValid())
-        txt = date.FormatDate();
-
-    if ( !wxControl::Create(parent, id, pos, size,
-                            style | wxCLIP_CHILDREN | wxWANTS_CHARS,
-                            wxDefaultValidator, name) )
+public:

 
 

+    wxCalendarComboPopup() : wxCalendarCtrl(),
+                             wxComboPopup()

     {
     {

-        return false;

     }
 
     }
 

-    SetWindowStyle(style | wxWANTS_CHARS);
-    InheritAttributes();
-
-    wxBitmap bmp(8, 4);
+    virtual void Init()

     {
     {

-        wxMemoryDC dc;
-
-        dc.SelectObject(bmp);
-        dc.SetBrush(wxBrush(GetBackgroundColour()));
-        dc.SetPen(wxPen(GetBackgroundColour()));
-        dc.DrawRectangle(0,0, 8,4);
-
-        dc.SetBrush(wxBrush(GetForegroundColour()));
-        dc.SetPen(wxPen(GetForegroundColour()));
-        wxPoint pt[3] = { wxPoint(0,0), wxPoint(6,0), wxPoint(3,3) };
-        dc.DrawPolygon(3, pt);
-        dc.SelectObject(wxNullBitmap);

     }
 
     }
 

-    m_txt=new wxTextCtrl(this, CTRLID_TXT, txt);
-    m_txt->Connect(wxID_ANY, wxID_ANY, wxEVT_KEY_DOWN, (wxObjectEventFunction)&wxDatePickerCtrl::OnEditKey, 0, this);
-    m_txt->Connect(wxID_ANY, wxID_ANY, wxEVT_KILL_FOCUS, (wxObjectEventFunction)&wxDatePickerCtrl::OnKillFocus, 0, this);
-    SetFormat(wxT("%x"));
-
-    m_btn = new wxBitmapButton(this, CTRLID_BTN, bmp);
+    // NB: Don't create lazily since it didn't work that way before
+    //     wxComboCtrl was used, and changing behaviour would almost
+    //     certainly introduce new bugs.
+    virtual bool Create(wxWindow* parent)
+    {
+        if ( !wxCalendarCtrl::Create(parent, wxID_ANY, wxDefaultDateTime,
+                              wxPoint(0, 0), wxDefaultSize,
+                              wxCAL_SEQUENTIAL_MONTH_SELECTION
+                              | wxCAL_SHOW_HOLIDAYS | wxBORDER_SUNKEN) )
+            return false;

 
 

-    m_dlg = new wxDialog(this, CTRLID_CAL, wxEmptyString, wxDefaultPosition, wxDefaultSize, wxSIMPLE_BORDER);
-    m_dlg->SetFont(GetFont());
+        SetFormat(GetLocaleDateFormat());

 
 

-    wxPanel *panel=new wxPanel(m_dlg, CTRLID_PAN, wxPoint(0, 0), wxDefaultSize, wxSUNKEN_BORDER|wxCLIP_CHILDREN);
-    m_cal = new wxCalendarCtrl(panel, CTRLID_CAL, wxDefaultDateTime, wxPoint(0,0), wxDefaultSize, wxSUNKEN_BORDER);
-    m_cal->Connect(CTRLID_CAL, CTRLID_CAL, wxEVT_CALENDAR_SEL_CHANGED, (wxObjectEventFunction)&wxDatePickerCtrl::OnSelChange, 0, this);
-    m_cal->Connect(wxID_ANY, wxID_ANY, wxEVT_KEY_DOWN, (wxObjectEventFunction)&wxDatePickerCtrl::OnCalKey, 0, this);
-    m_cal->Connect(CTRLID_CAL, CTRLID_CAL, wxEVT_CALENDAR_DOUBLECLICKED, (wxObjectEventFunction)&wxDatePickerCtrl::OnSelChange, 0, this);
-    m_cal->Connect(CTRLID_CAL, CTRLID_CAL, wxEVT_CALENDAR_DAY_CHANGED, (wxObjectEventFunction)&wxDatePickerCtrl::OnSelChange, 0, this);
-    m_cal->Connect(CTRLID_CAL, CTRLID_CAL, wxEVT_CALENDAR_MONTH_CHANGED, (wxObjectEventFunction)&wxDatePickerCtrl::OnSelChange, 0, this);
-    m_cal->Connect(CTRLID_CAL, CTRLID_CAL, wxEVT_CALENDAR_YEAR_CHANGED, (wxObjectEventFunction)&wxDatePickerCtrl::OnSelChange, 0, this);
+        m_useSize  = wxCalendarCtrl::GetBestSize();

 
 

-    wxWindow *yearControl = m_cal->GetYearControl();
+        wxWindow* tx = m_combo->GetTextCtrl();
+        if ( !tx )
+            tx = m_combo;

 
 

-    Connect(wxID_ANY, wxID_ANY, wxEVT_SET_FOCUS, (wxObjectEventFunction)&wxDatePickerCtrl::OnSetFocus);
+        tx->Connect(wxEVT_KILL_FOCUS,
+                    wxFocusEventHandler(wxCalendarComboPopup::OnKillTextFocus),
+                    NULL, this);

 
 

-    wxClientDC dc(yearControl);
-    dc.SetFont(m_font);
-    wxCoord width, dummy;
-    dc.GetTextExtent(wxT("2000"), &width, &dummy);
-    width += ConvertDialogToPixels(wxSize(20,0)).x;
+        return true;
+    }

 
 

-    wxSize calSize = m_cal->GetBestSize();
-    wxSize yearSize = yearControl->GetSize();
-    yearSize.x = width;
+    virtual wxSize GetAdjustedSize(int WXUNUSED(minWidth),
+                                   int WXUNUSED(prefHeight),
+                                   int WXUNUSED(maxHeight))
+    {
+        return m_useSize;
+    }

 
 

-    wxPoint yearPosition = yearControl->GetPosition();
+    virtual wxWindow *GetControl() { return this; }

 
 

-#ifdef __WXMSW__
-#define CALBORDER   0
-#else
-#define CALBORDER   4
-#endif
+    void SetDateValue(const wxDateTime& date)
+    {
+        if ( date.IsValid() )
+        {
+            m_combo->SetText(date.Format(m_format));
+            SetDate(date);
+        }
+        else // invalid date
+        {
+            wxASSERT_MSG( HasDPFlag(wxDP_ALLOWNONE),
+                            wxT("this control must have a valid date") );

 
 

-    width = yearPosition.x + yearSize.x+2+CALBORDER/2;
-    if (width < calSize.x-4)
-        width = calSize.x-4;
+            m_combo->SetText(wxEmptyString);
+        }
+    }

 
 

-    int calPos = (width-calSize.x)/2;
-    if (calPos == -1)
+    bool IsTextEmpty() const

     {
     {

-        calPos = 0;
-        width += 2;
+        return m_combo->GetTextCtrl()->IsEmpty();

     }
     }

-    m_cal->SetSize(calPos, 0, calSize.x, calSize.y);
-    yearControl->SetSize(width-yearSize.x-CALBORDER/2, yearPosition.y, yearSize.x, yearSize.y);
-    m_cal->GetMonthControl()->Move(0, 0);

 
 

+    bool ParseDateTime(const wxString& s, wxDateTime* pDt)
+    {
+        wxASSERT(pDt);

 
 

+        if ( !s.empty() )
+        {
+            pDt->ParseFormat(s.c_str(), m_format);
+            if ( !pDt->IsValid() )
+                return false;
+        }

 
 

-    panel->SetClientSize(width+CALBORDER/2, calSize.y-2+CALBORDER);
-    m_dlg->SetClientSize(panel->GetSize());
+        return true;
+    }

 
 

-    return TRUE;
-}
+    void SendDateEvent(const wxDateTime& dt)
+    {
+        // Sends both wxCalendarEvent and wxDateEvent
+        wxWindow* datePicker = m_combo->GetParent();

 
 

+        wxCalendarEvent cev(datePicker, dt, wxEVT_CALENDAR_SEL_CHANGED);
+        datePicker->GetEventHandler()->ProcessEvent(cev);

 
 

-void wxDatePickerCtrl::Init()
-{
-    m_dlg = NULL;
-    m_txt = NULL;
-    m_cal = NULL;
-    m_btn = NULL;
+        wxDateEvent event(datePicker, dt, wxEVT_DATE_CHANGED);
+        datePicker->GetEventHandler()->ProcessEvent(event);
+    }

 
 

-    m_dropped = false;
-    m_ignoreDrop = false;
-}
+private:

 
 

+    void OnCalKey(wxKeyEvent & ev)
+    {
+        if (ev.GetKeyCode() == WXK_ESCAPE && !ev.HasModifiers())
+            Dismiss();
+        else
+            ev.Skip();
+    }

 
 

-bool wxDatePickerCtrl::Destroy()
-{
-    if (m_cal)
-        m_cal->Destroy();
-    if (m_dlg)
-        m_dlg->Destroy();
-    if (m_txt)
-        m_txt->Destroy();
-    if (m_btn)
-        m_btn->Destroy();
-
-    m_dlg = NULL;
-    m_txt = NULL;
-    m_cal = NULL;
-    m_btn = NULL;
+    void OnSelChange(wxCalendarEvent &ev)
+    {
+        m_combo->SetText(GetDate().Format(m_format));

 
 

-    return wxControl::Destroy();
-}
+        if ( ev.GetEventType() == wxEVT_CALENDAR_DOUBLECLICKED )
+        {
+            Dismiss();
+        }

 
 

-// ----------------------------------------------------------------------------
-// overridden base class methods
-// ----------------------------------------------------------------------------
+        SendDateEvent(GetDate());
+    }

 
 

-void wxDatePickerCtrl::DoMoveWindow(int x, int y, int w, int h)
-{
-    wxControl::DoMoveWindow(x, y, w, h);
-    wxSize bs=m_btn->GetBestSize();
-    int eh=m_txt->GetBestSize().y;
+    void OnKillTextFocus(wxFocusEvent &ev)
+    {
+        ev.Skip();

 
 

-    m_txt->SetSize(0, 0, w-bs.x-1, h > eh ? eh : h);
-    m_btn->SetSize(w - bs.x, 0, bs.x, h > bs.y ? bs.y : h);
+        const wxDateTime& dtOld = GetDate();

 
 

-    if (m_dropped)
-        DropDown();
-}
+        wxDateTime dt;
+        wxString value = m_combo->GetValue();
+        if ( !ParseDateTime(value, &dt) )
+        {
+            if ( !HasDPFlag(wxDP_ALLOWNONE) )
+                dt = dtOld;
+        }

 
 

-wxSize wxDatePickerCtrl::DoGetBestSize() const
-{
-    int bh=m_btn->GetBestSize().y;
-    int eh=m_txt->GetBestSize().y;
-    return wxSize(DEFAULT_ITEM_WIDTH, bh > eh ? bh : eh);
-}
+        m_combo->SetText(GetStringValueFor(dt));
+
+        if ( !dt.IsValid() && HasDPFlag(wxDP_ALLOWNONE) )
+            return;

 
 

+        // notify that we had to change the date after validation
+        if ( (dt.IsValid() && (!dtOld.IsValid() || dt != dtOld)) ||
+                (!dt.IsValid() && dtOld.IsValid()) )
+        {
+            SetDate(dt);
+            SendDateEvent(dt);
+        }
+    }

 
 

-bool wxDatePickerCtrl::Show(bool show)
-{
-    if ( !wxControl::Show(show) )
+    bool HasDPFlag(int flag) const

     {
     {

-        return FALSE;
+        return m_combo->GetParent()->HasFlag(flag);

     }
 
     }
 

-    if (!show)
+    // it expands "%x" format and changes %y to %Y if wxDP_SHOWCENTURY flag
+    // is given. If the locale format can't be easily analyzed (e.g. when
+    // the month is given as a name, not number), "%x" is returned
+    wxString GetLocaleDateFormat() const

     {
     {

-        if (m_dlg)
+        wxString x_format(wxT("%x"));
+        wxString fmt;
+        int year_cnt = 0, month_cnt = 0, day_cnt = 0;
+
+        wxDateTime dt;
+        dt.ParseFormat(wxT("2003-10-17"), wxT("%Y-%m-%d"));
+        wxString str(dt.Format(x_format));
+
+        const wxChar *p = str.c_str();
+        while ( *p )

         {
         {

-            m_dlg->Hide();
-            m_dropped = false;
+            if (wxIsdigit(*p))
+            {
+                int n=wxAtoi(p);
+                if (n == dt.GetDay())
+                {
+                    fmt.Append(wxT("%d"));
+                    day_cnt++;
+                    p += 2;
+                }
+                else if (n == (int)dt.GetMonth()+1)
+                {
+                    fmt.Append(wxT("%m"));
+                    month_cnt++;
+                    p += 2;
+                }
+                else if (n == dt.GetYear())
+                {
+                    fmt.Append(wxT("%Y"));
+                    year_cnt++;
+                    p += 4;
+                }
+                else if (n == (dt.GetYear() % 100))
+                {
+                    if ( HasDPFlag(wxDP_SHOWCENTURY) )
+                        fmt.Append(wxT("%Y"));
+                    else
+                        fmt.Append(wxT("%y"));
+                    year_cnt++;
+                    p += 2;
+                }
+                else
+                    // this shouldn't happen
+                    return x_format;
+            }
+            else {
+                fmt.Append(*p);
+                p++;
+            }

         }
         }

+
+        if (year_cnt == 1 && month_cnt == 1 && day_cnt == 1)
+            return fmt;
+
+        return x_format;

     }
 
     }
 

-    return TRUE;
-}
+    bool SetFormat(const wxString& fmt)
+    {
+        m_format = fmt;

 
 

+        if ( m_combo )
+        {
+            wxArrayString allowedChars;
+            for ( wxChar c = wxT('0'); c <= wxT('9'); c++ )
+                allowedChars.Add(wxString(c, 1));

 
 

-bool wxDatePickerCtrl::Enable(bool enable)
-{
-    if ( !wxControl::Enable(enable) )
+            const wxChar *p2 = m_format.c_str();
+            while ( *p2 )
+            {
+                if ( *p2 == '%')
+                    p2 += 2;
+                else
+                    allowedChars.Add(wxString(*p2++, 1));
+            }
+
+    #if wxUSE_VALIDATORS
+            wxTextValidator tv(wxFILTER_INCLUDE_CHAR_LIST);
+            tv.SetIncludes(allowedChars);
+            m_combo->SetValidator(tv);
+    #endif
+
+            if ( GetDate().IsValid() )
+                m_combo->SetText(GetDate().Format(m_format));
+        }
+
+        return true;
+    }
+
+    virtual void SetStringValue(const wxString& s)

     {
     {

-        return FALSE;
+        wxDateTime dt;
+        if ( !s.empty() && ParseDateTime(s, &dt) )
+            SetDate(dt);
+        //else: keep the old value

     }
 
     }
 

-    if (!enable)
+    virtual wxString GetStringValue() const

     {
     {

-        if (m_cal)
-            m_cal->Hide();
+        return GetStringValueFor(GetDate());

     }
     }

-    if (m_btn)
-        m_btn->Enable(enable);
-    return TRUE;
-}
+
+private:
+    // returns either the given date representation using the current format or
+    // an empty string if it's invalid
+    wxString GetStringValueFor(const wxDateTime& dt) const
+    {
+        wxString val;
+        if ( dt.IsValid() )
+            val = dt.Format(m_format);
+
+        return val;
+    }
+
+    wxSize          m_useSize;
+    wxString        m_format;
+
+    DECLARE_EVENT_TABLE()
+};
+
+
+BEGIN_EVENT_TABLE(wxCalendarComboPopup, wxCalendarCtrl)
+    EVT_KEY_DOWN(wxCalendarComboPopup::OnCalKey)
+    EVT_CALENDAR_SEL_CHANGED(wxID_ANY, wxCalendarComboPopup::OnSelChange)
+    EVT_CALENDAR_PAGE_CHANGED(wxID_ANY, wxCalendarComboPopup::OnSelChange)
+    EVT_CALENDAR(wxID_ANY, wxCalendarComboPopup::OnSelChange)
+END_EVENT_TABLE()
+
+
+// ============================================================================
+// wxDatePickerCtrlGeneric implementation
+// ============================================================================
+
+BEGIN_EVENT_TABLE(wxDatePickerCtrlGeneric, wxDatePickerCtrlBase)
+    EVT_TEXT(wxID_ANY, wxDatePickerCtrlGeneric::OnText)
+    EVT_SIZE(wxDatePickerCtrlGeneric::OnSize)
+    EVT_SET_FOCUS(wxDatePickerCtrlGeneric::OnFocus)
+END_EVENT_TABLE()
+
+#ifndef wxHAS_NATIVE_DATEPICKCTRL
+    IMPLEMENT_DYNAMIC_CLASS(wxDatePickerCtrl, wxControl)
+#endif

 
 // ----------------------------------------------------------------------------
 
 // ----------------------------------------------------------------------------

-// wxDatePickerCtrl API
+// creation

 // ----------------------------------------------------------------------------
 
 // ----------------------------------------------------------------------------
 

-bool wxDatePickerCtrl::SetFormat(const wxChar *fmt)
+bool wxDatePickerCtrlGeneric::Create(wxWindow *parent,
+                                     wxWindowID id,
+                                     const wxDateTime& date,
+                                     const wxPoint& pos,
+                                     const wxSize& size,
+                                     long style,
+                                     const wxValidator& validator,
+                                     const wxString& name)

 {
 {

-    wxDateTime dt;
-    dt.ParseFormat(wxT("2003-10-13"), wxT("%Y-%m-%d"));
-    wxString str=dt.Format(fmt);
-    wxChar *p=(wxChar*)str.c_str();
+    wxASSERT_MSG( !(style & wxDP_SPIN),
+                  wxT("wxDP_SPIN style not supported, use wxDP_DEFAULT") );

 
 

-    m_format=wxEmptyString;
-
-    while (*p)
+    if ( !wxControl::Create(parent, id, pos, size,
+                            style | wxCLIP_CHILDREN | wxWANTS_CHARS | wxBORDER_NONE,
+                            validator, name) )

     {
     {

-        int n=wxAtoi(p);
-        if (n == dt.GetDay())
-        {
-            m_format.Append(wxT("%d"));
-            p += 2;
-        }
-        else if (n == (int)dt.GetMonth()+1)
-        {
-            m_format.Append(wxT("%m"));
-            p += 2;
-        }
-        else if (n == dt.GetYear())
-        {
-            m_format.Append(wxT("%Y"));
-            p += 4;
-        }
-        else
-            m_format.Append(*p++);
+        return false;

     }
 
     }
 

-    if (m_txt)
-    {
-        wxStringList valList;
-        wxChar c;
-        for (c='0'; c <= '9'; c++)
-            valList.Add(wxString(c, 1));
-        wxChar *p=(wxChar*)m_format.c_str();
-        while (*p)
-        {
-            if (*p == '%')
-                p += 2;
-            else
-                valList.Add(wxString(*p++, 1));
-        }
-        wxTextValidator tv(wxFILTER_INCLUDE_CHAR_LIST);
-        tv.SetIncludeList(valList);
+    InheritAttributes();

 
 

-        m_txt->SetValidator(tv);
-    }
-    return true;
-}
+    m_combo = new wxComboCtrl(this, -1, wxEmptyString,
+                              wxDefaultPosition, wxDefaultSize);

 
 

+    m_combo->SetCtrlMainWnd(this);

 
 

-wxDateTime wxDatePickerCtrl::GetValue() const
-{
-    wxDateTime dt;
-    wxString txt=m_txt->GetValue();
+    m_popup = new wxCalendarComboPopup();

 
 

-    if (!txt.IsEmpty())
-        dt.ParseFormat(txt, m_format);
+#if defined(__WXMSW__)
+    // without this keyboard navigation in month control doesn't work
+    m_combo->UseAltPopupWindow();
+#endif
+    m_combo->SetPopupControl(m_popup);

 
 

-    return dt;
-}
+    m_popup->SetDateValue(date.IsValid() ? date : wxDateTime::Today());

 
 

+    SetInitialSize(size);

 
 

-void wxDatePickerCtrl::SetValue(const wxDateTime& date)
-{
-    if (m_cal)
-    {
-        if (date.IsValid())
-            m_txt->SetValue(date.FormatDate());
-        else
-            m_txt->SetValue(wxEmptyString);
-    }
+    return true;

 }
 
 
 }
 
 

-bool wxDatePickerCtrl::GetRange(wxDateTime *dt1, wxDateTime *dt2) const
+void wxDatePickerCtrlGeneric::Init()

 {
 {

-    if (dt1)
-        *dt1 = GetLowerDateLimit();
-    if (dt1)
-        *dt2 = GetUpperDateLimit();
-    return true;
+    m_combo = NULL;
+    m_popup = NULL;

 }
 
 }
 

+wxDatePickerCtrlGeneric::~wxDatePickerCtrlGeneric()
+{
+}

 
 

-void wxDatePickerCtrl::SetRange(const wxDateTime &dt1, const wxDateTime &dt2)
+bool wxDatePickerCtrlGeneric::Destroy()

 {
 {

-    SetLowerDateLimit(dt1);
-    SetUpperDateLimit(dt2);
+    if ( m_combo )
+        m_combo->Destroy();
+
+    m_combo = NULL;
+    m_popup = NULL;
+
+    return wxControl::Destroy();

 }
 
 // ----------------------------------------------------------------------------
 }
 
 // ----------------------------------------------------------------------------

-// event handlers
+// overridden base class methods

 // ----------------------------------------------------------------------------
 
 // ----------------------------------------------------------------------------
 

-void wxDatePickerCtrl::DropDown(bool down)
+wxSize wxDatePickerCtrlGeneric::DoGetBestSize() const

 {
 {

-    if (m_dlg)
-    {
-        if (down)
-        {
-            if (m_txt->GetValue().IsEmpty())
-                m_cal->SetDate(wxDateTime::Today());
-            else
-            {
-                wxDateTime dt;
-                dt.ParseFormat(m_txt->GetValue(), m_format);
-                m_cal->SetDate(dt);
-            }
-            wxPoint pos=GetParent()->ClientToScreen(GetPosition());
-
-            m_dlg->Move(pos.x, pos.y + GetSize().y);
-            m_dlg->Show();
-            m_dropped = true;
-        }
-        else
-        {
-            if (m_dropped)
-                m_dlg->Hide();
-            m_dropped = false;
-        }
-    }
+    return m_combo->GetBestSize();

 }
 
 }
 

+// ----------------------------------------------------------------------------
+// wxDatePickerCtrlGeneric API
+// ----------------------------------------------------------------------------

 
 

-void wxDatePickerCtrl::OnChildSetFocus(wxChildFocusEvent &ev)
+bool
+wxDatePickerCtrlGeneric::SetDateRange(const wxDateTime& lowerdate,
+                                      const wxDateTime& upperdate)

 {
 {

-    ev.Skip();
-    m_ignoreDrop = false;
+    return m_popup->SetDateRange(lowerdate, upperdate);
+}

 
 

-    wxWindow  *w=(wxWindow*)ev.GetEventObject();
-    while (w)
-    {
-        if (w == m_dlg)
-            return;
-        w = w->GetParent();
-    }

 
 

-    if (m_dropped)
-    {
-        DropDown(false);
-        if (ev.GetEventObject() == m_btn)
-            m_ignoreDrop = true;
-    }
+wxDateTime wxDatePickerCtrlGeneric::GetValue() const
+{
+    if ( HasFlag(wxDP_ALLOWNONE) && m_popup->IsTextEmpty() )
+        return wxInvalidDateTime;
+    return m_popup->GetDate();

 }
 
 
 }
 
 

-void wxDatePickerCtrl::OnClick(wxCommandEvent& event)
+void wxDatePickerCtrlGeneric::SetValue(const wxDateTime& date)

 {
 {

-    if (m_ignoreDrop)
-    {
-        m_ignoreDrop = false;
-        m_txt->SetFocus();
-    }
-    else
-    {
-        DropDown();
-        m_cal->SetFocus();
-    }
+    m_popup->SetDateValue(date);

 }
 
 
 }
 
 

-void wxDatePickerCtrl::OnSetFocus(wxFocusEvent &ev)
+bool wxDatePickerCtrlGeneric::GetRange(wxDateTime *dt1, wxDateTime *dt2) const

 {
 {

-    if (m_txt)
-    {
-        m_txt->SetFocus();
-        m_txt->SetSelection(0, 100);
-    }
+    return m_popup->GetDateRange(dt1, dt2);

 }
 
 
 }
 
 

-void wxDatePickerCtrl::OnKillFocus(wxFocusEvent &ev)
+void
+wxDatePickerCtrlGeneric::SetRange(const wxDateTime &dt1, const wxDateTime &dt2)

 {
 {

-    ev.Skip();
+    m_popup->SetDateRange(dt1, dt2);
+}

 
 

-    wxDateTime dt;
-    dt.ParseFormat(m_txt->GetValue(), m_format);
-    if (!dt.IsValid())
-        m_txt->SetValue(wxEmptyString);
-    else
-        m_txt->SetValue(dt.Format(m_format));
+wxCalendarCtrl *wxDatePickerCtrlGeneric::GetCalendar() const
+{
+    return m_popup;

 }
 
 }
 

+// ----------------------------------------------------------------------------
+// event handlers
+// ----------------------------------------------------------------------------
+

 
 

-void wxDatePickerCtrl::OnSelChange(wxCalendarEvent &ev)
+void wxDatePickerCtrlGeneric::OnSize(wxSizeEvent& event)

 {
 {

-    if (m_cal)
-    {
-        m_txt->SetValue(m_cal->GetDate().FormatDate());
-        if (ev.GetEventType() == wxEVT_CALENDAR_DOUBLECLICKED)
-        {
-            DropDown(false);
-            m_txt->SetFocus();
-        }
-    }
-    ev.SetEventObject(this);
-    ev.SetId(GetId());
-    GetParent()->ProcessEvent(ev);
+    if ( m_combo )
+        m_combo->SetSize(GetClientSize());
+
+    event.Skip();

 }
 
 
 }
 
 

-void wxDatePickerCtrl::OnText(wxCommandEvent &ev)
+void wxDatePickerCtrlGeneric::OnText(wxCommandEvent &ev)

 {
     ev.SetEventObject(this);
     ev.SetId(GetId());
 {
     ev.SetEventObject(this);
     ev.SetId(GetId());

-    GetParent()->ProcessEvent(ev);
+    GetParent()->GetEventHandler()->ProcessEvent(ev);

 
     // We'll create an additional event if the date is valid.
 
     // We'll create an additional event if the date is valid.

-    // If the date isn't valid, the user's probable in the middle of typing
-    wxString txt=m_txt->GetValue();
+    // If the date isn't valid, the user's probably in the middle of typing

     wxDateTime dt;
     wxDateTime dt;

-    if (!txt.IsEmpty())
-    {
-        dt.ParseFormat(txt, m_format);
-        if (!dt.IsValid())
-            return;
-    }
-
-    wxCalendarEvent cev(m_cal, wxEVT_CALENDAR_SEL_CHANGED);
-    cev.SetEventObject(this);
-    cev.SetId(GetId());
-    cev.SetDate(dt);
+    if ( !m_popup || !m_popup->ParseDateTime(m_combo->GetValue(), &dt) )
+        return;

 
 

-    GetParent()->ProcessEvent(cev);
+    m_popup->SendDateEvent(dt);

 }
 
 
 }
 
 

-void wxDatePickerCtrl::OnEditKey(wxKeyEvent & ev)
+void wxDatePickerCtrlGeneric::OnFocus(wxFocusEvent& WXUNUSED(event))

 {
 {

-    if (ev.GetKeyCode() == WXK_DOWN && !ev.HasModifiers())
-        DropDown();
-    else
-        ev.Skip();
+    m_combo->SetFocus();

 }
 
 
 }
 
 

-void wxDatePickerCtrl::OnCalKey(wxKeyEvent & ev)
-{
-    if (ev.GetKeyCode() == WXK_ESCAPE && !ev.HasModifiers())
-        DropDown(false);
-    else
-        ev.Skip();
-}
+#endif // wxUSE_DATEPICKCTRL