moving value setting conformance to impl

[wxWidgets.git] / src / common / dynarray.cpp

diff --git a/src/common/dynarray.cpp b/src/common/dynarray.cpp
index 76cff5323e213e8a9ddbb5eb1eca1249cb10ab44..752effe3c23201c4190f98b37a3af8728d3fd361 100644 (file)
--- a/src/common/dynarray.cpp
+++ b/src/common/dynarray.cpp
@@ -87,7 +87,7 @@ name::name()                                                                \
 {                                                                           \
   m_nSize  =                                                                \
   m_nCount = 0;                                                             \
 {                                                                           \
   m_nSize  =                                                                \
   m_nCount = 0;                                                             \

-  m_pItems = (T *)NULL;                                                     \
+  m_pItems = NULL;                                                     \

 }                                                                           \
                                                                             \
 /* copy ctor */                                                             \
 }                                                                           \
                                                                             \
 /* copy ctor */                                                             \


@@ -107,7 +107,7 @@ name::name(const name& src)                                                 \
       }                                                                     \
   }                                                                         \
   else                                                                      \
       }                                                                     \
   }                                                                         \
   else                                                                      \

-    m_pItems = (T *) NULL;                                                  \
+    m_pItems = NULL;                                                  \

 }                                                                           \
                                                                             \
 /* assignment operator */                                                   \
 }                                                                           \
                                                                             \
 /* assignment operator */                                                   \


@@ -129,7 +129,7 @@ name& name::operator=(const name& src)                                      \
       }                                                                     \
   }                                                                         \
   else                                                                      \
       }                                                                     \
   }                                                                         \
   else                                                                      \

-    m_pItems = (T *) NULL;                                                  \
+    m_pItems = NULL;                                                  \

                                                                             \
   return *this;                                                             \
 }                                                                           \
                                                                             \
   return *this;                                                             \
 }                                                                           \


@@ -475,31 +475,19 @@ void wxArrayString::Sort(bool reverseOrder)
     }
 }
 
     }
 }
 

-int wxSortedArrayString::Index(const wxString& str, bool bCase, bool WXUNUSED(bFromEnd)) const
+int wxSortedArrayString::Index(const wxString& str,
+                               bool WXUNUSED_UNLESS_DEBUG(bCase),
+                               bool WXUNUSED_UNLESS_DEBUG(bFromEnd)) const

 {
 {

-    wxSortedArrayString::const_iterator it;
+    wxASSERT_MSG( bCase && !bFromEnd,
+                  "search parameters ignored for sorted array" );

 
 

-    if (bCase)
-        it = std::lower_bound(begin(), end(), str,
-                              wxStringCompare(wxStringCmp()));
-    else
-        it = std::lower_bound(begin(), end(), str,
-                              wxStringCompare(wxStringCmpNoCase()));
+    wxSortedArrayString::const_iterator
+        it = std::lower_bound(begin(), end(), str, wxStringCompare(wxStringCmp()));

 
 

-    if (it == end())
+    if ( it == end() || str.Cmp(*it) != 0 )

         return wxNOT_FOUND;
 
         return wxNOT_FOUND;
 

-    if (bCase)
-    {
-        if (str.Cmp(*it) != 0)
-            return wxNOT_FOUND;
-    }
-    else
-    {
-        if (str.CmpNoCase(*it) != 0)
-            return wxNOT_FOUND;
-    }
-

     return it - begin();
 }
 
     return it - begin();
 }